04 Jul, 2011

1 commit


22 Mar, 2011

1 commit

  • with an PAT-enabled kernel, when using uvesafb or vesafb, these drivers will
    create uncached-minus PAT entries for the framebuffer memory because they use
    ioremap() (not the *_cache or *_wc variants). When the framebuffer memory
    intersects with the video RAM used by Xorg, the complete video RAM will be
    mapped uncached-minus what results in a serve performance penalty.

    Here are the correct MTRR entries created by uvesafb:
    schlicht@netbook:~$ cat /proc/mtrr
    reg00: base=0x000000000 ( 0MB), size= 2048MB, count=1: write-back
    reg01: base=0x06ff00000 ( 1791MB), size= 1MB, count=1: uncachable
    reg02: base=0x070000000 ( 1792MB), size= 256MB, count=1: uncachable
    reg03: base=0x0d0000000 ( 3328MB), size= 16MB, count=1: write-combining

    And here are the problematic PAT entries:
    schlicht@netbook:~$ sudo cat /sys/kernel/debug/x86/pat_memtype_list
    PAT memtype list:
    write-back @ 0x0-0x1000
    uncached-minus @ 0x6fedd000-0x6fee3000
    uncached-minus @ 0x6fee2000-0x6fee3000
    uncached-minus @ 0x6fee2000-0x6fee3000
    uncached-minus @ 0x6fee2000-0x6fee3000
    uncached-minus @ 0x6fee2000-0x6fee3000
    uncached-minus @ 0x6fee2000-0x6fee3000
    uncached-minus @ 0x6fee2000-0x6fee3000
    uncached-minus @ 0x6fee2000-0x6fee3000
    uncached-minus @ 0x6fee3000-0x6fee4000
    uncached-minus @ 0x6fee3000-0x6fee4000
    uncached-minus @ 0x6fee3000-0x6fee4000
    uncached-minus @ 0xd0000000-0xe0000000
    Signed-off-by: Paul Mundt

    Thomas Schlichter
     

16 Aug, 2010

1 commit


18 May, 2010

1 commit


07 Apr, 2010

1 commit

  • Commit c2e13037e6794bd0d9de3f9ecabf5615f15c160b ("platform-drivers: move
    probe to .devinit.text in drivers/video") introduced a huge amount of
    section mismatch warnings in vesafb code. Rather than converting all of
    the annotations, do the obvious and revert the __init -> __devinit change,
    and use the recommended (in that patch) alternative to calling
    platform_driver_register(): vesafb depends on information obtained from by
    kernel at boot time, cannot be a module, and no post-boot devices can ever
    show up.

    Signed-off-by: Jan Beulich
    Cc: Greg KH
    Acked-by: Uwe Kleine-König
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Beulich
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

08 Mar, 2010

1 commit

  • A pointer to a probe callback is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König
    Cc: Adrian Bunk
    Cc: Alberto Mardegan
    Cc: Andrew Morton
    Cc: Andriy Skulysh
    Cc: Antonino Daplas
    Cc: Anton Vorontsov
    Cc: Ben Dooks
    Cc: Chandramouli Narayanan
    Cc: Christoph Hellwig
    Cc: Frans Pop
    Cc: Geert Uytterhoeven
    Cc: Greg Kroah-Hartman
    Cc: Helge Deller
    Cc: Huang Ying
    Cc: Ian Molton
    Cc: Joshua Kinard
    Cc: Kaj-Michael Lang
    Cc: Krzysztof Helt
    Cc: linux-fbdev-devel@lists.sourceforge.net
    Cc: Maciej W. Rozycki
    Cc: Magnus Damm
    Cc: Martin Michlmayr
    Cc: Matthias Kaehlcke
    Cc: Paul Mundt
    Cc: Pavel Machek
    Cc: Philipp Zabel
    Cc: Richard Purdie
    Cc: Roel Kluin
    Cc: Roland Stigge
    Cc: Russell King
    Cc: Thomas Bogendoerfer
    Cc: Vincent Sanders
    Cc: Yoichi Yuasa
    Acked-by: Ralf Baechle
    Acked-by: Arnaud Patard
    Acked-by: James Simmons
    Acked-by: Peter Jones
    Acked-by: Jaya Kumar
    Signed-off-by: Greg Kroah-Hartman

    Uwe Kleine-König
     

17 Jun, 2009

1 commit

  • With KMS we have ran into an issue where we really want the KMS fb driver
    to be the one running the console, so panics etc can be shown by switching
    out of X etc.

    However with vesafb/efifb built-in, we end up with those on fb0 and the
    KMS fb driver on fb1, driving the same piece of hw, so this adds an fb
    info flag to denote a firmware fbdev, and adds a new aperture base/size
    range which can be compared when the hw drivers are installed to see if
    there is a conflict with a firmware driver, and if there is the firmware
    driver is unregistered and the hw driver takes over.

    It uses new aperture_base/size members instead of comparing on the fix
    smem_start/length, as smem_start/length might for example only cover the
    first 1MB of the PCI aperture, and we could allocate the kms fb from 8MB
    into the aperture, thus they would never overlap.

    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: Dave Airlie
    Acked-by: Peter Jones
    Cc: Geert Uytterhoeven
    Cc: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dave Airlie
     

01 Apr, 2009

1 commit


09 Dec, 2006

2 commits


11 Jul, 2006

1 commit

  • MAX_NR_CONSOLES, fg_console, want_console and last_console are more of a
    function of the VT layer than the TTY one. Moving these to vt.h and vt_kern.h
    allows all of the framebuffer and VT console drivers to remove their
    dependency on tty.h.

    [akpm@osdl.org: fix alpha build]
    Signed-off-by: Jon Smirl
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jon Smirl
     

27 Jun, 2006

3 commits


11 Apr, 2006

1 commit

  • Bugzilla Bug 6299:

    A pixel size of 8 bits produces wrong logo colors in x86_64.

    The driver has 2 methods for setting the color map, using the protected
    mode interface provided by the video BIOS and directly writing to the VGA
    registers. The former is not supported in x86_64 and the latter is enabled
    only in i386.

    Fix by enabling the latter method in x86_64 only if supported by the BIOS.
    If both methods are unsupported, change the visual of vesafb to
    STATIC_PSEUDOCOLOR.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

11 Jan, 2006

3 commits

  • Fix vesafb hang when scroll mode is REDRAW.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     
  • Remove error checking from vesafb_pan_display. This is guaranteed to be done
    by the core layer.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     
  • From: Bugzilla Bug 5351

    "After resuming from S3 (suspended while in X), the LCD panel stays black .
    However, the laptop is up again, and I can SSH into it from another
    machine.

    I can get the panel working again, when I first direct video output to the
    CRT output of the laptop, and then back to LCD (done by repeatedly hitting
    Fn+F5 buttons on the Toshiba, which directs output to either LCD, CRT or
    TV) None of this ever happened with older kernels."

    This bug is due to the recently added vesafb_blank() method in vesafb. It
    works with CRT displays, but has a high incidence of problems in laptop
    users. Since CRT users don't really get that much benefit from hardware
    blanking, drop support for this.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

14 Nov, 2005

1 commit


10 Nov, 2005

1 commit


07 Nov, 2005

3 commits

  • vesafb occassionally gets the size wrong when setting the mtrr. When X or DRI
    attempts to set the mtrr, it will fail due to range overlap significantly
    affecting their performance. Disable mtrr and let the user explicitly enable
    it with the mtrr:n option.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     
  • Fix out-of-bounds bug. The pseudopalette has room only for 16 entries, thus,
    write only the first 16 entries to the pseudopalette.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     
  • According to Jon Smirl, filling in the field fb_cursor with soft_cursor for
    drivers that do not support hardware cursors is redundant. The soft_cursor
    function is usable by all drivers because it is just a wrapper around
    fb_imageblit. And because soft_cursor is an fbcon-specific hook, the file is
    moved to the console directory.

    Thus, drivers that do not support hardware cursors can leave the fb_cursor
    field blank. For drivers that do, they can fill up this field with their own
    version.

    The end result is a smaller code size. And if the framebuffer console is not
    loaded, module/kernel size is also reduced because the soft_cursor module will
    also not be loaded.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

30 Oct, 2005

1 commit


18 Oct, 2005

1 commit

  • Reported by: Bob Tracy

    "...I've got a Toshiba notebook (730XCDT -- Pentium 150MMX) for which
    I'm using the Vesa FB driver. When the machine has been idle for some
    time and the driver attempts to powerdown the display, rather than the
    display going blank, it goes gray with several strange lines. When I
    hit the "shift" key or other-wise wake up the display, the old video
    state is not fully restored..."

    vesafb recently added a blank method which has only 2 states, powerup and
    powerdown. The powerdown state is used for all blanking levels, but in his
    case, powerdown does not work correctly for higher levels of display
    powersaving. Thus, for intermediate power levels, use software blanking,
    and use only hardware blanking for an explicit powerdown.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

10 Sep, 2005

1 commit

  • Add rudimentary support by manipulating the VGA registers. However, not
    all vesa modes are VGA compatible, so VGA compatiblity is checked first.
    Only 2 levels are supported, powerup and powerdown.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

30 Jul, 2005

1 commit

  • >> vesafb: mode is 800x600x16, linelength=1600, pages=16
    >> vesafb: scrolling: redraw
    >> vesafb: Truecolor: size=0:5:6:5, shift=0:11:5:0
    >> mtrr: type mismatch for fc000000,1000000 old: write-back new: write-
    >> combining

    Range is already set to write-back, vesafb attempts to add a write-combining
    mtrr (default for vesafb).

    >> mtrr: size and base must be multiples of 4 kiB

    This is a bug, vesafb attempts to add a size < PAGE_SIZE triggering
    the messages below.

    To eliminate the warning messages, you can add the option mtrr:2 to add a
    write-back mtrr for vesafb. Or just use nomtrr option.

    1. Fix algorithm for finding the best power of 2 size with mtrr_add().

    2. Add option to choose the mtrr type by extending the mtrr boot option:

    mtrr:n where n

    0 = no mtrr (equivalent to using the nomtrr option)
    1 = uncachable
    2 = write back
    3 = write combining (default)
    4 = write through

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

26 Jun, 2005

1 commit

  • vesafb will do really silly things like..

    mtrr: type mismatch for e0000000,8000000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,4000000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,2000000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,1000000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,800000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,400000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,200000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,100000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,80000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,40000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,20000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,10000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,8000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,4000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,2000 old: write-back new: write-combining
    mtrr: type mismatch for e0000000,1000 old: write-back new: write-combining
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x800 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x400 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x200 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x100 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x80 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x40 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x20 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x10 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x8 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x4 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x2 base: 0xe0000000
    mtrr: size and base must be multiples of 4 kiB
    mtrr: size: 0x1 base: 0xe0000000

    Stop scaling down at PAGE_SIZE.
    Also fix up some broken indentation.

    Signed-off-by: Dave Jones
    Cc: Alexey Dobriyan
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dave Jones
     

22 Jun, 2005

1 commit

  • Fix the size passed to release_mem_region in an error path.

    Also adjust the message printed when vesafb cannot load; the comment there
    already says this must not be fatal, so the message should also not mention
    the word 'abort' otherwise indicating a problem to worry about in the log.

    Signed-off-by: Jan Beulich
    Signed-off-by: Gerd Knorr
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Gerd Knorr
     

01 May, 2005

1 commit


17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds