10 Jan, 2012
1 commit
-
Dan Carpenter reported that setting 0 to uinfo->value.enumerated.items
in snd_asihpi_cmode_info() may lead to Oops. This function should
return an error immediately in such a case instead.Cc: Dan Carpenter
Signed-off-by: Takashi Iwai
22 Dec, 2011
22 commits
-
Sharing and not reinitialising static pcm_hardware struct resulted in
stream format validity flags being incorrectly shared between cards.
Fix and clarify by declaring locally and initialising in the open functions.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Since introduction of mono and low latency modes, fixed channel count of 2
is not always valid. Use reported max_channels instead.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Previously, only payload and size were correct, sufficient for reading,
but other fields produced spurious debug output.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
It is useful to know the HPI version without having to load the module,
in order to determine the matching firmware version.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Add new error codes, and adapter properties.
Clean up some comments.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
dsp_code struct is not created if firmware is invalid, so check
and zero of firmware pointer is not necessarySigned-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Structs hpi_adapter and snd_card_asihpi had members that
duplicate those in underlying hpi_adapter_obj or whose info
can be retrieved using hpi_adapter_get_info().Print less info in probe function, it can be retrieved from /proc.
Avoid name redundancy: hpi_adapter_obj.adapter_type renamed to .type
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Enables retrieving more debug info in fewer transactions.
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Structs related to network flash update are not required in kernel.
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Add "Internal" node type.
Remove GPI and GPO node types.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
The channel count can be queried to determine which.
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Unlike other streams which support 1..max channels,
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
and update HPI version to 4.10
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Elapsed counter should only count data committed to snd_pcm_period_elapsed,
rather than all data availableSigned-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai
19 Dec, 2011
1 commit
-
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.Signed-off-by: Rusty Russell
Signed-off-by: Takashi Iwai
06 Dec, 2011
1 commit
-
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107Signed-off-by: Thomas Meyer
Signed-off-by: Takashi Iwai
01 Nov, 2011
1 commit
-
Lots of sound drivers were getting module.h via the implicit presence
of it in but we are going to clean that up. So
fix up those users now.Signed-off-by: Paul Gortmaker
07 Aug, 2011
1 commit
-
Use kzalloc rather than kmalloc followed by memset with 0
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguousThe semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.More information about semantic patching is available at
http://coccinelle.lip6.fr/Signed-off-by: Thomas Meyer
Signed-off-by: Takashi Iwai
02 Aug, 2011
1 commit
-
Avoids assigning possibly invalid address to pa, even if it
is never dereferenced.
Correct error response to reflect request object/function ids.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai
01 Aug, 2011
1 commit
-
We leak the memory allocated to 'firmware' when we fail to
release_firmware() after a kmalloc() failure in hpi_dsp_code_open().
This patch should take care of the leak.Signed-off-by: Jesper Juhl
Signed-off-by: Takashi Iwai
27 Jul, 2011
2 commits
-
"adapter" is used as an array index in the adapters[] array so
the off by one would make us read past the end.1c073b67979 "ALSA: asihpi - Remove spurious adapter index check"
reverted Dan Rosenberg's check that would have prevented the
overflow here.Signed-off-by: Dan Carpenter
Signed-off-by: Takashi Iwai -
Fixes bug introduced by 1c073b67.
Also declare pa local to block in which it is used.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai
24 Jul, 2011
1 commit
-
Formatting a PCM name is useful for module debug too.
Add snd_prefix when making function public.[minor coding-style fixes by tiwai]
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai
22 Jul, 2011
8 commits
-
Signed-off-by: Takashi Iwai
-
HPI Version is used to check for firmware compatibility.
This version will accept 4.08.xx released firmware,
and will also accept 4.09.xx beta firmwareSigned-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Mute functionality was recently added to the DSP firmware
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Add names corresponding to new HPI node types.
Shorten some names so that constructed names don't overflow the
maximum name length.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Because mutex is used in adapter struct defined here.
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai