03 Sep, 2011
1 commit
-
Signed-off-by: J. Bruce Fields
01 Sep, 2011
12 commits
-
This is used only as a local variable.
Signed-off-by: J. Bruce Fields
-
Maybe we'll bring it back some day, but we don't have much real use for
it now.Signed-off-by: J. Bruce Fields
-
If open fails with any error other than nfserr_replay_me, then the main
nfsd4_proc_compound() loop continues unconditionally to
nfsd4_encode_operation(), which will always call encode_seqid_op_tail.
Thus the condition we check for here does not occur.Signed-off-by: J. Bruce Fields
-
There are currently a couple races in the seqid replay code: a
retransmission could come while we're still encoding the original reply,
or a new seqid-mutating call could come as we're encoding a replay.So, extend the state lock over the encoding (both encoding of a replayed
reply and caching of the original encoded reply).I really hate doing this, and previously added the stateowner
reference-counting code to avoid it (which was insufficient)--but I
don't see a less complicated alternative at the moment.Signed-off-by: J. Bruce Fields
-
Now that the replay owner is in the cstate we can remove it from a lot
of other individual operations and further simplify
nfs4_preprocess_seqid_op().Signed-off-by: J. Bruce Fields
-
Set the stateowner associated with a replay in one spot in
nfs4_preprocess_seqid_op() and keep it in cstate. This allows removing
a few lines of boilerplate from all the nfs4_preprocess_seqid_op()
callers.Also turn ENCODE_SEQID_OP_TAIL into a function while we're here.
Signed-off-by: J. Bruce Fields
-
Thanks to Casey for reminding me that 5661 gives a special meaning to a
value of 0 in the stateid's seqid field, so all stateid's should start
out with si_generation 1. We were doing that in the open and lock
cases for minorversion 1, but not for the delegation stateid, and not
for openstateid's with v4.0.It doesn't *really* matter much for v4.0 or for delegation stateid's
(which never get the seqid field incremented), but we may as well do the
same for all of them.Reported-by: Casey Bodley
Signed-off-by: J. Bruce Fields -
Follow the recommendation from rfc3530bis for stateid generation number
wraparound, simplify some code, and fix or remove incorrect comments.Signed-off-by: J. Bruce Fields
-
There's no reason to have two separate hash tables for open and lock
stateid's.Signed-off-by: J. Bruce Fields
-
The trick free_stateid is using is a little cheesy, and we'll have more
uses for this field later.Signed-off-by: J. Bruce Fields
-
Wow, I wonder how long that typo's been there.
Signed-off-by: J. Bruce Fields
-
The values here represent highest slotid numbers. Since slotid's are
numbered starting from zero, the highest should be one less than the
number of slots.Reported-by: Rick Macklem
Signed-off-by: J. Bruce Fields
31 Aug, 2011
1 commit
-
We don't need this any more.
Signed-off-by: J. Bruce Fields
28 Aug, 2011
13 commits
-
When called with OPEN_STATE, preprocess_seqid_op only returns an open
stateid, hence only an open owner.Signed-off-by: J. Bruce Fields
-
We've got some lock-specific code here in nfs4_preprocess_seqid_op which
is only used by nfsd4_lock(). Move it to the caller.Signed-off-by: J. Bruce Fields
-
Note that the special handling for the lock stateid case is already done
by nfs4_check_openmode() (as of 02921914170e3b7fea1cd82dac9713685d2de5e2
"nfsd4: fix openmode checking on IO using lock stateid") so we no longer
need these two cases in the caller.Signed-off-by: J. Bruce Fields
-
Signed-off-by: J. Bruce Fields
-
This flag doesn't really buy us anything.
Signed-off-by: J. Bruce Fields
-
Share some common code, stop doing silly things like initializing a list
head immediately before adding it to a list, etc.Signed-off-by: J. Bruce Fields
-
These appear to be generic (for both open and lock owners), but they're
actually just for open owners. This has confused me more than once.Signed-off-by: J. Bruce Fields
-
For all the usual reasons. (Type safety, readability.)
Signed-off-by: J. Bruce Fields
-
The server is returning nfserr_resource for both permanent errors and
for errors (like allocation failures) that might be resolved by retrying
later. Save nfserr_resource for the former and use delay/jukebox for
the latter.Cc: stable@kernel.org
Signed-off-by: J. Bruce Fields -
Even if we fail to write a recovery record, we should still mark the
client as having acquired its first state. Otherwise we leave 4.1
clients with indefinite ERR_GRACE returns.However, an inability to write stable storage records may cause failures
of reboot recovery, and the problem should still be brought to the
server administrator's attention.So, make sure the error is logged.
These errors shouldn't normally be triggered on a corectly functioning
server--this isn't a case where a misconfigured client could spam the
logs.Signed-off-by: Boaz Harrosh
Signed-off-by: J. Bruce Fields -
Move around some of this code, simplify a bit.
Reviewed-by: Boaz Harrosh
Signed-off-by: J. Bruce Fields -
Acked-by: Jim Rees
Signed-off-by: J. Bruce Fields -
A client that wants to execute a file must be able to read it. Read
opens over nfs are therefore implicitly allowed for executable files
even when those files are not readable.NFSv2/v3 get this right by using a passed-in NFSD_MAY_OWNER_OVERRIDE on
read requests, but NFSv4 has gotten this wrong ever since
dc730e173785e29b297aa605786c94adaffe2544 "nfsd4: fix owner-override on
open", when we realized that the file owner shouldn't override
permissions on non-reclaim NFSv4 opens.So we can't use NFSD_MAY_OWNER_OVERRIDE to tell nfsd_permission to allow
reads of executable files.So, do the same thing we do whenever we encounter another weird NFS
permission nit: define yet another NFSD_MAY_* flag.The industry's future standardization on 128-bit processors will be
motivated primarily by the need for integers with enough bits for all
the NFSD_MAY_* flags.Reported-by: Leonardo Borda
Cc: stable@kernel.org
Signed-off-by: J. Bruce Fields
27 Aug, 2011
7 commits
-
Userspace shouldn't have a use for these constants. Nothing here is
used outside fs/nfsd.Signed-off-by: J. Bruce Fields
-
At least one of these is actually wrong anyway.
Signed-off-by: J. Bruce Fields
-
The nfsd4 code has a bunch of special exceptions for error returns which
map nfserr_symlink to other errors.In fact, the spec makes it clear that nfserr_symlink is to be preferred
over less specific errors where possible.The patch that introduced it back in 2.6.4 is "kNFSd: correct symlink
related error returns.", which claims that these special exceptions are
represent an NFSv4 break from v2/v3 tradition--when in fact the symlink
error was introduced with v4.I suspect what happened was pynfs tests were written that were overly
faithful to the (known-incomplete) rfc3530 error return lists, and then
code was fixed up mindlessly to make the tests pass.Delete these unnecessary exceptions.
Signed-off-by: J. Bruce Fields
-
Zero means "I don't care what kind of file this is". And that's
probably what we want--acls are also settable at least on directories,
and if the filesystem doesn't want them on other objects, leave it to it
to complain.Signed-off-by: J. Bruce Fields
-
Add some more comments, simplify logic, do & S_IFMT just once, name
"type" more helpfully.Signed-off-by: J. Bruce Fields
-
We allow the fh_verify caller to specify that any object *except* those
of a given type is allowed, by passing a negative type. But only one
caller actually uses it. Open-code that check in the one caller.Signed-off-by: J. Bruce Fields
-
A slightly unconventional approach to make the code more compact I could
live with, but let's give the poor reader *some* chance.Signed-off-by: J. Bruce Fields
20 Aug, 2011
6 commits
-
Use NUMA aware allocations to reduce latencies and increase throughput.
sunrpc kthreads can use kthread_create_on_node() if pool_mode is
"percpu" or "pernode", and svc_prepare_thread()/svc_init_buffer() can
also take into account NUMA node affinity for memory allocations.Signed-off-by: Eric Dumazet
CC: "J. Bruce Fields"
CC: Neil Brown
CC: David Miller
Reviewed-by: Greg Banks
[bfields@redhat.com: fix up caller nfs41_callback_up]
Signed-off-by: J. Bruce Fields -
There's an incorrect comment here. Also clean up the logic: the
"rdlease" and "wrlease" locals are confusingly named, and don't really
add anything since we can make a decision as soon as we hit one of these
cases.Signed-off-by: J. Bruce Fields
-
We currently use a bit in fl_flags to record whether a lease is being
broken, and set fl_type to the type (RDLCK or UNLCK) that it will
eventually have. This means that once the lease break starts, we forget
what the lease's type *used* to be. Breaking a read lease will then
result in blocking read opens, even though there's no conflict--because
the lease type is now F_UNLCK and we can no longer tell whether it was
previously a read or write lease.So, instead keep fl_type as the original type (the type which we
enforce), and keep track of whether we're unlocking or merely
downgrading by replacing the single FL_INPROGRESS flag by
FL_UNLOCK_PENDING and FL_DOWNGRADE_PENDING flags.To get this right we also need to track separate downgrade and break
times, to handle the case where a write-leased file gets conflicting
opens first for read, then later for write.(I first considered just eliminating the downgrade behavior
completely--nfsv4 doesn't need it, and nobody as far as I can tell
actually uses it currently--but Jeremy Allison tells me that Windows
oplocks do behave this way, so Samba will probably use this some day.)Reviewed-by: Jeff Layton
Signed-off-by: J. Bruce Fields -
F_INPROGRESS isn't exposed to userspace. To me it makes more sense in
fl_flags....Reviewed-by: Jeff Layton
Signed-off-by: J. Bruce Fields -
Use a helper function, to simplify upcoming changes.
Reviewed-by: Jeff Layton
Signed-off-by: J. Bruce Fields -
Without this, an attempt to open a device special file without first
stat'ing it will fail.Signed-off-by: J. Bruce Fields
