07 Jul, 2021
40 commits
-
The double copy of the string is a mistake, plus __assign_str()
uses strlen(), which is wrong to do on a string that isn't
guaranteed to be NUL-terminated.Fixes: 6019ce0742ca ("NFSD: Add a tracepoint to record directory entry encoding")
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
The pointer 'this' is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
Signed-off-by: J. Bruce Fields -
When flushing out the unstable file writes as part of a COMMIT call, try
to perform most of of the data writes and waits outside the semaphore.This means that if the client is sending the COMMIT as part of a memory
reclaim operation, then it can continue performing I/O, with contention
for the lock occurring only once the data sync is finished.Fixes: 5011af4c698a ("nfsd: Fix stable writes")
Signed-off-by: Trond Myklebust
Tested-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Add a .h file containing xdr_stream-based XDR helpers common to both
NLMv3 and NLMv4.Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
To enable xdr_stream-based encoding and decoding, create a bespoke
RPC dispatch function for the lockd service.Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields -
I'm not even sure cl_xprt can change here, but we're getting "suspicious
RCU usage" warnings, and other rpc_peeraddr2str callers are taking the
rcu lock.Signed-off-by: J. Bruce Fields
-
The variable status is being initialized with a value that is never
read, the assignment is redundant and can be removed.Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
Signed-off-by: J. Bruce Fields -
Fix gcc W=1 warning:
fs/nfs_common/grace.c:91: warning: Function parameter or member 'net' not described in 'locks_in_grace'
Signed-off-by: ChenXiaoSong
Signed-off-by: J. Bruce Fields -
'status' has been overwritten to 0 after nfsd4_ssc_setup_dul(), this
cause 0 will be return in vfs_kern_mount() error case. Fix to return
nfserr_nodev in this error.Fixes: f4e44b393389 ("NFSD: delay unmount source's export after inter-server copy completed.")
Reported-by: Hulk Robot
Signed-off-by: Wei Yongjun
Signed-off-by: J. Bruce Fields -
Fix by initializing pointer nfsd4_ssc_umount_item with NULL instead of 0.
Replace return value of nfsd4_ssc_setup_dul with __be32 instead of int.Reported-by: kernel test robot
Signed-off-by: Dai Ngo
Signed-off-by: J. Bruce Fields -
In addition to the client's address, display the callback channel
state and address in the 'info' file.Signed-off-by: Dave Wysochanski
Signed-off-by: J. Bruce Fields -
Fix some spelling mistakes in comments:
succes ==> successSigned-off-by: Zheng Yongjun
Signed-off-by: J. Bruce Fields -
This was causing a "sleeping function called from invalid context"
warning.I don't think we need the set_and_test_bit() here; clients move from
unconfirmed to confirmed only once, under the client_lock.The (conf == unconf) is a way to check whether we're in that confirming
case, hopefully that's not too obscure.Fixes: 472d155a0631 "nfsd: report client confirmation status in "info" file"
Signed-off-by: J. Bruce Fields
