23 Sep, 2006
1 commit
-
This adds transmit buffering to DCCP.
I have tested with CCID2/3 and with loss and rate limiting.
Signed off by: Ian McDonald
Signed-off-by: David S. Miller
01 Jul, 2006
1 commit
-
Signed-off-by: Jörn Engel
Signed-off-by: Adrian Bunk
21 Mar, 2006
7 commits
-
And not the silly LIMIT_NETDEBUG and silently return without inserting
the option requested.Also drop some old debugging messages associated to option insertion.
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Using this also provides opportunities for introducing
inet_csk_alloc_skb that would call alloc_skb, account it to the sock
and skb_reserve(max_header), but I'll leave this for later, for now
using sk_prot->max_header consistently is enough.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
With this patch in place we can break down the complexity by better
compartmentalizing the code that is common to ipv6 and ipv4.Now we have these modules:
Module Size Used by
dccp_diag 1344 0
inet_diag 9448 1 dccp_diag
dccp_ccid3 15856 0
dccp_tfrc_lib 12320 1 dccp_ccid3
dccp_ccid2 5764 0
dccp_ipv4 16996 2
dccp 48208 4 dccp_diag,dccp_ccid3,dccp_ccid2,dccp_ipv4dccp_ipv6 still requires dccp_ipv4 due to dccp_ipv6_mapped, that is
the next target to work on the "hey, ipv4 is legacy, I only want ipv6
dude!" direction.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
dccp_make_response is shared by ipv4/6 and the ipv6 code was
recalculating the checksum, not good, so move the dccp_v4_checksum
call to dccp_v4_send_response.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Renaming it to dccp_send_reset and moving it from the ipv4 specific
code to the core dccp code.This fixes some bugs in IPV6 where timers would send v4 resets, etc.
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Still needs more work, but boots and doesn't crashes, even
does some negotiation!18:38:52.174934 127.0.0.1.43458 > 127.0.0.1.5001: request
18:38:52.218526 127.0.0.1.5001 > 127.0.0.1.43458: response
18:38:52.185398 127.0.0.1.43458 > 127.0.0.1.5001::-)
Signed-off-by: Andrea Bittau
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
04 Jan, 2006
4 commits
-
To help in reducing the number of include dependencies, several files were
touched as they were getting needed headers indirectly for stuff they use.Thanks also to Alan Menegotto for pointing out that net/dccp/proto.c had
linux/dccp.h include twice.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
As DCCP needs to be called in the same spots.
Now we have a member in inet_sock (is_icsk), set at sock creation time from
struct inet_protosw->flags (if INET_PROTOSW_ICSK is set, like for TCP and
DCCP) to see if a struct sock instance is a inet_connection_sock for places
like the ones in ip_sockglue.c (v4 and v6) where we previously were looking if
sk_type was SOCK_STREAM, that is insufficient because we now use the same code
for DCCP, that has sk_type SOCK_DCCP.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Basically exports a similar set of functions as the one exported by
the non-AF specific TCP code.In the process moved some non-AF specific code from dccp_v4_connect to
dccp_connect_init and moved the checksum verification from
dccp_invalid_packet to dccp_v4_rcv, so as to use it in dccp_v6_rcv
too.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
And make the core DCCP code AF agnostic, just like TCP, now its time
to work on net/dccp/ipv6.c, we are close to the end!Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
01 Nov, 2005
2 commits
-
Here is a complimentary insurance policy for those feeling a bit insecure.
You don't have to accept this. However, if you do, you can't blame me for
it :)> 1) dccp_transmit_skb sets the owner for all packets except data packets.
We can actually verify this by looking at pkt_type.
Signed-off-by: Herbert Xu
Signed-off-by: Arnaldo Carvalho de Melo -
While we're at it let's reorganise the set_owner_w calls a little so that:
1) dccp_transmit_skb sets the owner for all packets except data packets.
2) Add dccp_skb_entail to set owner for packets queued for retransmission.
3) Make dccp_transmit_skb static.Signed-off-by: Herbert Xu
Signed-off-by: Arnaldo Carvalho de Melo
28 Oct, 2005
1 commit
-
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds
21 Oct, 2005
3 commits
-
Turns out the problem has nothing to do with use-after-free or double-free.
It's just that we're not clearing the CB area and DCCP unlike TCP uses a CB
format that's incompatible with IP.Signed-off-by: Herbert Xu
Signed-off-by: Ian McDonald
Signed-off-by: Arnaldo Carvalho de Melo -
icmp_send doesn't use skb->sk at all so even if skb->sk has already
been freed it can't cause crash there (it would've crashed somewhere
else first, e.g., ip_queue_xmit).I found a double-free on an skb that could explain this though.
dccp_sendmsg and dccp_write_xmit are a little confused as to what
should free the packet when something goes wrong. Sometimes they
both go for the ball and end up in each other's way.This patch makes dccp_write_xmit always free the packet no matter
what. This makes sense since dccp_transmit_skb which in turn comes
from the fact that ip_queue_xmit always frees the packet.Signed-off-by: Herbert Xu
Signed-off-by: Arnaldo Carvalho de Melo -
David S. Miller wrote:
> One thing you can probably do for this bug is to mark data packets
> explicitly somehow, perhaps in the SKB control block DCCP already
> uses for other data. Put some boolean in there, set it true for
> data packets. Then change the test in dccp_transmit_skb() as
> appropriate to test the boolean flag instead of "skb_cloned(skb)".I agree. In fact we already have that flag, it's called skb->sk.
So here is patch to test that instead of skb_cloned().Signed-off-by: Herbert Xu
Acked-by: Ian McDonald
Signed-off-by: Arnaldo Carvalho de Melo
18 Sep, 2005
1 commit
-
Isolating it, that will be used when we introduce a CCID2 (TCP-Like)
implementation.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
17 Sep, 2005
1 commit
-
As discussed in the dccp@vger mailing list:
Now applications have to use setsockopt(DCCP_SOCKOPT_SERVICE, service[s]),
prior to calling listen() and connect().An array of unsigned ints can be passed meaning that the listening sock accepts
connection requests for several services.With this we can ditch struct sockaddr_dccp and use only sockaddr_in (and
sockaddr_in6 in the future).Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
10 Sep, 2005
1 commit
-
Signed-off-by: Arnaldo Carvalho de Melo
30 Aug, 2005
10 commits
-
This makes the send rate calculations behave way more closely to what
is specified, with the jitter previously seen on x and x_recv
disappearing completely on non lossy setups.This resembles the tcp_data_snd_check code, that possibly we'll end up
using in DCCP as well, perhaps moving this code to
inet_connection_sock.For now I'm doing the simplest implementation tho.
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
This is not quite what I think we should have long term but improves
performance for now, so lets use it till we get CCID3 working well,
then we can think about using sk_write_queue, perhaps using some ideas
from Juwen Lai's old stack for 2.4.20.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
So that we retransmit CLOSE/CLOSEREQ packets till they elicit an
answer or we hit a timeout.Most of the machinery uses TCP approaches, this code has to be
polished & audited, but this is better than we had before.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Also fix step 6 when receiving SYNC or SYNCACK packets, i.e. we were not using
the updated swl.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Andrew Morton should be happy now 8)
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
This way it gets closer to the TCP flow, where congestion window
checks are done, it seems we can map ccid_hc_tx_send_packet in
dccp_write_xmit to tcp_snd_wnd_test in tcp_write_xmit, a CCID2
decision should just fit in here as well...Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Yoshifumi Nishida
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Development to this point was done on a subversion repository at:
http://oops.ghostprotocols.net:81/cgi-bin/viewcvs.cgi/dccp-2.6/
This repository will be kept at this site for the foreseable future,
so that interested parties can see the history of this code,
attributions, etc.If I ever decide to take this offline I'll provide the full history at
some other suitable place.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
