14 Nov, 2018
3 commits
-
Should use the correct build MARCO gcdANDROID to control android build.
Change-Id: I56a745b228a24ba502dc9771596aad78c1d8d808
Signed-off-by: Richard Liu -
there are lots of PFNs busy message when run GPU tests:
[ 622.370671] alloc_contig_range: [4ea70, 4ea7c) PFNs busy
[ 626.518072] alloc_contig_range: [4ea90, 4ea9c) PFNs busythis problem is related with CMA migration for fragments,
move CMA allocator after GFP to avoid memory migration,
also fix CMA preempt for contiguous memory request.can improve CTS and gpubench benchmarks on M850D.
Signed-off-by: Xianzhong
-
BUG: scheduling while atomic: swapper/0/0/0x00010002
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.14.62 #1
Call trace:
[] dump_backtrace+0x0/0x414
[] show_stack+0x14/0x1c
[] dump_stack+0x90/0xb0
[] __schedule_bug+0x50/0x6c
[] __schedule+0x720/0x8a8
[] schedule+0x38/0x9c
[] schedule_preempt_disabled+0x20/0x38
[] __mutex_lock.isra.9+0x4dc/0x4fc
[] __mutex_lock_slowpath+0x10/0x18
[] mutex_lock+0x30/0x38
[] gckOS_DestroySignal+0x30/0xcc
[] viv_fence_release+0x24/0x38
[] dma_fence_release+0x38/0xf4
[] dma_fence_array_release+0x78/0xac
[] dma_fence_release+0x38/0xf4
[] irq_dma_fence_array_work+0x40/0x4c
[] irq_work_run_list+0x68/0xa8
[] irq_work_run+0x24/0x40
[] handle_IPI+0x300/0x330
[] gic_handle_irq+0x8c/0x184Replace signal mutex lock with spin lock to handle signal in irq.
Change-Id: Id18e68f03bcb96c2aaf3ca8a0055fe6a64e8d10a
Signed-off-by: Ivan.liu
13 Nov, 2018
18 commits
-
Both dataline_off and dataline_off_dsd fields are unsigned,
thus checking negative values make no sense. Use a signed
variable to calculate offset instead.This fixes Coverity issue: CID1899299
Signed-off-by: Viorel Suman
-
Save error so that the following error checking now make sense.
This fixes Coverity issue: CID2828734
Signed-off-by: Viorel Suman
-
When hwvad is enabled, if you try to re-enable it again, it should fail.
However, we were also double setting state to OFF on fail, which is
wrong because it resets the state and allows the second retry to enable
even if it wasn't disabled before.
Now we only return EBUSY.Reviewed-by: Daniel Baluta
Signed-off-by: Cosmin-Gabriel Samoila -
An unsigned value can never be negative, so this test will always
evaluate the same way.Fixes Coverity issue CID3618200
Reviewed-by: Viorel Suman
Signed-off-by: Cosmin-Gabriel Samoila -
There may be a null pointer dereference, or else the comparison against
null is unnecessary.Fixes Coverity issue CID5327850
Reviewed-by: Viorel Suman
Reviewed-by: Daniel Baluta
Signed-off-by: Cosmin-Gabriel Samoila -
1.statistics on dma memory usage
2.fix alloc_dma_buffer error return value
3.remove unused member encoder_memSigned-off-by: ming_qian
-
Fixes build warning introduced by
90e818a0abcc("MLK-20342 i2c: xen-i2cback/front: Add i2c_smbus interface")Signed-off-by: Peng Fan
-
HDMI power domain is under DC0, however DC0 is used by the first OS,
so domu has no permission to use HDMI.Signed-off-by: Peng Fan
Reviewed-by: Flynn xu -
Add smbus_xfer interface in xen-i2cback/front driver.
Reviewed-by: Peng Fan
Signed-off-by: Flynn xu -
Signed-off-by: ming_qian
-
Add QVGA resolution support for mipi ov5640
Signed-off-by: Guoniu.Zhou
-
If camera is not connected and user try to use mem2mem function,
driver will return error but isi channel0 reference counter is
still increased by one. This will lead to mem2mem driver return
EBUSY error when user open mem2mem device, so correct this bug
in this patch.Signed-off-by: Guoniu.Zhou
-
Enable global alpha insertion for memory to memory function
of ISISigned-off-by: Guoniu.Zhou
-
Enable global alpha insertion feature for camera
Signed-off-by: Guoniu.Zhou
-
Eanble horizonal and vertical flip for memory to memory function
of ISISigned-off-by: Guoniu.Zhou
-
Enable horizonal and vertical flip for camera image
Signed-off-by: Guoniu.Zhou
-
Correct color mapping between V4L2 and ISI
Signed-off-by: Guoniu.Zhou
-
alloc_contig_range easily return -EBUSY when try to isolate pages,
there are lots of messages with PFNs busy when run GPU tests.
[ 622.370671] alloc_contig_range: [4ea70, 4ea7c) PFNs busy
[ 626.518072] alloc_contig_range: [4ea90, 4ea9c) PFNs busythese problems are related wht CMA migration for fragments,
need enlarge GPU reserved size to reduce CMA fragments.Signed-off-by: Xianzhong
12 Nov, 2018
12 commits
-
The video mode tmp_m, as a local variable in tcon_cfg_videomode(),
is uninitialized and used to store a copy instance from the real
video mode. tcon_cfg_videomode() would change the timing of it if
side_by_side mode is enabled. Theoretically, there should be no
problem even if we don't initialize tmp_m. However, coverity
reports that tmp_m is an uninitialized scalar variable when the copy
is being done(CID 5233067: Uninitialized scalar variable (UNINIT)).
This patch fixes the issue reported by coverity.Signed-off-by: Liu Ying
-
The logic in function h/vscaler_pixengcfg_dynamic_src_sel() to avoid
overrunning array src_sel[i][j] is wrong. The correct one is to check
on the index i which should be less than the array size of h/vs_id_array[].
This patch fixes the potential array overrunning issue, that is,
out-of-bounds array read issue. The issue is reported by coverity -
CID 1477349 and CID 1477345.Signed-off-by: Liu Ying
-
if suspend before configure codec,
the firmware should be re downloaded after resumeSigned-off-by: ming_qian
-
Fix uninitalized variable
Signed-off-by: Flynn xu
Reviewed-by: Peng Fan -
The callers of dpu_{unit}_init() might provide an invalid id as
the parameter, it may cause overrunning dpu->{unit}_priv[] and
cf_shdlreqs[] arrays and out-of-bound array access. Although
the current only caller is dpu_submodules_init() and it always
provides valid ids, it would be good to fix the potential issue.
This patch fixes several issues reported by coverity - CID 1477330,
CID 1477335, CID 1477348, CID 1477346, CID 3298619, CID 1477347,
CID 5233021 and CID 1477321.Signed-off-by: Liu Ying
-
The function get_xval() returns the C_XVAL and L_XVAL fields of
the CURPIXELCNT and LASTPIXELCNT registers. They are 16bit and
sit in the low 16bit of the registers. This patch fixes the way
we mask the register and read the fields out.Signed-off-by: Liu Ying
-
boot-region: 2M per core
rpc-buf-size: 512K per core
print-buf-size: 512K per coreSigned-off-by: ming_qian
-
Signed-off-by: ming_qian
-
Signed-off-by: ming_qian
-
Signed-off-by: ming_qian
-
Signed-off-by: ming_qian
-
Signed-off-by: ming_qian
09 Nov, 2018
7 commits
-
e_shstrndx already contains the section header index, so
shdr->sh_type will always be SHT_STRTAB.Remove this redundant check and make Coverity happy.
Fixes: CID3901026
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta -
The dts file was removed but makefile was not updated so build broke.
Fix by removing from makefile.Fixes: a9c2aa010df8 ("MLK-20252 ARM64: dts: correct imx8mm root memory")
Signed-off-by: Leonard Crestez
Reviewed-by: Daniel Baluta -
The layerblend units don't contain the CONTROLWORD, CURPIXELCNT,
LASTPIXELCNT and PERFCOUNTER registers, so let's remove them
and their wrappers(no one is calling them), which were introduced
accidentally.Signed-off-by: Liu Ying
-
xf_cmd_send_recv returns with lock taken if waiting was
interrupted by a signal.This fixes Coverity issues: CID5233120 / CID5233060
Reviewed-by: S.j. Wang
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta -
Bail out if kernel_read returns an error.
Fixes: CID1477415
Reviewed-by: S.j. Wang
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta -
At this point err is always 0. So, just remove the check.
Fixes: CID1477380
Reviewed-by: S.j. Wang
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta -
Return value is not used so better use atomic_dec.
This also silences coverity warning CID3344689.Reviewed-by: S.j. Wang
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta
