Eric Lee / smarc-fsl-linux-kernel

17 Nov, 2008

1 commit

  • ad133ba3d   sched, signals: fix the racy usage of ->signal in account_group_xxx/run_posix_cpu_timers ... Browse Code »

    Impact: fix potential NULL dereference

    Contrary to ad474caca3e2a0550b7ce0706527ad5ab389a4d4 changelog, other
    acct_group_xxx() helpers can be called after exit_notify() by timer tick.
    Thanks to Roland for pointing out this. Somehow I missed this simple fact
    when I read the original patch, and I am afraid I confused Frank during
    the discussion. Sorry.

    Fortunately, these helpers work with current, we can check ->exit_state
    to ensure that ->signal can't go away under us.

    Also, add the comment and compiler barrier to account_group_exec_runtime(),
    to make sure we load ->signal only once.

    Signed-off-by: Oleg Nesterov
    Signed-off-by: Ingo Molnar

    Oleg Nesterov
     

24 Oct, 2008

2 commits

  • 88ed86fee   Merge branch 'proc' of git://git.kernel.org/pub/scm/linux/kernel/git/adobriyan/proc ... Browse Code »

    * 'proc' of git://git.kernel.org/pub/scm/linux/kernel/git/adobriyan/proc: (35 commits)
    proc: remove fs/proc/proc_misc.c
    proc: move /proc/vmcore creation to fs/proc/vmcore.c
    proc: move pagecount stuff to fs/proc/page.c
    proc: move all /proc/kcore stuff to fs/proc/kcore.c
    proc: move /proc/schedstat boilerplate to kernel/sched_stats.h
    proc: move /proc/modules boilerplate to kernel/module.c
    proc: move /proc/diskstats boilerplate to block/genhd.c
    proc: move /proc/zoneinfo boilerplate to mm/vmstat.c
    proc: move /proc/vmstat boilerplate to mm/vmstat.c
    proc: move /proc/pagetypeinfo boilerplate to mm/vmstat.c
    proc: move /proc/buddyinfo boilerplate to mm/vmstat.c
    proc: move /proc/vmallocinfo to mm/vmalloc.c
    proc: move /proc/slabinfo boilerplate to mm/slub.c, mm/slab.c
    proc: move /proc/slab_allocators boilerplate to mm/slab.c
    proc: move /proc/interrupts boilerplate code to fs/proc/interrupts.c
    proc: move /proc/stat to fs/proc/stat.c
    proc: move rest of /proc/partitions code to block/genhd.c
    proc: move /proc/cpuinfo code to fs/proc/cpuinfo.c
    proc: move /proc/devices code to fs/proc/devices.c
    proc: move rest of /proc/locks to fs/locks.c
    ...

    Linus Torvalds
     
  • 133e887f9   Merge branch 'sched-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kerne… ... Browse Code »

    …l/git/tip/linux-2.6-tip

    * 'sched-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
    sched: disable the hrtick for now
    sched: revert back to per-rq vruntime
    sched: fair scheduler should not resched rt tasks
    sched: optimize group load balancer
    sched: minor fast-path overhead reduction
    sched: fix the wrong mask_len, cleanup
    sched: kill unused scheduler decl.
    sched: fix the wrong mask_len
    sched: only update rq->clock while holding rq->lock

    Linus Torvalds
     

23 Oct, 2008

1 commit

17 Oct, 2008

2 commits

28 Sep, 2008

1 commit

23 Sep, 2008

1 commit

  • bb34d92f6   timers: fix itimer/many thread hang, v2 ... Browse Code »

    This is the second resubmission of the posix timer rework patch, posted
    a few days ago.

    This includes the changes from the previous resubmittion, which addressed
    Oleg Nesterov's comments, removing the RCU stuff from the patch and
    un-inlining the thread_group_cputime() function for SMP.

    In addition, per Ingo Molnar it simplifies the UP code, consolidating much
    of it with the SMP version and depending on lower-level SMP/UP handling to
    take care of the differences.

    It also cleans up some UP compile errors, moves the scheduler stats-related
    macros into kernel/sched_stats.h, cleans up a merge error in
    kernel/fork.c and has a few other minor fixes and cleanups as suggested
    by Oleg and Ingo. Thanks for the review, guys.

    Signed-off-by: Frank Mayhar
    Cc: Roland McGrath
    Cc: Alexey Dobriyan
    Cc: Andrew Morton
    Signed-off-by: Ingo Molnar

    Frank Mayhar
     

04 Jul, 2008

1 commit

  • 46ac22bab   sched: fix accounting in task delay accounting & migration ... Browse Code »

    On Thu, Jun 19, 2008 at 12:27:14PM +0200, Peter Zijlstra wrote:
    > On Thu, 2008-06-05 at 10:50 +0530, Ankita Garg wrote:
    >
    > > Thanks Peter for the explanation...
    > >
    > > I agree with the above and that is the reason why I did not see weird
    > > values with cpu_time. But, run_delay still would suffer skews as the end
    > > points for delta could be taken on different cpus due to migration (more
    > > so on RT kernel due to the push-pull operations). With the below patch,
    > > I could not reproduce the issue I had seen earlier. After every dequeue,
    > > we take the delta and start wait measurements from zero when moved to a
    > > different rq.
    >
    > OK, so task delay delay accounting is broken because it doesn't take
    > migration into account.
    >
    > What you've done is make it symmetric wrt enqueue, and account it like
    >
    > cpu0 cpu1
    >
    > enqueue
    >
    > dequeue
    > enqueue
    >
    > run
    >
    > Where you add both d1 and d2 to the run_delay,.. right?
    >

    Thanks for reviewing the patch. The above is exactly what I have done.

    > This seems like a good fix, however it looks like the patch will break
    > compilation in !CONFIG_SCHEDSTATS && !CONFIG_TASK_DELAY_ACCT, of it
    > failing to provide a stub for sched_info_dequeue() in that case.

    Fixed. Pl. find the new patch below.

    Signed-off-by: Ankita Garg
    Acked-by: Peter Zijlstra
    Cc: Gregory Haskins
    Cc: rostedt@goodmis.org
    Cc: suresh.b.siddha@intel.com
    Cc: aneesh.kumar@linux.vnet.ibm.com
    Cc: dhaval@linux.vnet.ibm.com
    Cc: vatsa@linux.vnet.ibm.com
    Cc: David Bahi
    Signed-off-by: Ingo Molnar

    Ankita Garg
     

19 Jun, 2008

1 commit

  • d4abc238c   sched, delay accounting: fix incorrect delay time when constantly waiting on runqueue ... Browse Code »

    This patch corrects the incorrect value of per process run-queue wait
    time reported by delay statistics. The anomaly was due to the following
    reason. When a process leaves the CPU and immediately starts waiting for
    CPU on the runqueue (which means it remains in the TASK_RUNNABLE state),
    the time of re-entry into the run-queue is never recorded. Due to this,
    the waiting time on the runqueue from this point of re-entry upto the
    next time it hits the CPU is not accounted for. This is solved by
    recording the time of re-entry of a process leaving the CPU in the
    sched_info_depart() function IF the process will go back to waiting on
    the run-queue. This IF condition is verified by checking whether the
    process is still in the TASK_RUNNABLE state.

    The patch was tested on 2.6.26-rc6 using two simple CPU hog programs.
    The values noted prior to the fix did not account for the time spent on
    the runqueue waiting. After the fix, the correct values were reported
    back to user space.

    Signed-off-by: Bharath Ravi
    Signed-off-by: Madhava K R
    Cc: dhaval@linux.vnet.ibm.com
    Cc: vatsa@in.ibm.com
    Cc: balbir@in.ibm.com
    Acked-by: Peter Zijlstra
    Signed-off-by: Ingo Molnar

    Bharath Ravi
     

29 May, 2008

1 commit

  • c6fba5451   show_schedstat(): fix memleak ... Browse Code »

    The Coverity checker spotted a memleak introduced by commit
    39106dcf85285e78f3b290022122c76f851379b8 (cpumask: use new cpus_scnprintf
    function).

    It seems the kfree() got lost between v2 and v3 of this patch...

    Signed-off-by: Adrian Bunk
    Cc: Mike Travis
    Signed-off-by: Andrew Morton
    Signed-off-by: Ingo Molnar

    Adrian Bunk
     

20 Apr, 2008

1 commit

  • 39106dcf8   cpumask: use new cpus_scnprintf function ... Browse Code »

    * Cleaned up references to cpumask_scnprintf() and added new
    cpulist_scnprintf() interfaces where appropriate.

    * Fix some small bugs (or code efficiency improvments) for various uses
    of cpumask_scnprintf.

    * Clean up some checkpatch errors.

    Signed-off-by: Mike Travis
    Signed-off-by: Ingo Molnar

    Mike Travis
     

28 Nov, 2007

1 commit

10 Nov, 2007

1 commit

  • 9a41785cc   sched: fix delay accounting regression ... Browse Code »

    Fix the delay accounting regression introduced by commit
    75d4ef16a6aa84f708188bada182315f80aab6fa. rq no longer has sched_info
    data associated with it. task_struct sched_info structure is used by delay
    accounting to provide back statistics to user space.

    also remove direct use of sched_clock() (which is not a valid thing to
    do anymore) and use rq->clock instead.

    Signed-off-by: Balbir Singh
    Signed-off-by: Ingo Molnar

    Balbir Singh
     

19 Oct, 2007

1 commit

  • 480b9434c   sched: reduce schedstat variable overhead a bit ... Browse Code »

    schedstat is useful in investigating CPU scheduler behavior. Ideally,
    I think it is beneficial to have it on all the time. However, the
    cost of turning it on in production system is quite high, largely due
    to number of events it collects and also due to its large memory
    footprint.

    Most of the fields probably don't need to be full 64-bit on 64-bit
    arch. Rolling over 4 billion events will most like take a long time
    and user space tool can be made to accommodate that. I'm proposing
    kernel to cut back most of variable width on 64-bit system. (note,
    the following patch doesn't affect 32-bit system).

    Signed-off-by: Ken Chen
    Signed-off-by: Ingo Molnar

    Ken Chen
     

15 Oct, 2007

2 commits

  • 2d72376b3   sched: clean up schedstats, cnt -> count ... Browse Code »

    rename all 'cnt' fields and variables to the less yucky 'count' name.

    yuckage noticed by Andrew Morton.

    no change in code, other than the /proc/sched_debug bkl_count string got
    a bit larger:

    text data bss dec hex filename
    38236 3506 24 41766 a326 sched.o.before
    38240 3506 24 41770 a32a sched.o.after

    Signed-off-by: Ingo Molnar
    Reviewed-by: Thomas Gleixner

    Ingo Molnar
     
  • 75d4ef16a   sched: fix delay accounting performance regression ... Browse Code »

    fix delay accounting performance regression - those sched_clock()
    calls are not needed.

    Signed-off-by: Ingo Molnar
    Signed-off-by: Peter Zijlstra
    Reviewed-by: Thomas Gleixner

    Ingo Molnar
     

02 Aug, 2007

1 commit

10 Jul, 2007

2 commits