16 Oct, 2007

1 commit

  • Introduce ccflags-y, asflags-y and ldflags-y so we soon can
    deprecate use of EXTRA_CFLAGS, EXTRA_AFLAGS and EXTRA_LDFLAGS.
    This patch does not touch any in-tree users - thats next round.
    Lets get this committed first and then fix the users of the
    soon to be deprecated variants next.

    The rationale behind this change is to introduce support for
    makefile fragments like:

    ccflags-$(CONFIG_WHATEVER_DEBUG) := -DDEBUG

    As a replacement for the uglier:
    ifeq ($(CONFIG_WHATEVER_DEBUG),y)
    EXTRA_CFLAGS := -DDEBUG
    endif

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

15 Oct, 2007

1 commit

  • External modules have in a few cases modifed gcc option
    by modifying CFLAGS. This has never been documented and
    was a bad practice.
    With the check to use KBUILD_CFLAGS it will no longer work
    so we better error out and tell what was wrong as a service
    to the external module users.

    This check can be overruled if
    KBUILD_NOPEDANTIC is set to something.
    Addid this possibility may allow older external
    module to build without any code modifications but potentially
    only loosing some un-important gcc options.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

13 Oct, 2007

2 commits

  • These checks has been present for several kernel releases (> 5).
    So lets just get rid of them.
    With this we no longer check for use of:
    EXTRA_TARGETS, O_TARGET, L_TARGET, list-multi, export-objs

    There were three remaining in-tree users of O_TARGET in some
    unmaintained sh64 code - mail sent to the maintainer + list.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • EXTRA_ARFLAGS have never been used so no need to carry
    around on this.
    A google search did not reveal any external module
    using this either.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

26 Jul, 2007

1 commit

  • Sam Ravnborg pointed out that Documentation/kbuild/makefiles.txt already
    says this is what it's for. This patch makes the reality live up to the
    documentation. This fixes the problem of LDFLAGS_BUILD_ID getting into too
    many places.

    Signed-off-by: Roland McGrath
    Signed-off-by: Sam Ravnborg

    Roland McGrath
     

17 Jul, 2007

1 commit


06 May, 2007

1 commit


25 Sep, 2006

1 commit

  • Consistently decide when to rebuild a target across all of
    if_changed, if_changed_dep, if_changed_rule.
    PHONY targets are now treated alike (ignored) for all targets

    While add it make Kbuild.include almost readable by factoring out a few
    bits to some common variables and reuse this in Makefile.build.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

01 Jul, 2006

1 commit

  • kbuild used $¤(*F to get filename of target without extension.
    This was used in several places all over kbuild, but introducing
    make -rR broke his for all cases where we specified full path to
    target/prerequsite. It is assumed that make -rR disables old style
    suffix-rules which is why is suddenly failed.

    ia64 was impacted by this change because several div* routines in
    arch/ia64/lib are build using explicit paths and then kbuild failed.

    Thanks to David Mosberger-Tang for an explanation
    what was the root-cause and for testing on ia64.

    This patch also fixes two uses of $(*F) in arch/um

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

27 Jun, 2006

1 commit

  • This reverts commit e5c44fd88c146755da6941d047de4d97651404a9.

    Thanks to Daniel Ritz and Michal Piotrowski for noticing the problem.

    Daniel says:

    "[The] reason is a recent change that made modules always shows as
    module.mod. it breaks modprobe and probably many scripts..besides
    lsmod looking horrible

    stuff like this in modprobe.conf:
    install pcmcia_core /sbin/modprobe --ignore-install pcmcia_core; /sbin/modprobe pcmcia
    makes modprobe fork/exec endlessly calling itself...until oom
    interrupts it"

    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

25 Jun, 2006

2 commits

  • Here is a patch that adds a new -T option to genksyms for generating dumps of
    the type definition that makes up the symbol version hashes. This allows to
    trace modversion changes back to what caused them. The dump format is the
    name of the type defined, followed by its definition (which is almost C):

    s#list_head struct list_head { s#list_head * next , * prev ; }

    The s#, u#, e#, and t# prefixes stand for struct, union, enum, and typedef.
    The exported symbols do not define types, and thus do not have an x# prefix:

    nfs4_acl_get_whotype int nfs4_acl_get_whotype ( char * , t#u32 )

    The symbol type defintion of a single file can be generated with:

    make fs/jbd/journal.symtypes

    If KBUILD_SYMTYPES is defined, all the *.symtypes of all object files that
    export symbols are generated.

    The single *.symtypes files can be combined into a single file after a kernel
    build with a script like the following:

    for f in $(find -name '*.symtypes' | sort); do
    f=${f#./}
    echo "/* ${f%.symtypes}.o */"
    cat $f
    echo
    done \
    | sed -e '\:UNKNOWN:d' \
    -e 's:[,;] }:}:g' \
    -e 's:\([[({]\) :\1:g' \
    -e 's: \([])},;]\):\1:g' \
    -e 's: $::' \
    $f \
    | awk '
    /^.#/ { if (defined[$1] == $0) {
    print $1
    next
    }
    defined[$1] = $0
    }
    { print }
    '

    When the kernel ABI changes, diffing individual *.symtype files, or the
    combined files, against each other will show which symbol changes caused the
    ABI changes. This can save a tremendous amount of time.

    Dump the types that make up modversions

    Signed-off-by: Andreas Gruenbacher
    Signed-off-by: Sam Ravnborg

    Andreas Gruenbacher
     
  • make failed to supply the filename when using make -rR and using $(*F)
    to get target filename without extension.
    This bug was not reproduceable in small scale but using:
    $(basename $(notdir $@)) fixes it with same functionality.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

09 Jun, 2006

1 commit

  • This fixes one of the worst kbuild warts left - the broken dependencies used
    to check and regenerate the .config file. This was done via an indirect
    dependency and the .config itself had an empty command, which can cause make
    not to reread the changed .config file.

    Instead of this we generate now a new file include/config/auto.conf from
    .config, which is used for kbuild and has the proper dependencies. It's also
    the main make target now for all files generated during this step (and thus
    replaces include/linux/autoconf.h).

    This also means we can now relax the syntax requirements for the .config file
    and we don't have to rewrite it all the time, i.e. silentoldconfig only
    writes .config now when it's necessary to keep it in sync with the Kconfig
    files and even this can be suppressed by setting the environment variable
    KCONFIG_NOSILENTUPDATE, so the update can (and must) be done manually.

    Signed-off-by: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Roman Zippel
     

13 Mar, 2006

2 commits

  • Add -fverbose-asm to i386 Makefile rule for building .s files. This makes
    the assembler output much more readable for humans.

    Suggested by Der Herr Hofrat

    Signed-off-by: Chuck Ebbert
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Chuck Ebbert
     
  • genksyms needs to know when a symbol must have a "_" prefex as is
    true for a few architectures.
    Pass $(ARCH) as commandline argument and hardcode what architectures that
    needs this info.
    Previous attemt to take it from elfconfig.h was br0ken since elfconfig.h
    is a generated file.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

06 Mar, 2006

1 commit

  • The kbuild system takes advantage of an incorrect behavior in GNU make.
    Once this behavior is fixed, all files in the kernel rebuild every time,
    even if nothing has changed. This patch ensures kbuild works with both
    the incorrect and correct behaviors of GNU make.

    For more details on the incorrect behavior, see:

    http://lists.gnu.org/archive/html/bug-make/2006-03/msg00003.html

    Changes in this patch:
    - Keep all targets that are to be marked .PHONY in a variable, PHONY.
    - Add .PHONY: $(PHONY) to mark them properly.
    - Remove any $(PHONY) files from the $? list when determining whether
    targets are up-to-date or not.

    Signed-off-by: Paul Smith
    Signed-off-by: Sam Ravnborg

    Paul Smith
     

19 Feb, 2006

2 commits

  • While the recent change to also escape # symbols when storing C-file
    compilation command lines was helpful, it should be in effect for all
    command lines, as much as the dollar escaping should be in effect for
    C-source compilation commands. Additionally, for better readability and
    maintenance, consolidating all the escaping (single quotes, dollars,
    and now sharps) was also desirable.

    Signed-Off-By: Jan Beulich
    Signed-off-by: Sam Ravnborg

    Jan Beulich
     
  • Move $(CC) support functions to Kbuild.include so they are available
    in the kbuild files.
    In addition the following was done:
    o as-option documented in Documentation/kbuild/makefiles.txt
    o Moved documentation to new section to match
    new scope of functions
    o added cc-ifversion used to conditionally select a text string
    dependent on actual $(CC) version
    o documented cc-ifversion
    o change so Kbuild.include is read before the kbuild file

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

07 Jan, 2006

1 commit


28 Jul, 2005

1 commit

  • kbuild failed to locate Makefile for external modules.
    This brought to my attention how the variables for directories
    have different values in different usage scenarios.

    Different kbuild usage scenarios:
    make - plain make in same directory where kernel source lives
    make O= - kbuild is told to store output files in another directory
    make M= - building an external module
    make O= M= - building an external module with kernel output seperate from src

    Value assigned to the different variables:

    |$(src) |$(obj) |$(srctree) |$(objtree)
    make |reldir to k src |as src |abs path to k src |abs path to k src
    make O= |reldir to k src |as src |abs path to k src |abs path to output dir
    make M= |abs path to src |as src |abs path to k src |abs path to k src
    make O= M= |abs path to src |as src |abs path to k src |abs path to k output

    path to kbuild file:

    make | $(srctree)/$(src), $(src)
    make O= | $(srctree)/$(src)
    make M= | $(src)
    make O= M= | $(src)

    From the table above it can be seen that the only good way to find the
    home directory of the kbuild file is to locate the one of the two variants
    that is an absolute path. If $(src) is an absolute path (starts with /)
    then use it, otherwise prefix $(src) with $(srctree).

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

26 Jul, 2005

2 commits

  • kbuild failed to locate Kbuild.include.
    Teach kbuild how to find Kbuild files when using make O=...

    Signed-off-by: Sam Ravnborg
    ---

    Sam Ravnborg
     
  • Kbuild.include is a placeholder for definitions originally present in
    both the top-level Makefile and scripts/Makefile.build.
    There were a slight difference in the filechk definition, so the most videly
    used version was kept and usr/Makefile was adopted for this syntax.

    Signed-off-by: Sam Ravnborg
    ---

    Sam Ravnborg
     

15 Jul, 2005

1 commit

  • From: Matthew Wilcox
    I inadvertently built a tree as root and then rebuilt it as a user. I
    got a lot of prompts ...

    mv: overwrite `drivers/char/drm/drm_auth.o', overriding mode 0644?

    Using mv -f fixes that.

    Signed-off-by: Matthew Wilcox
    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

24 Jun, 2005

1 commit


17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds