21 Feb, 2008
10 commits
-
This fixes the pcicore driver to not die a horrible
crash death when inserting a cardbus card.Signed-off-by: Michael Buesch
Signed-off-by: John W. Linville -
This fixes the GPIO API to be reentrancy safe.
Signed-off-by: Michael Buesch
Signed-off-by: John W. Linville -
This fixes the GPIO API to be usable.
Signed-off-by: Michael Buesch
Signed-off-by: John W. Linville -
This fixes the SSB watchdog access for devices without a chipcommon.
These devices have the watchdog on the extif.Signed-off-by: Michael Buesch
Signed-off-by: John W. Linville -
This fixes the baud settings for new devices
like the Linksys WRT350n.Signed-off-by: Michael Buesch
Signed-off-by: John W. Linville -
'u64' is not necessarily 'unsigned long long'
drivers/net/wireless/ath5k/base.c: In function 'ath5k_beacon_update_timers':
drivers/net/wireless/ath5k/base.c:2130: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'u64'
drivers/net/wireless/ath5k/base.c:2130: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'u64'
drivers/net/wireless/ath5k/base.c: In function 'ath5k_intr':
drivers/net/wireless/ath5k/base.c:2391: warning: format '%llx' expects type 'long long unsigned int', but argument 6 has type 'u64'Signed-off-by: David S. Miller
Signed-off-by: John W. Linville -
sparse sees int -> bool cast as an error:
hw.c:3754:10: warning: cast truncates bits from constant value (ffffffea becomes 0)
Fix it by converting the rettype to int and check appropriately.Signed-off-by: Jiri Slaby
Cc: Nick Kossifidis
Cc: Luis R. Rodriguez
Signed-off-by: John W. Linville -
Omitted lock causes sparse warning
drivers/net/wireless/ath5k/base.c:1682:1: warning: context imbalance in 'ath5k_tasklet_rx' - different lock contexts for basic blockAdd the lock to the guilty fail path.
Signed-off-by: Jiri Slaby
Acked-by: Nick Kossifidis
Cc: Luis R. Rodriguez
Signed-off-by: John W. Linville -
Based on report from Cavan Carroll :
http://bugzilla.kernel.org/show_bug.cgi?id=9863
Cc: Cavan Carroll
Signed-off-by: John W. Linville -
Retarget of an old patch against prism54usb in linux-wireless archive:
http://marc.info/?l=linux-wireless&m=117449935810254&w=2
Cc: Ivo Couckuyt
Signed-off-by: John W. Linville
20 Feb, 2008
15 commits
-
release_net is missed on the error path in pneigh_lookup.
Signed-off-by: Denis V. Lunev
Signed-off-by: David S. Miller -
This counter is currently write-only.
Drawing an analogy with the similar tcp counter, I think
that this one should be pointed by the sockets_allocated
members of sctp_prot and sctpv6_prot.Signed-off-by: Pavel Emelyanov
Acked-by: Vlad Yasevich
Signed-off-by: David S. Miller -
When deleting the veth driver, veth_close calls netif_carrier_off
for the two extremities of the network device. netif_carrier_off on
the peer device will fire an event and hold a reference on the peer
device. Just after, the peer is unregistered taking the rtnl_lock while
the linkwatch_event is scheduled. If __linkwatch_run_queue does not
occurs before the unregistering, unregister_netdevice will wait for
the dev refcount to reach zero holding the rtnl_lock and linkwatch_event
will wait for the rtnl_lock and hold the dev refcount.Signed-off-by: Daniel Lezcano
Signed-off-by: David S. Miller -
From: Matheos Worku
1) niu_enable_alt_mac() needs to be adjusted so that the mask
is computed properly for the BMAC case.2) BMAC has 6 alt MAC addresses available, not 7.
Signed-off-by: David S. Miller
-
As reported by David Woodhouse , using u_int32_t
in struct nf_inet_addr breaks the busybox build. Fix by using __u32.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
The host address parts need to be converted to host-endian first
before arithmetic makes any sense on them.Signed-off-by: Jan Engelhardt
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
By allocating ->hinfo, we already have the needed indirection to cope
with the per-cpu xtables struct match_entry.[Patrick: do this now before the revision 1 struct is used by userspace]
Signed-off-by: Jan Engelhardt
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Since the header file xt_policy.h tests __KERNEL__, it should be
unifdef'ed before exporting to userspace.Signed-off-by: Robert P. J. Day
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
http://bugzilla.kernel.org/show_bug.cgi?id=9920
The function skb_make_writable returns true or false.Signed-off-by: Joonwoo Park
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
The int ret variable is used only to trigger the BUG_ON() after
the skb_copy_bits() call, so check the call failure directly
and drop the variable.Signed-off-by: Pavel Emelyanov
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
As reported by Tomas Simonaitis ,
inserting new data in skbs queued over {ip,ip6,nfnetlink}_queue
triggers a SKB_LINEAR_ASSERT in skb_put().Going back through the git history, it seems this bug is present since
at least 2.6.12-rc2, probably even since the removal of
skb_linearize() for netfilter.Linearize non-linear skbs through skb_copy_expand() when enlarging
them. Tested by Thomas, fixes bugzilla #9933.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Unless I miss a guaranteed relation between between "f" and
"new_fa->fa_info" this patch is required for fixing a NULL dereference
introduced by commit a6501e080c318f8d4467679d17807f42b3a33cd5 ("[IPV4]
FIB_HASH: Reduce memory needs and speedup lookups") and spotted by the
Coverity checker.Eric Dumazet says:
Hum, you are right, kmem_cache_free() doesnt allow a NULL
object, like kfree() does.Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
The Coverity checker spotted that less memory than required was
allocated.Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
IFLA_LINK is no longer a write-only attribute on the kernel side and
must thus be validated. Same goes for the newly introduced
IFLA_LINKINFO.Fixes undefined behaviour if either of the attributes are not well
formed.Signed-off-by: Thomas Graf
Signed-off-by: David S. Miller -
Commit a0a400d79e3dd7843e7e81baa3ef2957bdc292d0 ("[NET]: dev_mcast:
add multicast list synchronization helpers") from you introduced a new
field "da_synced" to struct dev_addr_list that is not properly
initialized to 0. So when any of the current users (8021q, macvlan,
mac80211) calls dev_mc_sync/unsync they mess the address list for both
devices.The attached patch fixed it for me and avoid future problems.
Signed-off-by: Jorge Boncompte [DTI2]
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller
19 Feb, 2008
8 commits
-
Signed-off-by: David S. Miller
-
BMAC port alternate MAC address index needs to start at 1. Index 0 is
used for the main MAC address.Signed-off-by: Matheos Worku
Signed-off-by: David S. Miller -
Add missing structure kernel-doc descriptions to sock.h & skbuff.h
to fix kernel-doc warnings.(I think that Stephen H. sent a similar patch, but I can't find it.
I just want to kill the warnings, with either patch.)Signed-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
The result of the ip_route_output is not assigned to skb. This means that
- it is leaked
- possible OOPS below dereferrencing skb->dst
- no ICMP message for this caseSigned-off-by: Denis V. Lunev
Signed-off-by: David S. Miller -
hci conn child devices other than rfcomm tty should not be moved here.
This is my lost, thanks for Barnaby's reporting and testing.Signed-off-by: Dave Young
Signed-off-by: David S. Miller -
Move hci_dev_put to del_conn to avoid hci dev going away before hci conn.
Signed-off-by: Dave Young
Signed-off-by: David S. Miller -
Patrick McHardy notes that print_mac() can get invoked
even if the result it unused (f.e. as an argument to
pr_debug() when DEBUG is not defined).Mark this function as "__pure" to eliminate this problem.
Signed-off-by: David S. Miller
18 Feb, 2008
7 commits
-
net/bluetooth/hci_sysfs.c: In function ‘del_conn’:
net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment used as truth valueSigned-off-by: David S. Miller
-
MAC_FMT is no longer used
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Remove direct use of MAC_FMT
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Keep ordering of policy entries with same selector in
xfrm_dst_hash_transfer().Issue should not appear in usual cases because multiple policy entries
with same selector are basically not allowed so far. Bug was pointed
out by Sebastien Decugis .We could convert bydst from hlist to list and use list_add_tail()
instead.Signed-off-by: YOSHIFUJI Hideaki
Acked-by: Sebastien Decugis
Signed-off-by: David S. Miller -
The functions time_before, time_before_eq, time_after, and
time_after_eq are more robust for comparing jiffies against other
values.So following patch implements usage of the time_after() macro, defined
at linux/jiffies.h, which deals with wrapping correctlySigned-off-by: S.Çağlar Onur
Acked-by: Marcel Holtmann
Signed-off-by: David S. Miller -
Rusty hardcoded the old module code.
We can remove it now.Signed-off-by: Wang Chen
Signed-off-by: David S. Miller -
Everything that is called from netlbl_init() can be marked with
__init. This moves 620 bytes from .text section to .text.init one.Signed-off-by: Pavel Emelyanov
Acked-by: Paul Moore
Signed-off-by: David S. Miller
