08 Jan, 2010
1 commit
-
The patch "sbawe: fix memory detection" fixed detection
for memoryless SB32 cards but broke detection of memory
above 512KB. This patch fixes the regression.The patch has been tested on the SB32 card (CT3670) with
0MB, 2MB and 8MB memory installed.Signed-off-by: Krzysztof Helt
Signed-off-by: Jaroslav Kysela
21 Dec, 2009
1 commit
-
Memory amount is increased before a successful write-read
sequence is done. Thus, 512 kB of onboard memory is detected
on memoryless cards like SB32.Move the increasing of memory counter after successful read
is done.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
19 Dec, 2009
1 commit
-
Use kzalloc rather than kcalloc(1,...)
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)//
@@
@@- kcalloc(1,
+ kzalloc(
...)
//Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai
15 Dec, 2009
1 commit
14 Dec, 2009
1 commit
-
sizeof(share_id) is just the size of the pointer. On the other hand,
block->share_id is an array, so its size seems more appropriate.A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)//
@@
expression *x;
expression f;
type T;
@@*f(...,(T)x,...)
//Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai
13 Dec, 2009
1 commit
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
ALSA: hda - Overwrite pin config on intel DG45ID board.
intelhdmi - dont power off HDA link
ALSA: hrtimer - Fix lock-up
ALSA: intelhdmi - add channel mapping for typical configurations
ALSA: intelhdmi - channel mapping applies to Pin
ALSA: intelhdmi - accept DisplayPort pin
ALSA: hda - show HBR(High Bit Rate) pin cap in procfs
ALSA: hda - Fix LED GPIO setup for HP laptops with IDT codecs
ASoC: Fix build of OMAP sound drivers
ALSA: opti93x: fix irq releasing if the irq cannot be allocated
10 Dec, 2009
3 commits
-
Use the chip->irq to check if the irq should be released so the irq is not released
if it has not been allocated.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai -
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
ALSA: ice1724 - aureon - modify WM8770 Master & DAC volume
ALSA: hda/realtek: quirk for D945GCLF2 mainboard
ALSA: hda - Terradici HDA controllers does not support 64-bit mode
ALSA: document: Add direct git link to grub hda-analyzer
ALSA: radio/sound/miro: fix build, cleanup depends/selects
ALSA: hda - Generalize EAPD inversion check in patch_analog.c
ASoC: Wrong variable returned on error
ALSA: snd-usb-us122l: add product IDs of US-122MKII and US-144MKII
ALSA: hda - Exclude unusable ADCs for ALC88x
ALSA: hda - Add missing Line-Out and PCM switches as slave
ALSA: hda - iMac 9,1 sound patch.
ALSA: opti93x: set MC indirect registers base from PnP data -
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (42 commits)
tree-wide: fix misspelling of "definition" in comments
reiserfs: fix misspelling of "journaled"
doc: Fix a typo in slub.txt.
inotify: remove superfluous return code check
hdlc: spelling fix in find_pvc() comment
doc: fix regulator docs cut-and-pasteism
mtd: Fix comment in Kconfig
doc: Fix IRQ chip docs
tree-wide: fix assorted typos all over the place
drivers/ata/libata-sff.c: comment spelling fixes
fix typos/grammos in Documentation/edac.txt
sysctl: add missing comments
fs/debugfs/inode.c: fix comment typos
sgivwfb: Make use of ARRAY_SIZE.
sky2: fix sky2_link_down copy/paste comment error
tree-wide: fix typos "couter" -> "counter"
tree-wide: fix typos "offest" -> "offset"
fix kerneldoc for set_irq_msi()
spidev: fix double "of of" in comment
comment typo fix: sybsystem -> subsystem
...
08 Dec, 2009
1 commit
-
The PnP data on the OPTI931 and OPTI933 contains io port
range for the MC indirect registers. Use the PnP range
instead of hardwired value 0xE0E.Also, request region of MC indirect registers so it is
marked as used to other drivers (this was missing previously).Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
04 Dec, 2009
2 commits
-
That is "success", "unknown", "through", "performance", "[re|un]mapping"
, "access", "default", "reasonable", "[con]currently", "temperature"
, "channel", "[un]used", "application", "example","hierarchy", "therefore"
, "[over|under]flow", "contiguous", "threshold", "enough" and others.Signed-off-by: André Goddard Rosa
Signed-off-by: Jiri Kosina
03 Dec, 2009
1 commit
-
Remove snd_opti9xx fields which are indirect arguments to
the snd_opti9xx_configure(). Pass these values as function
arguments.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
30 Nov, 2009
2 commits
-
The PCM12 and PCM20 can be set into the ISA PnP mode. The PCM12 PnP
was sold as the PnP device.
Add code to handle detection of these cards using ISA PnP framework.Tested on the PCM20 in PnP mode. The PCM12 PnP has the same MS Windows
INF file except for a card name displayed for user.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai -
Separate common probing code in order to use it
for PnP probing.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
27 Nov, 2009
1 commit
-
If a hardware is not detected there is a kernel crash
due to not initialized snd_miro->aci pointer. This pointer
is initialized after detection of the opti (miro) chip.This bug was introduced by patches to expose
ACI mikser outside the snd-miro driver.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
23 Nov, 2009
2 commits
-
The ACI mixer is used to control the radio FM module
installed on the Miro PCM20 sound card. Expose ACI mixer
outside the sound card driver.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai -
Move the miro.h header to the include/sound directory. It can
be used in the Miro PCM20 radio driver (v4l).Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
22 Nov, 2009
1 commit
-
Remove the snd_card pointer from the snd_miro structure and
do some small code improvements.Also, move Opti chipset detection before detection of the
ACI mixer, so the mci_base value is set in one place only.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
19 Nov, 2009
1 commit
-
Use db scale for all volume controls according to Crystal's datasheets.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
18 Nov, 2009
3 commits
-
To fix a build error
sound/isa/opti9xx/miro.c:1281: error: expected ';' before '}' tokenSigned-off-by: Takashi Iwai
-
Use the fm_port and mpu_port variables directly in a probe function.
This completely eliminates a need to copy the fm_port value to
the snd_miro structure.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai -
Update control names to be more closer to their meaning.
Change the "Mono" name to the "Beep" as this line is usually
used to forward the PC beeper signal to sound card's output.
Update names for both cs423x and wss.Clean up cs4235 controls according to the cs4235 doc. Rename
some of the cs4235 controls to be consistent with the cs4236's
ones.Also, delete one misnamed cs4231 register define.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
08 Nov, 2009
1 commit
-
1. Set the third argument of the snd_device_new to not NULL, so there is
no warning about bug during chip detection. The third argument is not
used in this driver. It was changed in my previous patch.2. Remove the fm_port and mpu_port fields from the snd_es18xx structure.
They can be converted to function arguments.3. Remove the dmaN_size fields from the snd_es18xx structure. These
values are used only in pointer functions and can be easily calculated.4. Remove the ctrl_lock spinlock which is used only in one read function
which is called once during chip initialization. There are many
writes to the same register and they are not protected on purpose
(see the comment ina the snd_es18xx_config_write()).5. Use the first part of the text5Sources string table as the text4Soruces
table (they are the same).6. Merge the same cases for the ES1887 and ES1888 when setting chip's caps.
7. Move the snd_es18xx_reset() to __devinit section.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
06 Nov, 2009
1 commit
-
The cs4236 was two step detection with call to the snd_wss_free()
between two steps. The snd_wss_free() did not free a sound device
created in the snd_wss_create(). This caused an OOPS during module
removal as the same sound device was released twice. The same OOPS
happened if the cs4236 module loading failed.Fix this by adapting the snd_cs4236_create() to correctly work with
chips less capable then cs4236. The snd_cs4236_create() behaves the
same as the snd_wss_create() if the chip is less capable than the cs4236.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
05 Nov, 2009
1 commit
-
To avoid confusion in control names for the standard analog PC Beep generator
using a small Internal PC Speaker, rename all related "PC Speaker" and "PC
Beep" controls to "Beep" only. This name is more universal and can be also
used on more platforms without confusion.Introduce also "Internal Speaker" in ControlNames.txt for systems with
full-featured build-in internal speaker.Signed-off-by: Jaroslav Kysela
Signed-off-by: Takashi Iwai
30 Oct, 2009
2 commits
-
Remove intermediate snd_audiodrive structure between
snd_card structure and snd_es18xx. This reduces size of
source code and binary driver.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai -
The snd_card pointer is redundant and code can be easily
changed to work without it.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
12 Oct, 2009
1 commit
-
The C4231 control set is a superset of the AD1848 control
set so reuse the CS4231 controls definitions for the AD1848.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
10 Oct, 2009
2 commits
-
Convert CS4231 mixer to dB scale after AD1848 mixer.
Also, add missing microphone boost control for the AD1848
and correct wrong bits for loopback volume on the AD1848.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai -
Fix coding style errors in the driver.
Also, add missing argument for CMD_XXX_MIDI_VOL command.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
06 Oct, 2009
2 commits
-
Module parameters shouldn't be marked as __devinitdata since they can be
referred via sysfs even after probing.Signed-off-by: Takashi Iwai
-
Old Soundscape cards (pre PnP) work only with AD1848 codecs.
If the CS4231 codec is installed it must be used in AD1848
compatible mode.Also, add gameport support and remove an unused mpu field.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
04 Oct, 2009
1 commit
-
There is no sense to limit open MIDI connections with limit
as high as ULONG_MAX.Also, convert more messages to use the snd_printk.
Correct few old and misleading comments as well.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
01 Oct, 2009
1 commit
-
The conversion solves the problem that firmware size was set to 64KB
while non PnP cards have 128KB firmware files.An additional firmware initialization code has been moved from the OSS
driver.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
28 Sep, 2009
1 commit
-
Move code from the OSS sscape driver in order to support old Soundscape OEM models.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
10 Sep, 2009
1 commit
-
* topic/cmi8330:
ALSA: cmi8330: Allow MPU-401-less operation
ALSA: cmi8330: find OPL3 port automatically
cmi8330: Add basic CMI8329 support
ALSA: cmi8330: revert comments about AD1848 back
19 Jul, 2009
1 commit
-
If spin_lock_irqsave is called twice in a row with the same second
argument, the interrupt state at the point of the second call overwrites
the value saved by the first call. Indeed, the second call does not need
to save the interrupt state, so it is changed to a simple spin_lock.The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)//
@@
expression lock1,lock2;
expression flags;
@@*spin_lock_irqsave(lock1,flags)
... when != flags
*spin_lock_irqsave(lock2,flags)
//Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai
08 Jul, 2009
1 commit
-
Adding MPU-401 support to cmi8330 driver could cause a regression (non-working
sound) on a system where there is no free IRQ for the MPU-401 device (which
is not very uncommon as this card requires two separate IRQs plus a third one
for MPU-401).When MPU-401 PnP configuration fails (mostly because of unavailable IRQ), just
ignore MPU-401 and continue without it.Signed-off-by: Ondrej Zary
Signed-off-by: Takashi Iwai
07 Jul, 2009
1 commit
-
My CMI8329 had OPL3 port specified in SB16 resources. But now I found out that
it was my modification of the card's PnP EEPROM a couple of years ago (can be
done using C9SETROM.EXE utility). I did it because the OPL3 port was
completely missing from PnP data. It seems to be hardwired to 0x388 on
CMI8329.Find OPL3 port automatically by searching in WSS and SB16 resources. If not
found, assume that it's hardwired to 0x388.Signed-off-by: Ondrej Zary
Signed-off-by: Takashi Iwai