02 Jul, 2011
11 commits
-
Make the case labels the same indent as the switch.
git diff -w shows useless break;s removed after returns
and a comment added to an unnecessary default: break;
because of a dubious gcc warning.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Make the case labels the same indent as the switch.
git diff -w shows code on same line as case moved
to separate lines and a "/* Fallthrough */" comment
added where appropriate.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Make the case labels the same indent as the switch.
git diff -w shows 80 column reflowing.
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Make the case labels the same indent as the switch.
git diff -w shows 80 column reflowing,
removal of a useless break after return, and moving
open brace after case instead of separate line.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Make the case labels the same indent as the switch.
git diff -w shows no difference.
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Make the case labels the same indent as the switch.
git diff -w shows miscellaneous 80 column wrapping,
comment reflowing and a comment for a useless gcc
warning for an otherwise unused default: case.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Make the case labels the same indent as the switch.
git diff -w shows miscellaneous 80 column wrapping.
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Make the case labels the same indent as the switch.
Simplify a default case / return (unreached)
Remove unnecessary break after return.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Make the case labels the same indent as the switch.
git diff -w shows differences for line wrapping.
(fit multiple lines to 80 columns, join where possible)Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Make the case labels the same indent as the switch.
(git diff -w net/appletalk shows no difference)
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
This patch adds a change sequence counter to each net namespace
which is bumped whenever a netdevice is added or removed from
the list. If such a change occurred while a link dump took place,
the dump will have the NLM_F_DUMP_INTR flag set in the first
message which has been interrupted and in all subsequent messages
of the same dump.Note that links may still be modified or renamed while a dump is
taking place but we can guarantee for userspace to receive a
complete list of links and not miss any.Testing:
I have added 500 VLAN netdevices to make sure the dump is split
over multiple messages. Then while continuously dumping links in
one process I also continuously deleted and re-added a dummy
netdevice in another process. Multiple dumps per seconds have
had the NLM_F_DUMP_INTR flag set.I guess we can wait for Johannes patch to hit net-next via the
wireless tree. I just wanted to give this some testing right away.Signed-off-by: Thomas Graf
Signed-off-by: David S. Miller
01 Jul, 2011
18 commits
-
There is no need to check for the address being a multicast address in
the netdev_for_each_mc_addr loop, so remove it.Signed-off-by: Tobias Klauser
Signed-off-by: David S. Miller -
It may be set in the card while the driver is probed by kdump kernel after a
crash.Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
On some skews, the BE card sends pause frames (and not drop pkts) if there are
no more posted buffers available for packet reception. This behaviour has a
side effect: When an interface is disabled, buffers are no longer posted on the
corresponding RX rings. All broadcast and multicast traffic being received on
the port will quickly fill up the PMEM and cause pause push back. As the PMEM
is shared by both the ports, all traffic being received on the other (enabled)
port also gets stalled.
The fix is to destroy RX rings when the interface is disabled. If there is no
RX ring match in the RXF lookup, the packets are discarded and so don't hog the
PMEM.
The RXQ creation cmd must now use MCC instead of MBOX as they are are called
post MCC queue creation.Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
Some (older)versions of cards/fw may not recognize certain cmds and
return illegal/unsupported errors. As long as the driver can handle
this gracefully there is no need to log an error msg.
Also finetuned 2 existing error log messages.Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
o Add external loopback test in self test:
- Send set external loopback mode request to fw.
To quiscent other storage functions.
- Perform test
- Send unset loopback mode request to fw.o Rename ilb to lb.
o Update driver version 5.0.20.Signed-off-by: Sucheta Chakraborty
Signed-off-by: Amit Kumar Salecha
Signed-off-by: David S. Miller -
External loopback test can be performed by application without any driver
support on normal Ethernet cards.
But on CNA devices, where multiple functions share same physical port.
Here internal loopback test and external loopback test can be initiated by
multiple functions at same time. To co exist all functions, firmware need
to regulate what test can be run by which function. So before performing external
loopback test, command need to send to firmware, which will quiescent other functions.User may not want to run external loopback test always. As special cable need to be
connected for this test.
So adding explicit flag in ethtool self test, which will specify interface
to perform external loopback test.
ETH_TEST_FL_EXTERNAL_LB: Application set to request external loopback test
ETH_TEST_FL_EXTERNAL_LB_DONE: Driver ack if test performedSigned-off-by: Amit Kumar Salecha
Reviewed-by: Ben Hutchings
Signed-off-by: David S. Miller -
There is no need to check for the address being a multicast address in
the netdev_for_each_mc_addr loop, so remove it.Signed-off-by: Tobias Klauser
Signed-off-by: David S. Miller -
There is no need to check for the address being a multicast address in
the netdev_for_each_mc_addr loop, so remove it.Signed-off-by: Tobias Klauser
Signed-off-by: David S. Miller -
There is no need to check for the address being a multicast address in
the netdev_for_each_mc_addr loop, so remove it.Signed-off-by: Tobias Klauser
Signed-off-by: David S. Miller -
There is no need to check for the address being a multicast address in
the netdev_for_each_mc_addr loop, so remove it.Signed-off-by: Tobias Klauser
Acked-by: Russell King
Signed-off-by: David S. Miller -
This is error path calls unlock_irq() where we haven't disabled the
IRQs. The comment says that this error path can never happen.Signed-off-by: Dan Carpenter
Signed-off-by: David S. Miller -
…rdable' function, which is subroutine of 'dev_forward_skb'.
Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net> -
1. Using enum name instead of numeric value.
2. device_set_wakeup_enable expect bool argument
adding !!() to the argument to be passed.
3. Remove non-jme-hardware related operations from
jme_clear_pm()
4. Reuse jme_clear_pm() in jme_resume() and jme_powersave_phy()Signed-off-by: Guo-Fu Tseng
Signed-off-by: David S. Miller -
SIMPLE_DEV_PM_OPS is using SET_SYSTEM_SLEEP_PM_OPS
and SET_SYSTEM_SLEEP_PM_OPS is empty when CONFIG_PM_SLEEP
is not defined.Switching #ifdef CONFIG_PM to #ifdef CONFIG_PM_SLEEP
Signed-off-by: Guo-Fu Tseng
Signed-off-by: David S. Miller -
There's no need for "default N' (or 'default n') as it's default.
Signed-off-by: Kurt Van Dijck
Acked-by: Marc Kleine-Budde
Signed-off-by: David S. Miller -
enic driver and the underlying hardware use different units for representing the interrupt coalesce timer.
Driver converts the interrupt coalesce timer in usec to hardware cycles while setting the relevant hardware
registers. The conversion factor can be different for each of the adapter hardware types. So it is dynamically
learnt from the adapter firmware using the devcmd CMD_INTR_COAL_CONVERT. This allows the driver to configure
the hardware interrupt coalesce timers in a platform independent way.Signed-off-by: Danny Guo
Signed-off-by: Vasanthy Kolluri
Signed-off-by: Roopa Prabhu
Signed-off-by: David Wang
Signed-off-by: David S. Miller -
Use per-cpu variables to maintain 64 bit statistics.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Add xen-backend:vif module alias to the xen-netback module. This allows
automatic loading of the module.Signed-off-by: Bastian Blank
Acked-by: Ian Campbell
Acked-by: Konrad Rzeszutek Wilk
29 Jun, 2011
11 commits
-
Update MAINTAINERS to refelect new people working on myri10ge
Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
Update version and copyright
Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
Miscellaneous white space, style, and other cleanups
v2 includes corrections from Joe Perches
Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
The PCIE capability offset is saved during PCI bus walking. It will
remove an unnecessary search in the PCI configuration space if this
value is referenced instead of reacquiring it.Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
Add myri10ge driver support for the ethtool identify operation.
NOTE: Rather than blinking (which is the normal case), when identify is
used, the yellow LED turns solid.Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
Allow page-based receive to work when small_bytes is set to 0.
Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
Clean up watchdog reset code:
- move code that checks for stuck slice to a common routine
- unless there is a confirmed h/w fault, verify that a stuck
slice is still stuck in the watchdog worker; if the slice is no
longer stuck, abort the reset.
- this removes an egregious 2000ms pause in the watchdog worker that
was a diagnostic aid (to look for spurious resets) the snuck into
production code.v3 includes corrections from Joe Perches
Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
A SRAM parity error can cause a surprise link down. Since We can
recover from SRAM parity errors, mask PCI surprise down events.Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
Ensure that our tx queues remain stopped when we stop them in
myri10ge_close(). Not doing so can potentially lead to traffic being
transmitted when the interface is removed, which can lead to NULL
pointer dereferences.Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
This patch enables the 6131 family of chips to forward DSA
packets to other switch chips. This is needed if multiple
DSA chips are used in a device. Without this patch the
chip will drop any DSA packets not destined for it.This patch only enables the forwarding of DSA packets if
multiple chips are used in the switch configuration.Signed-off-by: Barry Grussling
Signed-off-by: David S. Miller -
Just spelling fixes.
Actually, a twofer with vaiables/variables as well.
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
