26 Apr, 2008

1 commit


25 Apr, 2008

1 commit


24 Apr, 2008

1 commit


22 Apr, 2008

1 commit


17 Apr, 2008

1 commit


12 Apr, 2008

1 commit


02 Apr, 2008

1 commit


26 Mar, 2008

1 commit


24 Mar, 2008

1 commit

  • The module alias support in the kernel have a consistency
    check where it is checked that the size of a structure
    in the kernel and on the build host are the same.
    For cross builds this check does not make sense so detect
    when we do cross builds and silently skip the check in these
    situations.
    This fixes a build bug for a wireless driver when cross building
    for arm.

    Acked-by: Michael Buesch
    Tested-by: Gordon Farquharson
    Signed-off-by: Sam Ravnborg
    Cc: stable@kernel.org

    Sam Ravnborg
     

17 Mar, 2008

1 commit


10 Mar, 2008

1 commit


05 Mar, 2008

1 commit


25 Feb, 2008

1 commit


19 Feb, 2008

1 commit


16 Feb, 2008

1 commit


15 Feb, 2008

2 commits

  • Ingo Molnar wrote:
    >
    > i've got a build log from a weird build error below:
    >
    > LD init/built-in.o
    > distcc[12023] ERROR: compile (null) on localhost failed
    > make: *** [vmlinux.o] Error 1
    > make: *** Waiting for unfinished jobs....
    > LD .tmp_vmlinux1
    >

    Building vmlinux.o were moved up in the dependency chain so we started
    to build it before the kallsym stuff. This was done to let modpost
    report section mismatch bugs even when the final link failed.

    Originally I had expected the dependency of $(kallsyms.o) to
    cover this but it turns out that we need to be even more explicit.
    Fix this by adding a conditional dependency on firat target
    used in the kallsyms serie of builds.

    Signed-off-by: Sam Ravnborg
    Cc: Ingo Molnar
    Cc: Roland McGrath

    Sam Ravnborg
     
  • Arjan van de Ven wrote:
    ===
    I just read the excellent LWN writeup of the vmsplice
    security thing, and that got me wondering why this attack
    wasn't stopped by the CONFIG_CC_STACKPROTECTOR option...
    because it plain should have been...

    Some analysis later.. it turns out that the following line
    in the top level Makefile, added by you in October 2007,
    entirely disables CONFIG_CC_STACKPROTECTOR ;(
    With this line removed the exploit will be nicely stopped.

    CFLAGS += $(call cc-option, -fno-stack-protector)

    Now I realize that certain distros have patched gcc to
    compensate for their lack of distro wide CFLAGS, and it's
    great to work around that... but would there be a way to NOT
    disable this for CONFIG_CC_STACKPROTECTOR please?
    It would have made this exploit not possible for those kernels
    that enable this feature (and that includes distros like Fedora)
    ===

    Move the assignment to KBUILD_CFLAGS up before including
    the arch specific Makefile so arch makefiles may override
    the setting.

    Signed-off-by: Sam Ravnborg
    Cc: Arjan van de Ven
    Cc: stable@kernel.org

    Sam Ravnborg
     

11 Feb, 2008

1 commit


03 Feb, 2008

1 commit


29 Jan, 2008

9 commits


28 Jan, 2008

1 commit


25 Jan, 2008

1 commit


22 Jan, 2008

1 commit


16 Jan, 2008

1 commit


07 Jan, 2008

1 commit


21 Dec, 2007

1 commit


11 Dec, 2007

1 commit


09 Dec, 2007

2 commits

  • The check introduced in commit:
    4f1127e204377cbd2a56d112d323466f668e8334 "kbuild: fix
    infinite make recursion"

    caused certain external modules not to build and
    also caused 'make targz-pkg' to fail.
    This is a minimal fix so we revert to previous
    behaviour - but we do not overwrite the Makefile
    in the top-level directory.

    Signed-off-by: Sam Ravnborg
    Tested-by: Jay Cliburn
    Cc: Jay Cliburn

    Sam Ravnborg
     
  • Jan Altenberg reported that
    building with redirected input like this failed:
    make O=dir oldconfig bzImage < /dev/null

    The problem were caused by a make silentoldconfig being
    run before oldconfig and with a non-recent .config the build
    failed because silentoldconfig requires non-redirected stdin.

    Silentoldconfig was run as a side-effect of having the
    top-level Makefile re-made by make.
    Introducing an empty rule for the top-level Makefile
    (and Kbuild.include) fixed the issue.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

04 Dec, 2007

1 commit


18 Nov, 2007

1 commit

  • Simplify "make ARCH=x86" and fix kconfig so we again
    can set 64BIT in all.config.

    For a fix the diffstat is nice:
    6 files changed, 3 insertions(+), 36 deletions(-)

    The patch reverts these commits:
    0f855aa64b3f63d35a891510cf7db932a435c116
    -> kconfig: add helper to set config symbol from environment variable

    2a113281f5cd2febbab21a93c8943f8d3eece4d3
    -> kconfig: use $K64BIT to set 64BIT with all*config targets

    Roman Zippel pointed out that kconfig supported string
    compares so the additional complexity introduced by the
    above two patches were not needed.

    With this patch we have following behaviour:

    # make {allno,allyes,allmod,rand}config [ARCH=...]
    option \ host arch | 32bit | 64bit
    =====================================================
    ./. | 32bit | 64bit
    ARCH=x86 | 32bit | 32bit
    ARCH=i386 | 32bit | 32bit
    ARCH=x86_64 | 64bit | 64bit

    The general rule are that ARCH= and native architecture
    takes precedence over the configuration.
    So make ARCH=i386 [whatever] will always build a 32-bit
    kernel no matter what the configuration says.
    The configuration will be updated to 32-bit if it was
    configured to 64-bit and the other way around.

    This behaviour is consistent with previous behaviour so
    no suprises here.

    make ARCH=x86 will per default result in a 32-bit kernel
    but as the only ARCH= value x86 allow the user to select
    between 32-bit and 64-bit using menuconfig.

    Signed-off-by: Sam Ravnborg
    Cc: Roman Zippel
    Cc: Andreas Herrmann
    Cc: Thomas Gleixner
    Cc: Ingo Molnar
    Cc: "H. Peter Anvin"

    Sam Ravnborg
     

17 Nov, 2007

1 commit