30 Jul, 2010
1 commit
-
Fix __task_cred()'s lockdep check by removing the following validation
condition:lockdep_tasklist_lock_is_held()
as commit_creds() does not take the tasklist_lock, and nor do most of the
functions that call it, so this check is pointless and it can prevent
detection of the RCU lock not being held if the tasklist_lock is held.Instead, add the following validation condition:
task->exit_state >= 0
to permit the access if the target task is dead and therefore unable to change
its own credentials.Fix __task_cred()'s comment to:
(1) discard the bit that says that the caller must prevent the target task
from being deleted. That shouldn't need saying.(2) Add a comment indicating the result of __task_cred() should not be passed
directly to get_cred(), but rather than get_task_cred() should be used
instead.Also put a note into the documentation to enforce this point there too.
Signed-off-by: David Howells
Acked-by: Jiri Olsa
Cc: Paul E. McKenney
Signed-off-by: Linus Torvalds
27 Apr, 2010
1 commit
-
Change the credentials documentation to make it clear that the RCU read lock
must be explicitly held when accessing credentials pointers in some other task
than current. Holding a spinlock does not implicitly hold the RCU read lock.Signed-off-by: Serge Hallyn
Reviewed-by: Paul E. McKenney
Signed-off-by: David Howells
Signed-off-by: James Morris
14 Nov, 2008
1 commit
-
Document credentials and the new credentials API.
Signed-off-by: David Howells
Signed-off-by: James Morris