27 May, 2009
2 commits
-
The PCM hw_ptr jiffies check results sometimes in problems when a
hardware doesn't give smooth hw_ptr updates. So far, au88x0 and some
other drivers appear not working due to this strict check.
However, this check is a nice debug tool, and the capability should be
still kept.Hence, we disable this check now as default unless the user enables it
by setting the xrun_debug mode to the specific stream via a proc file.Signed-off-by: Takashi Iwai
-
The hw_ptr_jiffies has to be reset properly to avoid the invalid
check of jiffies delta in snd_pcm_update_hw_ptr*() functions.
Especailly this patch fixes the bogus jiffies check after the puase
and resume.This patch is a modified version of the original patch by Jaroslav.
Signed-off-by: Takashi Iwai
28 Apr, 2009
1 commit
-
The hardware devices with SNDRV_PCM_INFO_BATCH flag can't give the
precise current position. And such hardwares have often big FIFO
in addition to the ring buffer, and it screws up the jiffies check
in pcm_lib.c.This patch adds a simple check of info flag so that the driver skips
the jiffies check in snd_pcm_period_elapsed() when BATCH flag is set.Signed-off-by: Takashi Iwai
15 Apr, 2009
2 commits
-
* topic/memdup_user:
ALSA: sound/pci: use memdup_user()
ALSA: sound/usb: use memdup_user()
ALSA: sound/isa: use memdup_user()
ALSA: sound/core: use memdup_user() -
* topic/hda:
ALSA: hda - Add quirk mask for Fujitsu Amilo laptops with ALC883
ALSA: hda - Avoid call of snd_jack_report at release
ALSA: add private_data to struct snd_jack
14 Apr, 2009
2 commits
-
Added private_data and private_free fields to struct snd_jack so that
the caller can assign the data. It'll be helpful for avoiding the
double-free of the jack instance.Signed-off-by: Takashi Iwai
-
Remove open-coded memdup_user().
Signed-off-by: Li Zefan
Signed-off-by: Takashi Iwai
10 Apr, 2009
1 commit
-
Some drivers like Intel8x0 or Intel HDA are broken for some hardware variants.
This patch adds more strict buffer position checks based on jiffies when
internal hw_ptr is updated. Enable xrun_debug to see mangling of wrong
positions.As a side effect, the hw_ptr interrupt update routine might do slightly better
job when many interrupts are lost.Signed-off-by: Jaroslav Kysela
07 Apr, 2009
1 commit
-
Added an else part to check
SNDRV_MIXER_OSS_PRESENT_CVOLUME for MIC (slot 7)
in commit 36c7b833e5d2501142a371e4e75281d3a29fbd6bSimilarly, checks and volume control is required for
SNDRV_MIXER_OSS_PRESENT_CSWITCH and SNDRV_MIXER_OSS_PRESENT_CROUTE
as well.Signed-off-by: Deepika Makhija
Signed-off-by: Viral Mehta
Signed-off-by: Takashi Iwai
31 Mar, 2009
1 commit
-
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.->read_proc/->write_proc were just fixed to not require ->owner for
protection.rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.Removing ->owner will also make PDE smaller.
So, let's nuke it.
Kudos to Jeff Layton for reminding about this, let's say, oversight.
http://bugzilla.kernel.org/show_bug.cgi?id=12454
Signed-off-by: Alexey Dobriyan
27 Mar, 2009
1 commit
-
* 'bkl-removal' of git://git.lwn.net/linux-2.6:
Rationalize fasync return values
Move FASYNC bit handling to f_op->fasync()
Use f_lock to protect f_flags
Rename struct file->f_ep_lock
24 Mar, 2009
9 commits
20 Mar, 2009
1 commit
-
Make the boundary checks a bit safer.
These caese are rare or theoretically won't happen, but nothing
bad to keep the checks safer...Signed-off-by: Takashi Iwai
19 Mar, 2009
4 commits
-
When the hw_ptr_interrupt reaches the boundary, it must check whether
the hw_base was already lapped and corret the delta value appropriately.Also, rebasing the hw_ptr needs a correction because buffer_size isn't
always aligned to period_size.Signed-off-by: Takashi Iwai
-
Always reset the invalind hw_ptr position returned by the pointer
callback. The behavior should be consitent independently from the
debug option.Also, add the printk_ratelimit() check to avoid flooding debug
prints.Signed-off-by: Takashi Iwai
-
Remove unnecessary explicit inlininig of internal functions.
Let compiler optimize.Signed-off-by: Takashi Iwai
-
Fix a typo in error messages; forgotten after a copy&paste error.
Signed-off-by: Takashi Iwai
18 Mar, 2009
3 commits
-
In snd_free_sgbuf_pags(), vunmap() is called after releasing the SG
pages, and it causes errors on Xen as Xen manages the pages
differently. Although no significant errors have been reported on
the actual hardware, this order should be fixed other way round,
first vunmap() then free pages.Cc: Jan Beulich
Cc:
Signed-off-by: Takashi Iwai -
s/mutex_lock/mutex_unlock/ on 2 fail paths in snd_pcm_oss_proc_write.
Probably a typo, lock should be unlocked when leaving the function.Signed-off-by: Jiri Slaby
Cc:
Signed-off-by: Takashi Iwai -
At the time of initialization, SNDRV_MIXER_OSS_PRESENT_PVOLUME bit is not
set for MIC (slot 7).
So, the same should not be checked when an application tries to do gain
control for audio recording devices.Just check slot->present for SNDRV_MIXER_OSS_PRESENT_CVOLUME independently.
Verified with a simple application which opens /dev/dsp for recording and
/dev/mixer for volume control.Have tested two usb audio mic devices.
Signed-off-by: Viral Mehta
Signed-off-by: Takashi Iwai
16 Mar, 2009
2 commits
-
Most fasync implementations do something like:
return fasync_helper(...);
But fasync_helper() will return a positive value at times - a feature used
in at least one place. Thus, a number of other drivers do:err = fasync_helper(...);
if (err < 0)
return err;
return 0;In the interests of consistency and more concise code, it makes sense to
map positive return values onto zero where ->fasync() is called.Cc: Al Viro
Signed-off-by: Jonathan Corbet -
Traditionally, changes to struct file->f_flags have been done under BKL
protection, or with no protection at all. This patch causes all f_flags
changes after file open/creation time to be done under protection of
f_lock. This allows the removal of some BKL usage and fixes a number of
longstanding (if microscopic) races.Reviewed-by: Christoph Hellwig
Cc: Al Viro
Signed-off-by: Jonathan Corbet
09 Mar, 2009
7 commits
-
Refactor rawmidi open/close code messes.
Signed-off-by: Takashi Iwai
-
The module refcount should be handled in the register_mutex to avoid
possible races with module unloading.Signed-off-by: Takashi Iwai
-
Use the standard linked list for snd_monitor_file management.
Also, move the list deletion of shutdown_list element into
snd_disconnect_release() (for simplification).Signed-off-by: Takashi Iwai
-
Signed-off-by: Takashi Iwai
-
Added snd_ctl_add_slave_uncached() function to add a slave element
with volatile controls. The values of normal slave elements are
supposed to be cachable, i.e. they are changed only via the put
callbacks. OTOH, when a slave element is volatile and its values may
be changed by other reason (e.g. hardware status change), the values
will get inconsistent.The new function allows the slave elements with volatile changes.
When the slave is tied with this call, the native get callback is
issued at each time so that the values are always updated.Signed-off-by: Takashi Iwai
-
The timer callbacks are called in the protected status by the lock
of the timer instance, so there is no need for an extra lock in the
PCM substream.Signed-off-by: Takashi Iwai
-
Clean up and improve snd_pcm_update_hw_ptr*() functions.
snd_pcm_update_hw_ptr() tries to detect the unexpected hwptr jumps
more strictly to avoid the position mess-up, which often results in
the bad quality I/O with pulseaudio.The hw-ptr skip error messages are printed when xrun proc is set to
non-zero.Signed-off-by: Takashi Iwai
23 Feb, 2009
1 commit
-
Incorrect variable was used to get the next sample which caused S2
to be stuck with the same value resulting in loud background noise.Signed-off-by: Steve Chen
Cc:
Signed-off-by: Takashi Iwai
18 Feb, 2009
1 commit
-
Currently the jack layer refers to card->longname as a part of
its input device name string. However, longname is often really long
and way too ugly as an identifier, such as,
"HDA Intel at 0xf8400000 irq 21".This patch changes the code to use card->shortname instead.
The shortname string contains usually the h/w vendor and product
names but without messy I/O port or IRQ numbers.Signed-off-by: Takashi Iwai
10 Feb, 2009
1 commit