Eric Lee / smarc-fsl-linux-kernel

07 May, 2019

1 commit

06 May, 2019

1 commit

  • 476c7e1d3   i3c: Fix a shift wrap bug in i3c_bus_set_addr_slot_status() ... Browse Code »

    The problem here is that addr can be I3C_BROADCAST_ADDR (126). That
    means we're shifting by (126 * 2) % 64 which is 60. The
    I3C_ADDR_SLOT_STATUS_MASK is an enum which is an unsigned int in GCC
    so shifts greater than 31 are undefined.

    Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
    Cc:
    Signed-off-by: Dan Carpenter
    Signed-off-by: Boris Brezillon

    Dan Carpenter
     

10 Apr, 2019

2 commits

  • 907621e94   i3c: dw: Fix dw_i3c_master_disable controller by using correct mask ... Browse Code »

    The controller was being disabled incorrectly. The correct way is to clear
    the DEV_CTRL_ENABLE bit.

    Fix this by clearing this bit.

    Cc: Boris Brezillon
    Cc:
    Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
    Signed-off-by: Vitor Soares
    Signed-off-by: Boris Brezillon

    Vitor Soares
     
  • 9752c37cc   i3c: Fix the verification of random PID ... Browse Code »

    The validation of random PID should be done by checking the
    boardinfo->pid instead of info.pid which is empty.

    Doing the change the info struture declaration is no longer necessary.

    Cc: Boris Brezillon
    Cc:
    Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
    Signed-off-by: Vitor Soares
    Signed-off-by: Boris Brezillon

    Vitor Soares
     

30 Mar, 2019

1 commit

  • 124dbd750   i3c: master: dw: remove dead code from dw_i3c_master_*_xfers() ... Browse Code »

    Detected by CoverityScan (Event result_independent_of_operands):
    "(i3c_xfers + i).len > 65536" is always false regardless of the values
    of its operands. This occurs as the logical operand of "if"

    "(i2c_xfers + i).len > 65536" is always false regardless of the values
    of its operands. This occurs as the logical operand of "if"

    Signed-off-by: Vitor Soares
    Signed-off-by: Boris Brezillon

    Vitor Soares
     

05 Mar, 2019

1 commit

28 Feb, 2019

1 commit

  • 988bb4a19   i3c: master: dw-i3c-master: mark expected switch fall-through ... Browse Code »

    In preparation to enabling -Wimplicit-fallthrough, mark switch
    cases where we are expecting to fall through.

    This patch fixes the following warning:

    drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’:
    drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (ret)
    ^
    drivers/i3c/master/dw-i3c-master.c:605:2: note: here
    case I3C_BUS_MODE_PURE:
    ^~~~

    Warning level 3 was used: -Wimplicit-fallthrough=3

    This patch is part of the ongoing efforts to enable
    -Wimplicit-fallthrough.

    Signed-off-by: Gustavo A. R. Silva
    Acked-by: Vitor Soares
    Signed-off-by: Boris Brezillon

    Gustavo A. R. Silva
     

26 Jan, 2019

1 commit

  • f36c1f9a8   i3c: master: dw: fix deadlock ... Browse Code »

    In dw_i3c_master_irq_handler(), we already have gotten
    &master->xferqueue.lock, if we try to get the same lock again in
    dw_i3c_master_dequeue_xfer(), deadlock happens.

    We fix this issue by introduing dw_i3c_master_dequeue_xfer_locked()
    which does all what dw_i3c_master_dequeue_xfer() does without trying
    to lock &master->xferqueue.lock.

    Signed-off-by: Jisheng Zhang
    Acked-by: Vitor Soares 
    Signed-off-by: Boris Brezillon

    Jisheng Zhang
     

25 Jan, 2019

1 commit

15 Jan, 2019

1 commit

  • f29fd331a   i3c: master: dw-i3c-master: fix i3c_attach/reattach ... Browse Code »

    This patch fix i3c_attach/reattach functions.

    During the i3c_attach the driver ignores the static address used for
    SETDASA CCC command.

    During the i3c_reattach the driver doesn't update master->addrs[data->index]
    with new address if old_dyn_addr = 0.

    Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
    Signed-off-by: Vitor Soares
    Signed-off-by: Boris Brezillon

    Vitor Soares
     

07 Jan, 2019

1 commit

13 Dec, 2018

1 commit

06 Dec, 2018

6 commits

12 Nov, 2018

1 commit

  • 3a379bbce   i3c: Add core I3C infrastructure ... Browse Code »

    Add core infrastructure to support I3C in Linux and document it.

    This infrastructure adds basic I3C support. Advanced features will be
    added afterwards.

    There are a few design choices that are worth mentioning because they
    impact the way I3C device drivers can interact with their devices:

    - all functions used to send I3C/I2C frames must be called in
    non-atomic context. Mainly done this way to ease implementation, but
    this is not set in stone, and if anyone needs async support, new
    functions can be added later on.
    - the bus element is a separate object, but it's tightly coupled with
    the master object. We thus have a 1:1 relationship between i3c_bus
    and i3c_master_controller objects, and if 2 master controllers are
    connected to the same bus and both exposed to the same Linux instance
    they will appear as two distinct busses, and devices on this bus will
    be exposed twice.
    - I2C backward compatibility has been designed to be transparent to I2C
    drivers and the I2C subsystem. The I3C master just registers an I2C
    adapter which creates a new I2C bus. I'd say that, from a
    representation PoV it's not ideal because what should appear as a
    single I3C bus exposing I3C and I2C devices here appears as 2
    different buses connected to each other through the parenting (the
    I3C master is the parent of the I2C and I3C busses).
    On the other hand, I don't see a better solution if we want something
    that is not invasive.

    Missing features:
    - I3C HDR modes are not supported
    - no support for multi-master and the associated concepts (mastership
    handover, support for secondary masters, ...)
    - I2C devices can only be described using DT because this is the only
    use case I have. However, the framework can easily be extended with
    ACPI and board info support
    - I3C slave framework. This has been completely omitted, but shouldn't
    have a huge impact on the I3C framework because I3C slaves don't see
    the whole bus, it's only about handling master requests and generating
    IBIs. Some of the struct, constant and enum definitions could be
    shared, but most of the I3C slave framework logic will be different

    Signed-off-by: Boris Brezillon
    Reviewed-by: Arnd Bergmann
    Acked-by: Greg Kroah-Hartman

    Boris Brezillon