11 Apr, 2019

2 commits

  • Handling pcitest.sh along with pcitest (obtained by compiling
    pcitest.c) results in pcitest.sh getting removed inadvertently
    while "make -C tools/pci clean".

    Fix it by handling pcitest.sh independently of pcitest.

    Fixes: 1ce78ce09430 ("tools: PCI: Change pcitest compiling process")
    Reported-by: Adrian Hunter
    Signed-off-by: Kishon Vijay Abraham I
    Signed-off-by: Lorenzo Pieralisi
    Cc: Gustavo Pimentel

    Kishon Vijay Abraham I
     
  • 'h' is a valid option character for the pcitest tool used to print
    the pcitest usage.

    Add 'h' in optstring of getopt() in order to get rid of "pcitest:
    invalid option -- 'h'" warning.

    While at that remove unncessary case '?'.

    Signed-off-by: Kishon Vijay Abraham I
    Signed-off-by: Sekhar Nori
    Signed-off-by: Lorenzo Pieralisi

    Kishon Vijay Abraham I
     

22 Mar, 2019

1 commit


03 Oct, 2018

2 commits

  • Change tool compiling process in order to be build using the same
    mechanism used in other linux tools (e.g. iio, perf, etc). This will
    allow in future the buildroot tool to build and integrate this tool in
    a more expeditious way.

    Update documentation accordingly.

    Signed-off-by: Gustavo Pimentel
    Signed-off-by: Lorenzo Pieralisi
    Reviewed-by: Kishon Vijay Abraham I

    Gustavo Pimentel
     
  • Current compilation produces the following warnings:

    tools/pci/pcitest.c: In function 'run_test':
    tools/pci/pcitest.c:56:9: warning: unused variable 'time'
    [-Wunused-variable]
    double time;
    ^~~~
    tools/pci/pcitest.c:55:25: warning: unused variable 'end'
    [-Wunused-variable]
    struct timespec start, end;
    ^~~
    tools/pci/pcitest.c:55:18: warning: unused variable 'start'
    [-Wunused-variable]
    struct timespec start, end;
    ^~~~~
    tools/pci/pcitest.c:146:1: warning: control reaches end of non-void
    function [-Wreturn-type]
    }
    ^

    Fix them:
    - remove unused variables
    - change function return from int to void, since it's not used

    Signed-off-by: Gustavo Pimentel
    [lorenzo.pieralisi@arm.com: rewrote the commit log]
    Signed-off-by: Lorenzo Pieralisi
    Reviewed-by: Kishon Vijay Abraham I

    Gustavo Pimentel
     

19 Jul, 2018

1 commit

  • Add MSI-X support to pcitest tool.

    Modify pcitest.sh script to accommodate MSI-X interrupt tests.

    Update documentation accordingly.

    Signed-off-by: Gustavo Pimentel
    Signed-off-by: Lorenzo Pieralisi
    Acked-by: Kishon Vijay Abraham I

    Gustavo Pimentel
     

02 Nov, 2017

1 commit

  • Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

30 Aug, 2017

1 commit


28 Apr, 2017

2 commits