02 Jun, 2010
3 commits
-
This way, RX DMA overruns (actually being caused by overrun of the
512byte input FIFO) show up in ifconfig output. The rx_fifo_errors
counter is unused otherwise.Signed-off-by: Phil Sutter
Signed-off-by: David S. Miller -
This patch completes commit 89d71a66c40d629e3b1285def543ab1425558cd5
which missed this spot, as it seems.Signed-off-by: Phil Sutter
Signed-off-by: David S. Miller -
By calling korina_restart(), the IRQ handler tries to disable the
interrupt it's currently serving. This leads to a deadlock since
disable_irq() waits for any running IRQ handlers to finish before
returning. This patch addresses the issue by turning korina_restart()
into a workqueue task, which is then scheduled when needed.Reproducing the deadlock is easily done using e.g. GNU netcat to send
large amounts of UDP data to the host running this driver.Note that the same problem (and fix) applies to TX FIFO underruns, but
apparently these are less easy to trigger.Signed-off-by: Phil Sutter
Signed-off-by: David S. Miller
04 Apr, 2010
1 commit
-
Converts the list and the core manipulating with it to be the same as uc_list.
+uses two functions for adding/removing mc address (normal and "global"
variant) instead of a function parameter.
+removes dev_mcast.c completely.
+exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for
manipulation with lists on a sandbox (used in bonding and 80211 drivers)Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller
23 Mar, 2010
1 commit
-
This size calculation is wrong. It should be end - start + 1.
Use resource_size() to calculate it correctly.Signed-off-by: Dan Carpenter
Signed-off-by: David S. Miller
26 Feb, 2010
1 commit
-
removed some needless checks and also corrected bug in lp486e (dmi was passed
instead of dmi->dmi_addr)Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller
13 Feb, 2010
1 commit
-
This patch replaces dev->mc_count in all drivers (hopefully I didn't miss
anything). Used spatch and did small tweaks and conding style changes when
it was suitable.Jirka
Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller
19 Nov, 2009
1 commit
-
Not as fancy as coccinelle. Checkpatch errors ignored.
Compile tested allyesconfig x86, not all files compiled.grep -rPl --include=*.[ch] "\brequest_irq\s*\([^,\)]+,\s*\&" drivers/net | while read file ; do \
perl -i -e 'local $/; while (<>) { s@(\brequest_irq\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
doneSigned-off-by: Joe Perches
Signed-off-by: David S. Miller
14 Oct, 2009
1 commit
-
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
02 Sep, 2009
1 commit
-
No need to put ethtool_ops in data, they should be const.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller
14 Aug, 2009
2 commits
-
This also avoids a potential buffer overflow in case the very first
receive descriptor fails to allocate, as an index of -1 would be used
afterwards. Kudos to Roel Kluin for pointing this out and providing an
initial patch.Signed-off-by: Phil Sutter
Signed-off-by: David S. Miller -
The macro DRV_NAME contains "korina", the field dev->name points to the
actual interface name. So messages were formerly prefixed with
'korinaeth2:' (on my system).Signed-off-by: Phil Sutter
Signed-off-by: David S. Miller
29 May, 2009
1 commit
-
This patch makes the korina driver poll the media
for link change. This is actually required on
Mikrotik RB532 (not RB532A) for korina to
operate properly.Signed-off-by: Felix Fietkau
Signed-off-by: Florian Fainelli
Signed-off-by: David S. Miller
16 Apr, 2009
1 commit
-
Signed-off-by: Alexander Beregalov
Signed-off-by: David S. Miller
22 Jan, 2009
1 commit
-
Following the removal of the unused struct net_device * parameter from
the NAPI functions named *netif_rx_* in commit 908a7a1, they are
exactly equivalent to the corresponding *napi_* functions and are
therefore redundant.Signed-off-by: Ben Hutchings
Acked-by: Neil Horman
Signed-off-by: David S. Miller
20 Jan, 2009
3 commits
-
As the assigned value is being overwritten shortly after, it can be
dropped and so the whole variable definition moved to the start of the
function.Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli
Signed-off-by: David S. Miller -
This is copy and paste from the original driver. As skb_reserve() is
also called within korina_alloc_ring() when initially allocating the
receive descriptors, the same should be done when allocating new space
after passing an skb to upper layers.Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli
Signed-off-by: David S. Miller -
After the last loop iteration, i has the value RC32434_NUM_RDS and
therefore leads to an index overflow when used afterwards to address the
last element. This is yet another another bug introduced when rewriting
parts of the driver for upstream preparation, as the original driver
used 'RC32434_NUM_RDS - 1' instead.Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli
Signed-off-by: David S. Miller
16 Jan, 2009
9 commits
-
As the kernel warning states: "IRQF_DISABLED is not guaranteed on shared
IRQs". Since these IRQs' values are hardcoded and my test system doesn't
show any shared use of IRQs at all, rather make them non-shared than
non-disabled.Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli
Signed-off-by: David S. Miller -
Apparently this doesn't make sense. Otherwise the queue gets disabled as
soon as it's getting empty and can only be resurrected by a driver
restart.Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli
Signed-off-by: David S. Miller -
Originally this must have been a rewrite error when introducing
'chain_index'. But the original driver did not use the previous chain
item everywhere: when altering the address tx_chain_tail points to, it
should move forward, not backwards.
Also this is not an "index" but rather the penultimate element in the
chain, so rename it accordingly.Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli
Signed-off-by: David S. Miller -
Triggering TX before the write to the DMA status mask register leads to
transferring packets with maximum payload no matter what the actual
packet size is.
While here, also trigger RX scheduling after writing the DMA status mask
register, like it was in the original driver before it was sent
upstream.Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli
Signed-off-by: David S. Miller -
The called netif_rx_schedule() does all the work for us:
- it checks the return value of netif_rx_schedule_prep() and
- if everything is ok calls __netif_rx_schedule().
Before this change, the driver received absolutely nothing.Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli
Signed-off-by: David S. Miller -
This function needs an early exit condition to function properly, or
else caller assumes napi workload wasn't enough to handle all received
packets and korina_rx is called again (and again and again and ...).Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli
Signed-off-by: David S. Miller -
Without this the driver will crash when the NIC is being restarted.
Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli
Signed-off-by: David S. Miller -
The new value is the one used in the external patch before and allows at
least a standard MTU of 1500 to be handled correctly. Impact of this
change gets visible when bigger packets are to be received, issuing:
| ping -s 492
and bigger payload sized led to 100% packet loss.Signed-off-by: Phil Sutter
Acked-by: Florian Fainelli -
Using platform_set_drvdata() here makes no sense, since the driver_data
field has already been filled with valuable data (i.e. the MAC address).
Also having driver_data point to the net_device is rather pointless
since struct korina_device contains an apropriate field for it.Signed-off-by: Phil Sutter
Signed-off-by: David S. Miller
23 Dec, 2008
1 commit
-
When the napi api was changed to separate its 1:1 binding to the net_device
struct, the netif_rx_[prep|schedule|complete] api failed to remove the now
vestigual net_device structure parameter. This patch cleans up that api by
properly removing it..Signed-off-by: Neil Horman
Signed-off-by: David S. Miller
04 Nov, 2008
1 commit
-
The generic packet receive code takes care of setting
netdev->last_rx when necessary, for the sake of the
bonding ARP monitor.Drivers need not do it any more.
Some cases had to be skipped over because the drivers
were making use of the ->last_rx value themselves.Signed-off-by: David S. Miller
25 Apr, 2008
2 commits
-
- useless initialization (korina_ope / korina_restart)
- use a single variable for the status code in korina_probe
and propagate the error status code from below
- useless checks in korina_remove : the variables are
necessarily set when korina_probe succeedsSigned-off-by: Francois Romieu
Signed-off-by: Jeff Garzik -
The driver takes the error unwind path without condition.
Signed-off-by: Francois Romieu
Signed-off-by: Jeff Garzik
26 Mar, 2008
1 commit
-
This patch adds support for the IDT rc32434 Ethernet MAC
we can find in the IDT boards and the Mikrotik RB500.
Driver references some code from the linux-mips RB500
support.Signed-off-by: Florian Fainelli
Signed-off-by: Felix Fietkau
Signed-off-by: Philip Rischel
Signed-off-by: Jeff Garzik
