07 Oct, 2010

1 commit

  • Add missing #inclusion of . Without it, the following error can
    occur with the irqflags fixup patches applied:

    drivers/net/smc91x.c: In function 'smc_probe':
    drivers/net/smc91x.c:1987:2: error: implicit declaration of function 'irq_canonicalize'

    Signed-off-by: David Howells
    Acked-by: Nicolas Pitre

    David Howells
     

10 May, 2010

1 commit

  • Now that core network takes care of trans_start updates, dont do it
    in drivers themselves, if possible. Drivers can avoid one cache miss
    (on dev->trans_start) in their start_xmit() handler.

    Exceptions are NETIF_F_LLTX drivers

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

12 Apr, 2010

1 commit


04 Apr, 2010

1 commit

  • Converts the list and the core manipulating with it to be the same as uc_list.

    +uses two functions for adding/removing mc address (normal and "global"
    variant) instead of a function parameter.
    +removes dev_mcast.c completely.
    +exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for
    manipulation with lists on a sandbox (used in bonding and 80211 drivers)

    Signed-off-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Jiri Pirko
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

25 Mar, 2010

1 commit


26 Feb, 2010

1 commit


13 Feb, 2010

1 commit


12 Dec, 2009

2 commits

  • smc_drv_resume() takes a struct device, while smc_enable_device() takes a
    platform device. This fixes up the smc_enable_device() callsite with the
    proper pointer.

    It's not obvious when this change was introduced, as git history doesn't
    go back that far. Presumably the resume code has always been broken in
    this fashion.

    Signed-off-by: Paul Mundt
    Signed-off-by: David S. Miller

    Paul Mundt
     
  • Local flags variables will be declared whenever these functions get used,
    but obviously on UP systems the flags parameter won't be touched. So add
    some dummy ops that get optimized away anyways to satisfy gcc's warnings.

    Signed-off-by: Mike Frysinger
    Acked-by: Nicolas Pitre
    Signed-off-by: David S. Miller

    Mike Frysinger
     

02 Dec, 2009

1 commit


30 Nov, 2009

1 commit

  • smc91x.h defines SMC_IRQ_FLAGS to be -1 when it wants the interrupt
    flags to be taken from the resource structure. However, d280ead
    changed this to checking for non-zero resource flags.

    Unfortunately, this means that on some platforms, we end up passing
    '-1' to request_irq rather than the desired result. Combine the two
    conditions into one so that the IRQ flags are taken from the resource
    if either SMC_IRQ_FLAGS is -1 or the resource flags specify an
    interrupt trigger.

    This restores network on at least the Versatile platform.

    Signed-off-by: Russell King
    Acked-by: Eric Miao
    Signed-off-by: David S. Miller

    Russell King - ARM Linux
     

29 Nov, 2009

1 commit


19 Nov, 2009

1 commit

  • Not as fancy as coccinelle. Checkpatch errors ignored.
    Compile tested allyesconfig x86, not all files compiled.

    grep -rPl --include=*.[ch] "\brequest_irq\s*\([^,\)]+,\s*\&" drivers/net | while read file ; do \
    perl -i -e 'local $/; while (<>) { s@(\brequest_irq\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
    done

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

16 Sep, 2009

1 commit


02 Sep, 2009

1 commit


27 Aug, 2009

1 commit


24 Aug, 2009

1 commit

  • The NETPOLL requires that interrupts remain disabled in its callbacks.

    Using *_irq_save()/irq_restore() to replace *_irq_disable()/irq_enable()
    functions in NETPOLL's callbacks of smc91x, so that it doesn't enable
    interrupts when already disabled, and kgdboe/netconsole would work
    properly over smc91x.

    Signed-off-by: Dongdong Deng
    Acked-by: Nicolas Pitre
    Signed-off-by: David S. Miller

    Dongdong Deng
     

17 Jul, 2009

1 commit


13 Jul, 2009

1 commit


06 Jul, 2009

1 commit


27 Jan, 2009

2 commits


22 Jan, 2009

1 commit


04 Dec, 2008

1 commit

  • ISA support in smc91x is incomplete. I doubt there're any smc91x isa card.
    This driver is greatly used on arm pxa platforms. Hence we remove the
    isa stuff from smc91x driver.

    Signed-off-by: Luotao Fu
    Acked-by: Steve Glendinning
    Signed-off-by: David S. Miller

    Luotao Fu
     

03 Dec, 2008

1 commit


01 Dec, 2008

1 commit

  • a) ->probe() can be __devinit; no need to put it into .text
    b) calling __init stuff from it, OTOH, is wrong
    c) ->remove() is __devexit fodder

    Acked-by: rmk+kernel@arm.linux.org.uk
    Signed-off-by: Al Viro
    Signed-off-by: Linus Torvalds

    Al Viro
     

07 Nov, 2008

1 commit


04 Nov, 2008

1 commit


03 Nov, 2008

1 commit

  • This reverts 51ac3beffd4afaea4350526cf01fe74aaff25eff ('SMC91x: delete
    unused local variable "lp"') and adds __maybe_unused markers to these
    (potentially) unused variables.

    The issue is that in some configurations SMC_IO_SHIFT evaluates
    to '(lp->io_shift)', but in some others it's plain '0'.

    Based upon a build failure report from Manuel Lauss.

    Signed-off-by: David S. Miller

    David S. Miller
     

02 Nov, 2008

1 commit


31 Oct, 2008

2 commits


28 Oct, 2008

1 commit

  • This converts pretty much everything to print_mac. There were
    a few things that had conflicts which I have just dropped for
    now, no harm done.

    I've built an allyesconfig with this and looked at the files
    that weren't built very carefully, but it's a huge patch.

    Signed-off-by: Johannes Berg
    Signed-off-by: David S. Miller

    Johannes Berg
     

12 Oct, 2008

1 commit

  • * 'for-linus' of master.kernel.org:/home/rmk/linux-2.6-arm: (236 commits)
    [ARM] 5300/1: fixup spitz reset during boot
    [ARM] 5295/1: make ZONE_DMA optional
    [ARM] 5239/1: Palm Zire 72 power management support
    [ARM] 5298/1: Drop desc_handle_irq()
    [ARM] 5297/1: [KS8695] Fix two compile-time warnings
    [ARM] 5296/1: [KS8695] Replace macro's with trailing underscores.
    [ARM] pxa: allow multi-machine PCMCIA builds
    [ARM] pxa: add preliminary CPUFREQ support for PXA3xx
    [ARM] pxa: add missing ACCR bit definitions to pxa3xx-regs.h
    [ARM] pxa: rename cpu-pxa.c to cpufreq-pxa2xx.c
    [ARM] pxa/zylonite: add support for USB OHCI
    [ARM] ohci-pxa27x: use ioremap() and offset for register access
    [ARM] ohci-pxa27x: introduce pxa27x_clear_otgph()
    [ARM] ohci-pxa27x: use platform_get_{irq,resource} for the resource
    [ARM] ohci-pxa27x: move OHCI controller specific registers into the driver
    [ARM] ohci-pxa27x: introduce flags to avoid direct access to OHCI registers
    [ARM] pxa: move I2S register and bit definitions into pxa2xx-i2s.c
    [ARM] pxa: simplify DMA register definitions
    [ARM] pxa: make additional DCSR bits valid for PXA3xx
    [ARM] pxa: move i2c register and bit definitions into i2c-pxa.c
    ...

    Fixed up conflicts in
    arch/arm/mach-versatile/core.c
    sound/soc/pxa/pxa2xx-ac97.c
    sound/soc/pxa/pxa2xx-i2s.c
    manually.

    Linus Torvalds
     

10 Oct, 2008

1 commit


25 Sep, 2008

2 commits


08 Sep, 2008

1 commit

  • This patch provides a mechanism for platforms to be able to supply the
    LED configuration via platform data, rather than having to hard code
    it in smc91x.h.

    Acked-by: Eric Miao
    Acked-by: Nicolas Pitre
    Acked-by: Jeff Garzik
    Signed-off-by: Russell King

    Russell King
     

27 Aug, 2008

1 commit