19 Dec, 2011

1 commit

  • module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

01 Nov, 2011

2 commits


15 Aug, 2011

1 commit


19 Feb, 2011

1 commit


18 Feb, 2011

1 commit


15 Jan, 2011

1 commit


13 Dec, 2010

1 commit

  • flush_scheduled_work() is deprecated and scheduled to be removed.

    * cancel[_delayed]_work() + flush_scheduled_work() ->
    cancel[_delayed]_work_sync().

    * wm8350, wm8753 and soc-core use custom code to cancel a delayed
    work, execute it immediately if it was pending and wait for its
    completion. This is equivalent to flush_delayed_work_sync(). Use
    it instead.

    Signed-off-by: Tejun Heo
    Acked-by: Mark Brown
    Signed-off-by: Takashi Iwai

    Tejun Heo
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

29 Mar, 2010

1 commit

  • BugLink: https://launchpad.net/bugs/481058

    The OR has verified that both 'Headphone Jack Sense' and 'Line Jack Sense'
    need to be muted for sound to be audible, so just add the machine's SSID
    to the ac97 jack sense blacklist.

    Reported-by: Richard Gagne
    Tested-by: Richard Gagne
    Cc:
    Signed-off-by: Daniel T Chen
    Signed-off-by: Takashi Iwai

    Daniel Chen
     

26 Mar, 2010

1 commit


16 Feb, 2010

1 commit


11 Jan, 2010

2 commits


08 Jan, 2010

2 commits


15 Dec, 2009

1 commit

  • I have a Soundblaster 16PCI. For many years, alsa has had a bug where
    not all of the card's controls are detected (many alsa versions,
    many kernel versions). In particular, Master Playback Volume is
    usually not detected, and so I get no sound or extremely faint sound.
    The problem has always been inconsistent: sometimes all of the controls
    are detected correctly, and sometimes a partial set is detected. It works
    correctly about 10% of the time.

    Finally, I got around to tracking down the problem. When the driver
    fails, it prints the kernel message "AC'97 0 analog subsections not
    ready". This message is generated from the function snd_ac97_mixer()
    in ac97_codec.c. The message indicates that the card failed to come
    back after reset within the time limit. The time limit is
    120 milliseconds.

    I tried increasing the time limit to 1 second, and found that this
    made the driver work about 70% of the time. I tried increasing it
    to 5 seconds, and it now seems to work 100% of the time.

    I expect that this change would be completely harmless for
    existing cards that work, and would only introduce additional
    delay for cards that do not work.

    ALSA bug#4032.

    Signed-off-by: Steve Soule
    Signed-off-by: Jaroslav Kysela

    Steve Soule
     

05 Nov, 2009

1 commit

  • To avoid confusion in control names for the standard analog PC Beep generator
    using a small Internal PC Speaker, rename all related "PC Speaker" and "PC
    Beep" controls to "Beep" only. This name is more universal and can be also
    used on more platforms without confusion.

    Introduce also "Internal Speaker" in ControlNames.txt for systems with
    full-featured build-in internal speaker.

    Signed-off-by: Jaroslav Kysela
    Signed-off-by: Takashi Iwai

    Jaroslav Kysela
     

23 May, 2009

2 commits


21 Apr, 2009

1 commit


24 Mar, 2009

1 commit


06 Mar, 2009

1 commit


05 Feb, 2009

1 commit


29 Jan, 2009

2 commits


25 Dec, 2008

1 commit


11 Dec, 2008

1 commit


01 Dec, 2008

1 commit


07 Nov, 2008

1 commit


30 Oct, 2008

1 commit


20 Oct, 2008

1 commit


13 Oct, 2008

1 commit


04 Sep, 2008

1 commit

  • Only used in ac97_codec by including ac97_patch.c directly, effectively static

    Found by sparse:
    sound/pci/ac97/ac97_patch.c:3551:5: warning: symbol 'patch_vt1617a' was not declared. Should it be static?
    sound/pci/ac97/ac97_patch.c:3767:5: warning: symbol 'patch_vt1618' was not declared. Should it be static?

    Signed-off-by: Harvey Harrison
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Harvey Harrison
     

29 Aug, 2008

1 commit


13 Aug, 2008

1 commit


06 Aug, 2008

1 commit


27 Jul, 2008

1 commit


21 Jul, 2008

1 commit


15 Jul, 2008

1 commit