15 Mar, 2013
4 commits
-
During the transition to the generic parser, the hook to the codec
specific automute function was forgotten. This resulted in the silent
output on some MacBooks.Signed-off-by: Takashi Iwai
-
spec->dsp_state is initialized to DSP_DOWNLOAD_INIT, no need to reset
and check it in ca0132_download_dsp().Signed-off-by: Dylan Reid
Signed-off-by: Takashi Iwai -
Instead of using the dspload_is_loaded() function, check the dsp_state
that is kept in the spec. The dspload_is_loaded() function returns
true if the DSP transfer was never started. This false-positive leads
to multiple second delays when ca0132_setup_efaults() times out on
each write.Signed-off-by: Dylan Reid
Signed-off-by: Takashi Iwai -
If dspload_image() fails, it was ignored and dspload_wait_loaded() was
still called. dsp_loaded should never be set to true in this case,
skip it. The check in dspload_wait_loaded() return true if the DSP is
loaded or if it never started.Signed-off-by: Dylan Reid
Signed-off-by: Takashi Iwai
14 Mar, 2013
1 commit
-
If there are no internal speakers, we should not turn the eapd switch
off, because it might be necessary to keep high for Headphone.BugLink: https://bugs.launchpad.net/bugs/1155016
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai
12 Mar, 2013
2 commits
-
In the connection list expansion in hda_codec.c and hda_proc.c, the
value returned from snd_hda_get_num_raw_conns() is used as the array
size to store the connection list. However, the function returns
simply a raw value of the AC_PAR_CONNLIST_LEN parameter, and the
widget list with ranges isn't considered there. Thus it may return a
smaller size than the actual list, which results in -ENOSPC in
snd_hda_get_raw_conections().This patch fixes the bug by parsing the connection list correctly also
for snd_hda_get_num_raw_conns().Reported-and-tested-by: David Henningsson
Signed-off-by: Takashi Iwai -
The dereference should be moved below the NULL test.
Signed-off-by: Wei Yongjun
Signed-off-by: Takashi Iwai
07 Mar, 2013
5 commits
-
Set card->private_data in snd_ice1712_create for fixing NULL
dereference in snd_ice1712_remove().Signed-off-by: Sean Connor
Cc:
Signed-off-by: Takashi Iwai -
It's compatible with ALC282.
Signed-off-by: Kailang Yang
Signed-off-by: Takashi Iwai -
Move the zero check `hda_frame_size_words == 0' before the modulus
`buffer_size_words % hda_frame_size_words'.Also remove the redundant null check `buffer_addx == NULL'.
Signed-off-by: Xi Wang
Signed-off-by: Takashi Iwai -
If the new control cannot be created, this function will return to avoid
snd_hda_ctl_add dereferencing a NULL control pointer.Signed-off-by: Mengdong Lin
Signed-off-by: Takashi Iwai -
If the SPDIF control array cannot be reallocated, the function
will return to avoid dereferencing a NULL pointer.Signed-off-by: Mengdong Lin
Signed-off-by: Takashi Iwai
25 Feb, 2013
5 commits
-
Commit 57e5c63007955838043e34c732d224b2cbbb128f "emu10k1: allow to
disable the SRC" force hardware use only one rate (48000 hz).
EMU 0404/1010/1616 have support two hardware sampling rates (44100 and
48000 hz). This patch add check if we have EMU 0404/1010/1616 and
choose correct sample rate to restrict.Signed-off-by: Mihail Zenkov
Signed-off-by: Takashi Iwai -
Reported-by: Harald Becker
Signed-off-by: Takashi Iwai -
This expands the regression fix from
d28215996b0c3a900411769039aa3c54cf7008ab.
The firmware also needs to be loaded when it was already cached.Signed-off-by: Florian Zeitz
Cc:
Signed-off-by: Takashi Iwai -
This patch fixes initialization of the AK4114 chip so spdif capture is working properly.
Worked out together with Pavel Hofman.Signed-off-by: Jonas Petersen
Signed-off-by: Takashi Iwai -
Along with a clean up commit [e9f66d9b9: ALSA: pci: clean up using
module_pci_driver()], bt87x driver lost the functionality of load_all
parameter. This patch does a partial revert of the commit only for
bt87x.c to recover it.Reported-by: Clemens Ladisch
Cc:
Signed-off-by: Takashi Iwai
22 Feb, 2013
2 commits
-
This patch fix regression in emu1010 firmware loading after
http://git.alsa-project.org/?p=alsa-kprivate.git;a=commitdiff;h=b209c4dfcd960ab176d4746ab7dc442a3edb4575I just revert small part of this commit. Tested on emu1212m pci.
Signed-off-by: Mihail Zenkov
Cc:
Signed-off-by: Takashi Iwai -
Just as for analog codecs, a jack that isn't suitable for detection
(in this case, NO_PRESENCE was set) should be a phantom Jack
instead of a normal one.Thanks to Raymond Yau for spotting.
Cc: stable@vger.kernel.org
BugLink: https://bugs.launchpad.net/bugs/961286
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=903869
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai
20 Feb, 2013
5 commits
-
ELD validity can change during the lifetime of a presence detect,
so we need to be able to listen for changes on the ELD control.Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai -
Because the eld buffer can be simultaneously accessed from both
workqueue context (updating) and process context (kcontrol read),
we need to protect it with a mutex to guarantee consistency.To avoid holding the mutex while reading the ELD info from the
codec, we introduce a temporary eld buffer.Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai -
For better readability, the information that is parsed out of the
ELD data is now put into a separate parsed_hdmi_eld struct.Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai -
Previously, it was possible to read the eld data of the previous
monitor connected. This should not be allowed.Also refactor the function slightly.
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai -
Currently, eld_valid is never set to false, except at kernel module
load time. This patch makes sure that eld is no longer valid when
the cable is (hot-)unplugged.Cc: stable@kernel.org
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai
19 Feb, 2013
1 commit
-
In the recent update, Fujitsu S7020 laptop with ALC260 codec lost the
speaker output, no matter how the amps and the pins are set. After a
long debugging session, we found out that the default codec init code
is harmful for this machine, and we have to reset it to
ALC_INIT_NONE.Reported-and-tested-by: Jonathan Woithe
Signed-off-by: Takashi Iwai
18 Feb, 2013
1 commit
-
These two machines have no mute LED string in BIOS.
BugLink: https://bugs.launchpad.net/bugs/1128934
Tested-by: Tammy Yang
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai
14 Feb, 2013
3 commits
-
Define channel map for playback, capture devices of au88x0
Signed-off-by: Raymond Yau
Signed-off-by: Takashi Iwai -
This chip needs the speaker pin to go to D3 to avoid clicks,
so default_power_filter does not work here.This was found on Thinkpad R61i/T61i but I guess it applies to
the entire chip. If not, quirks should be set for at least
PCI SSID 17aa:20ac.Thanks to c4pp4 for testing.
BugLink: https://bugs.launchpad.net/bugs/886975
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai -
We've got a regression report wrt the IRQ issue related with the
power-save on a Dell machine, and disabling runtime PM works around.Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=53441
Cc: [v3.7+]
Signed-off-by: Takashi Iwai
13 Feb, 2013
2 commits
-
The current badness value used for the missing multi-io seems too
weak, and the multi-io tends to be skipped for desktop configurations
when no enough DACs are available. It's because the total badness of
the multi-io becomes often larger than the badness with assigning an
individual DAC to a headphone jack. This is good for one side, but it
seems that the surround outputs are more demanded by that.This patch increases the badness value for the missing multi-io
slightly so that the multi-io would be preferred than the individual
headphone DAC if they conflict. Through the tests with hda-emu,
mostly only desktop configurations with ALC662/663 and CMI codecs are
affected by this change, and all look reasonable.Reported-by: Raymond Yau
Signed-off-by: Takashi Iwai -
The commit [dcda58061: ALSA: hda - Add workaround for conflicting
IEC958 controls] introduced a workaround for cards that have both
SPDIF and HDMI devices for giving device=1 to SPDIF control elements.
It turned out, however, that this workaround doesn't work well -- The workaround checks only conflicts in a single codec, but SPDIF
and HDMI are provided by multiple codecs in many cases, and- ALSA mixer abstraction doesn't care about the device number in ctl
elements, thus you'll get errors from amixer such as
% amixer scontrols -c 0
ALSA lib simple_none.c:1551:(simple_add1) helem (MIXER,'IEC958
Playback Switch',0,1,0) appears twice or more
amixer: Mixer hw:0 load error: Invalid argumentThis patch fixes the previous broken workaround. Instead of changing
the device number of SPDIF ctl elements, shift the element indices of
such controls up to 16. Also, the conflict check is performed over
all codecs found on the bus.HDMI devices will be put to dev=0,index=0 as before. Only the
conflicting SPDIF device is moved to a different place. The new place
of SPDIF device is supposed by the updated alsa-lib HDA-Intel.conf,
respectively.Reported-by: Stephan Raue
Reported-by: Anssi Hannula
Cc: [v3.8]
Signed-off-by: Takashi Iwai
12 Feb, 2013
4 commits
-
Signed-off-by: Takashi Iwai
-
The chip address is 32bit long but INVALID_CHIP_ADDRESS is defined as
an unsigned long. This makes dsp_chip_to_dsp_addx() misbehaving on
64bit architectures. Fix the INVALID_CHIP_ADDRESS definition to be
32bit.Reported-by: Dan Carpenter
Signed-off-by: Takashi Iwai -
The problem addressed by this fixup is not specific to Vaio Z, affecting
some Vaio all-in-one desktop PCs too. Update the code comments accordingly.Signed-off-by: Fernando Luis Vazquez Cao
Signed-off-by: Takashi Iwai -
Some Vaio all-in-one desktop PCs (for example VGC-LN51JGB) are affected by
the same issue that caused Vaio Z laptops to become silent: the speaker pin
must be connected to the first DAC even though the codec itself advertises
flexible routing through any of the DACs.Use the no-primary-hp fixup for choosing the speaker pin as the primary so
that the right DAC is assigned on this device.Cc: stable@vger.kernel.org
Signed-off-by: Fernando Luis Vazquez Cao
Signed-off-by: Takashi Iwai
11 Feb, 2013
3 commits
-
snd_ali_pointer function is called with local
interrupts disabled. However it seems very strange to
reenable them in such way.Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov
Cc:
Signed-off-by: Takashi Iwai -
According to the other code in this driver and similar
code in rme96 it seems, that spin_lock_irq in
snd_rme32_capture_close function should be paired
with spin_unlock_irq.Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov
Cc:
Signed-off-by: Takashi Iwai -
This reduces the resultant binary size.
Signed-off-by: Takashi Iwai
10 Feb, 2013
2 commits
-
This patch fixes a few obvious bugs in DSP loader stuff:
- Fix possible memory leaks in the error path
- Avoid double-free calls in dma_reset()
- Properly set/unset WC bits for DMA buffers
- Add missing error status checksSigned-off-by: Takashi Iwai
-
Base the DSP firmware transfer and communication timeouts on jiffy values.
Signed-off-by: Ian Minett
Signed-off-by: Takashi Iwai
