22 Dec, 2016
9 commits
-
Implement mandatory export_operations, so it is possible to export befs via
nfs.Signed-off-by: Luis de Bethencourt
-
Removing all trailing whitespaces in befs.
I was skeptic about tainting the history with this, but whitespace changes
can be ignored by using 'git blame -w' and 'git log -w'.Signed-off-by: Luis de Bethencourt
-
No idea why some comments have signatures. These predate git. Removing them
since they add noise and no information.Signed-off-by: Luis de Bethencourt
-
Fixing checkpatch.pl issues in befs header files:
WARNING: Missing a blank line after declarations
+ befs_inode_addr iaddr;
+ iaddr.allocation_group = blockno >> BEFS_SB(sb)->ag_shift;WARNING: space prohibited between function name and open parenthesis '('
+ return BEFS_SB(sb)->block_size / sizeof (befs_disk_inode_addr);ERROR: "foo * bar" should be "foo *bar"
+ const char *key, befs_off_t * value);ERROR: Macros with complex values should be enclosed in parentheses
+#define PACKED __attribute__ ((__packed__))Signed-off-by: Luis de Bethencourt
-
Fix the following type of checkpatch.pl issues:
WARNING: line over 80 characters
+static struct dentry *befs_lookup(struct inode *, struct dentry *, unsigned int);ERROR: code indent should use tabs where possible
+ if (!bi)$WARNING: please, no spaces at the start of a line
+ if (!bi)$WARNING: labels should not be indented
+ unacquire_bh:WARNING: space prohibited between function name and open parenthesis '('
+ sizeof (struct befs_inode_info),WARNING: braces {} are not necessary for single statement blocks
+ if (!*out) {
+ return -ENOMEM;
+ }WARNING: Block comments use a trailing */ on a separate line
+ * in special cases */WARNING: Missing a blank line after declarations
+ int token;
+ if (!*p)ERROR: do not use assignment in if condition
+ if (!(bh = sb_bread(sb, sb_block))) {ERROR: space prohibited after that open parenthesis '('
+ if( befs_sb->num_blocks > ~((sector_t)0) ) {ERROR: space prohibited before that close parenthesis ')'
+ if( befs_sb->num_blocks > ~((sector_t)0) ) {ERROR: space required before the open parenthesis '('
+ if( befs_sb->num_blocks > ~((sector_t)0) ) {Signed-off-by: Luis de Bethencourt
-
Signed-off-by: Luis de Bethencourt
-
Fixing the two following checkpatch.pl issues:
ERROR: trailing whitespace
+ * Based on portions of file.c and inode.c $WARNING: labels should not be indented
+ error:Signed-off-by: Luis de Bethencourt
-
Fixing the following checkpatch.pl errors and warning:
ERROR: trailing whitespace
+ * $WARNING: Block comments use * on subsequent lines
+/*
+ Validates the correctness of the befs inodeERROR: "foo * bar" should be "foo *bar"
+befs_check_inode(struct super_block *sb, befs_inode * raw_inode,Signed-off-by: Luis de Bethencourt
-
Fix all checkpatch.pl errors and warnings in debug.c:
ERROR: trailing whitespace
+ * $WARNING: Missing a blank line after declarations
+ va_list args;
+ va_start(args, fmt);ERROR: "foo * bar" should be "foo *bar"
+befs_dump_inode(const struct super_block *sb, befs_inode * inode)ERROR: "foo * bar" should be "foo *bar"
+befs_dump_super_block(const struct super_block *sb, befs_super_block * sup)ERROR: "foo * bar" should be "foo *bar"
+befs_dump_small_data(const struct super_block *sb, befs_small_data * sd)WARNING: line over 80 characters
+befs_dump_index_entry(const struct super_block *sb, befs_disk_btree_super * super)ERROR: "foo * bar" should be "foo *bar"
+befs_dump_index_entry(const struct super_block *sb, befs_disk_btree_super * super)ERROR: "foo * bar" should be "foo *bar"
+befs_dump_index_node(const struct super_block *sb, befs_btree_nodehead * node)Signed-off-by: Luis de Bethencourt
16 Oct, 2016
1 commit
-
Pull befs fixes from Luis de Bethencourt:
"I recently took maintainership of the befs file system [0]. This is
the first time I send you a git pull request, so please let me know if
all the below is OK.Salah Triki and myself have been cleaning the code and fixing a few
small bugs.Sorry I couldn't send this sooner in the merge window, I was waiting
to have my GPG key signed by kernel members at ELCE in Berlin a few
days ago."[0] https://lkml.org/lkml/2016/7/27/502
* tag 'befs-v4.9-rc1' of git://github.com/luisbg/linux-befs: (39 commits)
befs: befs: fix style issues in datastream.c
befs: improve documentation in datastream.c
befs: fix typos in datastream.c
befs: fix typos in btree.c
befs: fix style issues in super.c
befs: fix comment style
befs: add check for ag_shift in superblock
befs: dump inode_size superblock information
befs: remove unnecessary initialization
befs: fix typo in befs_sb_info
befs: add flags field to validate superblock state
befs: fix typo in befs_find_key
befs: remove unused BEFS_BT_PARMATCH
fs: befs: remove ret variable
fs: befs: remove in vain variable assignment
fs: befs: remove unnecessary *befs_sb variable
fs: befs: remove useless initialization to zero
fs: befs: remove in vain variable assignment
fs: befs: Insert NULL inode to dentry
fs: befs: Remove useless calls to brelse in befs_find_brun_dblindirect
...
08 Oct, 2016
30 commits
-
Fixing the following checkpatch.pl errors:
ERROR: "foo * bar" should be "foo *bar"
+ befs_blocknr_t blockno, befs_block_run * run);WARNING: Missing a blank line after declarations
+ struct buffer_head *bh;
+ befs_debug(sb, "---> %s length: %llu", __func__, len);WARNING: Block comments use * on subsequent lines
+ /*
+ Double indir block, plus all the indirect blocks it maps.(and other instances of these)
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
Convert function descriptions to kernel-doc style.
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
Fixing typos in kernel-doc function descriptions in fs/befs/btree.c.
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
Fixing the following checkpatch.pl error:
ERROR: "foo * bar" should be "foo *bar"
+befs_load_sb(struct super_block *sb, befs_super_block * disk_sb)And the following warnings:
WARNING: suspect code indent for conditional statements (8, 12)
+ if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_LE)
+ befs_sb->byte_order = BEFS_BYTESEX_LE;WARNING: suspect code indent for conditional statements (8, 12)
+ else if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_BE)
+ befs_sb->byte_order = BEFS_BYTESEX_BE;WARNING: break quoted strings at a space character
+ befs_error(sb, "blocksize(%u) cannot be larger"
+ "than system pagesize(%lu)", befs_sb->block_size,WARNING: line over 80 characters
+ if (befs_sb->log_start != befs_sb->log_end || befs_sb->flags == BEFS_DIRTY) {Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
The description of befs_load_sb was confusing the kernel-doc system since,
because it starts with /**, it thinks it will document the function with
kernel-doc formatting. Which it isn't.Fix other comment style issues in the file while we are at it.
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
ag_shift and blocks_per_ag contain the same information in different ways,
same as block_shift and block_size do. It is worth checking this two are
consistent, but since blocks_per_ag isn't documented as mandatory to use
some implementations of befs don't enforce this, so making it non-fatal if
they don't match and just having it as a warning.Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
befs_dump_super_block() wasn't giving the inode_size information when
dumping all elements of the superblock. Add this element to have complete
information of the superblock.Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
There is no need to init block, since it will be overwitten later by
iaddr2blockno().Signed-off-by: Salah Triki
Signed-off-by: Luis de Bethencourt -
Fixing jornal to Journal.
Signed-off-by: Salah Triki
Signed-off-by: Luis de Bethencourt -
For validating superblock state, add flags field to befs_sb_info, read the state from the disk
and check if it is equal to BEFS_DIRTY.Signed-off-by: Salah Triki
Signed-off-by: Luis de Bethencourt -
Fixing skeep to skip.
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
befs_btree_find(), the only caller of befs_find_key(), only cares about if
the return from that function is BEFS_BT_MATCH or not. It never uses the
partial match given with BEFS_BT_PARMATCH. Make the overflow return clearer
by having BEFS_BT_OVERFLOW instead of BEFS_BT_PARMATCH.Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
ret is initialized to -EIO and is never modified, so remove ret and use
-EIO directly.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
There is no need to init res, since it will be overwitten later by
befs_fblock2brun().Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned
value by this function is only used once.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
node_off is unconditionally set to bt_super.root_node_ptr, so no need to
init it to zero.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
There is no need to set *value, it will be overwritten later.
Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
As VFS expects, lookup inserts NULL inode to dentry when the named inode
does not exist.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
The calls to brelse are useless since dbl_indir_block and indir_block
are NULL.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
Constant has to be capitalized.
Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
The only caller of befs_find_brun_direct is befs_fblock2brun, which
already validates that the block is within the range of direct blocks.
So remove the duplicate validation.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
Fixing a grammatical error in the documentation.
Signed-off-by: Luis de Bethencourt
-
The only place the values of free_node_ptr and max_size are read is in
befs_dump_index_entry(), which both times it is called, it is passed the on
disk superblock. Removing assignment of unused values.Signed-off-by: Luis de Bethencourt
-
befs_error() is used in potential errors that could happen in befs to
provide informational log messages. befs_debug() is silent when
CONFIG_BEFS_DEBUG=no, and very verbose when switched on, which is why it is
used for general debugging but not for errors.Fix a few cases where the befs debug utility usage isn't following the
expected pattern. To make sure we have consistent information in the logs.Signed-off-by: Luis de Bethencourt
-
Replace goto with simpler while loop to make befs_readdir() more readable.
Signed-off-by: Luis de Bethencourt
-
Use macro directly instead of via assigning it to an unchanging variable.
Signed-off-by: Luis de Bethencourt
Acked-by: Salah Triki -
No need to dereference dentry twice to get the name when we already have
it stored in a local variable.Signed-off-by: Luis de Bethencourt
-
This comment with a mysterious unfinished line confuses the kernel-doc
system since, because it starts with /**, it thinks it is documenting a
function.Signed-off-by: Luis de Bethencourt
-
Log error only when silent flag is not set.
Fixes: dbe6460388bc ("fs/befs/linuxvfs.c: check silent flag before logging errors")
Signed-off-by: Luis de Bethencourt
Acked-by: Salah Triki
