Eric Lee / smarc-fsl-linux-kernel

22 Aug, 2019

1 commit

  • 87fcb6a69   HID: do not call hid_set_drvdata(hdev, NULL) in drivers ... Browse Code »

    This is a common pattern in the HID drivers to reset the drvdata. Some
    do it properly, some do it only in case of failure.

    But, this is actually already handled by driver core, so there is no need
    to do it manually.

    [for hid-sensor-hub.c]
    Acked-by: Srinivas Pandruvada
    [For hid-picolcd_core.c]
    Acked-by: Bruno Prémont
    Signed-off-by: Benjamin Tissoires

    Benjamin Tissoires
     

05 Jun, 2019

1 commit

  • 24c9d96dd   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 265 ... Browse Code »

    Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation version 2 of the license this driver is
    distributed in the hope that it will be useful but without any
    warranty without even the implied warranty of merchantability or
    fitness for a particular purpose see the gnu general public license
    for more details you should have received a copy of the gnu general
    public license along with this software if not see http www gnu org
    licenses

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 8 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Richard Fontana
    Reviewed-by: Allison Randal
    Reviewed-by: Alexios Zavras
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190529141333.861653206@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

27 Mar, 2019

1 commit

28 Aug, 2014

1 commit

27 Aug, 2014

1 commit

04 Sep, 2013

1 commit

  • 1e87a2456   HID: picolcd_core: validate output report details ... Browse Code »

    A HID device could send a malicious output report that would cause the
    picolcd HID driver to trigger a NULL dereference during attr file writing.

    [jkosina@suse.cz: changed

    report->maxfield < 1

    to

    report->maxfield != 1

    as suggested by Bruno].

    CVE-2013-2899

    Signed-off-by: Kees Cook
    Cc: stable@kernel.org
    Reviewed-by: Bruno Prémont
    Acked-by: Bruno Prémont
    Signed-off-by: Jiri Kosina

    Kees Cook
     

25 Feb, 2013

1 commit

  • d88142725   HID: use hid_hw_request() instead of direct call to usbhid ... Browse Code »

    This allows the hid drivers to be independent from the transport layer.

    The patch was constructed by replacing all occurences of
    usbhid_submit_report() by its hid_hw_request() counterpart.
    Then, drivers not requiring USB_HID anymore have their USB_HID
    dependency cleaned in the Kconfig file.

    Finally, few drivers still depends on USB_HID. Many of them
    are requiring the io wait callback. They are found in the next patch.

    Signed-off-by: Benjamin Tissoires
    Reviewed-by: Mika Westerberg

    For the sensor-hub part:
    Tested-by: Mika Westerberg
    Signed-off-by: Jiri Kosina

    Benjamin Tissoires
     

03 Jan, 2013

1 commit

  • f425458ea   HID: Use module_hid_driver macro ... Browse Code »

    Use the new module_hid_driver macro in all HID drivers that have
    a simple register/unregister init/exit.

    This also converts the hid drivers that test for a failure of
    hid_register_driver() and report the failure. Using module_hid_driver
    in those drivers removes the failure message.

    Signed-off-by: H Hartley Sweeten
    Signed-off-by: Jiri Kosina

    H Hartley Sweeten
     

19 Sep, 2012

2 commits

  • 206e3f1cd   HID: picolcd_core: Remove setting hdev->claimed before calling hid_hw_start() ... Browse Code »

    Current implementation of hid_hw_start() allows connect_mask to be 0.
    Setting hdev->claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not
    necessary. Remove it.

    Signed-off-by: Axel Lin
    Acked-By: Bruno Prémont
    Signed-off-by: Jiri Kosina

    Axel Lin
     
  • bb5c32d99   HID: picoLCD: drop version check during probe ... Browse Code »

    Commit 4ea5454203d991ec85264f64f89ca8855fce69b0
    [HID: Fix race condition between driver core and ll-driver] introduced
    new locking around probe/remove functions that prevents any report/reply
    from hardware to reach driver until it returned from probe.

    As such, the ask-reply way to checking picoLCD firmware version during
    probe is bound to timeout and let probe fail.

    Drop the check to let driver successfully probe again (until locking issues
    are resolved allowing to reinstate the check).

    Signed-off-by: Bruno Prémont
    Signed-off-by: Jiri Kosina

    Bruno Prémont
     

05 Sep, 2012

3 commits

15 Aug, 2012

3 commits