04 Sep, 2019

1 commit


16 Apr, 2019

1 commit

  • The HWMON_CHANNEL_INFO macro simplifies the code, reduces the likelihood
    of errors, and makes the code easier to read.

    The conversion was done automatically with coccinelle. The semantic patch
    used to make this change is as follows.

    @r@
    initializer list elements;
    identifier i;
    @@

    -u32 i[] = {
    - elements,
    - 0
    -};

    @s@
    identifier r.i,j,ty;
    @@

    -struct hwmon_channel_info j = {
    - .type = ty,
    - .config = i,
    -};

    @script:ocaml t@
    ty << s.ty;
    elements << r.elements;
    shorter;
    elems;
    @@

    shorter :=
    make_ident (List.hd(List.rev (Str.split (Str.regexp "_") ty)));
    elems :=
    make_ident
    (String.concat ","
    (List.map (fun x -> Printf.sprintf "\n\t\t\t %s" x)
    (Str.split (Str.regexp " , ") elements)))

    @@
    identifier s.j,t.shorter;
    identifier t.elems;
    @@

    - &j
    + HWMON_CHANNEL_INFO(shorter,elems)

    This patch does not introduce functional changes. Many thanks to
    Julia Lawall for providing the semantic patch.

    Signed-off-by: Guenter Roeck

    Guenter Roeck
     

14 Nov, 2018

1 commit

  • In case an under-voltage happens before probing the driver wont
    write the critical warning into the kernel log. So don't init
    of last_throttled during probe and fix this issue.

    Fixes: 74d1e007915f ("hwmon: Add support for RPi voltage sensor")
    Reported-by: "Noralf Trønnes"
    Signed-off-by: Stefan Wahren
    Signed-off-by: Guenter Roeck

    Stefan Wahren
     

06 Sep, 2018

1 commit

  • The raspberrypi-hwmon driver doesn't automatically load, although it does work
    when loaded, by adding the alias it auto loads as expected when built as a
    module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with
    Fedora 28 and a patched 4.18 RC kernel.

    Fixes: 3c493c885cf ("hwmon: Add support for RPi voltage sensor")
    Signed-off-by: Peter Robinson
    CC: Stefan Wahren
    CC: Eric Anholt
    Acked-by: Guenter Roeck
    Tested-by: Stefan Wahren
    Reviewed-by: Eric Anholt
    Signed-off-by: Florian Fainelli

    Peter Robinson
     

10 Jul, 2018

1 commit

  • Currently there is no easy way to detect undervoltage conditions on a
    remote Raspberry Pi. This hwmon driver retrieves the state of the
    undervoltage sensor via mailbox interface. The handling based on
    Noralf's modifications to the downstream firmware driver. In case of
    an undervoltage condition only an entry is written to the kernel log.

    CC: "Noralf Trønnes"
    Signed-off-by: Stefan Wahren
    Signed-off-by: Eric Anholt
    Acked-by: Guenter Roeck

    Stefan Wahren