Eric Lee / smarc-fsl-linux-kernel

30 Dec, 2020

1 commit

  • 280f29c6b   powerpc/ps3: use dma_mapping_error() ... Browse Code »

    [ Upstream commit d0edaa28a1f7830997131cbce87b6c52472825d1 ]

    The DMA address returned by dma_map_single() should be checked with
    dma_mapping_error(). Fix the ps3stor_setup() function accordingly.

    Fixes: 80071802cb9c ("[POWERPC] PS3: Storage Driver Core")
    Signed-off-by: Vincent Stehlé
    Reviewed-by: Geert Uytterhoeven
    Signed-off-by: Michael Ellerman
    Link: https://lore.kernel.org/r/20201213182622.23047-1-vincent.stehle@laposte.net
    Signed-off-by: Sasha Levin

    Vincent Stehlé
     

24 Aug, 2020

1 commit

  • df561f668   treewide: Use fallthrough pseudo-keyword ... Browse Code »

    Replace the existing /* fall through */ comments and its variants with
    the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
    fall-through markings when it is the case.

    [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

    Signed-off-by: Gustavo A. R. Silva

    Gustavo A. R. Silva
     

18 May, 2020

1 commit

11 May, 2020

1 commit

  • 7bfc3c84c   drivers/powerpc: Replace _ALIGN_UP() by ALIGN() ... Browse Code »

    _ALIGN_UP() is specific to powerpc
    ALIGN() is generic and does the same

    Replace _ALIGN_UP() by ALIGN()

    Signed-off-by: Christophe Leroy
    Signed-off-by: Michael Ellerman
    Reviewed-by: Joel Stanley
    Link: https://lore.kernel.org/r/a5945463f86c984151962a475a3ee56a2893e85d.1587407777.git.christophe.leroy@c-s.fr

    Christophe Leroy
     

04 May, 2020

1 commit

  • 43c8a496f   powerpc/ps3: Move static keyword to the front of declaration ... Browse Code »

    Move the static keyword to the front of declaration of 'vuart_bus_priv',
    and resolve the following compiler warning that can be seen when
    building with warnings enabled (W=1):

    drivers/ps3/ps3-vuart.c:867:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
    } static vuart_bus_priv;
    ^

    Reported-by: Hulk Robot
    Signed-off-by: Xiongfeng Wang
    Signed-off-by: Michael Ellerman
    Link: https://lore.kernel.org/r/1588154448-56759-1-git-send-email-wangxiongfeng2@huawei.com

    Xiongfeng Wang
     

02 Apr, 2020

1 commit

  • 96efbab92   powerpc/ps3: Remove an unneeded NULL check ... Browse Code »

    Static checkers don't like the inconsistent NULL checking on "ops".
    This function is only called once and "ops" isn't NULL so the check
    can be removed.

    Signed-off-by: Dan Carpenter
    Signed-off-by: Geoff Levand
    Signed-off-by: Michael Ellerman
    Link: https://lore.kernel.org/r/ddc3513dc54d15456692c80df49287fe3babe40a.1585340156.git.geoff@infradead.org

    Dan Carpenter
     

31 May, 2019

2 commits

  • 873e65bc0   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 167 ... Browse Code »

    Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation version 2 of the license this program
    is distributed in the hope that it will be useful but without any
    warranty without even the implied warranty of merchantability or
    fitness for a particular purpose see the gnu general public license
    for more details you should have received a copy of the gnu general
    public license along with this program if not write to the free
    software foundation inc 59 temple place suite 330 boston ma 02111
    1307 usa

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 83 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Richard Fontana
    Reviewed-by: Kate Stewart
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190527070034.021731668@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     
  • 935912c53   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 164 ... Browse Code »

    Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation version 2 of the license this program
    is distributed in the hope that it will be useful but without any
    warranty without even the implied warranty of merchantability or
    fitness for a particular purpose see the gnu general public license
    for more details you should have received a copy of the gnu general
    public license along with this program if not write to the free
    software foundation inc 51 franklin street fifth floor boston ma
    02110 1301 usa

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 12 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Richard Fontana
    Reviewed-by: Kate Stewart
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190527070033.745497013@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

21 May, 2019

1 commit

04 Dec, 2017

1 commit

  • f0200c028   ps3: Remove deprecated create_singlethread_workqueue ... Browse Code »

    The workqueue "ps3av->wq" queues a single work item &ps3av->work and hence
    doesn't require ordering. It is involved in waking up ps3avd to do the
    video mode setting and hence it's not being used on a memory reclaim
    path. Hence, it has been converted to use system_wq.

    System workqueues have been able to handle high level of concurrency
    for a long time now and hence it's not required to have a singlethreaded
    workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
    created with create_singlethread_workqueue(), system_wq allows multiple
    work items to overlap executions even on the same CPU; however, a
    per-cpu workqueue doesn't have any CPU locality or global ordering
    guarantee unless the target CPU is explicitly specified and thus the
    increase of local concurrency shouldn't make any difference.

    The work item has been flushed in ps3av_remove to ensure that
    there are no pending tasks while disconnecting the driver.

    Signed-off-by: Bhaktipriya Shridhar
    Acked-by: Tejun Heo
    Signed-off-by: Michael Ellerman

    Bhaktipriya Shridhar
     

02 Mar, 2017

1 commit

20 Sep, 2016

1 commit

  • ef24ba709   powerpc: Remove all usages of NO_IRQ ... Browse Code »

    NO_IRQ has been == 0 on powerpc for just over ten years (since commit
    0ebfff1491ef ("[POWERPC] Add new interrupt mapping core and change
    platforms to use it")). It's also 0 on most other arches.

    Although it's fairly harmless, every now and then it causes confusion
    when a driver is built on powerpc and another arch which doesn't define
    NO_IRQ. There's at least 6 definitions of NO_IRQ in drivers/, at least
    some of which are to work around that problem.

    So we'd like to remove it. This is fairly trivial in the arch code, we
    just convert:

    if (irq == NO_IRQ) to if (!irq)
    if (irq != NO_IRQ) to if (irq)
    irq = NO_IRQ; to irq = 0;
    return NO_IRQ; to return 0;

    And a few other odd cases as well.

    At least for now we keep the #define NO_IRQ, because there is driver
    code that uses NO_IRQ and the fixes to remove those will go via other
    trees.

    Note we also change some occurrences in PPC sound drivers, drivers/ps3,
    and drivers/macintosh.

    Signed-off-by: Michael Ellerman

    Michael Ellerman
     

29 Sep, 2015

2 commits

26 Mar, 2015

1 commit

22 Jan, 2015

2 commits

07 Mar, 2014

1 commit

  • 4a8bb7f54   ps3-vuart: don't use PREPARE_WORK ... Browse Code »

    PREPARE_[DELAYED_]WORK() are being phased out. They have few users
    and a nasty surprise in terms of reentrancy guarantee as workqueue
    considers work items to be different if they don't have the same work
    function.

    ps3_vuart wasn't overriding the work item with multiple work functions
    but was using NULL for INIT_WORK() and then single PREPARE_WORK() to
    set the work function. We can simply invoke INIT_WORK() with the work
    function and remove the PREPARE_WORK() usage.

    It would probably be best to route this with other related updates
    through the workqueue tree.

    Geoff: Tested on ps3 (DECR-1400).

    Signed-off-by: Tejun Heo
    Acked-by: Geoff Levand
    Cc: linuxppc-dev@lists.ozlabs.org
    Cc: cbe-oss-dev@lists.ozlabs.org

    Tejun Heo
     

04 Jan, 2013

1 commit

  • 0fe763c57   Drivers: misc: remove __dev* attributes. ... Browse Code »

    CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
    markings need to be removed.

    This change removes the use of __devinit, __devexit_p, __devinitdata,
    __devinitconst, and __devexit from these drivers.

    Based on patches originally written by Bill Pemberton, but redone by me
    in order to handle some of the coding style issues better, by hand.

    Cc: Bill Pemberton
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

25 Apr, 2012

1 commit

08 Nov, 2011

1 commit

  • 6ea741a13   powerpc/ps3: irq: Remove IRQF_DISABLED ... Browse Code »

    Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
    We run all interrupt handlers with interrupts disabled
    and we even check and yell when an interrupt handler
    returns with interrupts enabled (see commit [b738a50a:
    genirq: Warn when handler enables interrupts]).

    So now this flag is a NOOP and can be removed.

    Signed-off-by: Yong Zhang
    Acked-by: Geoff Levand
    Signed-off-by: Benjamin Herrenschmidt

    Yong Zhang
     

01 Nov, 2011

2 commits

31 Mar, 2011

1 commit

29 Nov, 2010

1 commit

23 Apr, 2010

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

16 Mar, 2010

1 commit

09 Feb, 2010

1 commit

04 Dec, 2009

1 commit

  • af901ca18   tree-wide: fix assorted typos all over the place ... Browse Code »

    That is "success", "unknown", "through", "performance", "[re|un]mapping"
    , "access", "default", "reasonable", "[con]currently", "temperature"
    , "channel", "[un]used", "application", "example","hierarchy", "therefore"
    , "[over|under]flow", "contiguous", "threshold", "enough" and others.

    Signed-off-by: André Goddard Rosa
    Signed-off-by: Jiri Kosina

    André Goddard Rosa
     

11 Sep, 2009

1 commit

  • bc00351ed   powerpc/ps3: Workaround for flash memory I/O error ... Browse Code »

    A workaround for flash memory I/O errors when the PS3 internal
    hard disk has not been formatted for OtherOS use.

    This error condition mainly effects 'Live CD' users who have not
    formatted the PS3's internal hard disk for OtherOS.

    Fixes errors similar to these when using the ps3-flash-util
    or ps3-boot-game-os programs:

    ps3flash read failed 0x2050000
    os_area_header_read: read error: os_area_header: Input/output error
    main:627: os_area_read_hp error.
    ERROR: can't change boot flag

    Signed-off-by: Geoff Levand
    Signed-off-by: Benjamin Herrenschmidt

    Geoff Levand
     

15 Jun, 2009

3 commits

11 Mar, 2009

1 commit

16 Jan, 2009

2 commits

  • a9dad6e59   powerpc/ps3: Printing fixups for l64 to ll64 conversion drivers/ps3 ... Browse Code »

    Also some min -> mint_t conversion.

    Signed-off-by: Stephen Rothwell
    Acked-by: Geoff Levand
    Signed-off-by: Benjamin Herrenschmidt

    Stephen Rothwell
     
  • b17b3df16   powerpc/ps3: The lv1_ routines have u64 parameters ... Browse Code »

    We just fix up the reference parameters as the others are dealt with by
    arithmetic promotion rules and don't cause warnings.

    This removes warnings like this:

    arch/powerpc/platforms/ps3/interrupt.c:327: warning: passing argument 1 of 'lv1_construct_event_receive_port' from incompatible pointer type

    Also, these:

    drivers/ps3/ps3-vuart.c:462: warning: passing argument 4 of 'ps3_vuart_raw_read' from incompatible pointer type
    drivers/ps3/ps3-vuart.c:592: warning: passing argument 4 of 'ps3_vuart_raw_read' from incompatible pointer type

    Signed-off-by: Stephen Rothwell
    Acked-by: Geoff Levand
    Signed-off-by: Benjamin Herrenschmidt

    Stephen Rothwell
     

19 Nov, 2008

1 commit

05 Nov, 2008

1 commit

  • fce4d5835   powerpc/ps3: Fix compile error in ps3-lpm.c ... Browse Code »

    Compiling with CONFIG_SMP = n and CONFIG_PS3_LPM != n gives this error:

    drivers/ps3/ps3-lpm.c:838: error: implicit declaration of function 'get_hard_smp_processor_id'

    This fixes it. We have to include rather than
    because the UP definition of get_hard_smp_processor_id()
    is in , and only includes if
    CONFIG_SMP = y.

    Signed-off-by: Alexey Dobriyan
    Acked-by: Geoff Levand
    Signed-off-by: Paul Mackerras

    Alexey Dobriyan
     

20 Oct, 2008

1 commit