26 Sep, 2014
29 commits
-
The largest byte size in use currently is 8. Fix array size to 9.
drivers/mfd/max8925-i2c.c:40:33:
warning: Variable length array is usedSigned-off-by: Lee Jones
-
drivers/mfd/88pm860x-i2c.c:125:33:
warning: Variable length array is used.Signed-off-by: Lee Jones
-
The following functions appear to be unused since v2.6.39:
pm860x_page_reg_read()
pm860x_page_bulk_write()
pm860x_page_set_bits()Let's remove them.
Signed-off-by: Lee Jones
-
This patch adds the LPC Device IDs for the Intel 9 Series PCH.
Signed-off-by: James Ralston
Signed-off-by: Lee Jones -
This patch improves support for the flash cell of
max77693 mfd by adding relevant of_compatible field
and a structure for caching related platform data.
Added are also FLASH registers related macro definitions.Signed-off-by: Jacek Anaszewski
Signed-off-by: Andrzej Hajda
Acked-by: Kyungmin Park
Signed-off-by: Lee Jones -
According to the MAX77693 documentation the name of
the register is FLASH_STATUS.Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Signed-off-by: Lee Jones -
This is the same as used in Baytrail so add the new PCI ID to the driver's
list of supported IDs.Signed-off-by: Alan Cox
Signed-off-by: Mika Westerberg
Signed-off-by: Lee Jones -
Since commit b42261078a91 ("regmap: i2c: fallback to SMBus if the adapter
does not support standard I2C"), regmap-i2c will check the
I2C_FUNC_SMBUS_[BYTE|WORD]_DATA functionality based on the regmap_config
setting if the adapter does not support standard I2C.So remove the I2C_FUNC_SMBUS_BYTE_DATA functionality check in the driver code.
Signed-off-by: Axel Lin
Signed-off-by: Lee Jones -
Convert a zero return value on error to a negative one, as returned
elsewhere in the function.Additionally, converted 1 << 7 to BIT(7) at the suggestion of Lee Jones.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}//
Signed-off-by: Julia Lawall
Signed-off-by: Lee Jones -
regmap_add_irq_chip is called from arizona_irq_init with the irq_base
specified as -1 and regmap_add_irq_chip uses if (irq_base) to check if
it should use legacy IRQ mapping. As such the irq mappings are currently
added with irq_domain_add_legacy, rather than irq_domain_add_linear.
This is clearly a typo as there is no reason why this driver can't use
irq_domain_add_linear.This patch corrects this by passing the irq_base as zero to
regmap_add_irq_chip.Signed-off-by: Charles Keepax
Signed-off-by: Lee Jones -
Mark some additional registers as volatile. The write sequencer control
registers should not be cached, as we don't ever want their value
synchronised as this might cause a write sequence to be accidentally
initiated.Additionally, the DAC_COMP registers require special preconditions to
write so there values wouldn't be updated accurately during a register
sync.Signed-off-by: Charles Keepax
Signed-off-by: Lee Jones -
During init the core checks if the wm5102 has finished starting by reading
register 0x19 and looking at the value. This read always fails since this
is not a readable register, mark it as being one. While we're at it provide
a constant for the register name (as supplied by Charles Keepax).Signed-off-by: Mark Brown
Signed-off-by: Charles Keepax
Signed-off-by: Lee Jones -
The prefix suggests the number should be printed in hex, so use
the %x specifier to do that.Found by using regex suggested by Joe Perches.
Signed-off-by: Hans Wennborg
Signed-off-by: Lee Jones -
Convert a zero return value on error to a negative one, as returned
elsewhere in the function.A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}//
Signed-off-by: Julia Lawall
Signed-off-by: Lee Jones -
The interfaces that used to be built in only (interrupts IIRC) no longer
are so allow the driver to be built as a module fixing arm64 allmodconfig
builds.Signed-off-by: Mark Brown
Acked-by: Charles Keepax
Signed-off-by: Lee Jones -
If vtg is NULL, it is not possible to access its mode_reg field. At all
sites where the static function menelaus_set_voltage is called, the first
argument is the address of a structure defined in the file. So, the null
test is unnecessary and is removed. Also, a label is done away with.This problem was found using the following Coccinelle semantic match:
//
@@
expression E, E1;
identifier f;
statement S1,S2,S3;
@@* if (E == NULL)
{
... when != if (E == NULL) S1 else S2
when != E = E1
* E->f
... when any
return ...;
}
else S3
//Signed-off-by: Himangi Saraogi
Acked-by: Julia Lawall
Signed-off-by: Lee Jones -
We'd like to be able to build the WM8994 family as modules, but the
build will fail if the external symbols aren't exported first.Acked-by: Charles Keepax
Signed-off-by: Lee Jones -
Suspicious implicit sign extension where 'reg' (unsigned char) is
promoted in reg << clksrc to int, then sign-extended to unsigned
long. If reg << clksrc is greater than 0x7FFFFFFF, the upper bits
of the result will all be 1.Signed-off-by: Lee Jones
-
In the original code a return value variable was provided, but it
was never checked and the user was never informed of failure. Now
it is and they are.Signed-off-by: Lee Jones
-
The return value of platform_device_add() is checked after every
other use throughout the kernel.We're also sliding in another cheeky dev_err() => dev_warn() change
as we're not actually erroring out here, rather reporting the fact
that something's gone wrong, but carrying on regardless.Signed-off-by: Lee Jones
-
As 'reg' is unsigned, it can't be less than 0, so checking if it is
greater than or equal to 0 will always result in a true condition.Signed-off-by: Lee Jones
-
Chip identifier wm5102_reva_patch is always overwritten with
wm5102_revb_patch, even when the code is run on a Rev-A chip. Place
in the missing break to force the code into doing something sensible
instead.Signed-off-by: Lee Jones
-
Checking the result of container_of() against NULL will always result to
false. Using the offset of member 'chip_out' to find the start of 'struct
htcpld_chip' will result in an offset error when .get_chip() is attempting
to obtain 'htcpld-in'. Instead, we'll use the correct member based on a
previously the set chip label.Signed-off-by: Lee Jones
-
This aids in consistency, as the rest of the checks in the file use this
notation.Signed-off-by: Lee Jones
-
Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: return;
Remove the check for NULL.
Signed-off-by: Lee Jones
-
Calling strncpy with a maximum size argument of 32 bytes on destination
array kim_gdata->dev_name of size 32 bytes might leave the destination
string unterminated.Cc: gregkh@linuxfoundation.org
Signed-off-by: Lee Jones -
Coverity reported:
This less-than-zero comparison of an unsigned value is never true.In answer to that, we only ever decrement if protos_registered is
positive. We can subsequently remove the paranoid checking during
unregister.Cc: gregkh@linuxfoundation.org
Signed-off-by: Lee Jones -
Value from st_sensors_set_drdy_int_pin() is assigned to err here,
but that stored value is not used before it is overwritten. To fix
this we're enforcing a check on st_sensors_set_drdy_int_pin()'s
return value and if it's an error, we're returning right away.Cc: jic23@kernel.org
Cc: linux-iio@vger.kernel.org
Signed-off-by: Lee Jones -
…power-charger-regulator-3.18' into ibs-for-mfd-merged
24 Sep, 2014
11 commits
-
Added driver to support the 14F021P00 BMC Hardware Monitoring.
The BMC is a Board Management Controller including monitoring of the
board voltages.Signed-off-by: Andreas Werner
Reviewed-by: Guenter Roeck
Signed-off-by: Lee Jones -
Added driver to support the 14F021P00 BMC LEDs.
The BMC is a Board Management Controller including four LEDs which
can be switched on and off.Signed-off-by: Andreas Werner
Acked-by: Bryan Wu
Signed-off-by: Lee Jones -
Added driver to support the 14F021P00 BMC Watchdog.
The BMC is a Board Management Controller including watchdog functionality.Signed-off-by: Andreas Werner
Reviewed-by: Guenter Roeck
Signed-off-by: Lee Jones -
Document the 'fast charge timer' setting exported by max14577 driver
through sysfs entry.Signed-off-by: Krzysztof Kozlowski
Acked-by: Andrew Morton
Signed-off-by: Lee Jones -
Add document describing device tree bindings for MAX14577 MFD
drivers: MFD core, extcon, regulator and charger.Both MAX14577 and MAX77836 chipsets are documented.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Tomasz Figa
Acked-by: Andrew Morton
Signed-off-by: Lee Jones -
MAX77836 has the same Fuel Gauge as MAX17040/17048. The max17040 driver
can be safely re-used. The patch adds MAX77836 device to the array of
i2c_device_id. Additionally it removes the id associated with MAX17040
device as the value is not used.Signed-off-by: Krzysztof Kozlowski
Acked-by: Andrew Morton
Signed-off-by: Lee Jones -
Remove hard-coded values for:
- Fast Charge current,
- End Of Charge current,
- Fast Charge timer,
- Overvoltage Protection Threshold,
- Battery Constant Voltage,
and use DTS or sysfs to configure them. This allows using the max14577 charger
driver with different batteries.Now the charger driver requires valid configuration data from DTS. In
case of wrong configuration data it fails during probe.The fast charge timer is configured through sysfs entry.
Signed-off-by: Krzysztof Kozlowski
Acked-by: Andrew Morton
Signed-off-by: Lee Jones -
This patch prepares for changing the max14577 charger driver to allow
configuring battery-dependent settings from DTS.The patch moves from regulator driver to MFD core driver and exports:
- function for calculating register value for charger's current;
- table of limits for chargers (MAX14577, MAX77836).Previously they were used only by the max14577 regulator driver. In next
patch the charger driver will use them as well. Exporting them will
reduce unnecessary code duplication.Signed-off-by: Krzysztof Kozlowski
Acked-by: Mark Brown
Acked-by: Andrew Morton
Signed-off-by: Lee Jones -
Add support for MAX77836 charger to the max14577 driver. The MAX77836
charger is almost the same as 14577 model except:
- No dead-battery detection;
- Support for special charger (like in MAX77693);
- Support for DX over-voltage protection (like in MAX77693);
- Lower values of charging current (two times lower current for
slow/fast charge, much lower EOC current);
- Slightly different values in ChgTyp field of STATUS2 register. On
MAX14577 0x6 is reserved and 0x7 dead battery. On the MAX77836 the
0x6 means special charger and 0x7 is reserved. Regardless of these
differences the driver maps them to one enum max14577_muic_charger_type.Signed-off-by: Krzysztof Kozlowski
Acked-by: Andrew Morton
Signed-off-by: Lee Jones -
Add a "maxim,max14577-charger" of_compatible to the mfd_cell so the
MFD child device (the charger) will have its own of_node set. This will
be used by the max14577 charger driver in next patches to obtain battery
configuration from DTS.Signed-off-by: Krzysztof Kozlowski
Acked-by: Andrew Morton
Signed-off-by: Lee Jones -
Prepare for adding support for MAX77836 charger to the max14577 charger
driver by adding necessary new defines and prefixes to existing ones.The MAX77836 uses slightly different values for ChgTyp field of STATUS2
register. On the MAX14577 value of 0x6 is reserved and 0x7 dead battery.
On the MAX77836 the opposite:
- 0x6 means special charger,
- 0x7 is reserved.
Regardless of these differences use one common enum
max14577_muic_charger_type.Signed-off-by: Krzysztof Kozlowski
Cc: Kyungmin Park
Acked-by: Lee Jones
Acked-by: Andrew Morton
