31 Oct, 2009
5 commits
-
This implements a basic set of rtnl link ops and takes advantage of
the fact that rtnl_link_unregister kills all of the surviving
devices to all us to kill bond_free_all. A module alias
is added so ip link add can pull in the bonding module.Signed-off-by: Eric W. Biederman
Signed-off-by: David S. Miller -
Manually inline the code from bond_deinit to bond_uninit. bond_uninit
is the only caller and it is short.Move the call of bond_release_all from the netdev notifier into
bond_uninit. The call site is effectively the same and performing
the call explicitly allows all the paths for destroying a
bonding device to behave the same way.Signed-off-by: Eric W. Biederman
Signed-off-by: David S. Miller -
Stop calling dev_get_by_name to see if the bond device already
exists. register_netdevice already does that.Stop calling bond_deinit if register_netdevice fails as bond_uninit
is guaranteed to be called if bond_init succeeds.Signed-off-by: Eric W. Biederman
Signed-off-by: David S. Miller -
This patch delegates the work of creating the sysfs groups
to the netdev layer and ultimately to the device layer. This
closes races between uevents.Signed-off-by: Eric W. Biederman
Signed-off-by: David S. Miller -
This isn't beautifully abstracted, but it is simple,
simplifies uses and so far is only needed for the bonding driver.Signed-off-by: Eric W. Biederman
Signed-off-by: David S. Miller
30 Oct, 2009
16 commits
-
Small cleanup of __dev_get_by_name() and __dev_get_by_index()
to use hlist_for_each_entry() : They'll look like their _rcu variant.Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
In commit 23289a37e2b127dfc4de1313fba15bb4c9f0cd5b
(net: add a list_head parameter to dellink() method),
I forgot to actually use this parameter in veth_dellink.I remember feeling a bit uncomfortable about veth_close(),
because it does :netif_carrier_off(dev);
netif_carrier_off(priv->peer);Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
The temporary copy of the VLAN group is not neccessary since the lower device
is already in the process of being unregistered, if it was neccessary the
memset of the global group would introduce a race condition.With this removed, the changes to the original code are only a few lines, so
remove the new function and move the code back into vlan_device_event().Signed-off-by: Patrick McHardy
Acked-by: Eric Dumazet
Signed-off-by: David S. Miller -
For USB 3.0 it is necessary that all drivers use the standard
API to reset a configuration. This removes a home-grown
implementation.Signed-off-by: Oliver Neukum
Hi David,
please take this for the next merge window.
Regards
Oliver
Signed-off-by: David S. Miller -
struct ax25_ctl_struct member `arg' is unsigned and cannot be less
than 0.Signed-off-by: Roel Kluin
Signed-off-by: David S. Miller -
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Tentative support for newer Marvell hardware including
the Yukon-2 Optima chip. Do not have hatdware to test this yet,
code is based on vendor driver.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Changes related to support of Yukon supreme chip.
Don't have this chip version to test on,
these are reverse engineered from the vendor (GPL) driver.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Program the receive pause thresholds differently depending on
chip version. This cloned from from the vendor (GPL) driver.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
This adds infrastructure for the newer chip versions and workarounds.
Extracted from the vendor (GPL) driver.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
This is a new ID that just showed up in latest vendor driver.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Now that we can tell whether GRO is being applied, this heuristic is
effective once more.Signed-off-by: Ben Hutchings
Signed-off-by: David S. Miller -
When GRO is successfully merging received packets, we should allocate
raw page buffers rather than skbs that will be discarded by GRO.
Otherwise, we should allocate skbs.GRO also benefits from higher interrupt moderation, so increase the
score for mergeable RX packets.Signed-off-by: Ben Hutchings
Signed-off-by: David S. Miller -
This will allow drivers to adjust their receive path dynamically
based on whether GRO is being applied successfully.Currently all in-tree callers ignore the return values of these
functions and do not need to be changed.Signed-off-by: Ben Hutchings
Acked-by: Herbert Xu
Signed-off-by: David S. Miller -
This clarifies which return and parameter types are GRO result codes
and not RX result codes.Signed-off-by: Ben Hutchings
Acked-by: Herbert Xu
Signed-off-by: David S. Miller
29 Oct, 2009
19 commits
-
Currently PACKET_TX_RING forces certain amount of every frame to remain
unused. This probably originates from an early version of the
PACKET_TX_RING patch that in fact used the extra space when the (since
removed) CONFIG_PACKET_MMAP_ZERO_COPY option was enabled. The current
code does not make any use of this extra space.This patch removes the extra space reservation and lets userspace make
use of the full frame size.Signed-off-by: Gabor Gombas
Signed-off-by: David S. Miller -
proto_ops->getname implies copying protocol specific data
into storage unit (particulary to __kernel_sockaddr_storage).
So when we implement new protocol support we should keep such
a detail in mind (which is easy to forget about).Lets introduce DECLARE_SOCKADDR helper which check if
storage unit is not overfowed at build time.Eventually inet_getname is switched to use DECLARE_SOCKADDR
(to show example of usage).Signed-off-by: Cyrill Gorcunov
Signed-off-by: David S. Miller -
Some workloads hit dev_base_lock rwlock pretty hard.
We can use RCU lookups to avoid touching this rwlock.netdevices are already freed after a RCU grace period, so this patch
adds no penalty at device dismantle time.dev_ifname() converted to dev_get_by_index_rcu()
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
The variables are unsigned so the `< 0' test always fails, the
other part of the test catches wrapped values.Signed-off-by: Roel Kluin
Signed-off-by: David S. Miller -
optlen is unsigned so the `< 0' test is never true.
Signed-off-by: Roel Kluin
Signed-off-by: David S. Miller -
If there is data, the unsigned skb->len is greater than 0.
rt.sigdigits is unsigned as well, so the test `>= 0' is
always true, the other part of the test catches wrapped
values.Signed-off-by: Roel Kluin
Signed-off-by: David S. Miller -
Replace the sequence of strcmp calls for interpreting ZSAU parameter
strings by a table of known strings and lookup loop to improve
readability.Impact: readability improvement, no functional change
Signed-off-by: Tilman Schmidt
Signed-off-by: David S. Miller -
On more step towards the holy grail of checkpatch.pl silence.
Impact: cosmetic
Signed-off-by: Tilman Schmidt
Signed-off-by: David S. Miller -
On the quest for the holy grail of checkpatch.pl silence.
Impact: cosmetic
Signed-off-by: Tilman Schmidt
Signed-off-by: David S. Miller -
Duly uglified as demanded by checkpatch.pl.
Impact: cosmetic
Signed-off-by: Tilman Schmidt
Signed-off-by: David S. Miller -
Dum sanctis checkpatch.pl'ae legibus obsequimur.
Impact: cosmetic
Signed-off-by: Tilman Schmidt
Signed-off-by: David S. Miller -
Reorganize the code of the Gigaset M10x driver to make it more
readable, less redundant, better aligned to the style of other
parts of the driver, and cause fewer checkpatch.pl complaints.Impact: code reorganization, no functional change
Signed-off-by: Tilman Schmidt
Signed-off-by: David S. Miller -
The CAPI interface incorrectly assumed that CAPI messages would always
start at the beginning of the data buffer: fix by treating DATA_B3
messages as the link layer header to their payload data. This fix
changes the way acknowledgement information is propagated through the
hardware specific modules and thereby impacts the ISDN4Linux variant
of the driver, too.Also some assumptions about methods not being called from interrupt
context turned out to be unwarranted; fix by using dev_kfree_skb_any()
wherever non-interrupt context isn't guaranteed.Impact: bugfix
Signed-off-by: Tilman Schmidt
Signed-off-by: David S. Miller -
A missing dot lead to garbage characters being included in the
dial command generated from a CAPI CONNECT_REQ message, which
interestingly enough worked anyway, illustrating the resilience
of the device.Impact: bugfix
Signed-off-by: Tilman Schmidt
Signed-off-by: David S. Miller -
Replace the "ignoring Additional Info" warning message by better
readable ones citing the specific subparameters being ignored.
Make parts of the code more readable by using a local cmsg
pointer variable.Impact: readability improvement
Signed-off-by: Tilman Schmidt
Signed-off-by: David S. Miller -
Add and use no DSCAK bit in the features field.
Signed-off-by: Gilad Ben-Yossef
Sigend-off-by: Ori Finkelman
Sigend-off-by: Yony Amit
Signed-off-by: David S. Miller -
Add and use no window scale bit in the features field.
Note that this is not the same as setting a window scale of 0
as would happen with window limit on route.Signed-off-by: Gilad Ben-Yossef
Sigend-off-by: Ori Finkelman
Sigend-off-by: Yony Amit
Signed-off-by: David S. Miller -
Implement querying and acting upon the no timestamp bit in the feature
field.Signed-off-by: Gilad Ben-Yossef
Sigend-off-by: Ori Finkelman
Sigend-off-by: Yony Amit
Signed-off-by: David S. Miller
