16 Aug, 2013
2 commits
-
Gateway LT27 needs a fixup for the inverted digital mic.
Reported-by: "Nathanael D. Noblet"
Cc:
Signed-off-by: Takashi Iwai -
…nie/sound into for-linus
ASoC: Fixes for v3.11
A few driver specific fixes here plus one core fix for a memory
corruption issue in DAPM initialisation which could lead to crashes.
15 Aug, 2013
5 commits
-
The Tegra30 I2S driver was writing the AHUB interface parameters to the
playback path register rather than the capture path register. This
caused the capture parameters not to be configured at all, so if
capturing using non-HW-default parameters (e.g. 16-bit stereo rather
than 8-bit mono) the audio would be corrupted.With this fixed, audio capture from an analog microphone works correctly
on the Cardhu board.Cc: stable@vger.kernel.org
Signed-off-by: Stephen Warren
Signed-off-by: Mark Brown
12 Aug, 2013
6 commits
-
Add the volume control quirk for avoiding the kernel warning
for the Logitech HD Webcam C525
as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2
for the Logitech HD Webcam C310.Reported-by: Maksim Boyko
Tested-by: Maksim Boyko
Cc: # 3.10.5+
Signed-off-by: Maksim Boyko
Signed-off-by: Takashi Iwai -
We've added a fake mute control (setting the amp volume to zero) for
CX5051 at commit [3868137e: ALSA: hda - Add a fake mute feature], but
this feature was overlooked in the generic parser implementation. Now
the driver lacks of mute controls on these codecs.The fix is just to check both AC_AMPCAP_MUTE and AC_AMPCAP_MIN_MUTE
bits in each place checking the amp capabilities.Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=59001
Cc: [v3.9+]
Signed-off-by: Takashi Iwai -
Commit aafe77cc45a5 (ALSA: usb-audio: add support for many Roland/Yamaha
devices) had several logic errors that prevented create_auto_midi_quirk
from enumerating any MIDI ports.Reported-by: Keith A. Milner
Signed-off-by: Clemens Ladisch
Signed-off-by: Takashi Iwai -
Patch makes midi output buffer DMA-able by allocating it separately.
Signed-off-by: Torsten Schenk
Cc:
Signed-off-by: Takashi Iwai -
Patch makes pcm buffers DMA-able by allocating each one separately.
Signed-off-by: Torsten Schenk
Cc:
Signed-off-by: Takashi Iwai -
Correct the pins for a line-in and a headphone on LG LW25 laptop with
ALC880 codec. Other pins seem fine.Reported-and-tested-by: Joonas Saarinen
Cc: [v3.9+]
Signed-off-by: Takashi Iwai
08 Aug, 2013
1 commit
-
The driver used to assume that the streaming endpoint's wMaxPacketSize
value would be an indication of how much data the endpoint expects or
sends, and compute the number of packets per URB using this value.However, the Focusrite Scarlett 2i4 declares a value of 1024 bytes,
while only about 88 or 44 bytes are be actually used. This discrepancy
would result in URBs with far too few packets, which would not work
correctly on the EHCI driver.To get correct URBs, use wMaxPacketSize only as an upper limit on the
packet size.Reported-by: James Stone
Tested-by: James Stone
Cc: # 2.6.35+
Signed-off-by: Clemens Ladisch
Signed-off-by: Takashi Iwai
07 Aug, 2013
3 commits
-
Patch fixes 6fire not to use stack as URB transfer_buffer. URB buffers need to
be DMA-able, which stack is not. Furthermore, transfer_buffer should not be
allocated as part of larger device structure because DMA coherency issues and
patch fixes this issue too.Cc: stable@vger.kernel.org
Signed-off-by: Jussi Kivilinna
Tested-by: Torsten Schenk
Signed-off-by: Takashi Iwai -
CS42L52 Beep control uses 2dB scale from -56dB
Signed-off-by: Brian Austin
Signed-off-by: Mark Brown -
Beep Volume Min/Max was backwards.
Change to SOC_SONGLE_SX_TLV for correct volume representationSigned-off-by: Brian Austin
Signed-off-by: Mark Brown
Cc: stable@kernel.org
02 Aug, 2013
2 commits
-
A fixup for Apple Mac Mini was lost during the adaption to the generic
parser because the fallback for the generic ID 8384:7680 was dropped,
and it resulted in the silence output (and maybe other problems).Unfortunately, just adding the missing subsystem ID wasn't enough, in
this case. The subsystem ID of this machine is 0000:0100 (what Apple
thought...?), and since snd_hda_pick_fixup() doesn't take the vendor
id zero into account, the driver ignored this entry. Now it's fixed
to regard the vendor id zero as a valid value.Reported-and-tested-by: Linus Torvalds
Cc: [v3.9+]
Signed-off-by: Takashi Iwai -
list_first_entry() will always return a valid pointer, even if the list is
empty. So the check whether path is NULL will always be false. So we end up
calling dapm_create_or_share_mixmux_kcontrol() with a path struct that points
right in the middle of the widget struct and by trying to modify the path the
widgets memory will become corrupted. Fix this by using list_emtpy() to check if
the widget doesn't have any paths.Signed-off-by: Lars-Peter Clausen
Tested-by: Stephen Warren
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org
01 Aug, 2013
6 commits
-
The SGTL5000 Capture Attenuate Switch (or "ADC Volume Range Reduction"
as it is called in the manual) is single bit only.Signed-off-by: Lothar Waßmann
Reviewed-by: Fabio Estevam
Signed-off-by: Mark Brown -
When a sound capture/playback is terminated while a playback/capture
is running, power_vag_event() will clear SGTL5000_CHIP_ANA_POWER in
the SND_SOC_DAPM_PRE_PMD event, thus muting the respective other
channel.Don't clear SGTL5000_CHIP_ANA_POWER when both DAC and ADC are active
to prevent this.Signed-off-by: Lothar Waßmann
Reviewed-by: Fabio Estevam
Signed-off-by: Mark Brown -
…nie/sound into for-linus
ASoC: Fixes for v3.11
A fix to make sure userspace knows when control writes have caused a
change in value, fixing some UIs, plus a few few driver fixes mainly
cleaning up issues from recent refactorings on less mainstream platforms.
31 Jul, 2013
2 commits
-
If kzalloc() fails for `img' then we are going to leak the memory
for `out'. We are freeing the memory of all the tx/rx transfers
but the tx/rx buf pointers will be NULL if we drop out earlier.Signed-off-by: Dimitris Papastamos
Signed-off-by: Mark Brown -
d8b51c11ff5a70244753ba60abfd47088cf4dcd4 [ASoC: ac97c: Use
module_platform_driver()] broke the build:CC sound/soc/au1x/ac97c.o
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: expected identifier or ‘(’ before ‘&’ token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: pasting "__initcall_" and "&" does not give a valid preprocessing token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘&’ token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: expected identifier or ‘(’ before ‘&’ token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: pasting "__exitcall_" and "&" does not give a valid preprocessing token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘&’ token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:334:31: warning: ‘au1xac97c_driver’ defined but not used [-Wunused-variable]
make[5]: *** [sound/soc/au1x/ac97c.o] Error 1
make[4]: *** [sound/soc/au1x] Error 2
make[3]: *** [sound/soc] Error 2Signed-off-by: Ralf Baechle
Signed-off-by: Mark Brown
30 Jul, 2013
2 commits
-
If CONFIG_SND_BF5XX_HAVE_COLD_RESET is enabled building the blackfin ac97 driver
fails with the following compile error:
sound/soc/blackfin/bf5xx-ac97.c: In function ‘asoc_bfin_ac97_probe’:
sound/soc/blackfin/bf5xx-ac97.c:297: error: expected ‘;’ before ‘{’ token
sound/soc/blackfin/bf5xx-ac97.c:302: error: label ‘gpio_err’ used but not definedThe issue was introduced in commit 6dab2fd7 ("ASoC: bf5xx-ac97: Convert to
devm_gpio_request_one()").Signed-off-by: Lars-Peter Clausen
Signed-off-by: Mark Brown -
As part of the multiplatform refactoring for AC'97 the AC'97 bus ops were
staticised meaning that the prototype (which was never needed) conflicts
with the declaration causing build failures.Signed-off-by: Mark Brown
Acked-by: Lars-Peter Clausen
29 Jul, 2013
1 commit
-
the return value of SNDRV_COMPRESS_VERSION always return default -ENOTTY as the
return value was never updated for this call
assign return value from put_user()Reported-by: Haynes
CC: stable@vger.kernel.org
Signed-off-by: Vinod Koul
Signed-off-by: Takashi Iwai
24 Jul, 2013
7 commits
-
The ALSA core expect the put callback of a control to return 1 if the value of
the control changed and 0 if it did not. Both snd_soc_dapm_put_volsw() and
snd_soc_dapm_put_enum_virt() currently always returns 0. For both functions we
already have a 'change' variable which either contains 1 or 0 depending on
whether the value has changed or not, so just return that.Signed-off-by: Lars-Peter Clausen
Signed-off-by: Mark Brown -
…nie/sound into for-linus
ASoC: Updates for v3.11
A few small updates again, the sgtl5000 one fixes some newly triggered
issues due to some probe ordering changes which were introduced in the
last merge window. -
Return SNDRV_PCM_POS_XRUN (snd_pcm_uframes_t) instead of
SNDRV_PCM_STATE_XRUN (snd_pcm_state_t) from the pointer
function of hiface, as expected by snd_pcm_update_hw_ptr0().Caught by sparse.
Cc: Antonio Ospite
Signed-off-by: Eldad Zack
Cc:
Signed-off-by: Takashi Iwai
22 Jul, 2013
2 commits
-
The errors were caused by copy/paste mistake in below commit
since v3.10:
3489d50 ASoC: tegra: Use common DAI DMA data structIt also corrects slave_id initialization in tegra20_ac97 driver.
Signed-off-by: Richard Zhao
Acked-by: Stephen Warren
Acked-by: Lucas Stach
Signed-off-by: Mark Brown
Cc: # 3.10 -
There are three callers for this function, and none of them want it to
free platform for them. It leads to a double free.Signed-off-by: Dan Carpenter
Signed-off-by: Mark Brown
21 Jul, 2013
1 commit
-
Return SNDRV_PCM_POS_XRUN (snd_pcm_uframes_t) instead of
SNDRV_PCM_STATE_XRUN (snd_pcm_state_t) from the pointer
function of 6fire, as expected by snd_pcm_update_hw_ptr0().Caught by sparse.
Signed-off-by: Eldad Zack
Cc:
Signed-off-by: Takashi Iwai