20 May, 2008
4 commits
-
The return value on writes to the plock device should be
the number of bytes written. It was returning 0 instead
when an nfs lock callback was involved.Reported-by: Nathan Straz
Signed-off-by: David Teigland -
Signed-off-by: Marcin Slusarz
Cc: Christine Caulfield
Cc: David Teigland
Cc: cluster-devel@redhat.com
Signed-off-by: David Teigland -
Removed the section mismatch message:
WARNING: fs/dlm/dlm.o(.init.text+0x132): Section mismatch in reference from the function init_module() to the function .exit.text:dlm_netlink_exit()Since dlm_netlink_exit() is called in the init_dlm() error handling,
the __exit annotation has been removed.Signed-off-by: Leonardo Potenza
Signed-off-by: David Teigland -
The semaphore connections_lock is used as a mutex. Convert it to the mutex
API.Signed-off-by: Matthias Kaehlcke
Cc: Christine Caulfield
Cc: David Teigland
Cc: Steven Whitehouse
Signed-off-by: Andrew Morton
Signed-off-by: David Teigland
30 Apr, 2008
1 commit
-
__FUNCTION__ is gcc-specific, use __func__
Signed-off-by: Harvey Harrison
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
23 Apr, 2008
1 commit
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm:
dlm: linux/{dlm,dlm_device}.h: cleanup for userspace
dlm: common max length definitions
dlm: move plock code from gfs2
dlm: recover nodes that are removed and re-added
dlm: save master info after failed no-queue request
dlm: make dlm_print_rsb() static
dlm: match signedness between dlm_config_info and cluster_set
22 Apr, 2008
6 commits
-
Add central definitions for max lockspace name length and max resource
name length. The lack of central definitions has resulted in scattered
private definitions which we can now clean up, including an unused one
in dlm_device.h.Signed-off-by: David Teigland
-
Move the code that handles cluster posix locks from gfs2 into the dlm
so that it can be used by both gfs2 and ocfs2.Signed-off-by: David Teigland
-
If a node is removed from a lockspace, and then added back before the
dlm is notified of the removal, the dlm will not detect the removal
and won't clear the old state from the node. This is fixed by using a
list of added nodes so the membership recovery can detect when a newly
added node is already in the member list.Signed-off-by: David Teigland
-
When a NOQUEUE request fails, the rsb res_master field is unnecessarily
reset to -1, instead of leaving the valid master setting in place. We
want to save the looked-up master values while the rsb is on the "toss
list" so that another lookup can be avoided if the rsb is soon reused.
The fix is to simply leave res_master value alone.Signed-off-by: David Teigland
-
dlm_print_rsb() can now become static.
Signed-off-by: Adrian Bunk
Signed-off-by: David Teigland -
cluster_set is only called from the macro CLUSTER_ATTR which defines read/write
access functions. Make the signedness match to avoid sparse warnings every time
CLUSTER_ATTR is used (lines 149-159) all of the form:fs/dlm/config.c:149:1: warning: incorrect type in argument 3 (different signedness)
fs/dlm/config.c:149:1: expected unsigned int *info_field
fs/dlm/config.c:149:1: got int extern [toplevel] *Signed-off-by: Harvey Harrison
Signed-off-by: David Teigland
19 Apr, 2008
1 commit
-
None of these files use any of the functionality promised by
asm/semaphore.h.Signed-off-by: Matthew Wilcox
22 Feb, 2008
1 commit
-
The recent patch to validate data lengths in rcom_names messages
failed to account for fake messages a node directs to itself before
ever sending it. In this case we need to fill in the message length
in the header for the validation code to use.Signed-off-by: David Teigland
07 Feb, 2008
2 commits
-
it moves 365 bytes from .text to .init.text, and 30 bytes from .text to
.exit.text, saves memory.Signed-off-by: Denis Cheng
Signed-off-by: David Teigland -
Put lkb_astparam in a union with a dlm_user_args pointer to
eliminate a lot of type casting.Signed-off-by: David Teigland
06 Feb, 2008
1 commit
-
Use proper types for ast and bast functions, and use
consistent type for ast param.Signed-off-by: David Teigland
04 Feb, 2008
13 commits
-
a) in device_write(): add sentinel NUL byte, making sure that lspace.name will
be NUL-terminated
b) in compat_input() be keep it simple about the amounts of data we are copying.Signed-off-by: Al Viro
Signed-off-by: David Teigland -
... those can happen and BUG() from DLM_ASSERT() in allocate_direntry() is
not a good way to handle them.Signed-off-by: Al Viro
Signed-off-by: David Teigland -
Signed-off-by: Al Viro
Signed-off-by: David Teigland -
We *can* get there from receive_request() and dlm_recover_master_copy()
with namelen too large if incoming request is invalid; BUG() from
DLM_ASSERT() in allocate_rsb() is a bit excessive reaction to that
and in case of dlm_recover_master_copy() we would actually oops before
that while calculating hash of up to 64Kb worth of data - with data
actually being 64 _bytes_ in kmalloc()'ed struct.Signed-off-by: Al Viro
Signed-off-by: David Teigland -
Signed-off-by: Al Viro
Signed-off-by: David Teigland -
Signed-off-by: Al Viro
Signed-off-by: David Teigland -
Signed-off-by: Al Viro
Signed-off-by: David Teigland -
Signed-off-by: Al Viro
Signed-off-by: David Teigland -
Signed-off-by: Al Viro
Signed-off-by: David Teigland -
Signed-off-by: Al Viro
Signed-off-by: David Teigland -
Signed-off-by: Al Viro
Signed-off-by: David Teigland -
* check that length is large enough to cover the non-variable part of message or
rcom resp. (after checking that it's large enough to cover the header, of
course).* kill more pointless casts
Signed-off-by: Al Viro
Signed-off-by: David Teigland -
a) don't cast the pointer to dlm_header *, we use it as dlm_message *
anyway.
b) we copy the message into a queue element, then pass the pointer to
copy to dlm_receive_message_saved(); declare it properly to make sure
that we have the right alignment.Signed-off-by: Al Viro
Signed-off-by: David Teigland
31 Jan, 2008
10 commits
-
also change name_prefix from char pointer to char array.
Signed-off-by: Denis Cheng
Signed-off-by: David Teigland -
A couple small clean-ups. Remove unnecessary wrapper-functions in
rcom.c, and remove unnecessary casting and an unnecessary ASSERT in
util.c.Signed-off-by: David Teigland
-
The 32/64 compatibility code in the DLM does not check the validity of
the lock name length passed into it, so it can easily overwrite memory
if the value is rubbish (as early versions of libdlm can cause with
unlock calls, it doesn't zero the field).This patch restricts the length of the name to the amount of data
actually passed into the call.Signed-off-by: Patrick Caulfield
Signed-off-by: David Teigland -
To prevent the master of an rsb from changing rapidly, an unused rsb is kept
on the "toss list" for a period of time to be reused. The toss list was
being cleared completely for each recovery, which is unnecessary. Much of
the benefit of the toss list can be maintained if nodes keep rsb's in their
toss list that they are the master of. These rsb's need to be included
when the resource directory is rebuilt during recovery.Signed-off-by: David Teigland
-
The invalid lockspace messages are normal and can appear relatively
often. They should be suppressed without debugging enabled.Signed-off-by: David Teigland
-
The dlm_put_lkb() can free the lkb and its associated ua structure,
so we can't depend on using the ua struct after the put.Signed-off-by: David Teigland
-
In a rare case we may need to repeat a local resource directory lookup
due to a race with removing the rsb and removing the resdir record.
We'll never need to do more than a single additional lookup, though,
so the infinite loop around the lookup can be removed. In addition
to being unnecessary, the infinite loop is dangerous since some other
unknown condition may appear causing the loop to never break.Signed-off-by: David Teigland
-
Non-forced unlocks should be rejected if the lock is waiting on the
rsb_lookup list for another lock to establish the master node.Signed-off-by: David Teigland
-
There was some hit and miss validation of messages that has now been
cleaned up and unified. Before processing a message, the new
validate_message() function checks that the lkb is the appropriate type,
process-copy or master-copy, and that the message is from the correct
nodeid for the the given lkb. Other checks and assertions on the
lkb type and nodeid have been removed. The assertions were particularly
bad since they would panic the machine instead of just ignoring the bad
message.Although other recent patches have made processing old message unlikely,
it still may be possible for an old message to be processed and caught
by these checks.Signed-off-by: David Teigland
-
Messages from nodes that are no longer members of the lockspace should be
ignored. When nodes are removed from the lockspace, recovery can
sometimes complete quickly enough that messages arrive from a removed node
after recovery has completed. When processed, these messages would often
cause an error message, and could in some cases change some state, causing
problems.Signed-off-by: David Teigland
