11 Jun, 2010
1 commit
-
bdi_seq is an atomic_long_t but we're using ATOMIC_INIT, which causes
build failures on ia64. This patch fixes it to use ATOMIC_LONG_INIT.Signed-off-by: Jeff Mahoney
Signed-off-by: Sage Weil
02 Jun, 2010
1 commit
-
We were setting f_namelen in kstatfs to PATH_MAX instead of NAME_MAX.
That disagrees with ceph_lookup behavior (which checks against NAME_MAX),
and also makes the pjd posix test suite spit out ugly errors because with
can't clean up its temporary files.Signed-off-by: Sage Weil
30 May, 2010
3 commits
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client:
ceph: clean up on forwarded aborted mds request
ceph: fix leak of osd authorizer
ceph: close out mds, osd connections before stopping auth
ceph: make lease code DN specific
fs/ceph: Use ERR_CAST
ceph: renew auth tickets before they expire
ceph: do not resend mon requests on auth ticket renewal
ceph: removed duplicated #includes
ceph: avoid possible null dereference
ceph: make mds requests killable, not interruptible
sched: add wait_for_completion_killable_timeout -
The auth module (part of the mon_client) is needed to free any
ceph_authorizer(s) used by the mds and osd connections. Flush the msgr
workqueue before stopping monc to ensure that the destroy_authorizer
auth op is available when those connections are closed out.Signed-off-by: Sage Weil
-
Use ERR_CAST(x) rather than ERR_PTR(PTR_ERR(x)). The former makes more
clear what is the purpose of the operation, which otherwise looks like a
no-op.In the case of fs/ceph/inode.c, ERR_CAST is not needed, because the type of
the returned value is the same as the type of the enclosing function.The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)//
@@
type T;
T x;
identifier f;
@@T f (...) { }
@@
expression x;
@@- ERR_PTR(PTR_ERR(x))
+ ERR_CAST(x)
//Signed-off-by: Julia Lawall
Signed-off-by: Sage Weil
24 May, 2010
1 commit
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client: (59 commits)
ceph: reuse mon subscribe message instead of allocated anew
ceph: avoid resending queued message to monitor
ceph: Storage class should be before const qualifier
ceph: all allocation functions should get gfp_mask
ceph: specify max_bytes on readdir replies
ceph: cleanup pool op strings
ceph: Use kzalloc
ceph: use common helper for aborted dir request invalidation
ceph: cope with out of order (unsafe after safe) mds reply
ceph: save peer feature bits in connection structure
ceph: resync headers with userland
ceph: use ceph. prefix for virtual xattrs
ceph: throw out dirty caps metadata, data on session teardown
ceph: attempt mds reconnect if mds closes our session
ceph: clean up send_mds_reconnect interface
ceph: wait for mds OPEN reply to indicate reconnect success
ceph: only send cap releases when mds is OPEN|HUNG
ceph: dicard cap releases on mds restart
ceph: make mon client statfs handling more generic
ceph: drop src address(es) from message header [new protocol feature]
...
22 May, 2010
1 commit
-
Signed-off-by: Al Viro
18 May, 2010
6 commits
-
Specify max bytes in request to bound size of reply. Add associated
mount option with default value of 512 KB.Signed-off-by: Sage Weil
-
The bdi_setup_and_register() helper doesn't help us since we bdi_init() in
create_client() and bdi_register() only when sget() succeeds.Signed-off-by: Sage Weil
-
Ensure all options are included in /proc/mounts. Some cleanup.
Signed-off-by: Sage Weil
-
Remove unused #include's in
fs/ceph/super.cSigned-off-by: Huang Weiyi
Signed-off-by: Sage Weil -
Signed-off-by: Yehuda Sadeh
-
ceph_sb_to_client and ceph_client are really identical, we need to dump
one; while function ceph_client is confusing with "struct ceph_client",
ceph_sb_to_client's definition is more clear; so we'd better switch all
call to ceph_sb_to_client.-static inline struct ceph_client *ceph_client(struct super_block *sb)
-{
- return sb->s_fs_info;
-}Signed-off-by: Cheng Renquan
Signed-off-by: Sage Weil
05 May, 2010
1 commit
-
Unregister and destroy the bdi in put_super, after mount is r/o, but before
put_anon_super releases the device name.For symmetry, bdi_destroy in destroy_client (we bdi_init in create_client).
Only set s_bdi if bdi_register succeeds, since we use it to decide whether
to bdi_unregister.Signed-off-by: Sage Weil
04 May, 2010
1 commit
-
Decouple the client version from the server side. Print relevant protocol
and map version info instead.Signed-off-by: Sage Weil
30 Mar, 2010
1 commit
-
…it slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
05 Mar, 2010
1 commit
-
This simplifies the process of timing out messages. We
keep lru of current messages that are in flight. If a
timeout has passed, we reset the osd connection, so that
messages will be retransmitted. This is a failsafe in case
we hit some sort of problem sending out message to the OSD.
Normally, we'll get notification via an updated osdmap if
there are problems.If a request is older than the keepalive timeout, send a
keepalive to ensure we detect any breaks in the TCP connection.Signed-off-by: Yehuda Sadeh
Signed-off-by: Sage Weil
18 Feb, 2010
1 commit
-
Use a global counter for the minimum number of allocated caps instead of
hard coding a check against readdir_max. This takes into account multiple
client instances, and avoids examining the superblock mount options when a
cap is dropped.Signed-off-by: Sage Weil
12 Feb, 2010
1 commit
-
Instead of removing osd connection immediately when the
requests list is empty, put the osd connection on an lru.
Only if that osd has not been used for more than a specified
time, will it be removed.Signed-off-by: Yehuda Sadeh
Signed-off-by: Sage Weil
11 Feb, 2010
1 commit
-
Add infrastructure to allow the mon_client to periodically renew its auth
credentials. Also add a messenger callback that will force such a renewal
if a peer rejects our authenticator.Signed-off-by: Yehuda Sadeh
Signed-off-by: Sage Weil
24 Dec, 2009
1 commit
-
Signed-off-by: Sage Weil
22 Dec, 2009
2 commits
-
Set bdi congestion bit when amount of write data in flight exceeds adjustable
threshold.Signed-off-by: Yehuda Sadeh
Signed-off-by: Sage Weil -
Also, print fsid using standard format, NOT hex dump.
Signed-off-by: Sage Weil
21 Nov, 2009
2 commits
-
Signed-off-by: Yehuda Sadeh
-
We may first learn our fsid from any of the mon, osd, or mds maps
(whichever the monitor sends first). Consolidate checks in a single
helper. Initialize the client debugfs entry then, since we need the
fsid (and global_id) for the directory name.Also remove dead mount code.
Signed-off-by: Sage Weil
19 Nov, 2009
3 commits
-
Signed-off-by: Sage Weil
-
When we open a monitor session, we send an initial AUTH message listing
the auth protocols we support, our entity name, and (possibly) a previously
assigned global_id. The monitor chooses a protocol and responds with an
initial message.Initially implement AUTH_NONE, a dummy protocol that provides no security,
but works within the new framework. It generates 'authorizers' that are
used when connecting to (mds, osd) services that simply state our entity
name and global_id.This is a wire protocol change.
Signed-off-by: Sage Weil
-
Unwind initializing if we get ENOMEM during client initialization.
Signed-off-by: Sage Weil
05 Nov, 2009
1 commit
-
Use the __le macro, even though for -1 it doesn't matter.
Signed-off-by: Sage Weil
03 Nov, 2009
1 commit
-
This keeps bdi setup/teardown in line with client life cycle.
Signed-off-by: Sage Weil
28 Oct, 2009
2 commits
-
This simplifies much of the error handling during mount. It also means
that we have the mount args before client creation, and we can initialize
based on those options.Signed-off-by: Sage Weil
-
Clearly demark int and string argument options, and do not try to convert
string arguments to ints.Signed-off-by: Sage Weil
27 Oct, 2009
2 commits
-
Signed-off-by: Sage Weil
-
Since we've increased the max mon count, we shouldn't put the addr array
on the parse_mount_args stack. Put it on the heap instead.Signed-off-by: Sage Weil
23 Oct, 2009
1 commit
-
Get rid of separate max mon limit; use the system limit instead. This
allows mounts when there are lots of mon addrs provided by mount.ceph (as
with a host with lots of A/AAAA records).Signed-off-by: Sage Weil
17 Oct, 2009
1 commit
-
Initialized bdi->ra_pages to enable readahead. Use 512KB default.
Signed-off-by: Sage Weil
15 Oct, 2009
1 commit
-
Writeback doesn't work without the bdi set, and writeback on
umount doesn't work if we unregister the bdi too early.Signed-off-by: Sage Weil
13 Oct, 2009
1 commit
-
Signed-off-by: Sage Weil
08 Oct, 2009
1 commit
-
Kill the old git revision; print the ceph version and protocol
versions instead.Signed-off-by: Sage Weil
07 Oct, 2009
1 commit
-
Mount option parsing, client setup and teardown, and a few odds and
ends (e.g., statfs).Signed-off-by: Sage Weil