28 May, 2010
1 commit
-
Signed-off-by: Christoph Hellwig
Signed-off-by: Al Viro
22 May, 2010
1 commit
-
Signed-off-by: Al Viro
21 May, 2010
1 commit
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (44 commits)
vlynq: make whole Kconfig-menu dependant on architecture
add descriptive comment for TIF_MEMDIE task flag declaration.
EEPROM: max6875: Header file cleanup
EEPROM: 93cx6: Header file cleanup
EEPROM: Header file cleanup
agp: use NULL instead of 0 when pointer is needed
rtc-v3020: make bitfield unsigned
PCI: make bitfield unsigned
jbd2: use NULL instead of 0 when pointer is needed
cciss: fix shadows sparse warning
doc: inode uses a mutex instead of a semaphore.
uml: i386: Avoid redefinition of NR_syscalls
fix "seperate" typos in comments
cocbalt_lcdfb: correct sections
doc: Change urls for sparse
Powerpc: wii: Fix typo in comment
i2o: cleanup some exit paths
Documentation/: it's -> its where appropriate
UML: Fix compiler warning due to missing task_struct declaration
UML: add kernel.h include to signal.c
...
18 May, 2010
1 commit
-
* git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs:
logfs: handle powerfail on NAND flash
logfs: handle errors from get_mtd_device()
logfs: remove unused variable
logfs: fix sync
logfs: fix compile failure
logfs: initialize li->li_refcount
logfs: commit reservations under space pressure
logfs: survive logfs_buf_recover read errors
logfs: Close i_ino reuse race
logfs: fix logfs_seek_hole()
logfs: Return -EINVAL if filesystem image doesn't match
LogFS: Fix typo in b6349ac8
logfs: testing the wrong variable
15 May, 2010
1 commit
-
iput() is needed *until* we'd done successful d_alloc_root()
Signed-off-by: Al Viro
10 May, 2010
1 commit
-
s/seperate/separate
Signed-off-by: Anand Gadiyar
Signed-off-by: Jiri Kosina
08 May, 2010
1 commit
-
The write buffer may not have been written and may no longer be written
due to an interrupted write in the affected page.Signed-off-by: Joern Engel
07 May, 2010
2 commits
-
The get_mtd_device() function returns error pointers on failure and if we
don't handle it, it leads to a crash.Signed-off-by: Dan Carpenter
Signed-off-by: Joern Engel -
Signed-off-by: Joern Engel
06 May, 2010
2 commits
-
Rather self-explanatory.
Signed-off-by: Joern Engel
-
When CONFIG_BLOCK is not enabled:
fs/logfs/super.c:142: error: implicit declaration of function 'bdev_get_queue'
fs/logfs/super.c:142: error: invalid type argument of '->' (have 'int')Found by Randy Dunlap
Signed-off-by: Joern Engel
05 May, 2010
3 commits
-
li_refcount was not re-initialized in function logfs_init_inode(), small
patch that will fix the problemSigned-off-by: Prasad Joshi
Signed-off-by: Joern Engel -
Ensures we only return -ENOSPC when there really is no space.
Signed-off-by: Joern Engel
-
Refusing to mount beats a kernel crash.
Signed-off-by: Joern Engel
02 May, 2010
3 commits
-
logfs_seek_hole() may return the same offset it is passed as argument.
Found by Prasad JoshiSigned-off-by: Joern Engel
-
logfs_seek_hole(inode, 0x200) would crap itself if the inode contained
just 0x1ff (or fewer) blocks.Signed-off-by: Joern Engel
-
Signed-off-by: Joern Engel
29 Apr, 2010
2 commits
-
Signed-off-by: Joern Engel
-
There is a typo here. We should test "last" instead of "first".
Signed-off-by: Dan Carpenter
Signed-off-by: Joern Engel
22 Apr, 2010
1 commit
-
* git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs:
[LogFS] Split large truncated into smaller chunks
[LogFS] Set s_bdi
[LogFS] Prevent mempool_destroy NULL pointer dereference
[LogFS] Move assertion
[LogFS] Plug 8 byte information leak
[LogFS] Prevent memory corruption on large deletes
[LogFS] Remove unused methodFix trivial conflict with added header includes in fs/logfs/super.c
21 Apr, 2010
1 commit
-
Truncate would do an almost limitless amount of work without invoking
the garbage collector in between. Split it up into more manageable,
though still large, chunks.Signed-off-by: Joern Engel
18 Apr, 2010
1 commit
-
Since 32a88aa1 sync() was turned into a NOP for logfs. Worse, sync()
would not return an error, giving the illusion that writeout had
actually happened.Afaics jffs2 was broken as well.
Signed-off-by: Joern Engel
15 Apr, 2010
1 commit
-
It would probably be better to just accept NULL pointers in
mempool_destroy(). But for the current -rc series let's keep things
simple.This patch was lost in the cracks for a while.
Kevin Cernekee had to rediscover the problem and
send a similar patch because of it. :(Signed-off-by: Joern Engel
13 Apr, 2010
3 commits
-
The assertion is valid independently of the condition.
Signed-off-by: Joern Engel
-
Within each journal segment, 8 bytes at offset 24 would remain
uninitialized.Signed-off-by: Joern Engel
-
Removing sufficiently large files would create aliases for a large
number of segments. This in turn results in a large number of journal
entries and an overflow of s_je_array.Cheap fix is to add a BUG_ON, turning memory corruption into something
annoying, but less dangerous. Real fix is to count the number of
affected segments and prevent the problem completely.Signed-off-by: Joern Engel
05 Apr, 2010
1 commit
31 Mar, 2010
1 commit
-
All callers are long gone.
Signed-off-by: Joern Engel
30 Mar, 2010
3 commits
-
…it slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com> -
If the device contains on old logfs image and the journal is moved to
segment that have never been used by the current logfs and not all
journal segments are erased before the next mount, the old content can
confuse mount code. To prevent this, always erase the new journal
segments.Signed-off-by: Joern Engel
-
Fixes a GC livelock.
Signed-off-by: Joern Engel
29 Mar, 2010
1 commit
-
do_logfs_journal_wl_pass() must call freeseg(), thereby clear
PagePrivate on all pages of the current journal segment.Signed-off-by: Joern Engel
28 Mar, 2010
2 commits
-
A comment in the old code read:
/* The math in this function can surely use some love */And indeed it did. In the case that area->a_used_bytes is exactly
4096 bytes below segment size it fell apart. pad_wbuf is now split
into two helpers that are significantly less complicated.Signed-off-by: Joern Engel
-
The comment was correct, so make the code match the comment. As the
new comment indicates, we might be able to do a little less work. But
for the current -rc series let's keep it simple and just fix the bug.Signed-off-by: Joern Engel
27 Mar, 2010
6 commits
-
Found by Al Viro.
Signed-off-by: Joern Engel
-
rootdir was already allocated, so we must iput it again.
Found by Al Viro.Signed-off-by: Joern Engel
-
If the first superblock is wrong and the second gets written, there
will still be a mismatch on next mount. Write both to make sure they
match.Signed-off-by: Joern Engel
-
Apparently filldir can sleep, which forbids kmap_atomic.
Signed-off-by: Joern Engel
-
Signed-off-by: Joern Engel
-
Intel SSDs have a limit of 0xffff as queue_max_hw_sectors(q). Such a
limit may make sense from a hardware pov, but it causes bio_alloc() to
return NULL.Signed-off-by: Joern Engel