28 Jul, 2006
1 commit
-
Signed-off-by: Dave Kleikamp
27 Jul, 2006
1 commit
-
jfs_quota_read/write are very near duplicates of ext2_quota_read/write.
Cleaned up jfs_get_block as long as I had to change it to be non-static.
Signed-off-by: Dave Kleikamp
26 Jul, 2006
9 commits
-
This fixes three drivers to compile again after my patch that removes
the data_cmnd member from struct scsi_cmnd.The fas216 change is trivial, it should have been using ->cmnd all the
time.NCR53C9 (which seem to be mostly duplicate driver with esp.c!) is doing
something odd, it should only have looked at ->cmnd before not the saved
copy that is kept for the error handlers sake. Note that it really
should deal with the sync setting themselves but use the generic domain
validation code that get this right - but that's for later let's push
this simple compile fix for now.And sorry for the late fix for this, I have been busy with OLS and
associated activities last week.Signed-off-by: Christoph Hellwig
Signed-off-by: Linus Torvalds -
* master.kernel.org:/pub/scm/linux/kernel/git/davem/sparc-2.6:
[SCSI] esp: Fix build.
[SPARC]: Fix SA_STATIC_ALLOC value.
[SPARC64]: Explicitly print return PC when the kernel fault PC is bogus. -
* master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6:
[IPV4/IPV6]: Setting 0 for unused port field in RAW IP recvmsg().
[IPV4] ipmr: ip multicast route bug fix.
[TG3]: Update version and reldate
[TG3]: Handle tg3_init_rings() failures
[TG3]: Add tg3_restart_hw()
[IPV4]: Clear the whole IPCB, this clears also IPCB(skb)->flags.
[IPV6]: Clean skb cb on IPv6 input.
[NETFILTER]: Demote xt_sctp to EXPERIMENTAL
[NETFILTER]: bridge netfilter: add deferred output hooks to feature-removal-schedule
[NETFILTER]: xt_pkttype: fix mismatches on locally generated packets
[NETFILTER]: SNMP NAT: fix byteorder confusion
[NETFILTER]: conntrack: fix SYSCTL=n compile
[NETFILTER]: nf_queue: handle NF_STOP and unknown verdicts in nf_reinject
[NETFILTER]: H.323 helper: fix possible NULL-ptr dereference -
The patch below moves the cpu hotplugging higher up in the cpufreq
layering; this is needed to avoid recursive taking of the cpu hotplug
lock and to otherwise detangle the mess.The new rules are:
1. you must do lock_cpu_hotplug() around the following functions:
__cpufreq_driver_target
__cpufreq_governor (for CPUFREQ_GOV_LIMITS operation only)
__cpufreq_set_policy
2. governer methods (.governer) must NOT take the lock_cpu_hotplug()
lock in any way; they are called with the lock taken already
3. if your governer spawns a thread that does things, like calling
__cpufreq_driver_target, your thread must honor rule #1.
4. the policy lock and other cpufreq internal locks nest within
the lock_cpu_hotplug() lock.I'm not entirely happy about how the __cpufreq_governor rule ended up
(conditional locking rule depending on the argument) but basically all
callers pass this as a constant so it's not too horrible.The patch also removes the cpufreq_governor() function since during the
locking audit it turned out to be entirely unused (so no need to fix it)The patch works on my testbox, but it could use more testing
(otoh... it can't be much worse than the current code)Signed-off-by: Arjan van de Ven
Signed-off-by: Linus Torvalds -
From: Tetsuo Handa from-linux-kernel@i-love.sakura.ne.jp
The recvmsg() for raw socket seems to return random u16 value
from the kernel stack memory since port field is not initialized.
But I'm not sure this patch is correct.
Does raw socket return any information stored in port field?[ BSD defines RAW IP recvmsg to return a sin_port value of zero.
This is described in Steven's TCP/IP Illustrated Volume 2 on
page 1055, which is discussing the BSD rip_input() implementation. ]Acked-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller -
IP multicast route code was reusing an skb which causes use after free
and double free.From: Alexey Kuznetsov
Note, it is real skb_clone(), not alloc_skb(). Equeued skb contains
the whole half-prepared netlink message plus room for the rest.
It could be also skb_copy(), if we want to be puristic about mangling
cloned data, but original copy is really not going to be used.Acked-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Update version to 3.63.
Signed-off-by: Michael Chan
Signed-off-by: David S. Miller -
Handle dev_alloc_skb() failures when initializing the RX rings.
Without proper handling, the driver will crash when using a partial
ring.Thanks to Stephane Doyon for reporting the bug and
providing the initial patch.Howie Xu also reported the same issue.
Signed-off-by: Michael Chan
Signed-off-by: David S. Miller -
Add tg3_restart_hw() to handle failures when re-initializing the
device.Signed-off-by: Michael Chan
Signed-off-by: David S. Miller
25 Jul, 2006
29 commits
-
The CIC_SEEKY() test really wants to use the minimum of either:
- 2 msecs (not jiffies)
- or, the pending slice time
So code it like that.
Signed-off-by: Jens Axboe
-
It should be toggling the same bit on and off, fix it up.
Signed-off-by: Jens Axboe
-
We need to postpone the queue startup until after the softirq
handler has actually finished some requests, otherwise we could
be racing with cciss_softirq_done() and not actually restart
the queue handling.Signed-off-by: Jens Axboe
-
Signed-off-by: Guillaume Chazarain
Signed-off-by: David S. Miller -
Clear the accumulated junk in IP6CB when starting to handle an IPV6
packet.Signed-off-by: Guillaume Chazarain
Signed-off-by: David S. Miller -
After the recent problems with all the SCTP stuff it seems reasonable
to mark this as experimental.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Add bridge netfilter deferred output hooks to feature-removal-schedule
and disable them by default. Until their removal they will be
activated by the physdev match when needed.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Locally generated broadcast and multicast packets have pkttype set to
PACKET_LOOPBACK instead of PACKET_BROADCAST or PACKET_MULTICAST. This
causes the pkttype match to fail to match packets of either type.The below patch remedies this by using the daddr as a hint as to
broadcast|multicast. While not pretty, this seems like the only way
to solve the problem short of just noting this as a limitation of the
match.This resolves netfilter bugzilla #484
Signed-off-by: Phil Oester
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Signed-off-by: Adrian Bunk
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
In case of an unknown verdict or NF_STOP the packet leaks. Unknown verdicts
can happen when userspace is buggy. Reinject the packet in case of NF_STOP,
drop on unknown verdicts.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
An RCF message containing a timeout results in a NULL-ptr dereference if
no RRQ has been seen before.Noticed by the "SATURN tool", reported by Thomas Dillig
and Isil Dillig .Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
The data_cmd[] member got deleted, so do not use it any more. Scsi
commands do not have their ->cmd[] overwritten temporary to probe for
status after an error before retrying.Signed-off-by: David S. Miller
-
It alises IRQF_SHARED which causes all kinds of
problems.Signed-off-by: David S. Miller
-
That way we'll have at least some debugging info even if
the stack dump explodes.Signed-off-by: David S. Miller
-
dev_alloc_skb is designated for RX descriptors, not TX. (Some drivers
use it for the latter anyway, but that's a different story)Signed-off-by: Christoph Hellwig
Signed-off-by: David S. Miller -
skbuff.h has an #ifndef CONFIG_HAVE_ARCH_DEV_ALLOC_SKB to allow
architectures to reimplement __dev_alloc_skb. It's not set on any
architecture and now that we have an architecture-overrideable
NET_SKB_PAD there is not point at all to have one either.Signed-off-by: Christoph Hellwig
Signed-off-by: David S. Miller -
When the queue of the underlying device is stopped at initialization time
or the device is marked "not present", the state will be propagated to the
vlan device and never change. Based on an analysis by Patrick McHardy.Signed-off-by: Stefan Rompf
ACKed-by: Patrick McHardy
Signed-off-by: David S. Miller -
It doesn't compile, and it's dubious in several regards:
1) is enabled by non-Kconfig controlled CONFIG_* value
(noted by Randy Dunlap)
2) XFRM6_TUNNEL_SPI_MAGIC is defined after it's first use
3) the debugging messages print object pointer addresses
which have no meaning without contextSo let's just get rid of it.
Signed-off-by: David S. Miller
-
The Broadcom dongles with HID proxy support actually support SCO over
HCI if the SCO buffer size values are corrected. So instead of disabling
the SCO support, mark this dongle with the quirk for the Bluetooth core
to correct the wrong buffer size values.Signed-off-by: Marcel Holtmann
-
This patch disables the ISOC transfers for another broken RTX Telecom
based USB dongle. Starting the USB ISOC transfers only ends in a burst
of error messages for invalid SCO packets on connection handle 0.Signed-off-by: Marcel Holtmann
-
The Belkin F8T012 and F8T013 devices are both based on a Bluetooth chip
from Broadcom and their SCO buffer size values are wrong. The Bluetooth
core should correct these values.Signed-off-by: Marcel Holtmann
-
The SCO buffer size values on IBM/Lenovo ThinkPad laptops with a
Bluetooth chip from Broadcom are wrong. The USB Bluetooth driver
has to set a quirk to correct the SCO buffer size values.Signed-off-by: Marcel Holtmann
-
Some Bluetooth RFCOMM implementations try to negotiate a bigger channel
MTU than we can support for a particular session. The maximum MTU for
a RFCOMM session is limited through the L2CAP layer. So if the other
side proposes a channel MTU that is bigger than the underlying L2CAP
MTU, we should reduce it to the L2CAP MTU of the session minus five
bytes for the RFCOMM headers.Signed-off-by: Marcel Holtmann
-
In PSCHED_TADD and PSCHED_TADD2, if delta is less than tv.tv_usec (so,
less than USEC_PER_SEC too) then tv_res will be smaller than tv. The
affectation "(tv_res).tv_usec = __delta;" is wrong. The fix is to
revert to the original code before
4ee303dfeac6451b402e3d8512723d3a0f861857 and change the 'if' in
'while'.[Shuya MAEDA: "while (__delta >= USEC_PER_SEC){ ... }" instead of
"while (__delta > USEC_PER_SEC){ ... }"]Signed-off-by: Guillaume Chazarain
Signed-off-by: David S. Miller -
When using the default sequence window size (100) I got the following in
my logs:Jun 22 14:24:09 localhost kernel: [ 1492.114775] DCCP: Step 6 failed for
DATA packet, (LSWL(6279674225)
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Read the max_cmds value from the response to the QUERY_FW command
before printing out the value, so that the real value goes into the
debug output.Signed-off-by: Roland Dreier
-
The neighbour ha field may get updated without destroying the
neighbour. In this case, the ha field gets out of sync with the
address handle stored in ipoib_neigh->ah, with the result that
the ah field would point to an incorrect path, resulting in all
packets being lost.Signed-off-by: Michael S. Tsirkin
Signed-off-by: Roland Dreier -
Need to set mcast->ah before debug code dereferences it.
Signed-off-by: Or Gerlitz
Signed-off-by: Roland Dreier
