Eric Lee / smarc-fsl-linux-kernel

12 Apr, 2008

3 commits

31 Mar, 2008

4 commits

29 Mar, 2008

27 commits

  • af8be4e4b   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6 ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6:
    [PATCH] mnt_expire is protected by namespace_sem, no need for vfsmount_lock
    [PATCH] do shrink_submounts() for all fs types
    [PATCH] sanitize locking in mark_mounts_for_expiry() and shrink_submounts()
    [PATCH] count ghost references to vfsmounts
    [PATCH] reduce stack footprint in namespace.c

    Linus Torvalds
     
  • d478376cb   driver core: fix small mem leak in driver_add_kobj() ... Browse Code »

    The Coverity checker spotted that we leak the storage allocated to 'name' in
    int driver_add_kobj(). The leak looks legit to me - this is the code :

    int driver_add_kobj(struct device_driver *drv, struct kobject *kobj,
    const char *fmt, ...)
    {
    va_list args;
    char *name;
    int ret;

    va_start(args, fmt);
    name = kvasprintf(GFP_KERNEL, fmt, args);
    ^^^^^^^^ This dynamically allocates space...

    va_end(args);

    if (!name)
    return -ENOMEM;

    return kobject_add(kobj, &drv->p->kobj, "%s", name);
    ^^^^^^^^ This neglects to free the space allocated
    }

    Inside kobject_add() a copy of 'name' will be made and used. As far as I can
    see, Coverity is correct in flagging this as a leak, but I'd like some
    configmation before the patch is applied.

    This should fix it.

    Signed-off-by: Jesper Juhl
    Cc: Greg KH
    Cc: Kay Sievers
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     
  • 4cdc1d1fa   dm io: write error bits form long not int ... Browse Code »

    write_err is an unsigned long used with set_bit() so should not be passed
    around as unsigned int.

    http://bugzilla.kernel.org/show_bug.cgi?id=10271

    Signed-off-by: Alasdair G Kergon
    Cc: Heiko Carstens
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alasdair G Kergon
     
  • d250dad64   memstick: suppress uninitialized-var warning ... Browse Code »

    drivers/memstick/host/tifm_ms.c: In function 'tifm_ms_data_event':
    drivers/memstick/host/tifm_ms.c:185: warning: 'p_off' may be used uninitialized in this function

    Cc: Alex Dubov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • 4a5691c0f   mtd: maps/physmap: fix oops in suspend/resume/shutdown ops ... Browse Code »

    # reboot
    ...
    [ 42.351266] Flash device refused suspend due to active operation (state 0)
    [ 42.358195] Unable to handle kernel NULL pointer dereference at virtual address 00000078
    [ 42.360060] pgd = c7d9c000
    [ 42.362769] [00000078] *pgd=a7d8d031, *pte=00000000, *ppte=00000000
    [ 42.372902] Internal error: Oops: 17 [#1]
    [ 42.376911] Modules linked in:
    [ 42.379980] CPU: 0 Not tainted (2.6.25-rc2-10642-ge8f2594-dirty #73)
    [ 42.380000] PC is at physmap_flash_shutdown+0x28/0x54
    ...
    [ 42.380000] Backtrace:
    [ 42.380000] [] (physmap_flash_shutdown+0x0/0x54) from [] (platform_drv_shutdown+0x20/0x24)
    [ 42.380000] r5:28121969 r4:c0229e08
    [ 42.380000] [] (platform_drv_shutdown+0x0/0x24) from [] (device_shutdown+0x60/0x88)
    [ 42.380000] [] (device_shutdown+0x0/0x88) from [] (kernel_restart_prepare+0x2c/0x3c)
    [ 42.380000] r4:00000000
    [ 42.380000] [] (kernel_restart_prepare+0x0/0x3c) from [] (kernel_restart+0x14/0x48)
    [ 42.380000] [] (kernel_restart+0x0/0x48) from [] (sys_reboot+0xe8/0x1f8)
    [ 42.380000] r4:01234567
    [ 42.380000] [] (sys_reboot+0x0/0x1f8) from [] (ret_fast_syscall+0x0/0x2c)
    [ 42.380000] r7:00000058 r6:00000004 r5:00000001 r4:00000000
    [ 42.380000] Code: 0a000009 e7953004 e1a00003 e1a0e00f (e593f078)
    [ 42.650051] ---[ end trace 6d6c26a0fc3141de ]---
    Segmentation fault
    INIT: no more processes left in this runlevel

    While looping for mtd[i]s, we should stop at the mtd[i] == NULL.

    This patch also removes unnecessary "if (info)" checks:
    suspend/resume/shutdown ops are executed only if probe() is succeeded, so info
    is guaranteed to be !NULL.

    Signed-off-by: Anton Vorontsov
    Cc: David Brownell
    Cc: David Woodhouse
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Anton Vorontsov
     
  • 3f1e9070f   dm crypt: fix ctx pending ... Browse Code »

    Fix regression in dm-crypt introduced in commit
    3a7f6c990ad04e6f576a159876c602d14d6f7fef ("dm crypt: use async crypto").

    If write requests need to be split into pieces, the code must not process them
    in parallel because the crypto context cannot be shared. So there can be
    parallel crypto operations on one part of the write, but only one write bio
    can be processed at a time.

    This is not optimal and the workqueue code needs to be optimized for parallel
    processing, but for now it solves the problem without affecting the
    performance of synchronous crypto operation (most of current dm-crypt users).

    http://bugzilla.kernel.org/show_bug.cgi?id=10242
    http://bugzilla.kernel.org/show_bug.cgi?id=10207

    Signed-off-by: Milan Broz
    Signed-off-by: Alasdair G Kergon
    Cc: "Rafael J. Wysocki"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Milan Broz
     
  • ab473a525   kprobes: another MAINTAINERS update ... Browse Code »

    Prasanna has taken a new job. Update the MAINTAINERS file

    Signed-off-by: Ananth N Mavinakayanahalli
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ananth N Mavinakayanahalli
     
  • 363df3994   blackfin video driver: fix bug when opening/reading/mmaping BF54x and BF52x fram… ... Browse Code »

    …ebuffer simultaneously

    http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=3974

    opening/reading/mmaping BF54x and BF52x framebuffer simultaneously triggers
    BUG: failure at mm/nommu.c:470/add_nommu_vma() Add VM_SHARED to the default
    vm_flags

    Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
    Signed-off-by: Bryan Wu <cooloney@kernel.org>
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    Cc: "Antonino A. Daplas" <adaplas@pol.net>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

    Michael Hennerich
     
  • 7ef9861c7   blackfin video driver: update the BF52x EZKIT video framebuffer driver according to LKML review ... Browse Code »

    - Allocate pseudo_palette together with fbinfo
    - Code cleanup

    Signed-off-by: Michael Hennerich
    Signed-off-by: Bryan Wu
    Cc: Geert Uytterhoeven
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bryan Wu
     
  • a99acc832   pci: revert SMBus unhide on HP Compaq nx6110 ... Browse Code »

    This reverts commit 3c0a654e390d00fef9d8faed758f5e1e8078adb5 and
    fixes kernel bug #10245:

    http://bugzilla.kernel.org/show_bug.cgi?id=10245

    The HP Compaq nc6120 has the same PCI sub-device ID as the nx6110, and the
    SMBus is used by ACPI for thermal management on the nc6120, so Linux should
    not attach a native driver to it. This means that this quirk is unsafe and
    has to be removed.

    I also added a comment to help developers realize that adding new IDs to this
    SMBus unhiding quirk table should be done only with great care, and in
    particular only after checking that ACPI is not making use of the SMBus.

    Signed-off-by: Jean Delvare
    Cc: Tomasz Koprowski
    Acked-by: Greg Kroah-Hartman
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jean Delvare
     
  • 5ac7ec85b   ext3: don't export ext3_fs.h and jbd.h ... Browse Code »

    Neither of the headers actually compiles when included from userpsace nor
    should it be made available as userspace tools should be using the libraries
    or at least headers from e2fsprogs.

    Signed-off-by: Christoph Hellwig
    Acked-by: "Theodore Ts'o"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     
  • 3afe39259   kernel: add bit rotation helpers for 16 and 8 bit ... Browse Code »

    Will replace open-coded variants elsewhere. Done in the same
    style as the 32-bit versions.

    Signed-off-by: Harvey Harrison
    Acked-by: Randy Dunlap
    Cc: Johannes Berg
    Cc: John W. Linville
    Cc: Joe Perches
    Cc: Jiri Benc
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     
  • 589499c04   ixp4xx-beeper: add MODULE_ALIAS ... Browse Code »

    The following patch allows ixp4xx-beeper to be loaded by udev
    automatically when compiled as a module with kernel versions 2.4.24 and
    greater.

    This patch is required because 43cc71eed1250755986da4c0f9898f9a635cb3bf
    ("platform: prefix MODALIAS with "platform:"") changed the modalias
    string to have the extra prefix.

    LKG7102D7:~# udevinfo -a -p /sys/devices/platform/ixp4xx-beeper.4

    looking at device '/devices/platform/ixp4xx-beeper.4':
    KERNEL=="ixp4xx-beeper.4"
    SUBSYSTEM=="platform"
    DRIVER==""
    ATTR{modalias}=="platform:ixp4xx-beeper"

    udev therefore tries to modprobe platform:ixp4xx-beeper instead of
    ixp4xx-beeper.

    LKG7102D7:~# udevtest /sys/devices/platform/ixp4xx-beeper.4
    ...
    import_uevent_var: import into environment: 'PHYSDEVBUS=platform'
    import_uevent_var: import into environment: 'MODALIAS=platform:ixp4xx-beeper'
    main: looking at device '/devices/platform/ixp4xx-beeper.4' from
    subsystem 'platform'
    wait_for_sysfs: file '/sys/devices/platform/ixp4xx-beeper.4/bus'
    appeared after 0 loops
    main: run: 'socket:/org/kernel/udev/monitor'
    main: run: '/sbin/modprobe --use-blacklist platform:ixp4xx-beeper'

    With this patch, depmod adds an alias line (see below) to
    modules.alias which allows modprobe to load the right module.

    alias platform:ixp4xx-beeper ixp4xx-beeper

    Signed-off-by: Gordon Farquharson
    Signed-off-by: Alessandro Zummo
    Cc: Kay Sievers
    Cc: David Brownell
    Cc: Atsushi Nemoto
    Cc: Greg Kroah-Hartman
    Cc: Dmitry Torokhov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alessandro Zummo
     
  • 773647a09   update checkpatch.pl to version 0.16 ... Browse Code »

    This version brings proper quote tracking across lines, and brings the
    handling of comments into the same mechanism ensuring nesting is correctly
    handled. It brings the usual flurry of fixes for false positives. It also
    brings a number of new checks. The most contentious change will likely be
    the checks for NR_CPUS as this throws some new warnings in kernel/sched.c.

    Of note:
    - all new quote tracking across lines
    - all new comment tracking
    - new more direct, less ambigious wording for some warnings
    - recommends mutexes and completions over semaphores
    - recommends strict_strto* over simple_strto*
    - report on direct use of NR_CPUS

    Andy Whitcroft (22):
    Version: 0.16
    string quote tracking should cross line boundaries
    check spacing round -> correctly across newlines
    checks for linux/ against asm/ include files should be warnings
    standardise on 'required' and 'prohibited'
    take the first end of condition when parsing statements
    values: cope with unbalanced brackets
    preprocessor #elif is not a function
    preprocessor #if should not trigger trailing statement checks
    test: allow us to limit output to a single error
    recommend real mutexes over semaphores
    asm checks should mirror those for __asm__
    warn on semaphores being used in place of completions
    trailing ; on control structure should ignore do {} while ();
    recommend strict_strtoX over simple_strtoX
    redo comment handling as a quote type
    use of NR_CPUS is normally wrong
    consistant spacing should only be about spaces
    if brace check suppression should only apply to the top-levels
    use tr/// to align spacing for operators
    move to using four parameter form of substr
    check and report modifications to include/asm

    Signed-off-by: Andy Whitcroft
    Cc: Ingo Molnar
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • 3387b804d   net/9p/trans_fd.c:p9_trans_fd_init(): module_init functions should return 0 on success ... Browse Code »

    Mar 23 09:06:31 opensuse103 kernel: Installing 9P2000 support
    Mar 23 09:06:31 opensuse103 kernel: sys_init_module: '9pnet_fd'->init suspiciously returned 1, it should follow 0/-E convention
    Mar 23 09:06:31 opensuse103 kernel: sys_init_module: loading module anyway...
    Mar 23 09:06:31 opensuse103 kernel: Pid: 5323, comm: modprobe Not tainted 2.6.25-rc6-git7-default #1
    Mar 23 09:06:31 opensuse103 kernel: [] sys_init_module+0x172b/0x17c9
    Mar 23 09:06:31 opensuse103 kernel: [] sys_mmap2+0x62/0x77
    Mar 23 09:06:31 opensuse103 kernel: [] sysenter_past_esp+0x6d/0xa9
    Mar 23 09:06:31 opensuse103 kernel: =======================

    Cc: Latchesar Ionkov
    Cc: Eric Van Hensbergen
    Cc: David S. Miller
    Cc: "Rafael J. Wysocki"
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • f706d5d22   audit: silence two kerneldoc warnings in kernel/audit.c ... Browse Code »

    Silence two kerneldoc warnings.

    Warning(kernel/audit.c:1276): No description found for parameter 'string'
    Warning(kernel/audit.c:1276): No description found for parameter 'len'

    [also fix a typo for bonus points]

    Signed-off-by: Dave Jones
    Acked-by: Randy Dunlap
    Cc: Al Viro
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dave Jones
     
  • 5214b729e   afs: prevent double cell registration ... Browse Code »

    kafs doesn't check if the cell already exists - so if you do an echo "add
    newcell.org 1.2.3.4" >/proc/fs/afs/cells it will try to create this cell
    again. kobject will also complain about a double registration. To prevent
    such problems, return -EEXIST in that case.

    Signed-off-by: Sven Schnelle
    Signed-off-by: David Howells
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sven Schnelle
     
  • fac533c25   afs: add a MAINTAINERS record for AFS ... Browse Code »

    Add a MAINTAINERS record for AFS.

    Signed-off-by: David Howells
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Howells
     
  • 5b41e74ad   vfs: fix data leak in nobh_write_end() ... Browse Code »

    Current nobh_write_end() implementation ignore partial writes(copied < len)
    case if page was fully mapped and simply mark page as Uptodate, which is
    totally wrong because area [pos+copied, pos+len) wasn't updated explicitly in
    previous write_begin call. It simply contains garbage from pagecache and
    result in data leakage.

    #TEST_CASE_BEGIN:
    ~~~~~~~~~~~~~~~~
    In fact issue triggered by classical testcase
    open("/mnt/test", O_RDWR|O_CREAT|O_TRUNC, 0666) = 3
    ftruncate(3, 409600) = 0
    writev(3, [{"a", 1}, {NULL, 4095}], 2) = 1
    ##TESTCASE_SOURCE:
    ~~~~~~~~~~~~~~~~~
    #include
    #include
    #include
    #include
    #include
    #include
    int main(int argc, char **argv)
    {
    int fd, ret;
    void* p;
    struct iovec iov[2];
    fd = open(argv[1], O_RDWR|O_CREAT|O_TRUNC, 0666);
    ftruncate(fd, 409600);
    iov[0].iov_base="a";
    iov[0].iov_len=1;
    iov[1].iov_base=NULL;
    iov[1].iov_len=4096;
    ret = writev(fd, iov, sizeof(iov)/sizeof(struct iovec));
    printf("writev = %d, err = %d\n", ret, errno);
    return 0;
    }
    ##TESTCASE RESULT:
    ~~~~~~~~~~~~~~~~~~
    [root@ts63 ~]# mount | grep mnt2
    /dev/mapper/test on /mnt2 type ext2 (rw,nobh)
    [root@ts63 ~]# /tmp/writev /mnt2/test
    writev = 1, err = 0
    [root@ts63 ~]# hexdump -C /mnt2/test

    00000000 61 65 62 6f 6f 74 00 00 f0 b9 b4 59 3a 00 00 00 |aeboot.....Y:...|
    00000010 20 00 00 00 00 00 00 00 21 00 00 00 00 00 00 00 | .......!.......|
    00000020 df df df df df df df df df df df df df df df df |................|
    00000030 3a 00 00 00 2a 00 00 00 21 00 00 00 00 00 00 00 |:...*...!.......|
    00000040 60 c0 8c 00 00 00 00 00 40 4a 8d 00 00 00 00 00 |`.......@J......|
    00000050 00 00 00 00 00 00 00 00 41 00 00 00 00 00 00 00 |........A.......|
    00000060 74 69 6d 65 20 64 64 20 69 66 3d 2f 64 65 76 2f |time dd if=/dev/|
    00000070 6c 6f 6f 70 30 20 20 6f 66 3d 2f 64 65 76 2f 6e |loop0 of=/dev/n|
    skip..
    00000f50 00 00 00 00 00 00 00 00 31 00 00 00 00 00 00 00 |........1.......|
    00000f60 6d 6b 66 73 2e 65 78 74 33 20 2f 64 65 76 2f 76 |mkfs.ext3 /dev/v|
    00000f70 7a 76 67 2f 74 65 73 74 20 2d 62 34 30 39 36 00 |zvg/test -b4096.|
    00000f80 a0 fe 8c 00 00 00 00 00 21 00 00 00 00 00 00 00 |........!.......|
    00000f90 23 31 32 30 35 39 35 30 34 30 34 00 3a 00 00 00 |#1205950404.:...|
    00000fa0 20 00 8d 00 00 00 00 00 21 00 00 00 00 00 00 00 | .......!.......|
    00000fb0 d0 cf 8c 00 00 00 00 00 10 d0 8c 00 00 00 00 00 |................|
    00000fc0 00 00 00 00 00 00 00 00 41 00 00 00 00 00 00 00 |........A.......|
    00000fd0 6d 6f 75 6e 74 20 2f 64 65 76 2f 76 7a 76 67 2f |mount /dev/vzvg/|
    00000fe0 74 65 73 74 20 20 2f 76 7a 20 2d 6f 20 64 61 74 |test /vz -o dat|
    00000ff0 61 3d 77 72 69 74 65 62 61 63 6b 00 00 00 00 00 |a=writeback.....|
    00001000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|

    As you can see file's page contains garbage from pagecache instead of zeros.
    #TEST_CASE_END

    Attached patch:
    - Add sanity check BUG_ON in order to prevent incorrect usage by caller,
    This is function invariant because page can has buffers and in no zero
    *fadata pointer at the same time.
    - Always attach buffers to page is it is partial write case.
    - Always switch back to generic_write_end if page has buffers.
    This is reasonable because if page already has buffer then generic_write_begin
    was called previously.

    Signed-off-by: Dmitri Monakhov
    Reviewed-by: Nick Piggin
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dmitri Monakhov
     
  • 1d4a788f1   memcgroup: fix spurious EBUSY on memory cgroup removal ... Browse Code »

    Call mm_free_cgroup earlier. Otherwise a reference due to lazy mm switching
    can prevent cgroup removal.

    Signed-off-by: YAMAMOTO Takashi
    Acked-by: Balbir Singh
    Cc: KAMEZAWA Hiroyuki
    Cc: Paul Menage
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    YAMAMOTO Takashi
     
  • 8c703d35f   in_atomic(): document why it is unsuitable for general use ... Browse Code »

    Discourage people from inappropriately using in_atomic()

    Signed-off-by: Jonathan Corbet
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jonathan Corbet
     
  • f67e74ca6   drivers/char/drm/ati_pcigart.c: fix printk warning ... Browse Code »

    drivers/char/drm/ati_pcigart.c: In function 'drm_ati_pcigart_init':
    drivers/char/drm/ati_pcigart.c:125: warning: format '%08X' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'

    Cc: Dave Airlie
    Cc: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • 6f5afaed5   mtd: nand: add out label in rfc_from4 ... Browse Code »

    This has been forgotten in commit f5bbdacc419 ("[MTD] NAND Modularize
    read function") and nobody compiled the driver.

    Signed-off-by: Sebastian Siewior
    Cc: Thomas Gleixner
    Cc: David Woodhouse
    Cc: Joern Engel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sebastian Siewior
     
  • 9c312058b   Avoid false positive warnings in kmap_atomic_prot() with DEBUG_HIGHMEM ... Browse Code »

    I believe http://bugzilla.kernel.org/show_bug.cgi?id=10318 is a false
    positive. There's no way in which networking will be using highmem pages
    here, so it won't be taking the KM_USER0 kmap slot, so there's no point in
    performing these checks.

    Cc: Pawel Staszewski
    Cc: Ingo Molnar
    Acked-by: Christoph Lameter
    Cc: "David S. Miller"
    Signed-off-by: Andrew Morton
    [ Really sad. We lose almost all real-life coverage of the debug tests
    with this patch. Now it will only report problems for the cases where
    people actually end up using a HIGHMEM page, not when they just _might_
    use one. - Linus ]
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • 1f71f5034   RDMA/cxgb3: Program hardware IRD with correct value ... Browse Code »

    Because of a typo in iwch_accept_cr(), the cxgb3 connection handling
    code programs the hardware IRD (incoming RDMA read queue depth) with
    the value that is passed in for the ORD (outgoing RDMA read queue
    depth). In particular this means that if an application passes in IRD
    > 0 and ORD = 0 (which is a completely sane and valid thing to do for
    an app that expects only incoming RDMA read requests), then the
    hardware will end up programmed with IRD = 0 and the app will fail in
    a mysterious way.

    Fix this by using "ep->ird" instead of "ep->ord" in the intended place.

    Signed-off-by: Roland Dreier
    Acked-by: Steve Wise
    Signed-off-by: Linus Torvalds

    Roland Dreier
     
  • 8c178beeb   Merge branch 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc ... Browse Code »

    * 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc:
    [POWERPC] Fix missed hardware breakpoints across multiple threads

    Linus Torvalds
     
  • 48d3d8263   revert "ACPI: drivers/acpi: elide a non-zero test on a result that is never 0" ... Browse Code »

    Revert commit 1192aeb957402b45f311895f124e4ca41206843c ("ACPI:
    drivers/acpi: elide a non-zero test on a result that is never 0")
    because it turns out that thermal_cooling_device_register() does
    actually return NULL if CONFIG_THERMAL is turned off (then the routine
    turns into a dummy inline routine in the header files that returns NULL
    unconditionally).

    This was found with randconfig testing, causing a crash during bootup:

    initcall 0x78878534 ran for 13 msecs: acpi_button_init+0x0/0x51()
    Calling initcall 0x78878585: acpi_fan_init+0x0/0x2c()
    BUG: unable to handle kernel NULL pointer dereference at 00000000
    IP: [] acpi_fan_add+0x7d/0xfd
    *pde = 00000000
    Oops: 0000 [#1]
    Modules linked in:

    Pid: 1, comm: swapper Not tainted (2.6.25-rc7-sched-devel.git-x86-latest.git #14)
    EIP: 0060:[] EFLAGS: 00010246 CPU: 0
    EIP is at acpi_fan_add+0x7d/0xfd
    EAX: b787c718 EBX: b787c400 ECX: b782ceb4 EDX: 00000007
    ESI: 00000000 EDI: b787c6f4 EBP: b782cee0 ESP: b782cecc
    DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068
    Process swapper (pid: 1, ti=b782c000 task=b7846000 task.ti=b782c000)
    Stack: b787c459 00000000 b787c400 78790888 b787c60c b782cef8 782b6fb8 ffffffda
    b787c60c 00000000 78790958 b782cf0c 783005d7 b787c60c 78790958 78790584
    b782cf1c 783007f6 b782cf28 00000000 b782cf40 782ffc4a 78790958 b794d558
    Call Trace:
    [] ? acpi_device_probe+0x3e/0xdb
    [] ? driver_probe_device+0x82/0xfc
    [] ? __driver_attach+0x3a/0x70
    [] ? bus_for_each_dev+0x3e/0x60
    [] ? driver_attach+0x14/0x16
    [] ? __driver_attach+0x0/0x70
    [] ? bus_add_driver+0x9d/0x1b0
    [] ? driver_register+0x47/0xa3
    [] ? timespec_to_ktime+0x9/0xc
    [] ? acpi_bus_register_driver+0x3a/0x3c
    [] ? acpi_fan_init+0xd/0x2c
    [] ? kernel_init+0xac/0x1f9
    [] ? kernel_init+0x0/0x1f9
    [] ? kernel_thread_helper+0x7/0x10
    =======================
    Code: 6e 78 e8 57 44 e7 ff 58 e9 93 00 00 00 8b 55 f0 8d bb f4 02 00 00 80 4b 2d 10 8b 03 e8 87 cb ff ff 8d 83 18 03 00 00 80 63 2d ef 35 00 00 00 00 50 68 e8 9c 6e 78 e8 22 44 e7 ff b9 b6 9c 6e
    EIP: [] acpi_fan_add+0x7d/0xfd SS:ESP 0068:b782cecc
    ---[ end trace 778e504de7e3b1e3 ]---
    Kernel panic - not syncing: Attempted to kill init!

    Signed-off-by: Ingo Molnar
    Acked-by: Julia Lawall
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     

28 Mar, 2008

6 commits