23 Feb, 2010

18 commits


21 Feb, 2010

1 commit


20 Feb, 2010

12 commits

  • Signed-off-by: Ajit Khaparde
    Signed-off-by: David S. Miller

    Ajit Khaparde
     
  • Signed-off-by: Ajit Khaparde
    Signed-off-by: David S. Miller

    Ajit Khaparde
     
  • For certain skews of the BE adapter, H/W Tx and Rx
    counters could be common for more than one interface.
    Add Tx and Rx counters in the adapter structure
    (to maintain stats on a per interfae basis).

    Signed-off-by: Ajit Khaparde
    Signed-off-by: David S. Miller

    Ajit Khaparde
     
  • Signed-off-by: Ajit Khaparde
    Signed-off-by: David S. Miller

    Ajit Khaparde
     
  • Currently use of 64-bit DMA is disabled in r8169 unless the user passes the
    use_dac module option. This is reasonable for conventional PCI devices where
    broken chipsets may not handle dual-address-cycle transfers properly for
    32-bit slots and so this may not be safe. However, PCI Express should not have
    this problem and not using 64-bit DMA results in DMA transfers needlessly using
    the IOMMU or SWIOTLB. Set the use_dac module parameter to a new default value of
    -1 which results in 64-bit DMA being enabled by default for PCI Express devices
    only.

    Signed-off-by: Robert Hancock
    Signed-off-by: David S. Miller

    Robert Hancock
     
  • There are only two users of the dma_sync_single_range_for_cpu/device
    API in mainline (mlx4 and ssb). The
    dma_sync_single_range_for_cpu/device API has never been documented and
    the dma_sync_single_for_cpu/device API also support a partial sync.

    This converts mlx4 to use the dma_sync_single_for_cpu/device API
    (preparations for the removal of the dma_sync_single_range_for_cpu/device API).

    Signed-off-by: FUJITA Tomonori
    Signed-off-by: David S. Miller

    FUJITA Tomonori
     
  • On Fri, Feb 19, 2010 at 13:51 +0100, Jiri Pirko wrote:
    >
    >
    > >>@@ -1031,7 +1029,7 @@ static void greth_set_multicast_list(struct net_device *dev)
    > >> return;
    > >> }
    > >>
    > >>- if (dev->mc_count == 0) {
    > >>+ if (!netdev_mc_count(dev)) {
    > also please use netdev_mc_empty() here.
    Some driver cleanups:
    * convert to use phy_find_first/phy_direct_connect
    * convert to use netdev_mc_* helpers
    * fixed missing validate_addr hook
    * removed netdev_priv castings

    Signed-off-by: Denis Kirjanov
    Reviewed-by: Jiri Pirko
    Signed-off-by: David S. Miller

    kirjanov@gmail.com
     
  • removed fill_multicast_tbl function in smc91c92_cs and do the work inline

    rewritten set_addresses function in xirc2ps_cs. This was kinda headache.
    Simulated the original and new functions and they bahave the same.

    Signed-off-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Jiri Pirko
     
  • To see the effect make sure you have an empty SPD.
    On window1 "ip xfrm mon" and on window2 issue "ip xfrm policy flush"
    You get prompt back in window2 and you see the flush event on window1.
    With this fix, you still get prompt on window1 but no event on window2.

    Thanks to Alexey Dobriyan for finding a bug in earlier version
    when using pfkey to do the flushing.

    Signed-off-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    Jamal Hadi Salim
     
  • To see the effect make sure you have an empty SAD.
    On window1 "ip xfrm mon" and on window2 issue "ip xfrm state flush"
    You get prompt back in window2 and you see the flush event on window1.
    With this fix, you still get prompt on window1 but no event on window2.

    Thanks to Alexey Dobriyan for finding a bug in earlier version
    when using pfkey to do the flushing.

    Signed-off-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    Jamal Hadi Salim
     
  • RFC 2367 says flushing behavior should be:
    1) user space -> kernel: flush
    2) kernel: flush
    3) kernel -> user space: flush event to ALL listeners

    This is not realistic today in the presence of selinux policies
    which may reject the flush etc. So we make the sequence become:
    1) user space -> kernel: flush
    2) kernel: flush
    3) kernel -> user space: flush response to originater from #1
    4) if there were no errors then:
    kernel -> user space: flush event to ALL listeners

    Signed-off-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    Jamal Hadi Salim
     
  • David S. Miller
     

19 Feb, 2010

9 commits

  • commit 3bc38712e3a6e059 (handle NF_STOP and unknown verdicts in
    nf_reinject) was a partial fix to packet leaks.

    If user asks NF_STOLEN status, we must free the skb as well.

    Reported-by: Afi Gjermund
    Signed-off-by: Eric DUmazet
    Signed-off-by: Patrick McHardy

    Eric Dumazet
     
  • This patch fixes a bug that triggers an assertion if you create
    a conntrack entry with a helper and netfilter debugging is enabled.
    Basically, we hit the assertion because the confirmation flag is
    set before the conntrack extensions are added. To fix this, we
    move the extension addition before the aforementioned flag is
    set.

    This patch also removes the possibility of setting a helper for
    existing conntracks. This operation would also trigger the
    assertion since we are not allowed to add new extensions for
    existing conntracks. We know noone that could benefit from
    this operation sanely.

    Thanks to Eric Dumazet for initial posting a preliminary patch
    to address this issue.

    Reported-by: David Ramblewski
    Signed-off-by: Pablo Neira Ayuso
    Signed-off-by: Eric Dumazet
    Signed-off-by: Patrick McHardy

    Pablo Neira Ayuso
     
  • Reported by Stephen Rothwell.

    Signed-off-by: David S. Miller

    David S. Miller
     
  • Commit 2249065 ("netfilter: get rid of the grossness in netfilter.h")
    inverted the logic for conditional hook invocation, breaking the
    POST_ROUTING hook invoked by ip_output().

    Correct the logic and remove an unnecessary initialization.

    Reported-by: Stephen Hemminger
    Signed-off-by: Patrick McHardy

    Patrick McHardy
     
  • Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
    Remove #define PFX
    Use pr_
    Use netdev_
    Use netif_ and netif_msg_
    Remove local #define net_ macros
    Remove periods from formats

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     
  • Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
    Remove #define PFX
    Use pr_
    Use netdev_
    Remove periods from most formats
    Coalesce long formats
    Use printk_once

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     
  • Due to lack of time, space, motivation, hardware and probably expertise,
    I have reluctantly decided to orphan the DECnet code in the kernel.

    Judging by the deafening silence on the linux-decnet mailing list I
    suspect it's either not being used anyway, or the few people that are
    using it are happy with their older kernels.

    Signed-Off-By: Christine Caulfield

    Signed-off-by: David S. Miller

    Chrissie Caulfield
     
  • be2net: free tx buffers when completions never arrive

    In cases like when a pci device is disconnected on an error,
    pending tx completions will never arrive. Unmap and free such
    buffers in the tx cleanup path.

    Signed-off-by: Sathya Perla
    Signed-off-by: David S. Miller

    Sathya Perla
     
  • XFRMINHDRERROR counter is ambigous when validating forwarding
    path. It makes it tricky to debug when you have both in and fwd
    validation.

    Signed-off-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    jamal