22 Nov, 2012
1 commit
-
This is required by NAND flash driver for initializing wait counters.
Signed-off-by: Rafał Miłecki
Signed-off-by: Artem Bityutskiy
21 Nov, 2012
8 commits
-
Use ll to be able to remove the casts.
Signed-off-by: Jonas Gorski
Reviewed-by: Florian Fainelli
Signed-off-by: Artem Bityutskiy -
The line belongs above the comment, not below it.
Signed-off-by: Jonas Gorski
Reviewed-by: Florian Fainelli
Signed-off-by: Artem Bityutskiy -
The CFE does not use 4K sectors even if the flash supports it, so
for the fixed partitions like CFE itself or NVRAM the erase block
size is always 64k or bigger.Signed-off-by: Jonas Gorski
Reviewed-by: Florian Fainelli
Signed-off-by: Artem Bityutskiy -
The length of the spare part is calculated the same way in both branches
so move to a common place.Signed-off-by: Jonas Gorski
Reviewed-by: Florian Fainelli
Signed-off-by: Artem Bityutskiy -
namelen is never used, so drop it.
Signed-off-by: Jonas Gorski
Reviewed-by: Florian Fainelli
Signed-off-by: Artem Bityutskiy -
Signed-off-by: Luka Perkov
Signed-off-by: Artem Bityutskiy -
By replacing a kthread with a workqueue, the code is now a bit clearer.
There's also a slight reduction of code size (numbers apply for x86):
Before:
text data bss dec hex filename
3248 36 0 3284 cd4 drivers/mtd/mtd_blkdevs.oAfter:
text data bss dec hex filename
3150 36 0 3186 c72 drivers/mtd/mtd_blkdevs.oDue to lack of real hardware, tests have been performed on an emulated
environment with mtdswap and mtdblock over nandsim devices.
Some real testing should be done, before merging this patch.Signed-off-by: Ezequiel Garcia
Signed-off-by: Artem Bityutskiy -
struct mtd_blktrans_ops is a type, and mtd_blktrans_ops is a variable.
To improve code clarity it's better to not use the same names,
so we just change the latter.Signed-off-by: Ezequiel Garcia
Signed-off-by: Artem Bityutskiy
18 Nov, 2012
4 commits
-
Correct spelling typo in printk within drivers/mtd/tests.
Signed-off-by: Masanari Iida
Signed-off-by: Artem Bityutskiy -
When we scan several nand chips with nand_scan(), such as
.......................
nand_scan(*, 2);
.......................In nand_scan_ident(), the maxchips will become 2, so the current code
will select chip 1 to read the device ID. But the chip 0 is still
selected in this case.To make the logic clear, we'd better de-select the chip when it is not used.
This patch de-select the nand chip if it is not used any more.
Signed-off-by: Huang Shijie
Signed-off-by: Artem Bityutskiy -
'set' is tested for NULL. But subsequently accessed without the check.
Thus making it conditional to avoid NULL pointer dereferencing.Signed-off-by: Sachin Kamat
Signed-off-by: Artem Bityutskiy -
Users of jffs2_do_reserve_space() expect they still held
erase_completion_lock after call to it. But there is a path
where jffs2_do_reserve_space() leaves erase_completion_lock unlocked.
The patch fixes it.Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
Cc: stable@vger.kernel.org
Signed-off-by: Artem Bityutskiy
16 Nov, 2012
9 commits
-
linux,mtd-name allow to specify the mtd name for retro capability with
physmap-flash drivers as boot loader pass the mtd partition via the old
device name physmap-flash.Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Artem Bityutskiy -
IFC_FIR_OP_CMD0 issues command for execution without checking flash
readiness. It may cause problem if flash is not ready. Instead use
IFC_FIR_OP_CW0 which Wait for tWB time and poll R/B to return high or
time-out, before issuing command.NAND_CMD_READID command implemention does not fulfill above requirement. So
update its programming.Signed-off-by: Prabhakar Kushwaha
Signed-off-by: Hemant Nautiyal
Signed-off-by: Artem Bityutskiy -
The map_word_load() function initializes exactly
as many words in the buffer as required, but gcc
cannot figure this out and gives a misleading
warning. Marking the local variable as
uninitialized_var shuts up that warning.Without this patch, building acs5k_defconfig results in:
drivers/mtd/chips/cfi_cmdset_0002.c: In function 'cfi_amdstd_panic_write':
include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wuninitialized]
drivers/mtd/chips/cfi_cmdset_0002.c: In function 'cfi_amdstd_write_words':
include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wuninitialized]
drivers/mtd/chips/cfi_cmdset_0001.c: In function 'cfi_intelext_write_words':
include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wuninitialized]Signed-off-by: Arnd Bergmann
Signed-off-by: Artem Bityutskiy -
The diskonchip drivers traditionally use home-grown macros for
doing MMIO accesses, which cause a lot of warnings, at least
on ARM machines:drivers/mtd/devices/doc2000.c: In function 'doc_write':
drivers/mtd/devices/doc2000.c:854:5: warning: value computed is not used [-Wunused-value]
drivers/mtd/devices/doc2000.c: In function 'doc_erase':
drivers/mtd/devices/doc2000.c:1123:5: warning: value computed is not used [-Wunused-value
drivers/mtd/nand/diskonchip.c: In function 'doc2000_read_byte':
drivers/mtd/nand/diskonchip.c:318:3: warning: value computed is not used [-Wunused-value]A nicer solution is to use the architecture-defined I/O accessors.
Here, we use the __raw_readl/__raw_writel style, instead of the
proper readl/writel ones, in order to preserve the odd semantics
of the existing macros that have their own barrier implementation
and no byte swap. It would be nice to fix this properly and use
the correct accessors as well as make the word size independent
from the architecture, but I guess the hardware is obsolete
enough that we should better not mess the driver an more than
necessary.Signed-off-by: Arnd Bergmann
Signed-off-by: Artem Bityutskiy -
Enabling the diskonchip drivers on most architectures results
in a pointless warning "#warning Unknown architecture for
DiskOnChip. No default probe locations defined". The driver
can in fact handle the default location already through the
CONFIG_MTD_DOCPROBE_ADDRESS, which gets set on the platforms
that need it, and we get a run-time error if this is not
set correctly.Signed-off-by: Arnd Bergmann
Signed-off-by: Artem Bityutskiy -
This patch allow to detect buggy driver/hardware with
bad RnB (dev_ready) management or when timeout occurs in polling mode.This works when dev_ready is set or not set.
There are 2 methods to wait for an erase/program command completion:1. Wait until nand RnB pin goes high (that's what chip->dev_ready usually does)
2. Poll the device: send a status (0x70) command and read status byte in a loop
until bit NAND_STATUS_READY is setIn all cases, you should send a status command after completion, to check if
the operation was successful. And if the operation completed, the status should
have bit NAND_STATUS_READY set.Signed-off-by: Matthieu CASTET
Signed-off-by: Artem Bityutskiy -
Enhance the driver to support partition subnodes inside the nand
device bindings to describe partions on the nand device.Signed-off-by: Murali Karicheri
Reviewed-by: Grant Likely
Signed-off-by: Artem Bityutskiy -
When the kernel parses the following cmdline
#mtdparts=gpmi-nand:16m(boot),16m(kernel),1g(home),4g(test),-(usr)
for a big nand chip Micron MT29F64G08AFAAAWP(8GB), we got the following wrong
result:.............................................
"mtd: partition size too small (0)"
.............................................We can not get any partition.
The "4g(test)" partition triggers a overflow of the "size". The memparse()
returns 4g to the "size", but the size is "unsigned long" type, so a overflow
occurs, the "size" becomes zero in the end.This patch changes the "size"/"offset" to "unsigned long long" type,
and replaces the UINT_MAX with ULLONG_MAX for macros SIZE_REMAINING and
OFFSET_CONTINUOUS.Signed-off-by: Huang Shijie
Signed-off-by: Artem Bityutskiy -
This patch is an attempt to fix following compilation warning.
In file included from drivers/mtd/chips/cfi_cmdset_0001.c:35:0:
drivers/mtd/chips/cfi_cmdset_0001.c: In function 'cfi_intelext_write_words':
include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wmaybe-uninitialized]I could have used uninitialized_var() too, but didn't used it as the final else
part of map_word_load() is missing. So there is a chance that it might be passed
uninitialized. Better initialize to zero.Signed-off-by: Viresh Kumar
Signed-off-by: Artem Bityutskiy
15 Nov, 2012
18 commits
-
Add missing colons to fix kernel-doc generation warnings.
Signed-off-by: Robert P. J. Day
Signed-off-by: Artem Bityutskiy -
The current version on mtdoops erase first block of mtdoops partition at each
boot if there is no oops stored in flash. This can wear the flash.When mtdoops start, find_next_position is called to find the next free entry in
the circular buffer. But if the flash is erased, find_next_position don't find
anything (maxcount == 0xffffffff) and start with the first entry after erasing it.The scanning that is done in find_next_position already track free/used entries.
So if at the end of the scanning we don't find anything, we can start at the
first entry and erased the entry only if it is marked as used.
Most of this is implemented in mtdoops_inc_counter, so to avoid duplicating
code, if we don't find anything we set position to -1. mtdoops_inc_counter with
increment it, erase the entry if needed and start as before with nextpage = 0
and nextcount = 1).Also during the scan phase, we use the MTDOOPS_KERNMSG_MAGIC to detect corruped
entries.Signed-off-by: Matthieu Castet
Signed-off-by: Artem Bityutskiy -
The flctl can now be probed via device tree setup in addition to the
existing platform data way.SoC specific setup data is set in the .data member of the OF match, so
kept within the driver itself, while board/user specific setup - like
partitioning - is taken from the device tree.Actual configuration is added for the SoC sh7372.
Signed-off-by: Bastian Hecht
Signed-off-by: Artem Bityutskiy -
The code probes if DMA channels can get allocated and tears them down at
removal/failure if needed.
If available it uses them to transfer the data part (not ECC). On
failure we fall back to PIO mode.Based on Guennadi Liakhovetski's code from the sh_mmcif driver.
Signed-off-by: Bastian Hecht
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Artem Bityutskiy -
Some small fixes to avoid sparse and smatch complain. Other cosmetic fixes
as well.- Change of the type of the member index in struct sh_flctl from signed
to unsigned. We use index by addressing array members, so unsigned is more
concise here. Adapt functions relying on sh_flctl::index.
- Remove a blurring cast in write_fiforeg().
- Apply consistent naming scheme when refering to the data buffer.
- Shorten some unnecessarily verbose functions.
- Remove spaces at start of lines.Signed-off-by: Bastian Hecht
Signed-off-by: Artem Bityutskiy -
The whole gpmi-nand driver has turned to pure devicetree supported.
So the linux/mtd/gpmi-nand.h is not neccessary now. Just remove it,
and move some macros to the gpmi-nand driver itself.Signed-off-by: Huang Shijie
Signed-off-by: Artem Bityutskiy -
In some configurations of "gpio-nand" RDY-pin may be not connected.
This patch allow to use driver for these configurations. In this case
we are assume that device always ready.Signed-off-by: Alexander Shiyan
Signed-off-by: Artem Bityutskiy -
Use the NAND_STATUS_FAIL to replace the hardcode "0x01",
which make the code more readable.Signed-off-by: Huang Shijie
Acked-by: Brian Norris
Signed-off-by: Artem Bityutskiy -
Use pr_info() and pr_err() while defining pr_fmt(). This saves a few
characters, joins a few lines, and makes the code a little more readable
(and grep-able).Signed-off-by: Brian Norris
Signed-off-by: Vikram Narayanan
Signed-off-by: Artem Bityutskiy -
Use pr_fmt instead of PRINT_PREF macro
Signed-off-by: Vikram Narayanan
Signed-off-by: Artem Bityutskiy -
Use pr_fmt instead of PRINT_PREF macro
Signed-off-by: Vikram Narayanan
Signed-off-by: Artem Bityutskiy -
Use pr_fmt instead of PRINT_PREF macro
Signed-off-by: Vikram Narayanan
Signed-off-by: Artem Bityutskiy -
Use pr_fmt instead of PRINT_PREF macro
Signed-off-by: Vikram Narayanan
Signed-off-by: Artem Bityutskiy -
Use pr_fmt instead of PRINT_PREF macro
Signed-off-by: Vikram Narayanan
Signed-off-by: Artem Bityutskiy -
Use pr_fmt instead of PRINT_PREF macro
Signed-off-by: Vikram Narayanan
Signed-off-by: Artem Bityutskiy -
Use KBUILD_MODNAME instead of hardcoding the filename
Signed-off-by: Vikram Narayanan
Signed-off-by: Artem Bityutskiy -
Use pr_fmt instead of msg macro
Signed-off-by: Vikram Narayanan
Signed-off-by: Artem Bityutskiy -
This patch removes some code duplication by using
module_platform_driver.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Artem Bityutskiy
