06 Dec, 2018
2 commits
-
In TDM mode with Daisy Chain enabled (CPLD mode 0x04) DAC1 and DAC2
AK4458 codecs on audio board are able to play 16 channels, so extend
the TDM mode constraint to 16 channels.Signed-off-by: Viorel Suman
(cherry picked from commit bc8b6a74175c2d120383875b00b5a2a44def9dd0) -
Enable Daisy Chain if in TDM mode and the number of played
channels is bigger than the maximum supported number of channels.Signed-off-by: Viorel Suman
(cherry picked from commit 5ae97f159bfd9c4a37e7e60cd20aa3437041b251)
28 Nov, 2018
1 commit
-
We enable the ASRC clocks from CPU side. We only need
the following clocks: "mem", "ipg" and "asrc0..3".Signed-off-by: Daniel Baluta
Reviewed-by: Shengjiu Wang
(cherry picked from commit 586297d7d5855cf75e25f629ca495b8ac5c1bb96)
23 Nov, 2018
7 commits
-
Change source and header License comment to SPDX format.
Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta
(cherry picked from commit 6d17e38a8d8cd3eab3015988a6f24cf64ec0d1df) -
When CONFIG_PM is not defined, the runtime suspend and resume
are unused so we should use __maybe_unused attribute.Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta
(cherry picked from commit b2285d1937872b5023074644d0a8f7c9a2e3158a) -
It is error prone to use soc_enum array for controls because introducing
new controls must always be done at the end of array or it will add
offset to existing controls.Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta
(cherry picked from commit 409e235cb0e3fbf48251375e040d7f37b2734be2) -
The patch enable mapping the number of pins required to play or record
a specific number of channels to a specific dataline mask.Three consequent elements in "fsl,dataline" and "fsl,dataline,dsd" defines a
particular mapping, for instance for: fsl,dataline = "0 0xff 0xff 2 0x11 0x11"
there are two mappings defined:default (0 pins) "rx" and "tx" dataline masks: 0 0xff 0xff
2 pins "rx" and "tx" dataline masks: 2 0x11 0x11In case if property is missing, then default value "0 0x1 0x1" is considered.
Signed-off-by: Viorel Suman
(cherry picked from commit 707fdf7759c0e11abf84573eb60bba104d681736) -
If the FMT of tx and rx is different, there will be issue. for example
tx is working at TDM mode, but rx want to work at I2S mode, this case
is not supported in current ALSA driver, the best way to support this
is to distinguish substream in set_fmt function.Signed-off-by: Shengjiu Wang
(cherry picked from commit 897e9e8b4e7a59d81048d05f9377b8c68fc7cd64) -
TDM mode can only work with codec slave mode, and the mclk
frequency should be 256FS.Signed-off-by: Shengjiu Wang
(cherry picked from commit 769121ead6ef8919b7f6869defe594be978d82cd) -
add more rates in constraint list, Fixes commit ee959e2c9b18
("MLK-19581-3: ASoC: fsl_rpmsg_i2s: support multipul rate and DSD format")Signed-off-by: Shengjiu Wang
(cherry picked from commit bcc6185a392b46d2b5af315894b06e6ebaff8046)
15 Nov, 2018
1 commit
-
The rpmsg wm8960 codec driver is completed to support
full function, not only the volume control. which cause
an issue that there is no sound when recording, the reason
is that the MIC Bias not enabled, and it should be enabled
through audio routing.Signed-off-by: Shengjiu Wang
14 Nov, 2018
8 commits
-
Remove paranthesis that are not needed.
Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta -
Remove unused commented code.
Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta -
Fix checkpatch error by removin extra empty rows.
Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta -
Braces {} are not necessary for single statement blocks.
Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta -
In order to upstream the micfil driver, we need to fix
missing space after if errors and warnings reported
by checkpatch.Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta -
In order to upstream the micfil driver, we need to fix
line over 80 characters errors and warnings reported
by checkpatch.Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta -
In order to upstream the micfil driver, we need to fix allignment
and code indent errors and warnings reported by checkpatch.Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta -
strtab is always non-null so remove unnecessary check.
This is a follow up of patch
167a6d79f ("ASoC: fsl: Skip checking for string section type")
and finally fixes CID3901026Reviewed-by: Shengjiu Wang
Signed-off-by: Daniel Baluta
13 Nov, 2018
7 commits
-
In the case where lo_vag
Signed-off-by: Mark Brown -
Remove the dead code.
This fixes Coverity issue: CID1529915
Signed-off-by: Viorel Suman
-
Both dataline_off and dataline_off_dsd fields are unsigned,
thus checking negative values make no sense. Use a signed
variable to calculate offset instead.This fixes Coverity issue: CID1899299
Signed-off-by: Viorel Suman
-
Save error so that the following error checking now make sense.
This fixes Coverity issue: CID2828734
Signed-off-by: Viorel Suman
-
When hwvad is enabled, if you try to re-enable it again, it should fail.
However, we were also double setting state to OFF on fail, which is
wrong because it resets the state and allows the second retry to enable
even if it wasn't disabled before.
Now we only return EBUSY.Reviewed-by: Daniel Baluta
Signed-off-by: Cosmin-Gabriel Samoila -
An unsigned value can never be negative, so this test will always
evaluate the same way.Fixes Coverity issue CID3618200
Reviewed-by: Viorel Suman
Signed-off-by: Cosmin-Gabriel Samoila -
There may be a null pointer dereference, or else the comparison against
null is unnecessary.Fixes Coverity issue CID5327850
Reviewed-by: Viorel Suman
Reviewed-by: Daniel Baluta
Signed-off-by: Cosmin-Gabriel Samoila
09 Nov, 2018
10 commits
-
e_shstrndx already contains the section header index, so
shdr->sh_type will always be SHT_STRTAB.Remove this redundant check and make Coverity happy.
Fixes: CID3901026
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta -
xf_cmd_send_recv returns with lock taken if waiting was
interrupted by a signal.This fixes Coverity issues: CID5233120 / CID5233060
Reviewed-by: S.j. Wang
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta -
Bail out if kernel_read returns an error.
Fixes: CID1477415
Reviewed-by: S.j. Wang
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta -
At this point err is always 0. So, just remove the check.
Fixes: CID1477380
Reviewed-by: S.j. Wang
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta -
Return value is not used so better use atomic_dec.
This also silences coverity warning CID3344689.Reviewed-by: S.j. Wang
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta -
xf_cmd_recv will return with lock taken in two cases:
* msg was received
* waiting for msg was interrupted by a signalMake sure we unlock proxy->lock in both cases.
This fixes Coverity issue: CID3335482.
Reviewed-by: S.j. Wang
Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta -
The reason is same as commit d4eb8ab26399 ("MLK-19854-1: ASoC:
imx-cs42888: fix error when m4 image is not loaded")Signed-off-by: Shengjiu Wang
-
In LPA mode, the system will be resumed by audio notification, when the
period size is small, there will be occasion that when notification
the underrun is happen, but the substream runtime state is not running
so the aplay won't trigger stop first, then start. just only trigger
the start, which don't comply with the convention.
So in this patch, we change the substream runtime state to running, when
the notification happened at resume.Signed-off-by: Shengjiu Wang
-
For the LPA mode, when the system enter suspend, the M4 will
continue to play the data, but for normal ALSA case, the digital
mute should be called at suspend, so the codec will be mute,
which conflict with the requirement of LPA.Signed-off-by: Shengjiu Wang
-
With the case that underrun happened, the aplay will trigger
stop and start, if the period index is not reset at stop, the
counter of period will be wrongSigned-off-by: Shengjiu Wang
08 Nov, 2018
1 commit
-
Enable and disable procedures contain info and warn prints. This
introduces delay in initialization / disablement procedures and we have
kept only the necessary prints in case of error.Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Shengjiu Wang
03 Nov, 2018
3 commits
-
Update SCFW API to the following commit:
"
("430d1e3646fbe75e339e18abf2330565eac906e0")
Author: Chuck Cannon
Date: Fri Nov 2 15:25:45 2018 -0500SCF-105: RN updates.
"Signed-off-by: Ranjani Vaidyanathan
-
Implemented system suspend resume functions to call hwvad enable/disable
then do runtime_force_suspend/resume.
Since hwvad can run independently, when user calls enable/disable, we
will have to increment/decrement usage counter by calling
runtime_*_sync but to avoid doing this when disable/enable is called
from system_suspend/resume since we called pm_runtime functions - this
is why we have added the sync parameter in enable/disable_hwvad.
However, we ignore the busy flag because the module wasn't designed to
work with arecord and hwvad in parralel and we only print a warning.
Since hwvad and recording share the same clock and initialization
procedures require module to be disabled, the busy flag will be set
when having both features enabled.Signed-off-by: Cosmin-Gabriel Samoila
Reviewed-by: Daniel Baluta -
We must find a way to no longer touch resources after they are
cleand up.Now, after a stress test we get the following crash:
[ 2156.863772] fsl-dsp 596e8000.dsp: xf_pool_alloc failed
[ 2156.869337] Unable to handle kernel NULL pointer dereference at
virtual address 00000060
[ 2157.148594] [] _raw_spin_lock+0x14/0x48
[ 2157.153995] [] xf_cmd_send_recv_complete+0x40/0xf0
[ 2157.160354] [] xf_close+0x40/0x88
[ 2157.165239] [] xaf_comp_delete+0x5c/0x70
[ 2157.170730] [] dsp_platform_compr_free+0xa0/0xe8
[ 2157.176917] [] soc_compr_free_fe+0x144/0x1a0
[ 2157.182754] [] snd_compr_free+0x64/0x98This happens because:
1) dsp_platform_process work handler waits in a loop for
messages to arrive.
2) when cplay process finishes it cleans up most of the
resources.
3) when another cplay process starts it reinitializes the
resources including queues for example.
4) a message will be generated and kernel will crash because
dsp_platform_process uses the older queues.A solution for this is to make sure dsp_platform_process work loop
is stopped at cleanup time.We use is_active state and signal dsp_platform_process handler to
finish because we are on the cleanup path.While at it replace cancel_work with cancel_work sync to be sure
that work handler ends before going on with the rest of the cleanup.Reviewed-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta
