30 Mar, 2020

10 commits

  • Setting the SLEEP pin to its shutdown function for appropriate PMICs
    doesn't need to happen in single-CPU context, so there's really no point
    involving the syscore machinery. Hook it up to the standard driver model
    shutdown method instead. This also obviates the issue that the syscore
    ops weren't being unregistered on probe failure or module removal.

    Signed-off-by: Robin Murphy
    Signed-off-by: Lee Jones

    Robin Murphy
     
  • The RK809/RK817 suspend/resume hooks should not have to depend on
    whether this driver owns the pm_power_off hook, and thus the global
    rk808_i2c_client is set - indeed, the GPIO-based control is really
    only relevant when PSCI firmware is in charge of power rather than
    the kernel. As driver model callbacks, they have an appropriate
    device argument to hand, so can just always use that.

    Signed-off-by: Robin Murphy
    Signed-off-by: Lee Jones

    Robin Murphy
     
  • With the device tree property "rockchip,system-power-controller" we
    explicitly request to use this PMIC to power off the system. So always
    register our poweroff function, even if some other handler (probably
    PSCI poweroff) was registered before.

    This does tend to reveal a warning on shutdown due to the Rockchip I2C
    driver not implementing an atomic transfer method, however since the
    write to DEV_OFF takes effect immediately the I2C completion interrupt
    is moot anyway, and as the very last thing written to the console it is
    only visible to users going out of their way to capture serial output.

    Signed-off-by: Soeren Moch
    Reviewed-by: Heiko Stuebner
    [ rm: note potential warning in commit message ]
    Signed-off-by: Robin Murphy
    Signed-off-by: Lee Jones

    Soeren Moch
     
  • device_driver name is const char pointer, so it not useful to cast
    xx_driver_name (which is already const char).

    Signed-off-by: Corentin Labbe
    Signed-off-by: Lee Jones

    Corentin Labbe
     
  • Fix several variations of typo around functionali{ty,es}.

    Signed-off-by: Christophe JAILLET
    Signed-off-by: Lee Jones

    Christophe JAILLET
     
  • The current codebase makes use of the zero-length array language
    extension to the C90 standard, but the preferred mechanism to declare
    variable-length types such as these ones is a flexible array member[1][2],
    introduced in C99:

    struct foo {
    int stuff;
    struct boo array[];
    };

    By making use of the mechanism above, we will get a compiler warning
    in case the flexible array does not occur last in the structure, which
    will help us prevent some kind of undefined behavior bugs from being
    inadvertently introduced[3] to the codebase from now on.

    Also, notice that, dynamic memory allocations won't be affected by
    this change:

    "Flexible array members have incomplete type, and so the sizeof operator
    may not be applied. As a quirk of the original implementation of
    zero-length arrays, sizeof evaluates to zero."[1]

    This issue was found with the help of Coccinelle.

    [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
    [2] https://github.com/KSPP/linux/issues/21
    [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

    Signed-off-by: Gustavo A. R. Silva
    Signed-off-by: Lee Jones

    Gustavo A. R. Silva
     
  • The current codebase makes use of the zero-length array language
    extension to the C90 standard, but the preferred mechanism to declare
    variable-length types such as these ones is a flexible array member[1][2],
    introduced in C99:

    struct foo {
    int stuff;
    struct boo array[];
    };

    By making use of the mechanism above, we will get a compiler warning
    in case the flexible array does not occur last in the structure, which
    will help us prevent some kind of undefined behavior bugs from being
    inadvertently introduced[3] to the codebase from now on.

    Also, notice that, dynamic memory allocations won't be affected by
    this change:

    "Flexible array members have incomplete type, and so the sizeof operator
    may not be applied. As a quirk of the original implementation of
    zero-length arrays, sizeof evaluates to zero."[1]

    This issue was found with the help of Coccinelle.

    [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
    [2] https://github.com/KSPP/linux/issues/21
    [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

    Signed-off-by: Gustavo A. R. Silva
    Signed-off-by: Lee Jones

    Gustavo A. R. Silva
     
  • If only cpcap mfd driver is selected we will get:

    ERROR: "devm_mfd_add_devices" [drivers/mfd/motorola-cpcap.ko] undefined!

    This is because Kconfig is missing select for MFD_CORE.

    Signed-off-by: Tony Lindgren
    Signed-off-by: Lee Jones

    Tony Lindgren
     
  • Add a check to ensure there is indeed an EC device tree entry before
    adding the cros-usbpd-notify device. This covers configs where both
    CONFIG_ACPI and CONFIG_OF are defined, but the EC device is defined
    using device tree and not in ACPI.

    Fixes: 4602dce0361e ("mfd: cros_ec: Add cros-usbpd-notify subdevice")
    Signed-off-by: Prashant Malani
    Tested-by: Enric Balletbo i Serra
    Signed-off-by: Lee Jones

    Prashant Malani
     
  • Lee Jones
     

27 Mar, 2020

13 commits


10 Feb, 2020

12 commits

  • Linus Torvalds
     
  • Pull more Kbuild updates from Masahiro Yamada:

    - fix randconfig to generate a sane .config

    - rename hostprogs-y / always to hostprogs / always-y, which are more
    natual syntax.

    - optimize scripts/kallsyms

    - fix yes2modconfig and mod2yesconfig

    - make multiple directory targets ('make foo/ bar/') work

    * tag 'kbuild-v5.6-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild:
    kbuild: make multiple directory targets work
    kconfig: Invalidate all symbols after changing to y or m.
    kallsyms: fix type of kallsyms_token_table[]
    scripts/kallsyms: change table to store (strcut sym_entry *)
    scripts/kallsyms: rename local variables in read_symbol()
    kbuild: rename hostprogs-y/always to hostprogs/always-y
    kbuild: fix the document to use extra-y for vmlinux.lds
    kconfig: fix broken dependency in randconfig-generated .config

    Linus Torvalds
     
  • Pull new zonefs file system from Damien Le Moal:
    "Zonefs is a very simple file system exposing each zone of a zoned
    block device as a file.

    Unlike a regular file system with native zoned block device support
    (e.g. f2fs or the on-going btrfs effort), zonefs does not hide the
    sequential write constraint of zoned block devices to the user. As a
    result, zonefs is not a POSIX compliant file system. Its goal is to
    simplify the implementation of zoned block devices support in
    applications by replacing raw block device file accesses with a richer
    file based API, avoiding relying on direct block device file ioctls
    which may be more obscure to developers.

    One example of this approach is the implementation of LSM
    (log-structured merge) tree structures (such as used in RocksDB and
    LevelDB) on zoned block devices by allowing SSTables to be stored in a
    zone file similarly to a regular file system rather than as a range of
    sectors of a zoned device. The introduction of the higher level
    construct "one file is one zone" can help reducing the amount of
    changes needed in the application while at the same time allowing the
    use of zoned block devices with various programming languages other
    than C.

    Zonefs IO management implementation uses the new iomap generic code.
    Zonefs has been successfully tested using a functional test suite
    (available with zonefs userland format tool on github) and a prototype
    implementation of LevelDB on top of zonefs"

    * tag 'zonefs-5.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/zonefs:
    zonefs: Add documentation
    fs: New zonefs file system

    Linus Torvalds
     
  • In order to allow the GICv4 code to link properly on 32bit ARM,
    make sure we don't use 64bit divisions when it isn't strictly
    necessary.

    Fixes: 4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")
    Reported-by: Stephen Rothwell
    Cc: Zenghui Yu
    Signed-off-by: Marc Zyngier
    Signed-off-by: Linus Torvalds

    Marc Zyngier
     
  • Pull cifs fixes from Steve French:
    "13 cifs/smb3 patches, most from testing at the SMB3 plugfest this week:

    - Important fix for multichannel and for modefromsid mounts.

    - Two reconnect fixes

    - Addition of SMB3 change notify support

    - Backup tools fix

    - A few additional minor debug improvements (tracepoints and
    additional logging found useful during testing this week)"

    * tag '5.6-rc-smb3-plugfest-patches' of git://git.samba.org/sfrench/cifs-2.6:
    smb3: Add defines for new information level, FileIdInformation
    smb3: print warning once if posix context returned on open
    smb3: add one more dynamic tracepoint missing from strict fsync path
    cifs: fix mode bits from dir listing when mounted with modefromsid
    cifs: fix channel signing
    cifs: add SMB3 change notification support
    cifs: make multichannel warning more visible
    cifs: fix soft mounts hanging in the reconnect code
    cifs: Add tracepoints for errors on flush or fsync
    cifs: log warning message (once) if out of disk space
    cifs: fail i/o on soft mounts if sessionsetup errors out
    smb3: fix problem with null cifs super block with previous patch
    SMB3: Backup intent flag missing from some more ops

    Linus Torvalds
     
  • Pull vboxfs from Al Viro:
    "This is the VirtualBox guest shared folder support by Hans de Goede,
    with fixups for fs_parse folded in to avoid bisection hazards from
    those API changes..."

    * 'work.vboxsf' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
    fs: Add VirtualBox guest shared folder (vboxsf) support

    Linus Torvalds
     
  • Pull x86 fixes from Thomas Gleixner:
    "A set of fixes for X86:

    - Ensure that the PIT is set up when the local APIC is disable or
    configured in legacy mode. This is caused by an ordering issue
    introduced in the recent changes which skip PIT initialization when
    the TSC and APIC frequencies are already known.

    - Handle malformed SRAT tables during early ACPI parsing which caused
    an infinite loop anda boot hang.

    - Fix a long standing race in the affinity setting code which affects
    PCI devices with non-maskable MSI interrupts. The problem is caused
    by the non-atomic writes of the MSI address (destination APIC id)
    and data (vector) fields which the device uses to construct the MSI
    message. The non-atomic writes are mandated by PCI.

    If both fields change and the device raises an interrupt after
    writing address and before writing data, then the MSI block
    constructs a inconsistent message which causes interrupts to be
    lost and subsequent malfunction of the device.

    The fix is to redirect the interrupt to the new vector on the
    current CPU first and then switch it over to the new target CPU.
    This allows to observe an eventually raised interrupt in the
    transitional stage (old CPU, new vector) to be observed in the APIC
    IRR and retriggered on the new target CPU and the new vector.

    The potential spurious interrupts caused by this are harmless and
    can in the worst case expose a buggy driver (all handlers have to
    be able to deal with spurious interrupts as they can and do happen
    for various reasons).

    - Add the missing suspend/resume mechanism for the HYPERV hypercall
    page which prevents resume hibernation on HYPERV guests. This
    change got lost before the merge window.

    - Mask the IOAPIC before disabling the local APIC to prevent
    potentially stale IOAPIC remote IRR bits which cause stale
    interrupt lines after resume"

    * tag 'x86-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
    x86/apic: Mask IOAPIC entries when disabling the local APIC
    x86/hyperv: Suspend/resume the hypercall page for hibernation
    x86/apic/msi: Plug non-maskable MSI affinity race
    x86/boot: Handle malformed SRAT tables during early ACPI parsing
    x86/timer: Don't skip PIT setup when APIC is disabled or in legacy mode

    Linus Torvalds
     
  • Pull SMP fixes from Thomas Gleixner:
    "Two fixes for the SMP related functionality:

    - Make the UP version of smp_call_function_single() match SMP
    semantics when called for a not available CPU. Instead of emitting
    a warning and assuming that the function call target is CPU0,
    return a proper error code like the SMP version does.

    - Remove a superfluous check in smp_call_function_many_cond()"

    * tag 'smp-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
    smp/up: Make smp_call_function_single() match SMP semantics
    smp: Remove superfluous cond_func check in smp_call_function_many_cond()

    Linus Torvalds
     
  • Pull perf fixes from Thomas Gleixner:
    "A set of fixes and improvements for the perf subsystem:

    Kernel fixes:

    - Install cgroup events to the correct CPU context to prevent a
    potential list double add

    - Prevent an integer underflow in the perf mlock accounting

    - Add a missing prototype for arch_perf_update_userpage()

    Tooling:

    - Add a missing unlock in the error path of maps__insert() in perf
    maps.

    - Fix the build with the latest libbfd

    - Fix the perf parser so it does not delete parse event terms, which
    caused a regression for using perf with the ARM CoreSight as the
    sink configuration was missing due to the deletion.

    - Fix the double free in the perf CPU map merging test case

    - Add the missing ustring support for the perf probe command"

    * tag 'perf-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
    perf maps: Add missing unlock to maps__insert() error case
    perf probe: Add ustring support for perf probe command
    perf: Make perf able to build with latest libbfd
    perf test: Fix test case Merge cpu map
    perf parse: Copy string to perf_evsel_config_term
    perf parse: Refactor 'struct perf_evsel_config_term'
    kernel/events: Add a missing prototype for arch_perf_update_userpage()
    perf/cgroups: Install cgroup events to correct cpuctx
    perf/core: Fix mlock accounting in perf_mmap()

    Linus Torvalds
     
  • Pull timer fixes from Thomas Gleixner:
    "Two small fixes for the time(r) subsystem:

    - Handle a subtle race between the clocksource watchdog and a
    concurrent clocksource watchdog stop/start sequence correctly to
    prevent a timer double add bug.

    - Fix the file path for the core time namespace file"

    * tag 'timers-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
    clocksource: Prevent double add_timer_on() for watchdog_timer
    MAINTAINERS: Correct path to time namespace source file

    Linus Torvalds
     
  • Pull interrupt fixes from Thomas Gleixner:
    "A set of fixes for the interrupt subsystem:

    - Provision only ACPI enabled redistributors on GICv3

    - Use the proper command colums when building the INVALL command for
    the GICv3-ITS

    - Ensure the allocation of the L2 vPE table for GICv4.1

    - Correct the GICv4.1 VPROBASER programming so it uses the proper
    size

    - A set of small GICv4.1 tidy up patches

    - Configuration cleanup for C-SKY interrupt chip

    - Clarify the function documentation for irq_set_wake() to document
    that the wakeup functionality is orthogonal to the irq
    disable/enable mechanism"

    * tag 'irq-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
    irqchip/gic-v3-its: Rename VPENDBASER/VPROPBASER accessors
    irqchip/gic-v3-its: Remove superfluous WARN_ON
    irqchip/gic-v4.1: Drop 'tmp' in inherit_vpe_l1_table_from_rd()
    irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level
    irqchip/gic-v4.1: Set vpe_l1_base for all redistributors
    irqchip/gic-v4.1: Fix programming of GICR_VPROPBASER_4_1_SIZE
    genirq: Clarify that irq wake state is orthogonal to enable/disable
    irqchip/gic-v3-its: Reference to its_invall_cmd descriptor when building INVALL
    irqchip: Some Kconfig cleanup for C-SKY
    irqchip/gic-v3: Only provision redistributors that are enabled in ACPI

    Linus Torvalds
     
  • Pull EFI fix from Thomas Gleixner:
    "A single fix for a EFI boot regression on X86 which was caused by the
    recent rework of the EFI memory map parsing. On systems with invalid
    memmap entries the cleanup function uses an value which cannot be
    relied on in this stage. Use the actual EFI memmap entry instead"

    * tag 'efi-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
    efi/x86: Fix boot regression on systems with invalid memmap entries

    Linus Torvalds
     

09 Feb, 2020

5 commits

  • Pull misc SCSI fixes from James Bottomley:
    "Five small patches, all in drivers or doc, which missed the initial
    pull request.

    The qla2xxx and megaraid_sas are actual fixes and the rest are
    spelling and doc changes"

    * tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
    scsi: ufs: fix spelling mistake "initilized" -> "initialized"
    scsi: pm80xx: fix spelling mistake "to" -> "too"
    scsi: MAINTAINERS: ufs: remove pedrom.sousa@synopsys.com
    scsi: megaraid_sas: fixup MSIx interrupt setup during resume
    scsi: qla2xxx: Fix unbound NVME response length

    Linus Torvalds
     
  • Pull networking fixes from David Miller:

    1) Unbalanced locking in mwifiex_process_country_ie, from Brian Norris.

    2) Fix thermal zone registration in iwlwifi, from Andrei
    Otcheretianski.

    3) Fix double free_irq in sgi ioc3 eth, from Thomas Bogendoerfer.

    4) Use after free in mptcp, from Florian Westphal.

    5) Use after free in wireguard's root_remove_peer_lists, from Eric
    Dumazet.

    6) Properly access packets heads in bonding alb code, from Eric
    Dumazet.

    7) Fix data race in skb_queue_len(), from Qian Cai.

    8) Fix regression in r8169 on some chips, from Heiner Kallweit.

    9) Fix XDP program ref counting in hv_netvsc, from Haiyang Zhang.

    10) Certain kinds of set link netlink operations can cause a NULL deref
    in the ipv6 addrconf code. Fix from Eric Dumazet.

    11) Don't cancel uninitialized work queue in drop monitor, from Ido
    Schimmel.

    * git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (84 commits)
    net: thunderx: use proper interface type for RGMII
    mt76: mt7615: fix max_nss in mt7615_eeprom_parse_hw_cap
    bpf: Improve bucket_log calculation logic
    selftests/bpf: Test freeing sockmap/sockhash with a socket in it
    bpf, sockhash: Synchronize_rcu before free'ing map
    bpf, sockmap: Don't sleep while holding RCU lock on tear-down
    bpftool: Don't crash on missing xlated program instructions
    bpf, sockmap: Check update requirements after locking
    drop_monitor: Do not cancel uninitialized work item
    mlxsw: spectrum_dpipe: Add missing error path
    mlxsw: core: Add validation of hardware device types for MGPIR register
    mlxsw: spectrum_router: Clear offload indication from IPv6 nexthops on abort
    selftests: mlxsw: Add test cases for local table route replacement
    mlxsw: spectrum_router: Prevent incorrect replacement of local table routes
    net: dsa: microchip: enable module autoprobe
    ipv6/addrconf: fix potential NULL deref in inet6_set_link_af()
    dpaa_eth: support all modes with rate adapting PHYs
    net: stmmac: update pci platform data to use phy_interface
    net: stmmac: xgmac: fix missing IFF_MULTICAST checki in dwxgmac2_set_filter
    net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter
    ...

    Linus Torvalds
     
  • VirtualBox hosts can share folders with guests, this commit adds a
    VFS driver implementing the Linux-guest side of this, allowing folders
    exported by the host to be mounted under Linux.

    This driver depends on the guest host IPC functions exported by
    the vboxguest driver.

    Acked-by: Christoph Hellwig
    Signed-off-by: Hans de Goede
    Signed-off-by: Al Viro

    Hans de Goede
     
  • Pull powerpc fixes from Michael Ellerman:

    - Fix an existing bug in our user access handling, exposed by one of
    the bug fixes we merged this cycle.

    - A fix for a boot hang on 32-bit with CONFIG_TRACE_IRQFLAGS and the
    recently added CONFIG_VMAP_STACK.

    Thanks to: Christophe Leroy, Guenter Roeck.

    * tag 'powerpc-5.6-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
    powerpc: Fix CONFIG_TRACE_IRQFLAGS with CONFIG_VMAP_STACK
    powerpc/futex: Fix incorrect user access blocking

    Linus Torvalds
     
  • This is a merge error on my part - the driver was merged into mainline
    by commit c5951e7c8ee5 ("Merge tag 'mips_5.6' of git://../mips/linux")
    over a week ago, but nobody apparently noticed that it didn't actually
    build due to still having a reference to the devm_ioremap_nocache()
    function, removed a few days earlier through commit 6a1000bd2703 ("Merge
    tag 'ioremap-5.6' of git://../ioremap").

    Apparently this didn't get any build testing anywhere. Not perhaps all
    that surprising: it's restricted to 64-bit MIPS only, and only with the
    new SGI_MFD_IOC3 support enabled.

    I only noticed because the ioremap conflicts in the ARM SoC driver
    update made me check there weren't any others hiding, and I found this
    one.

    Signed-off-by: Linus Torvalds

    Linus Torvalds