12 Oct, 2007
1 commit
-
Use builtin statistics structure from net device.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller
11 Oct, 2007
4 commits
-
Use the PCI layer config access functions. The driver was using the
memory mapped window in device, to workaround issues accessing the
advanced error reporting registers.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
Signed-off-by: David S. Miller -
Use the kernel interfaces for advanced error reporting.
This should be cleaner and clear up errors on boot.For those systems with busted BIOS's that don't correctly
support mmconfig, advanced error reporting will be disabled.
The PCI registers for advanced error reporting start at 0x100 which
is too large to be accessed by legacy functions.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Add documentation of GPHY_CTRL register bits even if driver
is not using them (yet).Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Several devices have multiple independant RX queues per net
device, and some have a single interrupt doorbell for several
queues.In either case, it's easier to support layouts like that if the
structure representing the poll is independant from the net
device itself.The signature of the ->poll() call back goes from:
int foo_poll(struct net_device *dev, int *budget)
to
int foo_poll(struct napi_struct *napi, int budget)
The caller is returned the number of RX packets processed (or
the number of "NAPI credits" consumed if you want to get
abstract). The callee no longer messes around bumping
dev->quota, *budget, etc. because that is all handled in the
caller upon return.The napi_struct is to be embedded in the device driver private data
structures.Furthermore, it is the driver's responsibility to disable all NAPI
instances in it's ->stop() device close handler. Since the
napi_struct is privatized into the driver's private data structures,
only the driver knows how to get at all of the napi_struct instances
it may have per-device.With lots of help and suggestions from Rusty Russell, Roland Dreier,
Michael Chan, Jeff Garzik, and Jamal Hadi Salim.Bug fixes from Thomas Graf, Roland Dreier, Peter Zijlstra,
Joseph Fannin, Scott Wood, Hans J. Koch, and Michael Chan.[ Ported to current tree and all drivers converted. Integrated
Stephen's follow-on kerneldoc additions, and restored poll_list
handling to the old style to fix mutual exclusion issues. -DaveM ]Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller
25 Sep, 2007
1 commit
-
Be more selective about when to enable the ram buffer watchdog code.
It is unnecessary on XL A3 or later revs, and with Yukon FE
the buffer is so small (4K) that the watchdog detects false positives.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
21 Sep, 2007
4 commits
-
A driver writer from another operating system hinted that
the versions of Yukon 2 chip with rambuffer (EC and XL) have
a hardware bug that if the FIFO ever gets completely full it
will hang. Sounds like a classic ring full vs ring empty wrap around
bug.As a workaround, use the existing watchdog timer to check for
ring full lockup.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Add support for newest Marvell chips.
The Yukon FE plus chip is found in some not yet released laptops.
Tested on hardware evaluation boards.This version of the patch is for 2.6.23. It supersedes
the two previous patches that are sitting in netdev-2.6 (upstream branch).Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
This patch should cause no functional changes in driver behaviour.
There are (too) many revisions of the Yukon 2 chip now. Instead of
adding more conditionals based on chip revision; rerganize into a
set of feature flags so adding new versions is less problematic.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
The length check for truncated frames was not correctly handling
the case where VLAN acceleration had already read the tag.
Also, the Yukon EX has some features that use high bit of status
as security tag.Signed-off-by: Pierre-Yves Ritschard
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
25 Aug, 2007
1 commit
-
This fixes the extra timer overhead that people were whining about
as a 2.6.23 regression.Running the watchdog timer all the time is unneeded. Change it
to run only if link is up, and reduce frequency to save power.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
11 Jul, 2007
1 commit
-
Add an optional debug interface for displaying state of transmit/receive
rings. Creates a file debugfs/sky2/ethX for each device that is up.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
09 Jul, 2007
4 commits
-
Enable support for Yukon EX chipset (88e8071).
Most of changes are related to new commands to chip for transmit,
and change in status and checksumming.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
The General Purpose I/O register is yet another hardware workaround
catchall. Enable workaround that vendor driver does to stay
but for bug compatiable.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
This register is more of a test and control register on Yukon2.
So rename it to Q_TEST and give some bit definitions.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Need to setup more PCI control control registers are on Yukon EX.
Some of these also exist on Yukon EC-U as well.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
30 May, 2007
2 commits
-
Don't want IRQ on FIFO error because there is nothing useful to do with it.
But do want IRQ on duplex change.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
This code inherited from the sk98lin driver is incorrect on the Yukon2.
The GPHY_CTRL register values are specific to the internal PHY of the chip
and the values used were leftovers.
Driver was setting bit 13 which is now the INT polarity for the PHY!Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
20 Apr, 2007
2 commits
-
The Yukon EC Ultra chips have transmit settings for store and
forward and PCI buffering. By setting these appropriately, normal
performance goes from 750Mbytes/sec to 940Mbytes/sec (non-jumbo).It is also possible to do Jumbo mode, but it means turning off
TSO and checksum offload so the performance gets worse. There isn't
enough buffering for checksum offload to work.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
There should never be descriptor error unless hardware or driver is buggy.
But if an error occurs, print useful information, clear irq, and recover.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
18 Feb, 2007
2 commits
-
The transmit timeout code could hang, and it would not clear out
problems if the hardware was stuck. Change the code to effectively do
a device down/up similar to the suspend/resume code.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Don't mark pause frames as errors. This problem caused transmitter not
to pause and would effectively take out a gigabit switch because the
it can't handle overrun.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
08 Feb, 2007
2 commits
-
This is basic support for the new Yukon Extreme
chip, extracted from the new vendor driver 10.0.4.3.Since this is untested hardware, it has a big fat warning for now.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Adds basic magic packet wake on lan support to the sky2 driver.
Note: initial WOL value is based on BIOS settings.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
06 Feb, 2007
1 commit
-
Improve power management and error handling by using pci_set_power_state(),
instead of driver doing PCI PM register changes in the driver.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
07 Dec, 2006
2 commits
-
Get rid of sparse warnings in sky2 driver because of mixed enum
usage.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
This patch makes the receive performance on some systems go from
714MB/s to 941MB/s. It adjusts the watermark of the receive queue
to be lower, thereby avoiding excess hardware flow control. This is
most important on the systems which have little/no additional buffering.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
02 Dec, 2006
2 commits
-
If using Message Signaled Interrupts (MSI) then the IRQ will never
be shared. Don't call pci_disable_msi() unless using MSI.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Update workarounds for 88E803X based on the latest SysKonnect vendor
driver version (8.41). Tested on EC_U rev A1, only.
These up the receive performance.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
18 Oct, 2006
3 commits
-
This reverts earlier change that attempted to fix flow control.
Device needs to discard pause frames, otherwise it hangs after a while.Signed-off-by: Stephen Hemminger
-
The result of flow control negotiation should not limit the next
negotiatition. If board is plugged into an old half duplex 10Mbit port,
without pause, then replugged into a gigabit port, it should negotiate
what is desired, not inherit that last negotiation.Signed-off-by: Stephen Hemminger
-
The advertising bits (from ethtool.h) fit in 16 bits.
11 Oct, 2006
1 commit
-
The pci express error handling extensions don't work unless PCI access is via
mmconfig. Otherwise, all accesses to pci config registers greater than 256 fail.
Since the sky2 driver has other ways of getting to PCI config space, it works
around this short coming, but the pci_find_ext_capablity doesn't work.This backs out commit 91aeb3edbcf4e6ed72d138ac8c22fd68e6d717c3
Go back to hardcoding, since we know where the error registers are anyway.
Fixes http://bugzilla.kernel.org/show_bug.cgi?id=7222Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
28 Sep, 2006
4 commits
-
Use hardware support for chained receive to break up large frames
into multiple pages. This avoids having to do a mult-page allocation
that can fail on a busy system due to fragmented memory.For normal size MTU, this code behaves the same.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Use the netdevice transmit lock via netif_tx_lock rather than putting
lock in device specific code and using lockless transmit. The code is
cleaner using netif_tx_lock, and the performance is same.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Since a transmit can take several control blocks, the old code waited
until the last control block was marked as done. This code processes
the return values incrementally. This makes slots in the tx ring available
and less chance of getting stuck.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Use the standard pci capability mechanism to access PCI express error
registers, rather than hard coding the offset. Mask off the PCI express
error from ever occuring on non-PCI express systems.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
14 Sep, 2006
3 commits
-
Fix support for big endian platforms like PPC.
Still not sure about VLAN acceleration (does it need swapping)?Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Fix the support for fiber connected gigabit boards.
Allow half duplex gigabit to be configured.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Fix problems with transmit pause frames. The driver was telling the
GMAC to flush (not process) pause frames. Manually disabling pause wasn't
working because of problems in the setup.This maybe the cause of the lockup under load.
http://bugzilla.kernel.org/show_bug.cgi?id=6839Patch against netdev-2.6 git tree
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik