11 Jul, 2007
21 commits
-
We don't need the BKL when wrapping and unwrapping; and experiments by Avishay
Traeger have found that permitting multiple encryption and decryption
operations to proceed in parallel can provide significant performance
improvements.Signed-off-by: J. Bruce Fields
Cc: Avishay Traeger
Signed-off-by: Trond Myklebust -
In addition to binding to a local privileged port the NFS client should
allow binding to a specific local address. This is used by the server
for callbacks. The patch adds the necessary interface.Signed-off-by: Frank van Maarseveen
Signed-off-by: Trond Myklebust -
Cleanup argument passing to functions for creating an RPC transport.
Signed-off-by: Frank van Maarseveen
Signed-off-by: Trond Myklebust -
A couple of callers just use a stringified IP address for the rpc client's
hostname. Move the logic for constructing this into rpc_create(), so it can
be shared.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
Convert them into dprintk() calls.
Signed-off-by: Trond Myklebust
-
We should almost always be deferencing the rpc_auth struct by means of the
credential's cr_auth field instead of the rpc_clnt->cl_auth anyway. Fix up
that historical mistake, and remove the macro that propagated it.Signed-off-by: Trond Myklebust
-
RPCSEC_GSS needs to be able to send NULL RPC calls to the server in order
to free up any remaining GSS contexts.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Does a NULL RPC call and returns a pointer to the resulting rpc_task. The
call may be either synchronous or asynchronous.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Ensures that an rpc_client always has the possibility to send asynchronous
RPC calls.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
The kref now does most of what cl_count + cl_user used to do. The only
remaining role for cl_count is to tell us if we are in a 'shutdown'
phase. We can provide that information using a single bit field instead
of a full atomic counter.Also rename rpc_destroy_client() to rpc_close_client(), which reflects
better what its role is these days.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Replace it with explicit calls to rpc_shutdown_client() or
rpc_destroy_client() (for the case of asynchronous calls).Signed-off-by: Trond Myklebust
-
Its use is at best racy, and there is only one user (lockd), which has
additional locking that makes the whole thing redundant.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Use that to protect the rpc_clnt->cl_tasks list instead of using a global
lock.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
01 May, 2007
3 commits
-
Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
Currently rpc_malloc sets req->rq_buffer internally. Make this a more
generic interface: return a pointer to the new buffer (or NULL) and
make the caller set req->rq_buffer and req->rq_bufsize. This looks much
more like kmalloc and eliminates the side effects.To fix a potential deadlock, this patch also replaces GFP_NOFS with
GFP_NOWAIT in rpc_malloc. This prevents async RPCs from sleeping outside
the RPC's task scheduler while allocating their buffer.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
The RPC buffer size estimation logic in net/sunrpc/clnt.c always
significantly overestimates the requirements for the buffer size.
A little instrumentation demonstrated that in fact rpc_malloc was never
allocating the buffer from the mempool, but almost always called kmalloc.To compute the size of the RPC buffer more precisely, split p_bufsiz into
two fields; one for the argument size, and one for the result size.Then, compute the sum of the exact call and reply header sizes, and split
the RPC buffer precisely between the two. That should keep almost all RPC
buffers within the 2KiB buffer mempool limit.And, we can finally be rid of RPC_SLACK_SPACE!
Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust
21 Apr, 2007
1 commit
-
Fix a regression due to the patch "NFS: disconnect before retrying NFSv4
requests over TCP"The assumption made in xprt_transmit() that the condition
"req->rq_bytes_sent == 0 and request is on the receive list"
should imply that we're dealing with a retransmission is false.
Firstly, it may simply happen that the socket send queue was full
at the time the request was initially sent through xprt_transmit().
Secondly, doing this for each request that was retransmitted implies
that we disconnect and reconnect for _every_ request that happened to
be retransmitted irrespective of whether or not a disconnection has
already occurred.Fix is to move this logic into the call_status request timeout handler.
Signed-off-by: Trond Myklebust
Signed-off-by: Linus Torvalds
13 Feb, 2007
2 commits
-
Conflicts:
net/sunrpc/auth_gss/gss_krb5_crypto.c
net/sunrpc/auth_gss/gss_spkm3_token.c
net/sunrpc/clnt.cMerge with mainline and fix conflicts.
-
RFC3530 section 3.1.1 states an NFSv4 client MUST NOT send a request
twice on the same connection unless it is the NULL procedure. Section
3.1.1 suggests that the client should disconnect and reconnect if it
wants to retry a request.Implement this by adding an rpc_clnt flag that an ULP can use to
specify that the underlying transport should be disconnected on a
major timeout. The NFSv4 client asserts this new flag, and requests
no retries after a minor retransmit timeout.Note that disconnecting on a retransmit is in general not safe to do
if the RPC client does not reuse the TCP port number when reconnecting.See http://bugzilla.linux-nfs.org/show_bug.cgi?id=6
Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust
11 Feb, 2007
1 commit
-
Signed-off-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller
04 Feb, 2007
2 commits
-
The tk_pid field is an unsigned short. The proper print format specifier for
that type is %5u, not %4d.Also clean up some miscellaneous print formatting nits.
Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
The error values are already propagated through task->tk_status, and
none of the callers check one without checking the other, so we can
drop the return value.Signed-off-by: Trond Myklebust
25 Jan, 2007
1 commit
-
Fix the Oops in http://bugzilla.linux-nfs.org/show_bug.cgi?id=138
We shouldn't be calling rpc_release_task() for tasks that are not active.Signed-off-by: Trond Myklebust
Signed-off-by: Linus Torvalds
06 Dec, 2006
6 commits
-
For now we will assume that all transports will use the address format
buffers in the rpc_xprt struct to store their addresses. Change
rpc_peer2str() to be a generic routine to handle this, and get rid of the
print_address() op in the rpc_xprt_ops vector.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
All internal RPC client operations should no longer depend on the BKL,
however lockd and NFS callbacks may still require it.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
03 Dec, 2006
1 commit
-
Signed-off-by: Arnaldo Carvalho de Melo
02 Oct, 2006
1 commit
-
Replace references to system_utsname to the per-process uts namespace
where appropriate. This includes things like uname.Changes: Per Eric Biederman's comments, use the per-process uts namespace
for ELF_PLATFORM, sunrpc, and parts of net/ipv4/ipconfig.c[jdike@addtoit.com: UML fix]
[clg@fr.ibm.com: cleanup]
[akpm@osdl.org: build fix]
Signed-off-by: Serge E. Hallyn
Cc: Kirill Korotaev
Cc: "Eric W. Biederman"
Cc: Herbert Poetzl
Cc: Andrey Savochkin
Signed-off-by: Cedric Le Goater
Cc: Jeff Dike
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
29 Sep, 2006
1 commit
-
pure s/u32/__be32/
[AV: large part based on Alexey's patches]
Signed-off-by: Alexey Dobriyan
Signed-off-by: Al Viro
Signed-off-by: David S. Miller
