25 Sep, 2008
40 commits
-
use normal kbuild syntax to build acl.o conditinally and remove comment
out lines.Signed-off-by: Christoph Hellwig
Signed-off-by: Chris Mason -
These ioctls let a user application hold a transaction open while it
performs a series of operations. A final ioctl does a sync on the fs
(closing the current transaction). This is the main requirement for
Ceph's OSD to be able to keep the data it's storing in a btrfs volume
consistent, and AFAICS it works just fine. The application would do
something likefd = ::open("some/file", O_RDONLY);
::ioctl(fd, BTRFS_IOC_TRANS_START);
/* do a bunch of stuff */
::ioctl(fd, BTRFS_IOC_TRANS_END);
or just
::close(fd);And to ensure it commits to disk,
::ioctl(fd, BTRFS_IOC_SYNC);
When a transaction is held open, the trans_handle is attached to the
struct file (via private_data) so that it will get cleaned up if the
process dies unexpectedly. A held transaction is also ended on fsync() to
avoid a deadlock.A misbehaving application could also deliberately hold a transaction open,
effectively locking up the FS, so it may make sense to restrict something
like this to root or something.Signed-off-by: Chris Mason
-
The acl code is not yet complete, and the xattr handlers are causing
problems for cp -p on some distros.Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Send the error back to userland if the ioctl fails
Signed-off-by: Chris Mason
-
We need to invalidate an existing dcache entry after creating a new
snapshot or subvolume, because a negative dache entry will stop us from
accessing the new snapshot or subvolume.---
ctree.h | 23 +++++++++++++++++++++++
inode.c | 4 ++++
transaction.c | 4 ++++
3 files changed, 31 insertions(+)Signed-off-by: Chris Mason
-
When a new transaction was started, the code would incorrectly
set the pointer in fs_info before all the data structures were setup.
fsync heavy workloads hit races on the setup of the ordered inode spinlockSigned-off-by: Chris Mason
-
Use btrfs_release_file instead of a put_inode call
Signed-off-by: Chris Mason
-
This avoids IO stalls and poorly ordered IO from inline writers mixing in
with the async submission queueSigned-off-by: Chris Mason
-
* Force chunk allocation when find_free_extent has to do a full scan
* Record the max key at the start of defrag so it doesn't run forever
* Block groups might not be contiguous, make a forward search for the
next block group in extent-tree.c
* Get rid of extra checks for total fs size
* Fix relocate_one_reference to avoid relocating the same file data block
twice when referenced by an older transaction
* Use the open device count when allocating chunks so that we don't
try to allocate from devices that don't existSigned-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
The async submit workqueue was absorbing too many requests, leading to long
stalls where the async submitters were stalling.Signed-off-by: Chris Mason
-
The extent_io writepage calls needed an extra check for discarding
pages that started on th last byte in the file.btrfs_truncate_page needed checks to make sure the page was still part
of the file after reading it, and most importantly, needed to wait for
all IO to the page to finish before freeing the corresponding extents on
disk.Signed-off-by: Chris Mason
-
Devices can change after the scan ioctls are done, and btrfs_open_devices
needs to be able to verify them as they are opened and used by the FS.Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
When duplicate copies exist, writes are allowed to fail to one of those
copies. This changeset includes a few changes that allow the FS to
continue even when some IOs fail.It also adds verification of the parent generation number for btree blocks.
This generation is stored in the pointer to a block, and it ensures
that missed writes to are detected.Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Once part of a delalloc request fails the cow checks, just cow the
entire rangeIt is possible for the back references to all be from the same root,
but still have snapshots against an extent. The checks are now more strict,
forcing cow any time there are multiple refs against the data extent.Signed-off-by: Chris Mason
-
btrfs_open_devices needed a check to see if the device was already
open.Signed-off-by: Chris Mason
-
Before, nodatacow only checked to make sure multiple roots didn't have
references on a single extent. This check makes sure that multiple
inodes don't have references.nodatacow needed an extra check to see if the block group was currently
readonly. This way cows forced by the chunk relocation code are honored.Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
This required a few structural changes to the code that manages bdev pointers:
The VFS super block now gets an anon-bdev instead of a pointer to the
lowest bdev. This allows us to avoid swapping the super block bdev pointer
around at run time.The code to read in the super block no longer goes through the extent
buffer interface. Things got ugly keeping the mapping constant.Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
In openSUSE 10.3, AppArmor modifies remove_suid to take a struct path
rather than just a dentry. This patch tests that the kernel is openSUSE
10.3 or newer and adjusts the call accordingly.Debian/Ubuntu with AppArmor applied will also need a similar patch.
Maintainers of btrfs under those distributions should build on this
patch or, alternatively, alter their package descriptions to add
-DREMOVE_SUID_PATH to the compiler command line.Signed-off-by: Jeff Mahoney
- --- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ b/compat.h 2008-02-06 16:46:13.000000000 -0500
@@ -0,0 +1,15 @@
+#ifndef _COMPAT_H_
+#define _COMPAT_H_
+
+
+/*
+ * Even if AppArmor isn't enabled, it still has different prototypes.
+ * Add more distro/version pairs here to declare which has AppArmor applied.
+ */
+#if defined(CONFIG_SUSE_KERNEL)
+# if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,22)
+# define REMOVE_SUID_PATH 1
+# endif
+#endif
+
+#endif /* _COMPAT_H_ */
- --- a/file.c 2008-02-06 11:37:39.000000000 -0500
+++ b/file.c 2008-02-06 16:46:23.000000000 -0500
@@ -37,6 +37,7 @@
#include "ordered-data.h"
#include "ioctl.h"
#include "print-tree.h"
+#include "compat.h"static int btrfs_copy_from_user(loff_t pos, int num_pages, int write_bytes,
@@ -790,7 +791,11 @@ static ssize_t btrfs_file_write(struct f
goto out_nolock;
if (count == 0)
goto out_nolock;
+#ifdef REMOVE_SUID_PATH
+ err = remove_suid(&file->f_path);
+#else
err = remove_suid(fdentry(file));
+#endif
if (err)
goto out_nolock;
file_update_time(file);Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Add a new ioctl to clone file data
Signed-off-by: Chris Mason
-
2.6.18 seems to get caught in an infinite loop when
cancel_rearming_delayed_workqueue is called more than once, so this switches
to cancel_delayed_work, which is arguably more correct.Also, balance_dirty_pages can run into problems with 2.6.18 based kernels
because it doesn't have the per-bdi dirty limits. This avoids calling
balance_dirty_pages on the btree inode unless there is actually something
to balance, which is a good optimization in general.Finally there's a compile fix for ordered-data.h
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
-
Signed-off-by: Chris Mason
