09 Jun, 2006
5 commits
-
Update version string.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Sometimes boards don't reset properly, and the address read out of the
EEPROM is zero. Stop the insanity before the device gets registered.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
The transmit side code has a number of ring problems that caused some
of the Bugzilla reports. Rather than trying to fix the details, it is safer
to rewrite the code that handles transmit completion and freeing.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Consolidate all usage of ring low water mark to one value.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Since accessing the PHY can take 100's of usecs, use a work queue to
allow spinning in outside of soft/hard irq.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
20 May, 2006
3 commits
-
The driver will get stuck (permanent transmit timeout), if the transmit
ring size is set too small. It needs to have enough ring elements to
hold one maximum size transmit.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Skge driver always causes bad checksums on big-endian.
The checksum in the receive control block was being swapped
when it doesn't need to be.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
The Dlink DGE-560T uses Yukon2 chipset so it needs sky2 driver; and
the DGE-530T uses Yukon1 so it uses skge driver.Bug: http://bugzilla.kernel.org/show_bug.cgi?id=6544
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
13 Apr, 2006
1 commit
-
This patch fixes the problem of some Dlink cards picking the wrong
driver. It looks like these cards use Yukon 1 chipset, not Yukon 2.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
24 Mar, 2006
7 commits
-
Update version to allow tracking of complaints.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Don't need to keep track of available buffers, it is simpler
to just compute the value (ala e1000). Don't need tes on link up
because should always have available buffers then.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Don't free transmit buffers until the whole set of transmit descriptors
has been marked as done. Otherwise, we risk freeing a skb before the
whole transmit is done.This changes the transmit completion handling from incremental to a
two pass algorithm. First pass scans and records the start of the last
done descriptor, second cleans up until that point.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Fix count of multicast packets.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
In the error case we call skge_rx_reuse twice. This is harmless
but unnecessary.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
The skge driver was using dev_alloc_skb which reserves space for the
Ethernet header. This unnecessary and it should just use alloc_skb,
also by using GFP_KERNEL during startup it won't run into problems when
a user asks for a huge ring size or mtu and potentially drains the
reserved atomic pool.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
The skge driver aligns the header on the initial receive buffers, but
but doesn't on followon receive buffer allocations.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
22 Mar, 2006
9 commits
-
Update version number
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
When a PCI error occurs, try and report more info.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Reformat some code to make it easier to read. And whitespace
fixes.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Add mmio barriers at the appropriate places, don't have a platform
that needs them, but this is where the documentation of the patch
says to add them.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Use kcalloc when allocating ring data structure.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Cleanup of the part of the code that sets up DMA configuration.
Should cause no real change in operation, just clearer.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
The SysKonnect Genesis and Yukon chip sets have restrictions on the possible
control block area. The memory needs to not cross 4 Gig boundary, and it needs
to be 8 byte aligned. This patch checks and fails to bring the device up
if region is unacceptable.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Improve performance of skge driver by not touching irq mask
register as much. Since the interrupt source auto-masks, the driver
can just leave it disabled until the end of the soft irq.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Cleanup transmit buffers using NAPI. This allows the transmit routine
to leave interrupts enabled, and that improves performance.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
24 Feb, 2006
3 commits
-
There is a race between updating the irq mask and setting it
which can be triggered on SMP with a bad cable.
Similar patch from Ingo Molnar and Thomas GleixnerSigned-off-by: Stephen Hemminger
-
The SysKonnect Genesis based board would fail on initialization
with phy_read errors caused by not waiting for last phy write.Signed-off-by: Stephen Hemminger
-
Fix a race in the receive NAPI, irq handling. The interrupt clear and the
start need to be separated. Otherwise there is a window between the last
frame received and the NAPI done level handling.Signed-off-by: Stephen Hemminger
18 Feb, 2006
1 commit
-
This is a clone of John Linville's fixed for speed setting on sky2 driver.
The skge driver has the same code (and bug). It would not allow manually forcing
100 and 10 mbit.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
18 Jan, 2006
1 commit
-
There are a couple of problems in the DMA setup code for skge.
* In the 64 bit case, it doesn't set the consistent mask.
* In the 32 bit case, the error check is backwards!
It likely will only be visible as a bug on 64 bit platforms.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
05 Jan, 2006
1 commit
04 Jan, 2006
1 commit
-
To help in reducing the number of include dependencies, several files were
touched as they were getting needed headers indirectly for stuff they use.Thanks also to Alan Menegotto for pointing out that net/dccp/proto.c had
linux/dccp.h include twice.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
24 Dec, 2005
6 commits
-
Also have to handle out of memory condition on resume.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Enough changes for one version.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
If changing ring parameters is unable to allocate memory, we need
to return an error and take the device down.Fixes-bug: http://bugzilla.kernel.org/show_bug.cgi?id=5715
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Changing the MTU size causes the receiver to have to reallocate buffers.
If this allocation fails, then we need to return an error, and take
the device offline. It can then be brought back up or reconfigured
for a smaller MTU.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Change the pause settings doesn't need to cause link to go down/up.
It can be handled by the phy_reset code.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Change the speed settings doesn't need to cause link to go down/up.
It can be handled by doing the same logic as nway_reset.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
14 Dec, 2005
1 commit
13 Dec, 2005
1 commit
-
Get rid of warning in case of race with ring full and lockless
tx on the skge driver. It is possible to be in the transmit
routine with no available slots and already stopped.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik