29 Mar, 2011
1 commit
-
Signed-off-by: Thomas Gleixner
19 Feb, 2011
6 commits
-
That's the data structure chip functions get provided. Also allow them
to signal the core code that they updated the flags in irq_data.state
by returning IRQ_SET_MASK_OK_NOCOPY. The default is unchanged.The type bits should be accessed via:
val = irqd_get_trigger_type(irqdata);
and
irqd_set_trigger_type(irqdata, val);Coders who access them directly will be tracked down and slapped with
stinking trouts.Signed-off-by: Thomas Gleixner
-
Keep status in sync until all users are fixed.
Signed-off-by: Thomas Gleixner
-
No users outside of core.
Signed-off-by: Thomas Gleixner
-
Handle IRQ_DISABLED consistent.
Signed-off-by: Thomas Gleixner
-
Create irq_disable/enable and use them to keep the flags consistent.
Signed-off-by: Thomas Gleixner
-
Lars-Peter Clausen pointed out:
I stumbled upon this while looking through the existing archs using
SPARSE_IRQ. Even with SPARSE_IRQ the NR_IRQS is still the upper
limit for the number of IRQs.Both PXA and MMP set NR_IRQS to IRQ_BOARD_START, with
IRQ_BOARD_START being the number of IRQs used by the core.In various machine files the nr_irqs field of the ARM machine
defintion struct is then set to "IRQ_BOARD_START + NR_BOARD_IRQS".As a result "nr_irqs" will greater then NR_IRQS which then again
causes the "allocated_irqs" bitmap in the core irq code to be
accessed beyond its size overwriting unrelated data.The core code really misses a sanity check there.
This went unnoticed so far as by chance the compiler/linker places
data behind that bitmap which gets initialized later on those affected
platforms.So the obvious fix would be to add a sanity check in early_irq_init()
and break all affected platforms. Though that check wants to be
backported to stable as well, which will require to fix all known
problematic platforms and probably some more yet not known ones as
well. Lots of churn.A way simpler solution is to allocate a slightly larger bitmap and
avoid the whole churn w/o breaking anything. Add a few warnings when
an arch returns utter crap.Reported-by: Lars-Peter Clausen
Signed-off-by: Thomas Gleixner
Cc: stable@kernel.org # .37
Cc: Haojian Zhuang
Cc: Eric Miao
Cc: Peter Zijlstra
04 Oct, 2010
3 commits
-
Wrap the old chip function retrigger() until the migration is complete
and the old chip functions are removed.Signed-off-by: Thomas Gleixner
Cc: Peter Zijlstra
LKML-Reference:
Reviewed-by: H. Peter Anvin
Reviewed-by: Ingo Molnar -
Wrap the old chip function enable() until the migration is complete and
the old chip functions are removed.Signed-off-by: Thomas Gleixner
Cc: Peter Zijlstra
LKML-Reference:
Reviewed-by: H. Peter Anvin
Reviewed-by: Ingo Molnar -
Convert all references in the core code to orq, chip, handler_data,
chip_data, msi_desc, affinity to irq_data.*Signed-off-by: Thomas Gleixner
Reviewed-by: Ingo Molnar
09 Aug, 2009
1 commit
-
This takes care of the following entry from Dan's list:
kernel/irq/resend.c +73 check_irq_resend(17) warning: variable derefenced before check 'desc->chip'
Reported-by: Dan Carpenter
Signed-off-by: Bartlomiej Zolnierkiewicz
Cc: Jonathan Corbet
Cc: Eugene Teo
Cc: Julia Lawall
LKML-Reference:
Signed-off-by: Ingo Molnar
16 Oct, 2008
2 commits
-
add CONFIG_HAVE_SPARSE_IRQ to for use condensed array.
Get rid of irq_desc[] array assumptions.Preallocate 32 irq_desc, and irq_desc() will try to get more.
( No change in functionality is expected anywhere, except the odd build
failure where we missed a code site or where a crossing commit itroduces
new irq_desc[] usage. )v2: according to Eric, change get_irq_desc() to irq_desc()
Signed-off-by: Yinghai Lu
Signed-off-by: Ingo Molnar -
at this point nr_irqs is equal NR_IRQS
convert a few easy users from NR_IRQS to dynamic nr_irqs.
v2: according to Eric, we need to take care of arch without generic_hardirqs
Signed-off-by: Yinghai Lu
Signed-off-by: Ingo Molnar
13 Aug, 2007
1 commit
-
Level type interrupts are resent by the interrupt hardware when they are
still active at irq_enable().Suppress the resend mechanism for interrupts marked as level.
Signed-off-by: Thomas Gleixner
Signed-off-by: Linus Torvalds
09 Aug, 2007
1 commit
-
This reverts commit 0fc4969b866671dfe39b1a9119d0fdc7ea0f63e5. It was
always meant to be temporary, but it's generating more useless noise
than anything else, and we probably should never have done it in the
generic kernel (only had the people involved test it on their own).Signed-off-by: Linus Torvalds
02 Aug, 2007
1 commit
-
Marcin Slusarz reported a ne2k-pci "hung network interface" regression.
delayed disable relies on the ability to re-trigger the interrupt in the
case that a real interrupt happens after the software disable was set.
In this case we actually disable the interrupt on the hardware level
_after_ it occurred.On enable_irq, we need to re-trigger the interrupt. On i386 this relies
on a hardware resend mechanism (send_IPI_self()).Actually we only need the resend for edge type interrupts. Level type
interrupts come back once enable_irq() re-enables the interrupt line.I assume that the interrupt in question is level triggered because it is
shared and above the legacy irqs 0-15:17: 12 IO-APIC-fasteoi eth1, eth0
Looking into the IO_APIC code, the resend via send_IPI_self() happens
unconditionally. So the resend is done for level and edge interrupts.
This makes the problem more mysterious.The code in question lib8390.c does
disable_irq();
fiddle_with_the_network_card_hardware()
enable_irq();The fiddle_with_the_network_card_hardware() might cause interrupts,
which are cleared in the same code path again,Marcin found that when he disables the irq line on the hardware level
(removing the delayed disable) the card is kept alive.So the difference is that we can get a resend on enable_irq, when an
interrupt happens during the time, where we are in the disabled region.Signed-off-by: Ingo Molnar
Signed-off-by: Linus Torvalds
07 Oct, 2006
1 commit
-
With the following patch, the ixp4xxdefconfig builds correctly. I'll
test some more configs if I get some time.Signed-off-by: Frederik Deweerdt
Signed-off-by: Linus Torvalds
17 Sep, 2006
1 commit
-
Fix a bug where the IRQ_PENDING flag is never cleared and the ISR is called
endlessly without an actual interrupt.Signed-off-by: Imre Deak
Acked-by: Thomas Gleixner
Acked-by: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
30 Jun, 2006
2 commits
-
Core genirq support: add the irq-chip and irq-flow abstractions.
Signed-off-by: Thomas Gleixner
Signed-off-by: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Enable platforms that do not have a hardware-assisted hardirq-resend mechanism
to resend them via a softirq-driven IRQ emulation mechanism.Signed-off-by: Thomas Gleixner
Signed-off-by: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds