17 Jul, 2007
1 commit
-
Recent breakage..
net/sunrpc/auth_gss/auth_gss.c:1002: warning: implicit declaration of function 'lock_kernel'
net/sunrpc/auth_gss/auth_gss.c:1004: warning: implicit declaration of function 'unlock_kernel'Cc: Trond Myklebust
Cc: "J. Bruce Fields"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
14 Jul, 2007
1 commit
-
* git://git.linux-nfs.org/pub/linux/nfs-2.6: (122 commits)
sunrpc: drop BKL around wrap and unwrap
NFSv4: Make sure unlock is really an unlock when cancelling a lock
NLM: fix source address of callback to client
SUNRPC client: add interface for binding to a local address
SUNRPC server: record the destination address of a request
SUNRPC: cleanup transport creation argument passing
NFSv4: Make the NFS state model work with the nosharedcache mount option
NFS: Error when mounting the same filesystem with different options
NFS: Add the mount option "nosharecache"
NFS: Add support for mounting NFSv4 file systems with string options
NFS: Add final pieces to support in-kernel mount option parsing
NFS: Introduce generic mount client API
NFS: Add enums and match tables for mount option parsing
NFS: Improve debugging output in NFS in-kernel mount client
NFS: Clean up in-kernel NFS mount
NFS: Remake nfsroot_mount as a permanent part of NFS client
SUNRPC: Add a convenient default for the hostname when calling rpc_create()
SUNRPC: Rename rpcb_getport to be consistent with new rpcb_getport_sync name
SUNRPC: Rename rpcb_getport_external routine
SUNRPC: Allow rpcbind requests to be interrupted by a signal.
...
11 Jul, 2007
38 commits
-
Make all initialized struct seq_operations in net/ const
Signed-off-by: Philippe De Muyter
Signed-off-by: David S. Miller -
We don't need the BKL when wrapping and unwrapping; and experiments by Avishay
Traeger have found that permitting multiple encryption and decryption
operations to proceed in parallel can provide significant performance
improvements.Signed-off-by: J. Bruce Fields
Cc: Avishay Traeger
Signed-off-by: Trond Myklebust -
In addition to binding to a local privileged port the NFS client should
allow binding to a specific local address. This is used by the server
for callbacks. The patch adds the necessary interface.Signed-off-by: Frank van Maarseveen
Signed-off-by: Trond Myklebust -
Save the destination address of an incoming request over TCP like is
done already for UDP. It is necessary later for callbacks by the server.Signed-off-by: Frank van Maarseveen
Signed-off-by: Trond Myklebust -
Cleanup argument passing to functions for creating an RPC transport.
Signed-off-by: Frank van Maarseveen
Signed-off-by: Trond Myklebust -
A couple of callers just use a stringified IP address for the rpc client's
hostname. Move the logic for constructing this into rpc_create(), so it can
be shared.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
Clean up, for consistency. Rename rpcb_getport as rpcb_getport_async, to
match the naming scheme of rpcb_getport_sync.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
In preparation for handling NFS mount option parsing in the kernel,
rename rpcb_getport_external as rpcb_get_port_sync, and make it available
always (instead of only when CONFIG_ROOT_NFS is enabled).Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
This allows NFS mount requests and RPC re-binding to be interruptible if the
server isn't responding.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
Convert them into dprintk() calls.
Signed-off-by: Trond Myklebust
-
Do so by set the gc_proc field to RPC_GSS_PROC_DESTROY, and then sending a
NULL RPC call.Signed-off-by: Trond Myklebust
-
Add a refcount in order to ensure that the gss_auth doesn't disappear from
underneath us while we're freeing up GSS contexts.Signed-off-by: Trond Myklebust
-
We should almost always be deferencing the rpc_auth struct by means of the
credential's cr_auth field instead of the rpc_clnt->cl_auth anyway. Fix up
that historical mistake, and remove the macro that propagated it.Signed-off-by: Trond Myklebust
-
RPCSEC_GSS needs to be able to send NULL RPC calls to the server in order
to free up any remaining GSS contexts.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Convert to the use of atomic bitops...
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Add a helper rpc_cred_init()
Signed-off-by: Trond Myklebust
-
Also do the same for gss_api operation tables.
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Does a NULL RPC call and returns a pointer to the resulting rpc_task. The
call may be either synchronous or asynchronous.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
See the FIXME: auth_flavors[] really needs a lock and module refcounting.
Signed-off-by: Trond Myklebust
-
Fix a memory leak in gss_create() whereby the rpc credcache was not being
freed if the rpc_mkpipe() call failed.Signed-off-by: Trond Myklebust
-
We want to set the unix_cred_cache.nextgc on the first call to
unx_create(), which should be when unix_auth.au_count === 1Signed-off-by: Trond Myklebust
-
The leak only affects the RPCSEC_GSS caches, since they are the only ones
that are dynamically allocated...
Rename the existing rpcauth_free_credcache() to rpcauth_clear_credcache()
in order to better describe its role, then add a new function
rpcauth_destroy_credcache() that actually frees the cache in addition to
clearing it out.Also move the call to destroy the credcache in gss_destroy() to come before
the rpc upcall pipe is unlinked.Signed-off-by: Trond Myklebust
-
This allows us to correctly deduce when we need to remove the pipe.
Signed-off-by: Trond Myklebust
-
Add a dentry_ops with a d_delete() method in order to ensure that dentries
are removed as soon as the last reference is gone.Clean up rpc_depopulate() so that it only removes files that were created
via rpc_populate().Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Currently, the downcall queue is tied to the struct gss_auth, which means
that different RPCSEC_GSS pseudoflavours must use different upcall pipes.
Add a list to struct rpc_inode that can be used instead.Signed-off-by: Trond Myklebust
-
It used to be possible for an rpc.gssd daemon to stuff the RPC credential
cache for any rpc client simply by creating RPCSEC_GSS contexts and then
doing downcalls. In practice, no daemons ever made use of this feature.Remove this feature now, since it will be impossible to figure out which
mechanism a given context actually matches if we enable more
than one gss mechanism to use the same upcall pipe.Signed-off-by: Trond Myklebust
-
We're just as well off using the inode spinlock instead.
Signed-off-by: Trond Myklebust
-
Cleans up an issue whereby rpcsec_gss uses the rpc_clnt->cl_auth. If we want
to be able to add several rpc_auths to a single rpc_clnt, then this abuse
must go.Signed-off-by: Trond Myklebust
-
Brian Behlendorf writes:
The root cause of the NFS hang we were observing appears to be a rare
deadlock between the kernel provided usermodehelper API and the linux NFS
client. The deadlock can arise because both of these services use the
generic linux work queues. The usermodehelper API run the specified user
application in the context of the work queue. And NFS submits both cleanup
and reconnect work to the generic work queue for handling. Normally this
is fine but a deadlock can result in the following situation.- NFS client is in a disconnected state
- [events/0] runs a usermodehelper app with an NFS dependent operation,
this triggers an NFS reconnect.
- NFS reconnect happens to be submitted to [events/0] work queue.
- Deadlock, the [events/0] work queue will never process the
reconnect because it is blocked on the previous NFS dependent
operation which will not complete.`The solution is simply to run reconnect requests on rpciod.
Signed-off-by: Trond Myklebust
