15 Oct, 2007
1 commit
-
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds
13 Oct, 2007
1 commit
-
This changes the uevent buffer functions to use a struct instead of a
long list of parameters. It does no longer require the caller to do the
proper buffer termination and size accounting, which is currently wrong
in some places. It fixes a known bug where parts of the uevent
environment are overwritten because of wrong index calculations.Many thanks to Mathieu Desnoyers for finding bugs and improving the
error handling.Signed-off-by: Kay Sievers
Cc: Mathieu Desnoyers
Cc: Cornelia Huck
Signed-off-by: Greg Kroah-Hartman
07 Oct, 2007
1 commit
-
Signed-off-by: Stefan Richter
08 Sep, 2007
1 commit
-
Fixes (papers over) "Sleep problems with kernels >= 2.6.21 on powerpc",
http://lkml.org/lkml/2007/8/25/155. The issue is that the FireWire
controller's pci_dev.current_state of iBook G3 and presumably older
PowerBooks is still in PCI_UNKNOWN instead of PCI_D0 when the firewire
driver's .suspend method is called.Like it was suggested earlier in http://lkml.org/lkml/2006/10/24/13, we
do not fail .suspend anymore if pci_set_power_state failed.Signed-off-by: Stefan Richter
26 Aug, 2007
2 commits
-
This handles the case where we get the status write before getting the
complete_transaction callback ("status write for unknown orb"). In
this case, we just assume that the initial orb pointer transaction
succeeded and finish the orb. To prevent the transaction callback
from touching freed memory, we ref-count the orb structures.Signed-off-by: Kristian Høgsberg
Signed-off-by: Stefan Richter -
Fix panic in run_timer_softirq right after "modprobe -r firewire-ohci"
if a FireWire disk was attached and firewire-sbp2 loaded.Signed-off-by: Stefan Richter
03 Aug, 2007
3 commits
-
Signed-off-by: Stefan Richter
-
Signed-off-by: Stefan Richter
-
As far as I know, all CardBus FireWire 400 adapters have a maximum
payload of 1024 bytes which is less than the speed-dependent limit of
2048 bytes. Fw-sbp2 has to take the host adapter's limit into account.This apparently fixes Juju's incompatibility with my CardBus cards, a
NEC based card and a VIA based card.Signed-off-by: Stefan Richter
Acked-by: Kristian Høgsberg
23 Jul, 2007
1 commit
-
* master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (60 commits)
[SCSI] libsas: make ATA functions selectable by a config option
[SCSI] bsg: unexport sg v3 helper functions
[SCSI] bsg: fix bsg_unregister_queue
[SCSI] bsg: make class backlinks
[SCSI] 3w-9xxx: add support for 9690SA
[SCSI] bsg: fix bsg_register_queue error path
[SCSI] ESP: Increase ESP_BUS_TIMEOUT to 275.
[SCSI] libsas: fix scr_read/write users and update the libata documentation
[SCSI] mpt fusion: update Kconfig help
[SCSI] scsi_transport_sas: add destructor for bsg
[SCSI] iscsi_tcp: buggered kmalloc()
[SCSI] qla2xxx: Update version number to 8.02.00-k2.
[SCSI] qla2xxx: Add ISP25XX support.
[SCSI] qla2xxx: Use pci_try_set_mwi().
[SCSI] qla2xxx: Use PCI-X/PCI-Express read control interfaces.
[SCSI] qla2xxx: Re-factor isp_operations to static structures.
[SCSI] qla2xxx: Validate mid-layer 'underflow' during check-condition handling.
[SCSI] qla2xxx: Correct setting of 'current' and 'supported' speeds during FDMI registration.
[SCSI] qla2xxx: Generalize iIDMA support.
[SCSI] qla2xxx: Generalize FW-Interface-2 support.
...
20 Jul, 2007
1 commit
-
Signed-off-by: Kristian Høgsberg
collapsed with fw-sbp2 patch "Drop cast to non-const char * in host
template initialization." from Kristian HøgsbergSigned-off-by: Stefan Richter
Signed-off-by: James Bottomley
19 Jul, 2007
5 commits
-
Signed-off-by: Stefan Richter
-
Found and debugged by Jay Fenlason .
The bug was especially noticeable with direct I/O over fw-sbp2.Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg -
This check is bogus:
- Maximum asynchronous payload size for S800...S3200 is 4096.
- The p->payload_length is totally uninteresting. Only the
request->length of the subsequently allocated and initialized
struct fw_request is of significance.Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg -
context_stop is called by bus_reset_tasklet, among else.
Signed-off-by: Stefan Richter
-
Signed-off-by: Stefan Richter
10 Jul, 2007
17 commits
-
The CPU must not touch the buffer after it was DMA-mapped.
Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg -
The CPU must not touch the buffer after it was DMA-mapped.
Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg -
- The CPU must not touch the buffer after it was DMA-mapped.
- The size argument of dma_unmap_single(...page_table...) was bogus.
- Move a comment closer to the code to which it refers to.Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg -
Add rudimentary check for the case that the page table overflows due to
merging of s/g elements by the IOMMU. This would have lead to
overwriting of arbitrary memory.After this change I expect that an offending command will be
unsuccessfully retried until the scsi_device is taken offline by SCSI
core. It's a border case and not worth to implement a recovery
strategy.Signed-off-by: Stefan Richter
Acked-by: Kristian Høgsberg -
This is required per SBP-2 clause 5.2.
Signed-off-by: Stefan Richter
Acked-by: Kristian Høgsberg -
Signed-off-by: Stefan Richter
Acked-by: Kristian Høgsberg -
noticed by Jay Fenlason
Signed-off-by: Stefan Richter
Acked-by: Kristian Høgsberg -
Replace a cast with a container_of(). As long as nobody reorders the
structure elements, they do the same thing, but container_of() is more
readable.Signed-off-by: Stefan Richter (added complete_command_orb)
Acked-by: Kristian Høgsberg -
Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg -
This affects of course only the "soft shutdown" case, e.g. "modprobe -r
firewire-sbp2", while it doesn't matter for hot unplug.Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg -
This currently only affects one bridge in the hardwired blacklist.
I don't own one of those, hence haven't tested it.Signed-off-by: Stefan Richter
-
cleanup after "firewire: support S100B...S400B and link slower than PHY"
Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg -
Use a speed probe to determine the speed over 1394b buses and of nodes
which report a link speed less than their PHY speed.Log the effective maximum speed of newly created nodes in dmesg.
Also, read the config ROM (except bus info block) at the maximum speed
rather than S100. This isn't a real optimization though because we
still only use quadlet read requests for the entire ROM.The patch also adds support for S1600 and S3200, although such hardware
does not exist yet.Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg -
Table-based gap count optimization cannot be used if 1394b repeater PHYs
are present. But it does work with 1394b leaf nodes.Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg -
Signed-off-by: Stefan Richter
-
Also remove some errno printouts which will be shown by infrastructure
code anyway.Signed-off-by: Stefan Richter
-
cleanup after support of single-buffer requests was dropped
Signed-off-by: Stefan Richter
Signed-off-by: Kristian Hoegsberg
29 Jun, 2007
2 commits
-
Alas that won't work so good, because nobody reads help texts.
I thought about adding some crude multiple choice selection (build the
old stack, build the new stack, build both stacks). It's possible, but
it would introduce awkward dummy config variables.Signed-off-by: Stefan Richter
-
descriptor.data_address is little endian
Tested-by: Olaf Hering
Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg
21 Jun, 2007
1 commit
-
This patch fixes an OOPS on cdev release for an fd where iso context
creation failed.Signed-off-by: Kristian Høgsberg
Signed-off-by: Stefan Richter
16 Jun, 2007
1 commit
-
Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg
01 Jun, 2007
3 commits
-
The struct is part of the userspace interface and can not use
bitfields. This patch replaces the bitfields with a __u32 'control'
word and provides access macros to set the bits.Signed-off-by: Kristian Høgsberg
Signed-off-by: Stefan Richter -
It's a low-impact design, that just makes suspend/resume look like
a bus reset to the upper level drivers, but it should be sufficient.Signed-off-by: Kristian Høgsberg
Signed-off-by: Stefan Richter -
The attribute /sys/bus/scsi/devices/*:*:*:*/ieee1394_id, as generated by
the old sbp2 driver, is typically used to create persistently named
links in /dev/disk/by-id.Signed-off-by: Stefan Richter
Signed-off-by: Kristian Høgsberg