28 May, 2015
8 commits
-
This patch fixes a bug in the context size calculation where we
were still referring to the old cra_aead.Signed-off-by: Herbert Xu
-
This patch makes use of the new common IV generation code.
Signed-off-by: Herbert Xu
-
As the AD does not necessarily exist in the destination buffer
it must be copied along with the plain text.Signed-off-by: Herbert Xu
-
This patch adds some common IV generation code currently duplicated
by seqiv and echainiv. For example, the setkey and setauthsize
functions are completely identical.Signed-off-by: Herbert Xu
-
This patch tries to preserve in-place processing in old_crypt as
various algorithms are optimised for in-place processing where
src == dst.Signed-off-by: Herbert Xu
-
We need to call sg_init_table as otherwise the first entry may
inadvertently become the last.Signed-off-by: Herbert Xu
-
This patch defines the behaviour of AD in the new interface more
clearly. In particular, it specifies that if the user must copy
the AD to the destination manually when src != dst if they wish
to guarantee that the destination buffer contains a copy of the
AD.The reason for this is that otherwise every AEAD implementation
would have to perform such a copy when src != dst. In reality
most users do in-place processing where src == dst so this is
not an issue.This patch also kills some remaining references to cryptoff.
Signed-off-by: Herbert Xu
-
Merge the crypto tree for 4.1 to pull in the changeset that disables
algif_aead.
27 May, 2015
8 commits
-
Remove the length field from the ccp_sg_workarea since it is unused.
Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
The underlying device support will set the device dma_mask pointer
if DMA is set up properly for the device. Remove the check for and
assignment of dma_mask when it is null. Instead, just error out if
the dma_set_mask_and_coherent function fails because dma_mask is null.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
The CPU Jitter RNG provides a source of good entropy by
collecting CPU executing time jitter. The entropy in the CPU
execution time jitter is magnified by the CPU Jitter Random
Number Generator. The CPU Jitter Random Number Generator uses
the CPU execution timing jitter to generate a bit stream
which complies with different statistical measurements that
determine the bit stream is random.The CPU Jitter Random Number Generator delivers entropy which
follows information theoretical requirements. Based on these
studies and the implementation, the caller can assume that
one bit of data extracted from the CPU Jitter Random Number
Generator holds one bit of entropy.The CPU Jitter Random Number Generator provides a decentralized
source of entropy, i.e. every caller can operate on a private
state of the entropy pool.The RNG does not have any dependencies on any other service
in the kernel. The RNG only needs a high-resolution time
stamp.Further design details, the cryptographic assessment and
large array of test results are documented at
http://www.chronox.de/jent.html.CC: Andreas Steffen
CC: Theodore Ts'o
CC: Sandy Harris
Signed-off-by: Stephan Mueller
Signed-off-by: Herbert Xu -
During initialization, the DRBG now tries to allocate a handle of the
Jitter RNG. If such a Jitter RNG is available during seeding, the DRBG
pulls the required entropy/nonce string from get_random_bytes and
concatenates it with a string of equal size from the Jitter RNG. That
combined string is now the seed for the DRBG.Written differently, the initial seed of the DRBG is now:
get_random_bytes(entropy/nonce) || jitterentropy (entropy/nonce)
If the Jitter RNG is not available, the DRBG only seeds from
get_random_bytes.CC: Andreas Steffen
CC: Theodore Ts'o
CC: Sandy Harris
Signed-off-by: Stephan Mueller
Signed-off-by: Herbert Xu -
The async seeding operation is triggered during initalization right
after the first non-blocking seeding is completed. As required by the
asynchronous operation of random.c, a callback function is provided that
is triggered by random.c once entropy is available. That callback
function performs the actual seeding of the DRBG.CC: Andreas Steffen
CC: Theodore Ts'o
CC: Sandy Harris
Signed-off-by: Stephan Mueller
Signed-off-by: Herbert Xu -
In order to prepare for the addition of the asynchronous seeding call,
the invocation of seeding the DRBG is moved out into a helper function.In addition, a block of memory is allocated during initialization time
that will be used as a scratchpad for obtaining entropy. That scratchpad
is used for the initial seeding operation as well as by the
asynchronous seeding call. The memory must be zeroized every time the
DRBG seeding call succeeds to avoid entropy data lingering in memory.CC: Andreas Steffen
CC: Theodore Ts'o
CC: Sandy Harris
Signed-off-by: Stephan Mueller
Signed-off-by: Herbert Xu -
The added API calls provide a synchronous function call
get_blocking_random_bytes where the caller is blocked until
the nonblocking_pool is initialized.CC: Andreas Steffen
CC: Theodore Ts'o
CC: Sandy Harris
Signed-off-by: Stephan Mueller
Signed-off-by: Herbert Xu -
If more than one application invokes getrandom(2) before the pool
is ready, then all bar one will be stuck forever because we use
wake_up_interruptible which wakes up a single task.This patch replaces it with wake_up_all.
Signed-off-by: Herbert Xu
26 May, 2015
1 commit
-
The newly added AEAD user-space isn't quite ready for prime time
just yet. In particular it is conflicting with the AEAD single
SG list interface change so this patch disables it now.Once the SG list stuff is completely done we can then renable
this interface.Signed-off-by: Herbert Xu
25 May, 2015
13 commits
-
This patch removes the cryptoff parameter now that all users
set it to zero.Signed-off-by: Herbert Xu
-
The cryptoff parameter was added to facilitate the skipping of
IVs that sit between the AD and the plain/cipher text. However,
it was never implemented correctly as and we do not handle users
such as IPsec setting cryptoff. It is simply ignored.Implementing correctly is in fact more trouble than what it's
worth.This patch removes the uses of cryptoff by moving the AD forward
to fill the gap left by the IV. The AD is moved back after the
underlying AEAD processing is finished.This is in fact beter than the cryptoff solution because it allows
algorithms that use seqniv (i.e., GCM and CCM) to hash the whole
packet as a single piece, while cryptoff meant that there was
guaranteed to be a gap.Signed-off-by: Herbert Xu
-
The cryptoff parameter was added to facilitate the skipping of
IVs that sit between the AD and the plain/cipher text. However,
it was never implemented correctly as and we do not handle users
such as IPsec setting cryptoff. It is simply ignored.Implementing correctly is in fact more trouble than what it's
worth.This patch removes the uses of cryptoff and simply falls back
to using the old AEAD interface as it's only needed for old AEAD
implementations.Signed-off-by: Herbert Xu
-
The function aead_geniv_alloc currently sets cra_type even for
new style instances. This is unnecessary and may hide bugs such
as when our caller uses crypto_register_instance instead of the
correct aead_register_instance.Signed-off-by: Herbert Xu
-
New style AEAD instances must use aead_register_instance. This
worked by chance because aead_geniv_alloc is still setting things
the old way.This patch converts the template over to the create model where
we are responsible for instance registration so that we can call
the correct function.Signed-off-by: Herbert Xu
-
New style AEAD instances must use aead_register_instance. This
worked by chance because aead_geniv_alloc is still setting things
the old way.This patch converts the template over to the create model where
we are responsible for instance registration so that we can call
the correct function.Signed-off-by: Herbert Xu
-
Newer templates use tmpl->create and have a NULL tmpl->alloc. So
we must use tmpl->create if it is set.Signed-off-by: Herbert Xu
-
Newer templates use tmpl->create and have a NULL tmpl->alloc. So
we must use tmpl->create if it is set.Signed-off-by: Herbert Xu
-
Signed-off-by: Fengguang Wu
Signed-off-by: Herbert Xu -
The mv_cesa driver does not request the CESA registers memory region.
Since we're about to add a new CESA driver, we need to make sure only one
of these drivers probe the CESA device, and requesting the registers memory
region is a good way to achieve that.Signed-off-by: Boris Brezillon
Signed-off-by: Herbert Xu -
The variable tfm_count is accessed by multiple threads without
locking. This patch converts it to an atomic_t.Signed-off-by: Herbert Xu
-
AEAD algorithm implementors need to figure out a given algorithm's
IV size and maximum authentication size. During the transition
this is difficult to do as an algorithm could be new style or old
style.This patch creates two helpers to make this easier.
Signed-off-by: Herbert Xu
-
Signed-off-by: Harald Freudenberger
Signed-off-by: Herbert Xu
22 May, 2015
10 commits
-
This patch adds a new AEAD IV generator echainiv. It is intended
to replace the existing skcipher IV generator eseqiv.If the underlying AEAD algorithm is using the old AEAD interface,
then echainiv will simply use its IV generator.Otherwise, echainiv will encrypt a counter just like eseqiv but
it'll first xor it against a previously stored IV similar to
chainiv.Signed-off-by: Herbert Xu
-
This patch adds a new IV generator seqniv which is identical to
seqiv except that it skips the IV when authenticating. This is
intended to be used by algorithms such as rfc4106 that does the
IV authentication implicitly.Note that the code used for seqniv is in fact identical to the
compatibility case for seqiv.Signed-off-by: Herbert Xu
-
This patch converts the seqiv IV generator to work with the new
AEAD interface where IV generators are just normal AEAD algorithms.Full backwards compatibility is paramount at this point since
no users have yet switched over to the new interface. Nor can
they switch to the new interface until IV generation is fully
supported by it.So this means we are adding two versions of seqiv alongside the
existing one. The first one is the one that will be used when
the underlying AEAD algorithm has switched over to the new AEAD
interface. The second one handles the current case where the
underlying AEAD algorithm still uses the old interface.Both versions export themselves through the new AEAD interface.
Signed-off-by: Herbert Xu
-
This patch adds a check for in scatterwalk_map_and_copy to avoid
copying from the same address to the same address. This is going
to be used for IV copying in AEAD IV generators.There is no provision for partial overlaps.
This patch also uses the new scatterwalk_ffwd instead of doing
it by hand in scatterwalk_map_and_copy.Signed-off-by: Herbert Xu
-
This patch makes gcm use the default null skcipher instead of
allocating a new one for each tfm.Signed-off-by: Herbert Xu
-
This patch adds a default null skcipher for users such as gcm
to perform copies on SG lists.Signed-off-by: Herbert Xu
-
This patch adds the basic structure of the new AEAD type. Unlike
the current version, there is no longer any concept of geniv. IV
generation will still be carried out by wrappers but they will be
normal AEAD algorithms that simply take the IPsec sequence number
as the IV.Signed-off-by: Herbert Xu
-
The crypto layer already checks maxauthsize when setauthsize is
called. So there is no need to check it again within setauthsize.Signed-off-by: Herbert Xu
-
This patch uses the helper crypto_aead_maxauthsize instead of
directly dereferencing aead_alg.Signed-off-by: Herbert Xu
-
This patch adds the helper crypto_aead_maxauthsize to remove the
need to directly dereference aead_alg internals by AEAD implementors.Signed-off-by: Herbert Xu