31 Aug, 2008
4 commits
-
cisinfo_t and cs_status_t are only used by the (deprecated) PCMCIA
ioctl. Therefore, move them out of the way.Signed-off-by: Dominik Brodowski
-
16-bit PCMCIA device handling function definitions are moved to ds.h.
Signed-off-by: Dominik Brodowski
-
Since we're just parsing the tuple being passed to this function, we don't
need any device-specific information.Also, remove the call to pcmcia_validate_cis() from pcmciamtd.c, since it
is already called by the PCMCIA core.Signed-off-by: Dominik Brodowski
-
16-bit PCMCIA device handling function definitions are moved to ds.h,
internal definitions to cs_internal.h.Signed-off-by: Dominik Brodowski
29 Aug, 2008
3 commits
-
Wrap in #ifdef to include header just once, and wrap in another #ifdef
to avoid it being used in userspace. Also, format the header similar to
the other PCMCIA header files.Signed-off-by: Dominik Brodowski
-
By now, ioaddr_t should only be used by the deprecated ioctl, as it does not
correctly reflect the maximum ioport range at least on some architectures.Signed-off-by: Dominik Brodowski
-
The header file primarily used for (in-kernel) PCMCIA device drivers
also deserved a major cleanup. This header file also serves as the dumping
ground for all typedefs and definitions only used by the deprecated PCMCIA
ioctl and the deprecated PCMCIA userspace tools using this ioctl.Signed-off-by: Dominik Brodowski
26 Aug, 2008
1 commit
-
The header file for use by (in-kernel) PCMCIA sockets deserved a major
cleanup. Some stuff only used by the pcmcia core modules was moved to
cs_internal.hSigned-off-by: Dominik Brodowski
23 Aug, 2008
22 commits
-
Use dev_printk() in cs_error()-based error reporting. While this
function-turned-macro will hopefully go away soon, using dev_printk
simplifies the code much.Signed-off-by: Dominik Brodowski
-
Remoe the CS_ error codes. Drivers are expected to use default
error definitions (errno.h etc.).Only one CS_ error code -- CS_IN_USE -- is used internally by the
(deprecated) pcmcia-cs userspace package. Therefore, keep this one
around so that it still compiles.Signed-off-by: Dominik Brodowski
-
CS_BAD_TUPLE was used to denote a bad tuple being passed to the parse
function. Therefore, replace it with -EINVAL and a verbose message.Signed-off-by: Dominik Brodowski
-
CS_BAD_ARGS mean a badly written driver or invalid userspace ioctl access,
so translate that to -EINVAL.Signed-off-by: Dominik Brodowski
-
These four error values mostly mean a badly written driver, so ds_dbg()
output and -EINVAL seems to be enough.Signed-off-by: Dominik Brodowski
-
CS_BAD_TYPE was only used in cs.c and already properly annotated by error
messages. CS_BAD_ATTRIBUTE and CS_BAD_PAGE mean a badly written driver, so
ds_dbg() output and -EINVAL seems to be enough.(includes bugfix from and
Signed-off-by: Harvey Harrison
)
Signed-off-by: Dominik Brodowski -
CS_NO_MORE_ITEMS is returned by the CIS tuple reading and parsing code if
the end of a tuple chain is reached. As at least one PCMCIA driver relies
on matching this return value, replace it with -ENOSPC which is now
uniquely used for this purpose within the in-kernel pcmcia subsystem.CC: Russell King
CC: linux-serial@vger.kernel.org
CC: Michael Buesch
Signed-off-by: Dominik Brodowski -
If a resource is already in use, mark it with -EBUSY. Same for cards already
asleep.(includes a fix for a bug found by Larry Finger -- thanks!)
Signed-off-by: Dominik Brodowski -
This error code meant that trying to change the configuration after the
initialization phase is forbidden.Signed-off-by: Dominik Brodowski
-
CS_BAD_HANDLE means that something went badly wrong: no parameter was passed,
or the paramater passed wasn't the correct one. Therefore, replace it with
-EINVAL.Signed-off-by: Dominik Brodowski
-
It's only used by pcmcia_core when socket-related queries time out.
Signed-off-by: Dominik Brodowski
-
It means that no card can be detected in the socket, so return -ENODEV
Signed-off-by: Dominik Brodowski
-
They were either used to report that changing voltage is not allowed, or that
changing voltage failed.Signed-off-by: Dominik Brodowski
-
CS_UNSUPPORTED_MODE and CS_UNSUPPORTED_FUNCTION were mostly used to denote
trying to use PCMCIA functions on CardBus cards.Signed-off-by: Dominik Brodowski
-
CS_OUT_OF_RESOURCE was almost only used to note -ENOMEM situations.
Therefore, use -ENOMEM explicitely, and also print out warnings.CC: netdev@vger.kernel.org
Signed-off-by: Dominik Brodowski -
Deprecate unused CS_ error codes by replacing their definitions with
generic error messages, and removing them from the error_t lookup table.Signed-off-by: Dominik Brodowski
-
Signed-off-by: Dominik Brodowski
-
With the PCMCIA ioctl being the only remaining user of
_get_configuration_info, move the function to pcmcia_ioctl.cSigned-off-by: Dominik Brodowski
-
* pcmcia-config-loop:
pcmcia: pcmcia_config_loop() improvement by passing vcc
pcmcia: pcmcia_config_loop() default CIS entry handling
pcmcia: pcmcia_config_loop() ConfigIndex unification
pcmcia: use pcmcia_loop_config in misc pcmcia drivers
pcmcia: use pcmcia_loop_config in net pcmcia drivers
pcmcia: use pcmcia_loop_config in ISDN pcmcia drivers
pcmcia: use pcmcia_loop_config in scsi pcmcia drivers
pcmcia: use pcmcia_loop_config in bluetooth drivers
pcmcia: use pcmcia_loop_config in pata and ide drivers
pcmcia: add pcmcia_loop_config() helper* pcmcia-printk:
pcmcia: don't add extra DEBUG cflag
pcmcia: remove unused cs_socket_name() definition
pcmcia: use dev_printk in module rsrc_nonstatic
pcmcia: use dev_printk in module pcmcia
pcmcia: use dev_printk in module pcmcia_core
pcmcia: use dev_printk and dev_dbg in yenta_socket -
By passing the current Vcc setting to the pcmcia_config_loop callback
function, we can remove pcmcia_get_configuration_info() calls from many
drivers.Signed-off-by: Dominik Brodowski
-
Many drivers use the default CIS entry within their pcmcia_config_loop()
callback function. Therefore, factor the default CIS entry handling out.Signed-off-by: Dominik Brodowski
-
By calling pcmcia_loop_config(), a pcmcia driver can iterate over all
available configuration options. During a driver's probe() phase, one
doesn't need to use pcmcia_get_{first,next}_tuple, pcmcia_get_tuple_data
and pcmcia_parse_tuple directly in most if not all cases.Signed-off-by: Dominik Brodowski
03 Aug, 2008
1 commit
-
Instead of copying CIS override data in socket_sysfs.c or ds.c, and then again
in cistpl.c, only do so once. Also, cisdump_t is now only used by the
deprecated ioctl.Signed-off-by: Dominik Brodowski
24 Jun, 2008
8 commits
-
Except for one debug message in a driver marked BROKEN, pcmcia_get_status is
only used by the ioctl. Therefore, move it to pcmcia_ioctl.c and unexport it.Signed-off-by: Dominik Brodowski
-
pcmcia: Remove unused header file code
Signed-off-by: Magnus Damm
Signed-off-by: Dominik Brodowski -
The code in include/pcmcia/bulkmem.h was only kept for compatibility reasons.
Therefore, move the remaining region_info_t definition to ds.h[linux@dominikbrodowski.net: do not modify the IOCTL, move definition to
ds.h, and update changelog]
Signed-off-by: Magnus Damm
Signed-off-by: Dominik Brodowski -
As cisinfo_t only contains one unsigned_int, pccard_validate_cis can
be simplified by passing that around directly.Signed-off-by: Dominik Brodowski
-
Let pcmcia_ioctl interact with rsrc_nonstatic using functions which
rsrc_nonstatic.c has to use anyway.Signed-off-by: Dominik Brodowski
-
A new host driver to add CompactFlash PCMCIA support for Blackfin.
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Michael Hennerich
Signed-off-by: Bryan Wu
Cc: Mike Frysinger
Signed-off-by: Andrew Morton
Signed-off-by: Dominik Brodowski -
pcmcia/version.h is empty and its existence is not even needed by
deprecated userspace tools.CC: David Sterba
Signed-off-by: Jiri Kosina
Signed-off-by: Dominik Brodowski -
There is not reason to have a waitqueue if it's always the same
thread that is waiting for it. Just use wake_up_process instead.Signed-off-by: Christoph Hellwig
Small modification: Also remove unused variable.
Signed-off-by: Dominik Brodowski
06 Feb, 2008
1 commit
-
Remove kio_addr_t, and replace it with unsigned int. No known architecture
needs more than 32 bits for IO addresses and ports and having a separate type
for it is just messy.Signed-off-by: Olof Johansson
Cc: Christoph Hellwig
Cc: Matthew Wilcox
Cc: Alan Cox
Cc: Dominik Brodowski
Cc: Benjamin Herrenschmidt
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
