01 Feb, 2008

12 commits

  • Fix section mismatches in mts64 by making a static variable __devinitdata.
    WARNING: vmlinux.o(.data+0x2e33f0): Section mismatch: reference to .init.data:mts64_ctl_smpte_switch (between 'control.19929' and 'snd_mts64_rawmidi_output_ops')
    WARNING: vmlinux.o(.data+0x2e33f8): Section mismatch: reference to .init.data:mts64_ctl_smpte_time_hours (between 'control.19929' and 'snd_mts64_rawmidi_output_ops')
    WARNING: vmlinux.o(.data+0x2e3400): Section mismatch: reference to .init.data:mts64_ctl_smpte_time_minutes (between 'control.19929' and 'snd_mts64_rawmidi_output_ops')
    WARNING: vmlinux.o(.data+0x2e3408): Section mismatch: reference to .init.data:mts64_ctl_smpte_time_seconds (between 'control.19929' and 'snd_mts64_rawmidi_output_ops')
    WARNING: vmlinux.o(.data+0x2e3410): Section mismatch: reference to .init.data:mts64_ctl_smpte_time_frames (between 'control.19929' and 'snd_mts64_rawmidi_output_ops')
    WARNING: vmlinux.o(.data+0x2e3418): Section mismatch: reference to .init.data:mts64_ctl_smpte_fps (between 'control.19929' and 'snd_mts64_rawmidi_output_ops')

    Signed-off-by: Randy Dunlap
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Randy Dunlap
     
  • This header file exists only for some hacks to adapt alsa-driver
    tree. It's useless for building in the kernel. Let's move a few
    lines in it to sound/core.h and remove it.
    With this patch, sound/driver.h isn't removed but has just a single
    compile warning to include it. This should be really killed in
    future.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • The functions time_before, time_before_eq, time_after, and time_after_eq
    are more robust for comparing jiffies against other values.
    A simplified version of the semantic patch making this change is as follows:
    (http://www.emn.fr/x-info/coccinelle/)
    //
    @ change_compare_np @
    expression E;
    @@
    (
    - jiffies = E
    + time_after_eq(jiffies,E)
    |
    - jiffies < E
    + time_before(jiffies,E)
    |
    - jiffies > E
    + time_after(jiffies,E)
    )
    @ include depends on change_compare_np @
    @@
    #include
    @ no_include depends on !include && change_compare_np @
    @@
    #include
    + #include
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Julia Lawall
     
  • Signed-off-by: Joe Perches
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Joe Perches
     
  • Added the missing call of snd_card_set_dev() in drivers/*

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • Check the value ranges in ctl put callbacks properly (in the rest drivers).

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • Check the value ranges in ctl put callbacks in vxpocket driver.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • We have to do fairly accurate counting of the minimal periods, instead
    of being lazy and just setting the number to zero as soon as one period
    elapses.

    Signed-off-by: Joachim Foerster
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Joachim Foerster
     
  • Add ALSA support for the opb_ac97_controller_ref_v1_00_a ip core found
    in Xilinx' ML403 reference design.
    Known issue: Currently this driver hits a WARN_ON_ONCE(1) statement in
    kernel/irq/resend.c (line 70). According to Linus
    (http://lkml.org/lkml/2007/8/5/5) this may be ignored, right? I haven't
    had a look into this 'problem' yet.

    Signed-off-by: Joachim Foerster
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Joachim Foerster
     
  • I applied a wrong patch for 'opl3 - simplify exclusive access lock'.
    Fixed now.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • Use the exclusive access lock in hwdep instead of the own one.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • Use the hwdep device for loading OPL2/3 patch data instead of the
    messy sequencer instrument layer.
    Due to this change, the sbiload program should be updated, too.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

21 Nov, 2007

1 commit

  • Reported by Ingo Molnar,
    when booting an allyesconfig bzImage kernel the bootup hangs in the
    portman2x4 driver (on a box that does not have this hardware), at:
    Pid: 1, comm: swapper
    EIP: 0060:[] CPU: 0
    EIP is at parport_pc_read_status+0x4/0x8
    EFLAGS: 00000202 Not tainted (2.6.23-rc9 #904)
    EAX: f7e57a7f EBX: 00000010 ECX: c2b808c0 EDX: 00000379
    ESI: f7cb8230 EDI: 00000010 EBP: f7cb8230 DS: 007b ES: 007b FS: 0000
    CR0: 8005003b CR2: fff9c000 CR3: 007ec000 CR4: 00000690
    DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
    DR6: ffff0ff0 DR7: 00000400
    [] portman_flush_input+0xde/0x12c
    [] snd_portman_probe+0x368/0x484
    [] __device_attach+0x0/0x8
    [] platform_drv_probe+0xc/0x10
    [] driver_probe_device+0x74/0x194
    [] klist_next+0x38/0x70
    [] __device_attach+0x0/0x8
    [] bus_for_each_drv+0x35/0x68
    [] device_attach+0x72/0x78
    the reason is due to an inconsistent error return code of 1 or 2, while
    snd_portman_probe only realizes negative error codes.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

20 Nov, 2007

1 commit


24 Oct, 2007

1 commit


20 Oct, 2007

1 commit


16 Oct, 2007

5 commits


20 Jul, 2007

3 commits

  • FIx section mismatch when CONFIG_HOTPLUG=n:
    WARNING: sound/built-in.o(.exit.text+0x271): Section mismatch: reference to .init.text:snd_p
    ortman_unregister_all (between 'snd_portman_module_exit' and 'alsa_mpu401_uart_exit')

    Signed-off-by: Randy Dunlap
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Randy Dunlap
     
  • Something about __init_or_module isn't working as expected (?).
    CONFIG_HOTPLUG=y
    CONFIG_MODULES=n
    Fix shared init/exit code helper:
    WARNING: sound/built-in.o(.exit.text+0x243): Section mismatch: reference to .init.text: (between 'alsa_card_mpu401_exit' and 'ac97_bus_exit')
    WARNING: sound/built-in.o(.exit.text+0x21b): Section mismatch: reference to .init.text: (between 'alsa_card_dummy_exit' and 'alsa_card_serial_exit')

    Signed-off-by: Randy Dunlap
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Randy Dunlap
     
  • Fix shared init/exit function attributes:
    WARNING: sound/built-in.o(.exit.text+0x4a1): Section mismatch: reference to .init.text: (between 'alsa_card_virmidi_exit' and 'alsa_card_serial_exit')
    WARNING: sound/built-in.o(.exit.text+0x4c1): Section mismatch: reference to .init.text: (between 'alsa_card_serial_exit' and 'ac97_bus_exit')

    Signed-off-by: Randy Dunlap
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Randy Dunlap
     

02 Jul, 2007

1 commit

  • Fix section mismatch warnings:

    WARNING: sound/built-in.o(.exit.text+0x3ad): Section mismatch: reference to .init.text: (between 'sb_exit' and 'unload_uart6850')
    WARNING: sound/built-in.o(.exit.text+0x753): Section mismatch: reference to .init.text: (between 'snd_mts64_module_exit' and 'snd_portman_module_exit')

    Signed-off-by: Randy Dunlap
    Cc: Jaroslav Kysela
    Cc: Takashi Iwai
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

11 May, 2007

3 commits

  • Add MODULE_FIRMWARE() entries, where appropriate.

    Signed-off-by: Clemens Ladisch
    Signed-off-by: Jaroslav Kysela

    Clemens Ladisch
     
  • The platform_device allocated by platform_device_alloc()
    should be added to the device hierarchy by platform_device_add()
    instead of platform_device_register().
    Otherwise it will hit WARN_ON() in platform_device_register().
    by illegal refcount.
    This patch fixes such incorrect usages in portman2x4 and mts64 drivers.
    Also it removes unnecessary trailing whitespaces.

    Signed-off-by: Akinobu Mita
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Akinobu Mita
     
  • Added MPU401_INFO_UART_ONLY bitflag to avoid issueing UART_ENTER command
    at opening streams. Some devices support only UART mode and give errors
    to UART_ENTER.
    A new module option, uart_enter, is added to snd-mpu401 driver.
    For UART-only devices, set uart_enter=0.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

15 Feb, 2007

2 commits

  • * 'linus' of master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa:
    [ALSA] version 1.0.14rc2
    [ALSA] Fix a typo in __dev* changes in portman2x4.c
    [ALSA] Change AT91 PDC register defines for 2.6.20 kernel
    [ALSA] SoC codecs - fix Kconfig - depends -> depends on
    [ALSA] Fix __devinit and __devexit issues with sound drivers
    [ALSA] hda-codec - Patch for enabling LFE on more Dell laptops
    [ALSA] hda-codec - More fixes for Conexant HD Audio support
    [ALSA] usb-audio: add PCR-A PCM support
    [ALSA] emu10k1: fix typo
    [ALSA] usbaudio - remove urb->bandwidth reference
    [ALSA] ac97 - Fix silent output problem with Cx20551 codec
    [ALSA] hda-codec - Fix Oops with probing sigmatel codec chips

    Linus Torvalds
     
  • After Al Viro (finally) succeeded in removing the sched.h #include in module.h
    recently, it makes sense again to remove other superfluous sched.h includes.
    There are quite a lot of files which include it but don't actually need
    anything defined in there. Presumably these includes were once needed for
    macros that used to live in sched.h, but moved to other header files in the
    course of cleaning it up.

    To ease the pain, this time I did not fiddle with any header files and only
    removed #includes from .c-files, which tend to cause less trouble.

    Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
    arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
    allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
    configs in arch/arm/configs on arm. I also checked that no new warnings were
    introduced by the patch (actually, some warnings are removed that were emitted
    by unnecessarily included header files).

    Signed-off-by: Tim Schmielau
    Acked-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tim Schmielau
     

14 Feb, 2007

2 commits

  • Fix a typo in the last __dev* changes in portman2x4.c.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • Fix __devinit and __devexit issues with sound drivers.
    Resolves MODPOST warnings similar to:
    WARNING: sound/drivers/snd-dummy.o - Section mismatch: reference to .init.text:snd_dummy_probe from .data.rel.local between 'snd_dummy_driver' (at offset 0x0) and 'snd_dummy_controls'
    WARNING: sound/drivers/snd-mtpav.o - Section mismatch: reference to .init.text:snd_mtpav_probe from .data.rel.local between 'snd_mtpav_driver' (at offset 0x0) and 'snd_mtpav_input'
    WARNING: sound/drivers/snd-virmidi.o - Section mismatch: reference to .init.text:snd_virmidi_probe from .data.rel.local after 'snd_virmidi_driver' (at offset 0x0)

    Signed-off-by: Prarit Bhargava
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Prarit Bhargava
     

09 Feb, 2007

3 commits


13 Dec, 2006

1 commit


05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

25 Sep, 2006

1 commit


23 Sep, 2006

2 commits