14 May, 2011

11 commits


13 May, 2011

5 commits


12 May, 2011

6 commits


11 May, 2011

3 commits


10 May, 2011

15 commits

  • Use the current logging styles.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     
  • Convert logging messages to more current styles.

    Added -DDEBUG to Makefile to maintain current message logging.
    This could be converted to a specific CONFIG_TULIP_DEBUG option.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     
  • Use the current more descriptive logging styles.

    Add pr_fmt and remove PFX where appropriate.
    Use netif_, netdev_
    Indent a few blocks in xircom_cb where appropriate.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     
  • Change the blocks that are guarded by #if DEBUG to
    be #if defined DEBUG && DEBUG > 1 so that pr_debug
    can be used later.

    Remove enter/leave macros and uses.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     
  • David S. Miller
     
  • Support new device OKI SEMICONDUCTOR ML7223 IOH(Input/Output Hub).
    The ML7223 IOH is for MP(Media Phone) use.
    The ML7223 is companion chip for Intel Atom E6xx series.
    The ML7223 is completely compatible for Intel EG20T PCH.

    Signed-off-by: Tomoya MORINAGA
    Signed-off-by: David S. Miller

    Tomoya
     
  • mac_pton() parses MAC address in form XX:XX:XX:XX:XX:XX and only in that form.

    mac_pton() doesn't dirty result until it's sure string representation is valid.

    mac_pton() doesn't care about characters _after_ last octet,
    it's up to caller to deal with it.

    mac_pton() diverges from 0/-E return value convention.
    Target usage:

    if (!mac_pton(str, whatever->mac))
    return -EINVAL;
    /* ->mac being u8 [ETH_ALEN] is filled at this point. */
    /* optionally check str[3 * ETH_ALEN - 1] for termination */

    Use mac_pton() in pktgen and netconsole for start.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: David S. Miller

    Alexey Dobriyan
     
  • Signed-off-by: Alexey Dobriyan
    Signed-off-by: David S. Miller

    Alexey Dobriyan
     
  • Pull read_lock(&bond->lock) and BOND_IS_OK() to bond_start_xmit() from
    mode-dependent xmit functions.

    netif_running() is always true in hard_start_xmit.

    Signed-off-by: Michał Mirosław
    Signed-off-by: David S. Miller

    Michał Mirosław
     
  • Unknown 8168 chips did not have any PLL power method set as they
    did not inherit a default family soon enough. Fix it.

    Signed-off-by: Francois Romieu
    Cc: Realtek linux nic maintainers

    Francois Romieu
     
  • - RTL_GIGA_MAC_NONE is a fake index so put it at the end of the
    enumeration and shift everybody.
    - RTL_GIGA_MAC_VER_17 / RTL_GIGA_MAC_VER_16 ordering fixed. Though
    not wrong it was confusing enough to wonder if things were right.

    Renaming rtl_chip_info was not strictly necessary. It allows to
    check the patch for the correct use of the indexes though.

    Signed-off-by: Francois Romieu
    Cc: Realtek linux nic maintainers

    Francois Romieu
     
  • There is no real firmware version yet but the manpage of ethtool
    is rather terse about the driver information.

    Former output:
    $ ethtool -i eth1
    driver: r8169
    version: 2.3LK-NAPI
    firmware-version:
    bus-info: 0000:01:00.0
    $ ethtool -i eth0
    driver: r8169
    version: 2.3LK-NAPI
    firmware-version:
    bus-info: 0000:03:00.0

    Current output:
    $ ethtool -i eth1
    driver: r8169
    version: 2.3LK-NAPI
    firmware-version: N/A
    bus-info: 0000:01:00.0

    $ ethtool -i eth0
    driver: r8169
    version: 2.3LK-NAPI
    firmware-version: rtl_nic/rtl8168d-1.fw
    bus-info: 0000:03:00.0

    Signed-off-by: Francois Romieu
    Fixed-by Ciprian Docan
    Cc: Realtek linux nic maintainers
    Cc: Fejes József
    Cc: Borislav Petkov

    Francois Romieu
     
  • Invocation of rtl8169_rx_interrupt from rtl8169_reset_task was originally
    intended to retrieve as much packets as possible from the rx ring when a
    reset was needed. Nowadays rtl8169_reset_task is only scheduled, with
    some delay
    a. from the tx timeout watchdog
    b. when resuming
    c. from rtl8169_rx_interrupt itself

    It's dubious that the loss of outdated packets will matter much for a)
    and b). c) does not need to call itself again.

    Signed-off-by: Francois Romieu
    Cc: Realtek linux nic maintainers

    Francois Romieu
     
  • The implementation was a bit krusty.

    The 10s rtl8169_phy_timer timer has been (was ?) required with older
    8169 for adequate phy operation when full gigabit is advertised in
    autonegotiated mode. The timer does nothing if the link is up.
    Otherwise it keeps resetting the phy until things improve.

    - the device private data field phy_1000_ctrl_reg was used to
    schedule the timer. Avoid it and save a few bytes.

    - rtl8169_set_settings
    pending timer is disabled before changing the link settings as
    rtl8169_phy_timer is not always needed (see the removed test in
    rtl8169_phy_timer).

    - rtl8169_set_speed
    the requested link parameters may not match the chipset : bail out
    early on failure.

    - rtl8169_open
    Calling rtl8169_request_timer is redundant with
    -> rtl8169_open
    -> rtl8169_init_phy
    -> rtl8169_set_speed
    -> mod_timer
    The latter always enables the phy timer whereas the former did not
    for RTL_GIGA_MAC_VER_01. It should not make things worse but only
    time will tell if reality agrees.

    - rtl8169_request_timer : unused yet. Removed.

    - rtl8169_delete_timer : useless. Bloat. Removed.

    Side effect : the timer may kick in if the TBI is enabled. I do not
    know if the TBI has ever been used in real life.

    Signed-off-by: Francois Romieu
    Cc: Realtek linux nic maintainers

    Francois Romieu
     
  • Shorten chipset version test.

    No functional change.

    Careful readers will notice that the 'supports_gmii' flag is deduced
    from the device PCI id. Though less specific than the chipset related
    RTL_GIGA_MAC_VER_XY, it is good enough to detect a GMII deprieved 810x.
    Some features push for a device specific configuration (improved jumbo
    frame support for instance). 'supports_gmii' will follow this path
    if / when the device PCI id test stops working.

    Signed-off-by: Francois Romieu
    Cc: Realtek linux nic maintainers

    Francois Romieu