14 May, 2011
11 commits
-
-Wunused-but-set-variable generates compile warnings. The affected
variables are removed.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
-Wunused-but-set-variable generates a compile warning for lcs' tasklet
function. Invoked functions contain already error handling; thus
additional return code checking is not needed here.Signed-off-by: Heiko Carstens
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
Remove unused return code handling. The claw driver is mostly dead, so
just make sure it keeps compiling without warnings.Signed-off-by: Heiko Carstens
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
Fill in the owner of qeth's ccw device driver.
Signed-off-by: Sebastian Ott
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
This patch improves FFDC (first failure data capture) by requesting
a hardware trace in case the device driver, the hardware or a user
detects an error.Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
Set rx csum default to hw checksumming again.
Remove sysfs interface for rx csum (checksumming) and TSO (large_send).
With the new hw_features it does not work to keep the old sysfs
interface in parallel. Convert options.checksum_type to new hw_features.Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
Update driver version number
Signed-off-by: Anirban Chakraborty
Signed-off-by: David S. Miller -
Driver checks if the previous dump has been cleared before taking the dump.
It doesn't take the dump if it is not cleared.Changes from v2:
Added lock to protect dump data structures from being mangled while
dumping or setting them via ethtool.Signed-off-by: Anirban Chakraborty
Signed-off-by: David S. Miller -
Added code to take FW dump.
o Driver queries FW at the init time and gets the dump template
o It takes FW dump as per the dump template
o Level of FW dump (and its size) is configured via dump flagSigned-off-by: Sritej Velaga
Signed-off-by: Anirban Chakraborty
Signed-off-by: David S. Miller -
Sending mbox cmds require multiple steps of writing to the DB register and polling
for an ack. Gettting interrupted in the middle by a signal breaks the mbox protocol.
Use msleep() to not get interrupted.Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
If waiting on POST returns prematurely (due to a signal), abort polling and return an error.
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller
13 May, 2011
5 commits
-
This should also fix updating of vlan_features and propagating changes to
VLAN devices on the bond.Side effect: it allows user to force-disable some offloads on the bond
interface.Note: NETIF_F_VLAN_CHALLENGED is managed by bond_fix_features() now.
Signed-off-by: Michał Mirosław
Signed-off-by: David S. Miller -
Changes:
- while making NTB, driver shall check if device dwNtbOutMaxSize is higher than
host value and shall add a short packet if this is the case
- previous temporary patch for this issue is replaced by this oneSigned-off-by: Alexey Orishko
Signed-off-by: David S. Miller -
This patch adds tg3_set_features() to handle loopback mode. Currently the
capability is added for the devices which support internal MAC loopback mode.
So when enabled, it enables internal-MAC loopback.Signed-off-by: Mahesh Bandewar
Signed-off-by: David S. Miller -
Resending this patch with few changes.
Avoid multiple queues when MSI or MSI-X not available
Limit number of Tx queues to 1 if MSI/MSI-X support is not configured in
the kernel. This will make number of tx and rx queues equal when MSI/X
is not configured thus providing better performance.Signed-off-by: Bhavesh Davda
Signed-off-by: Shreyas N Bhatewara
Signed-off-by: David S. Miller
12 May, 2011
6 commits
-
Start/stop TX queue is controlled by TX queue "used" counter.
It is incremented while WRBs are posted to TX queue and
decremented when TX completions are received. This counter was
getting decremented before HW is informed about processing of TX
completions. As used counter is decremented, transmit function
posts new WRBs and creates completion queue full scenario in HW.Signed-off-by: Padmanabh Ratnakar
Signed-off-by: David S. Miller -
Use OPCODE_COMMON_NTWK_RX_FILTER command for promiscous mode as
OPCODE_ETH_PROMISCUOUS command is getting deprecated.Signed-off-by: Padmanabh Ratnakar
Signed-off-by: David S. Miller -
In case of UE, do not dump registers for Lancer as they are not
supported.Signed-off-by: Padmanabh Ratnakar
Signed-off-by: David S. Miller -
Disable coalesce water mark mode of CQ for Lancer
Signed-off-by: Padmanabh Ratnakar
Signed-off-by: David S. Miller -
In Lancer if a frame is DMAed partially due to lack of RX buffers,
an error completion is sent with packet size as zero and num_recvd
indicating number of used buffers. These buffers need to be freed
and packet dropped.Signed-off-by: Padmanabh Ratnakar
Signed-off-by: David S. Miller -
Conflicts:
drivers/net/benet/be_main.c
11 May, 2011
3 commits
-
TTY layer expects 0 if the ldisc->open operation succeeded.
Reported-by: Matvejchikov Ilya
Signed-off-by: Oliver Hartkopp
Signed-off-by: David S. Miller -
Like other mobile broadband device ethernet interfaces, mark the LG
VL600 with the 'wwan' devtype so userspace knows it needs additional
configuration via the AT port before the interface can be used.Signed-off-by: Dan Williams
Signed-off-by: David S. Miller -
Use an explicit flow key and fetch it from there.
Signed-off-by: David S. Miller
10 May, 2011
15 commits
-
Use the current logging styles.
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Convert logging messages to more current styles.
Added -DDEBUG to Makefile to maintain current message logging.
This could be converted to a specific CONFIG_TULIP_DEBUG option.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Use the current more descriptive logging styles.
Add pr_fmt and remove PFX where appropriate.
Use netif_, netdev_
Indent a few blocks in xircom_cb where appropriate.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Change the blocks that are guarded by #if DEBUG to
be #if defined DEBUG && DEBUG > 1 so that pr_debug
can be used later.Remove enter/leave macros and uses.
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Support new device OKI SEMICONDUCTOR ML7223 IOH(Input/Output Hub).
The ML7223 IOH is for MP(Media Phone) use.
The ML7223 is companion chip for Intel Atom E6xx series.
The ML7223 is completely compatible for Intel EG20T PCH.Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
mac_pton() parses MAC address in form XX:XX:XX:XX:XX:XX and only in that form.
mac_pton() doesn't dirty result until it's sure string representation is valid.
mac_pton() doesn't care about characters _after_ last octet,
it's up to caller to deal with it.mac_pton() diverges from 0/-E return value convention.
Target usage:if (!mac_pton(str, whatever->mac))
return -EINVAL;
/* ->mac being u8 [ETH_ALEN] is filled at this point. */
/* optionally check str[3 * ETH_ALEN - 1] for termination */Use mac_pton() in pktgen and netconsole for start.
Signed-off-by: Alexey Dobriyan
Signed-off-by: David S. Miller -
Signed-off-by: Alexey Dobriyan
Signed-off-by: David S. Miller -
Pull read_lock(&bond->lock) and BOND_IS_OK() to bond_start_xmit() from
mode-dependent xmit functions.netif_running() is always true in hard_start_xmit.
Signed-off-by: Michał Mirosław
Signed-off-by: David S. Miller -
Unknown 8168 chips did not have any PLL power method set as they
did not inherit a default family soon enough. Fix it.Signed-off-by: Francois Romieu
Cc: Realtek linux nic maintainers -
- RTL_GIGA_MAC_NONE is a fake index so put it at the end of the
enumeration and shift everybody.
- RTL_GIGA_MAC_VER_17 / RTL_GIGA_MAC_VER_16 ordering fixed. Though
not wrong it was confusing enough to wonder if things were right.Renaming rtl_chip_info was not strictly necessary. It allows to
check the patch for the correct use of the indexes though.Signed-off-by: Francois Romieu
Cc: Realtek linux nic maintainers -
There is no real firmware version yet but the manpage of ethtool
is rather terse about the driver information.Former output:
$ ethtool -i eth1
driver: r8169
version: 2.3LK-NAPI
firmware-version:
bus-info: 0000:01:00.0
$ ethtool -i eth0
driver: r8169
version: 2.3LK-NAPI
firmware-version:
bus-info: 0000:03:00.0Current output:
$ ethtool -i eth1
driver: r8169
version: 2.3LK-NAPI
firmware-version: N/A
bus-info: 0000:01:00.0$ ethtool -i eth0
driver: r8169
version: 2.3LK-NAPI
firmware-version: rtl_nic/rtl8168d-1.fw
bus-info: 0000:03:00.0Signed-off-by: Francois Romieu
Fixed-by Ciprian Docan
Cc: Realtek linux nic maintainers
Cc: Fejes József
Cc: Borislav Petkov -
Invocation of rtl8169_rx_interrupt from rtl8169_reset_task was originally
intended to retrieve as much packets as possible from the rx ring when a
reset was needed. Nowadays rtl8169_reset_task is only scheduled, with
some delay
a. from the tx timeout watchdog
b. when resuming
c. from rtl8169_rx_interrupt itselfIt's dubious that the loss of outdated packets will matter much for a)
and b). c) does not need to call itself again.Signed-off-by: Francois Romieu
Cc: Realtek linux nic maintainers -
The implementation was a bit krusty.
The 10s rtl8169_phy_timer timer has been (was ?) required with older
8169 for adequate phy operation when full gigabit is advertised in
autonegotiated mode. The timer does nothing if the link is up.
Otherwise it keeps resetting the phy until things improve.- the device private data field phy_1000_ctrl_reg was used to
schedule the timer. Avoid it and save a few bytes.- rtl8169_set_settings
pending timer is disabled before changing the link settings as
rtl8169_phy_timer is not always needed (see the removed test in
rtl8169_phy_timer).- rtl8169_set_speed
the requested link parameters may not match the chipset : bail out
early on failure.- rtl8169_open
Calling rtl8169_request_timer is redundant with
-> rtl8169_open
-> rtl8169_init_phy
-> rtl8169_set_speed
-> mod_timer
The latter always enables the phy timer whereas the former did not
for RTL_GIGA_MAC_VER_01. It should not make things worse but only
time will tell if reality agrees.- rtl8169_request_timer : unused yet. Removed.
- rtl8169_delete_timer : useless. Bloat. Removed.
Side effect : the timer may kick in if the TBI is enabled. I do not
know if the TBI has ever been used in real life.Signed-off-by: Francois Romieu
Cc: Realtek linux nic maintainers -
Shorten chipset version test.
No functional change.
Careful readers will notice that the 'supports_gmii' flag is deduced
from the device PCI id. Though less specific than the chipset related
RTL_GIGA_MAC_VER_XY, it is good enough to detect a GMII deprieved 810x.
Some features push for a device specific configuration (improved jumbo
frame support for instance). 'supports_gmii' will follow this path
if / when the device PCI id test stops working.Signed-off-by: Francois Romieu
Cc: Realtek linux nic maintainers