22 Jul, 2008
40 commits
-
textsearch algorithms can be loaded, make the code depend
on CONFIG_MODULES instead of CONFIG_KMOD.Signed-off-by: Johannes Berg
Signed-off-by: Rusty Russell -
One place is just a comment, the other a conditional, unused
inclusion of linux/kmod.h.Signed-off-by: Johannes Berg
Cc: David S. Miller
Signed-off-by: Rusty Russell -
This reworks try_then_request_module to only invoke the "lookup"
function "x" once when the kernel is not modular.Signed-off-by: Johannes Berg
Signed-off-by: Rusty Russell -
Also includes a few Kconfig files (xtensa, blackfin)
Signed-off-by: Johannes Berg
Cc: Michael Kerrisk
Cc: linux-doc@vger.kernel.org
Signed-off-by: Rusty Russell
Acked-by: Randy Dunlap -
... as preparation for removing it completely, make it an
invisible bool defaulting to yes.Signed-off-by: Johannes Berg
Signed-off-by: Rusty Russell -
This patch keeps track of the boundaries of module allocation, in
order to speed up module_text_address().Inspired by Arjan's version, which required arch-specific defines:
Various pieces of the kernel (lockdep, latencytop, etc) tend
to store backtraces, sometimes at a relatively high
frequency. In itself this isn't a big performance deal (after
all you're using diagnostics features), but there have been
some complaints from people who have over 100 modules loaded
that this is a tad too slow.This is due to the new backtracer code which looks at every
slot on the stack to see if it's a kernel/module text address,
so that's 1024 slots. 1024 times 100 modules... that's a lot
of list walking.Signed-off-by: Rusty Russell
-
This shrinks module.o and each *.ko file.
And finally, structure members which hold length of module
code (four such members there) and count of symbols
are converted from longs to ints.We cannot possibly have a module where 32 bits won't
be enough to hold such counts.For one, module loading checks module size for sanity
before loading, so such insanely big module will fail
that test first.Signed-off-by: Denys Vlasenko
Signed-off-by: Rusty Russell -
module.c and module.h conatains code for finding
exported symbols which are declared with EXPORT_UNUSED_SYMBOL,
and this code is compiled in even if CONFIG_UNUSED_SYMBOLS is not set
and thus there can be no EXPORT_UNUSED_SYMBOLs in modules anyway
(because EXPORT_UNUSED_SYMBOL(x) are compiled out to nothing then).This patch adds required #ifdefs.
Signed-off-by: Denys Vlasenko
Signed-off-by: Rusty Russell -
reorder struct module to save space on 64 bit builds.
saves 1 cacheline_size (128 on default x86_64 & 64 on AMD
Opteron/athlon) when CONFIG_MODULE_UNLOAD=y.Signed-off-by: Richard Kennedy
Signed-off-by: Rusty Russell -
Introduce an each_symbol() iterator to avoid duplicating the knowledge
about the 5 different sections containing symbols. Currently only
used by find_symbol(), but will be used by symbol_put_addr() too.(Includes NULL ptr deref fix by Jiri Kosina )
Signed-off-by: Rusty Russell
Cc: Jiri Kosina -
rmmod has a little-used "-w" option, meaning that instead of failing if the
module is in use, it should block until the module becomes unused.In this case, we don't need to use stop_machine: Max Krasnyansky
indicated that would be useful for SystemTap which loads/unloads new
modules frequently.Cc: Max Krasnyansky
Signed-off-by: Rusty Russell -
* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6: (100 commits)
usb-storage: revert DMA-alignment change for Wireless USB
USB: use reset_resume when normal resume fails
usb_gadget: composite cdc gadget fault handling
usb gadget: minor USBCV fix for composite framework
USB: Fix bug with byte order in isp116x-hcd.c fio write/read
USB: fix double kfree in ipaq in error case
USB: fix build error in cdc-acm for CONFIG_PM=n
USB: remove board-specific UP2OCR configuration from pxa27x-udc
USB: EHCI: Reconciling USB register differences on MPC85xx vs MPC83xx
USB: Fix pointer/int cast in USB devio code
usb gadget: g_cdc dependso on NET
USB: Au1xxx-usb: suspend/resume support.
USB: Au1xxx-usb: clean up ohci/ehci bus glue sources.
usbfs: don't store bad pointers in registration
usbfs: fix race between open and unregister
usbfs: simplify the lookup-by-minor routines
usbfs: send disconnect signals when device is unregistered
USB: Force unbinding of drivers lacking reset_resume or other methods
USB: ohci-pnx4008: I2C cleanups and fixes
USB: debug port converter does not accept more than 8 byte packets
... -
This patch (as1110) reverts an earlier patch meant to help with
Wireless USB host controllers. These controllers can have bulk
maxpacket values larger than 512, which puts unusual constraints on
the sizes of scatter-gather list elements. However it turns out that
the block layer does not provide the support we need to enforce these
constraints; merely changing the DMA alignment mask doesn't help.
Hence there's no reason to keep the original patch. The Wireless USB
problem will have to be solved a different way.In addition, there is a reason to get rid of the earlier patch. By
dereferencing a pointer stored in the ep_in array of struct
usb_device, the current code risks an invalid memory access when it
runs concurrently with device removal. The members of that array are
cleared before the driver's disconnect method is called, so it should
not try to use them.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch (as1109b) makes USB-Persist more resilient to errors. With
the current code, if a normal resume fails, it's an unrecoverable
error. With the patch, if a normal resume fails (and if the device is
enabled for USB-Persist) then a reset-resume is tried.This fixes the problem reported in Bugzilla #10977.
Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
These two fixes ensure the new "CDC Composite Device" gadget
fails cleanly when it's loaded on hardware that can't support
this particular gadget driver.Signed-off-by: David Brownell
Signed-off-by: Greg Kroah-Hartman -
Fill in a reserved/unused device qualifier field to ensure that
the USBCV tests will always pass.Signed-off-by: David Brownell
Signed-off-by: Greg Kroah-Hartman -
URB payload data are transfered in wrong byte order on a big endinan
architecture (AVR32).Signed-off-by: Julien May
Signed-off-by: Greg Kroah-Hartman -
in the error case the ipaq driver leaves a dangling pointer to already
freed memory that will be freed again.Signed-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
Here's the fix. cdc-wdm has the same problem. The fix is the same.
Signed-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
Remove the board-specific UP2OCR configuration from the
pxa27x-udc driver.Signed-off-by: Daniel Ribeiro
Signed-off-by: Greg Kroah-Hartman -
A couple of USB register initializations had to be changed on MPC85xx
platforms. This is due to the internal SoC buses being different on
MPC83xx SoCs vs MPC85xx SoCs.We currently handle this via an ifdef since 83xx and 85xx are mutually
exclusive kernel builds.Signed-off-by: Srikanth Srinivasan
Signed-off-by: Kumar Gala
Signed-off-by: Greg Kroah-Hartman -
Fix pointer/int cast in USB devio code, and thus avoid a compiler warning.
A void* data argument passed to bus_find_device() and thence to match_devt()
is used to carry a 32-bit datum. However, casting directly between a u32 and
a pointer is not permitted - there must be an intermediate cast via (unsigned)
long.This was introduced by the following patch:
commit 94b1c9fa060ece2c8f080583beb6cc6008e41413
Author: Alan Stern
Date: Tue Jun 24 14:47:12 2008 -0400usbfs: simplify the lookup-by-minor routines
This patch (as1105) simplifies the lookup-by-minor-number code in
usbfs. Instead of passing the minor number to the callback, which
must then reconstruct the entire dev_t value, the patch passes the
dev_t value directly.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-HartmanSigned-off-by: David Howells
Cc: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
g_cdc needs to depend on NET, otherwise net-related build errors happen:
ERROR: "netif_carrier_on" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "netif_carrier_off" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "netif_rx" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "alloc_etherdev_mq" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "free_netdev" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "register_netdev" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "print_mac" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "dev_kfree_skb_any" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "__alloc_skb" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "eth_type_trans" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "unregister_netdev" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "__netif_schedule" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "skb_put" [drivers/usb/gadget/g_cdc.ko] undefined!Signed-off-by: Randy Dunlap
Signed-off-by: Greg Kroah-Hartman -
Copy the OHCI/EHCI PM callbacks of the PCI implementation since
they work equally well on Au1xxx hardware.Tested on Au1200.
Signed-off-by: Manuel Lauss
Cc: David Brownell
Signed-off-by: Greg Kroah-Hartman -
- Fold multiple probe/remove callbacks into one function;
- minor style fixes, no functional changes.Tested on Au1200.
Signed-off-by: Manuel Lauss
Cc: David Brownell
Signed-off-by: Greg Kroah-Hartman -
This patch (as1107) fixes a small bug in the usbfs registration and
unregistration code. It avoids leaving an error value stored in the
device's usb_classdev field and it avoids trying to unregister a NULL
pointer. (It also fixes a rather extreme overuse of whitespace.)Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch (as1106) fixes a race between opening and unregistering
device files in usbfs. The current code drops its reference to the
device and then reacquires it, ignoring the possibility that the
device structure might have been removed in the meantime. It also
doesn't check whether the device is already in the NOTATTACHED state
when the file is opened.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch (as1105) simplifies the lookup-by-minor-number code in
usbfs. Instead of passing the minor number to the callback, which
must then reconstruct the entire dev_t value, the patch passes the
dev_t value directly.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
USB device files are accessible in two ways: as files in usbfs and as
character device nodes. The two paths are supposed to behave
identically, but they don't. When the underlying USB device is
unplugged, disconnect signals are sent to processes with open usbfs
files (if they requested these signals) but not to processes with open
device node files.This patch (as1104) fixes the bug by moving the disconnect-signalling
code into a common subroutine which is called from both paths.
Putting this subroutine in devio.c removes the only out-of-file
reference to struct dev_state, and so the structure's declaration can
be moved from usb.h into devio.c.Finally, the new subroutine performs one extra action: It kills all
the outstanding async URBs. (I'd kill the outstanding synchronous
URBs too, if there was any way to do it.) In the past this hasn't
mattered much, because devices were unregistered from usbfs only
when they were disconnected. But now the unregistration can also
occur whenever devices are unbound from the usb_generic driver. At
any rate, killing URBs when a device is unregistered from usbfs seems
like a good thing to do.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch (as1024) takes care of a FIXME issue: Drivers that don't
have the necessary suspend, resume, reset_resume, pre_reset, or
post_reset methods will be unbound and their interface reprobed when
one of the unsupported events occurs.This is made slightly more difficult by the fact that bind operations
won't work during a system sleep transition. So instead the code has
to defer the operation until the transition ends.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
Various cleanups and fixes to the i2c code in ohci-pnx4008:
* Delete empty isp1301_command. The i2c driver command implementation
is optional, so there's no point in providing an empty
implementation.
* Give a name to isp1301_driver. I'm surprised that i2c-core accepted
to register this driver at all. I've chosen "isp1301_pnx" as the
name, because it's not a generic ISP1301 driver (much like the
isp1301_omap driver.) We might want to make the name even more
specific (but "isp1301_ohci_pnx4008" doesn't fit.)
* The ISP1301 is definitely not a hardware monitoring device.
* Fix a memory leak on failure in isp1301_attach. If
i2c_attach_client fails, the client is not registered so
isp1301_detach is never called and the i2c_client memory is lost.
* Use strlcpy instead of strcpy.Signed-off-by: Jean Delvare
Cc: Vitaly Wool
Cc: David Brownell
Signed-off-by: Greg Kroah-Hartman -
USB debug port only supports 8 byte rx/tx packets. Although spec implies that
"if a packet larger than eight bytes is received from the remote computer, the
device must break the larger packet into eight-byte packets before sending the
data to the Debug Port", the real PLX NET20DC device does not handle it right -
data is corrupted on debug port end if serial interface sends >8 byte urbs.
Patch below fixes the issue by limiting tx urb to 8 byte.Signed off by: Aleks Gorelov
Signed-off-by: Greg Kroah-Hartman -
cdc-acm must give up secondary interfaces if the primary is disconnected
and vice versa. This wasn't done correctly.Signed-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
usb serial decrements the pm counter even if an interface has been
disconnected. If it was a logical disconnect the interface may belong
already to another driver. This patch introduces a check for disconnected
interfaces.Signed-off-by: Oliver Neukum
Cc: Stable
Signed-off-by: Greg Kroah-Hartman -
this patch implements
- suspend/resume
- aggressive autosuspend for the cdc-wdm driver
- pre/post_resetSigned-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
this patch saves power for cdc-acm devices that support remote wakeup
while the device is connected.- request needs_remote_wakeup when needed
- delayed write while a device is autoresumed
- the device is marked busy when appropriateSigned-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
The 28xb, as documented in comments, has the same ID's as the 28x.
Remove the duplicated ID's from the device tables, and expand the
comment to document this.Signed-off-by: Ben Collins
Signed-off-by: Greg Kroah-Hartman -
This fixes the compiler warning.
Signed-off-by: Greg Kroah-Hartman
-
fix interrupt transfer interval for Full/Low speed device.
Signed-off-by: Yoshihiro Shimoda
Signed-off-by: Greg Kroah-Hartman -
fix the problem that did not set IRQF_TRIGGER_ flag.
Signed-off-by: Yoshihiro Shimoda
Signed-off-by: Greg Kroah-Hartman
