13 Jan, 2011
1 commit
-
As discussed one year ago, the WDIOC_GETSUPPORT ioctl only needs a
mutex because it operates on a static variable. There is no good
reason to keep this variable static, so let's just make it non-static
and drop the now useless mutex altogether.See the discussion at:
http://marc.info/?l=lm-sensors&m=125563869402323&w=2Signed-off-by: Jean Delvare
Cc: Hans de Goede
Acked-by: Guenter Roeck
Acked-by: Arnd Bergmann
Acked-by: Thomas Gleixner
05 Oct, 2010
1 commit
-
All these files use the big kernel lock in a trivial
way to serialize their private file operations,
typically resulting from an earlier semi-automatic
pushdown from VFS.None of these drivers appears to want to lock against
other code, and they all use the BKL as the top-level
lock in their file operations, meaning that there
is no lock-order inversion problem.Consequently, we can remove the BKL completely,
replacing it with a per-file mutex in every case.
Using a scripted approach means we can avoid
typos.These drivers do not seem to be under active
maintainance from my brief investigation. Apologies
to those maintainers that I have missed.file=$1
name=$2
if grep -q lock_kernel ${file} ; then
if grep -q 'include.*linux.mutex.h' ${file} ; then
sed -i '/include.*/d' ${file}
else
sed -i 's/include.*.*$/include /g' ${file}
fi
sed -i ${file} \
-e "/^#include.*linux.mutex.h/,$ {
1,/^\(static\|int\|long\)/ {
/^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);} }" \
-e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
-e '/[ ]*cycle_kernel_lock();/d'
else
sed -i -e '/include.*\/d' ${file} \
-e '/cycle_kernel_lock()/d'
fiSigned-off-by: Arnd Bergmann
17 May, 2010
1 commit
-
These are the last remaining device drivers using
the ->ioctl file operation in the drivers directory
(except from v4l drivers).[fweisbec: drop i8k pushdown as it has been done from
procfs pushdown branch already]Signed-off-by: Arnd Bergmann
Signed-off-by: Frederic Weisbecker
06 Mar, 2010
1 commit
-
Recent changes on the I2C front have left off-by-one array indexes in
3 hwmon drivers. Fix them.Faulty commit:
e5e9f44c2 i2c: Drop I2C_CLIENT_INSMOD_2 to 8Reported-by: Dan Carpenter
Signed-off-by: Jean Delvare
Cc: Hans de Goede
Cc: Andre Prendel
Cc: stable@kernel.org
25 Jan, 2010
1 commit
-
When /dev/watchdog gets opened a second time we return -EBUSY, but
we already have got a kref then, so we end up leaking our data struct.Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare
Cc: stable@kernel.org
15 Dec, 2009
3 commits
-
These macros simply declare an enum, so drivers might as well declare
it themselves. This puts an end to the arbitrary limit of 8 chip types
per i2c driver.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang -
Struct i2c_client_address_data only contains one field at this point,
which makes its usefulness questionable. Get rid of it and pass simple
address lists around instead.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang -
The "kind" parameter always has value -1, and nobody is using it any
longer, so we can remove it.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang
10 Dec, 2009
1 commit
-
As kind is now hard-coded to -1, there is room for code clean-ups.
Signed-off-by: Jean Delvare
Acked-by: Corentin Labbe
Cc: "Mark M. Hoffman"
Cc: Juerg Haefliger
Cc: Riku Voipio
Acked-by: "Hans J. Koch"
Cc: Rudolf Marek
24 Oct, 2009
1 commit
-
If unsigned the watchdog_trigger() return value will not be
checked correctly.Signed-off-by: Roel Kluin
Acked-by: Andrew Morton
Cc: Hans de Goede
Signed-off-by: Jean Delvare
02 Oct, 2009
1 commit
-
[akpm@linux-foundation.org: fix KVM]
Signed-off-by: Alexey Dobriyan
Acked-by: Mike Frysinger
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
31 Mar, 2009
3 commits
-
Add support for the Hades to the FSC hwmon driver.
Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare -
Many thanks to Fujitsu Siemens Computers for providing docs and a
machine to test the driver on.Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare -
At the moment, dmi_walk() lacks flexibility, users can't pass data to
the callback function. Add a pointer for private data to make this
function more flexible.Signed-off-by: Jean Delvare
Cc: Hans de Goede
Cc: Matthew Garrett
Cc: Roland Dreier
08 Jan, 2009
1 commit
-
* 'hwmon-for-linus' of git://jdelvare.pck.nerim.net/jdelvare-2.6: (29 commits)
hwmon: Fix various typos
hwmon: Check for ACPI resource conflicts
hwmon: (lm70) Add TI TMP121 support
hwmon: (lm70) Code streamlining and cleanup
hwmon: Deprecate the fscher and fscpos drivers
hwmon: (fschmd) Add watchdog support
hwmon: (fschmd) Cleanups for watchdog support
hwmon: (i5k_amb) Load automatically on all 5000/5400 chipsets
hwmon: (it87) Add support for the ITE IT8720F
hwmon: Don't overuse I2C_CLIENT_MODULE_PARM
hwmon: Add LTC4245 driver
hwmon: (f71882fg) Fix fan_to/from_reg prototypes
hwmon: (f71882fg) Printout fan modes
hwmon: (f71882fg) Add documentation
hwmon: (f71882fg) Fix auto_channels_temp temp numbering with f8000
hwmon: (f71882fg) Add missing pwm3 attr for f71862fg
hwmon: (f71882fg) Add F8000 support
hwmon: (f71882fg) Remove the fan_mode module option
hwmon: (f71882fg) Separate max and crit alarm and beep
hwmon: (f71882fg) Check for hwmon powerdown state
...
07 Jan, 2009
2 commits
-
This patch adds support for the watchdog part found in _all_ supported FSC
sensor chips.Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare -
Various small cleanups in preparation of adding watchdog support,
mostly removing _MASK postfix from defines which are not masks.Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare
06 Jan, 2009
1 commit
-
- (better, more, bigger ...) then -> (...) than
Signed-off-by: Frederik Schwarzer
Signed-off-by: Jiri Kosina
17 Jul, 2008
1 commit
-
The new-style fschmd driver implements the optional detect() callback
to cover the use cases of the legacy driver.Signed-off-by: Jean Delvare
Cc: Hans de Goede
19 Feb, 2008
1 commit
-
Signed-off-by: Mark M. Hoffman
08 Feb, 2008
2 commits
-
This patch adds support to the fschmd driver for reading the voltage scaling
factors from BIOS DMI tables, as specified in the Siemens datasheet.Signed-off-by: Hans de Goede
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Somehow non-ASCII characters managed to sneak into the fschmd driver.
Kick them out.Signed-off-by: Jean Delvare
Cc: Hans de Goede
Signed-off-by: Mark M. Hoffman
11 Oct, 2007
1 commit
-
This patch adds a new merged driver for FSC sensor chips, it merges the fscher
and fscpos drivers and adds support for the FSC Scylla, Heracles and Heimdall
chips.Signed-off-by: Hans de Goede
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman