02 Nov, 2011

1 commit


22 May, 2008

1 commit


17 Oct, 2007

2 commits

  • A bunch of MTU-related cleanups in the network code.

    First, there is the addition of the notion of a maximally-sized packet, which
    is the MTU plus headers. This is used to size the skb that will receive a
    packet. This allows ether_adjust_skb to go away, as it was used to resize the
    skb after it was allocated.

    Since the skb passed into the low-level read routine is no longer resized, and
    possibly reallocated, there, they (and the write routines) don't need to get
    an sk_buff **. They just need the sk_buff * now. The callers of
    ether_adjust_skb still need to do the skb_put, so that's now inlined.

    The MAX_PACKET definitions in most of the drivers are gone.

    The set_mtu methods were all the same and did nothing, so they can be
    removed.

    The ethertap driver had a typo which doubled the size of the packet rather
    than adding two bytes to it. It also wasn't defining its setup_size, causing
    a zero-byte kmalloc and crash when the invalid pointer returned from kmalloc
    was dereferenced.

    Signed-off-by: Jeff Dike
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Dike
     
  • Style and other non-functional changes in the UML networking code, including
    include tidying
    style violations
    copyright updates
    printks getting severities
    userspace code calling libc directly rather than using the os_*
    wrappers

    There's also a exit path cleanup in the pcap driver.

    Signed-off-by: Jeff Dike
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Dike
     

18 Jul, 2007

1 commit


09 May, 2007

1 commit

  • Some network device cleanup.

    When setup_etheraddr found a globally valid MAC being assigned to an
    interface, it went ahead and used it rather than assigning a random MAC like
    the other cases do. This isn't really an error like the others, but it seems
    consistent to make it behave the same.

    We were getting some duplicate kfree() in the error case in eth_configure
    because platform_device_unregister frees buffers that the error cases
    following tried to free again.

    The pcap initialization routine wasn't doing the proper printk of its
    information, causing a printk of the first part of that line to be
    unterminated by a newline.

    The pcap code had a bunch of style violations, which are now fixed.

    pcap_setup wasn't returning false when it detected an unrecognized
    option.

    The printks in pcap_user all got UM_KERN_BLAH prepended to their
    format strings.

    pcap_remove now checks for a non-NULL pcap structure before it calls
    pcap_close.

    Signed-off-by: Jeff Dike
    Acked-by: Paolo 'Blaisorblade' Giarrusso
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Dike
     

08 May, 2007

2 commits

  • This fixes a number of problems associated with network interface hotplug.

    The userspace initialization function can fail in some cases, but the
    failure was never passed back to eth_configure, which proceeded with the
    configuration. This results in a zombie device that is present, but can't
    work. This is fixed by allowing the initialization routines to return an
    error, which is checked, and the configuration aborted on failure.

    eth_configure failed to check for many failures. Even when it did check,
    it didn't undo whatever initializations has already happened, so a present,
    but partially initialized and non-working device could result. It now
    checks everything that can fail, and bails out, undoing whatever had been
    done.

    The return value of eth_configure was always ignored, so it is now just
    void.

    Signed-off-by: Jeff Dike
    Cc: Paolo 'Blaisorblade' Giarrusso
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Dike
     
  • Fix a bunch of formatting violations in the drivers:
    return(n) -> return n
    whitespace fixes
    emacs formatting comment removal
    breaking if(foo) return(n) into two lines

    There are also a couple of errno use bugs:
    using errno in a printk when the failure put errno into a local variable
    saving errno after a printk, which can change it

    Signed-off-by: Jeff Dike
    Cc: Paolo 'Blaisorblade' Giarrusso
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Dike
     

21 Oct, 2006

1 commit


27 Sep, 2006

1 commit

  • Make lots of structures const in order to make it obvious that they need no
    locking.

    Signed-off-by: Jeff Dike
    Cc: Paolo 'Blaisorblade' Giarrusso
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Dike
     

17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds